Re: [webkit-dev] webkit-dev Digest, Vol 99, Issue 17
amirabdul...@hotmail.com Amirabdulahiall@a...@yahool.com -Original Message- From: webkit-dev-requ...@lists.webkit.org Sent: 8/23/2013 7:00:01 PM To: webkit-dev@lists.webkit.org Subject: webkit-dev Digest, Vol 99, Issue 17 Send webkit-dev mailing list submissions to webkit-dev@lists.webkit.org To subscribe or unsubscribe via the World Wide Web, visit https://lists.webkit.org/mailman/listinfo/webkit-dev or, via email, send a message with subject or body 'help' to webkit-dev-requ...@lists.webkit.org You can reach the person managing the list at webkit-dev-ow...@lists.webkit.org When replying, please edit your Subject line so it is more specific than Re: Contents of webkit-dev digest... Today's Topics: 1. Re: ChangeLog format (Joseph Pecoraro) 2. New WebKit Reviewer: Mario Sanchez Prada (Christophe Dumez) 3. Re: New WebKit Reviewer: Mario Sanchez Prada (Bruno de Oliveira Abinader) 4. Re: New WebKit Reviewer: Mario Sanchez Prada (Brian Holt) 5. Re: New WebKit Reviewer: Mario Sanchez Prada (Simon Pena Placer) 6. Re: New WebKit Reviewer: Mario Sanchez Prada (Brian Holt) 7. Re: New WebKit Reviewer: Mario Sanchez Prada (Denis Nomiyama) 8. Proposal: Add support for Promises (Sam Weinig) 9. Re: Proposal: Add support for Promises (Filip Pizlo) -- Message: 1 Date: Thu, 22 Aug 2013 12:34:00 -0700 From: Joseph Pecoraro pecor...@apple.com To: Carlos Garcia Campos carlo...@webkit.org Cc: WebKit Development webkit-dev@lists.webkit.org, Mark Rowe mr...@apple.com Subject: Re: [webkit-dev] ChangeLog format Message-ID: 64f50409-3b17-4580-8e12-d729216c4...@apple.com Content-Type: text/plain; charset=windows-1252 On Aug 22, 2013, at 12:46 AM, Carlos Garcia Campos carlo...@webkit.org wrote: El jue, 22-08-2013 a las 00:41 -0700, Mark Rowe escribi?: On 2013-08-21, at 11:11 PM, Carlos Garcia Campos carlo...@webkit.org wrote: I see, I thought ChangeLog parser was used everywhere. So, I guess the solution would be to find a format most people like and adapt all scripts to it. I personally think it's not worth it, though. The oneline git log format is ok with the old commit message format IMO. If the only problem is that the bug number is not in the first line we can probably add it without adding the URL in angle brackets, something like: Bug 119872 - REGRESSION: Crash under JITCompiler::link while loading Gmail https://bugs.webkit.org/show_bug.cgi?id=119872 What benefit does duplicating the bug number in the first line provide? It?s just yet another thing to have to add when writing the ChangeLog entry. The benefit is that you see the bug number when using git log oneline format, I'm guessing that seeing the bug number in the first line was the motivation of the new ChangeLog format. I prefer the new format. However, the new format doesn't really gain us much, so it sounds like it is not worth the effort to change. As for duplicating the bug number, I don't think that matters. `git log --oneline` shows a short SHA the title line which is everything in the commit message until the first empty line. So duplicating the bug number in the first line doesn't really help, since both of these lines already show up. Old format: shell git log --oneline `git svn find-rev r153963` -10 503293b Move additionalIdentifiers into DFGCommonData as only the optimising JITs use them https://bugs.webkit.org/show_bug.cgi?id=119705 2dbc921 Stop making unnecessary copy of CodeBlock Identifier Vector https://bugs.webkit.org/show_bug.cgi?id=119702 c0c68df [cairo] memory corruption with putImageData and accelerated canvas. https://bugs.webkit.org/show_bug.cgi?id=118621 0502819 Layout Test fast/overflow/scrollbar-click-retains-focus.html is failing on Apple Mac WK1 and GTK. https://bugs.webkit.org/show_bug.cgi?id=104104 c19a87b Use const AtomicStringImpl* in DocumentOrderedMap https://bugs.webkit.org/show_bug.cgi?id=119700 02c59d8 The LayoutMilestones didLayout callback should only fire for the main frame https://bugs.webkit.org/show_bug.cgi?id=119457 2cb3317 Remove didNewFirstVisuallyNonEmptyLayout from WebKit2 https://bugs.webkit.org/show_bug.cgi?id=119658 6cb5165 Define DOM_KEY_LOCATION_* constants on KeyboardEvent https://bugs.webkit.org/show_bug.cgi?id=119341 597845d Remove glu's libtest rule from checker.py https://bugs.webkit.org/show_bug.cgi?id=119674 35852cd Multiple CSP tests complain about undefined strings in echo-object-data.pl and echo-script-src.pl https://bugs.webkit.org/show_bug.cgi?id=119692 New format: shell git log --oneline `git svn find-rev r154274` -10 c3bd590 https://webkit.org/b/119882 Speed up moving cursor/selection up or down past non-rendered elements. 6c326ac https://webkit.org/b/119933 [Qt] Fix tst_QObjectBridge::connectAndDisconnect() fail 381c093 https://webkit.org/b/12 Chrome::client() should return a reference.
Re: [webkit-dev] webkit-dev Digest, Vol 99, Issue 17
Thanks! amirabdul...@hotmail.com Amirabdulahiall@a...@yahool.com -Original Message- From: webkit-dev-requ...@lists.webkit.org Sent: 8/23/2013 7:00:01 PM To: webkit-dev@lists.webkit.org Subject: webkit-dev Digest, Vol 99, Issue 17 Send webkit-dev mailing list submissions to webkit-dev@lists.webkit.org To subscribe or unsubscribe via the World Wide Web, visit https://lists.webkit.org/mailman/listinfo/webkit-dev or, via email, send a message with subject or body 'help' to webkit-dev-requ...@lists.webkit.org You can reach the person managing the list at webkit-dev-ow...@lists.webkit.org When replying, please edit your Subject line so it is more specific than Re: Contents of webkit-dev digest... Today's Topics: 1. Re: ChangeLog format (Joseph Pecoraro) 2. New WebKit Reviewer: Mario Sanchez Prada (Christophe Dumez) 3. Re: New WebKit Reviewer: Mario Sanchez Prada (Bruno de Oliveira Abinader) 4. Re: New WebKit Reviewer: Mario Sanchez Prada (Brian Holt) 5. Re: New WebKit Reviewer: Mario Sanchez Prada (Simon Pena Placer) 6. Re: New WebKit Reviewer: Mario Sanchez Prada (Brian Holt) 7. Re: New WebKit Reviewer: Mario Sanchez Prada (Denis Nomiyama) 8. Proposal: Add support for Promises (Sam Weinig) 9. Re: Proposal: Add support for Promises (Filip Pizlo) -- Message: 1 Date: Thu, 22 Aug 2013 12:34:00 -0700 From: Joseph Pecoraro pecor...@apple.com To: Carlos Garcia Campos carlo...@webkit.org Cc: WebKit Development webkit-dev@lists.webkit.org, Mark Rowe mr...@apple.com Subject: Re: [webkit-dev] ChangeLog format Message-ID: 64f50409-3b17-4580-8e12-d729216c4...@apple.com Content-Type: text/plain; charset=windows-1252 On Aug 22, 2013, at 12:46 AM, Carlos Garcia Campos carlo...@webkit.org wrote: El jue, 22-08-2013 a las 00:41 -0700, Mark Rowe escribi?: On 2013-08-21, at 11:11 PM, Carlos Garcia Campos carlo...@webkit.org wrote: I see, I thought ChangeLog parser was used everywhere. So, I guess the solution would be to find a format most people like and adapt all scripts to it. I personally think it's not worth it, though. The oneline git log format is ok with the old commit message format IMO. If the only problem is that the bug number is not in the first line we can probably add it without adding the URL in angle brackets, something like: Bug 119872 - REGRESSION: Crash under JITCompiler::link while loading Gmail https://bugs.webkit.org/show_bug.cgi?id=119872 What benefit does duplicating the bug number in the first line provide? It?s just yet another thing to have to add when writing the ChangeLog entry. The benefit is that you see the bug number when using git log oneline format, I'm guessing that seeing the bug number in the first line was the motivation of the new ChangeLog format. I prefer the new format. However, the new format doesn't really gain us much, so it sounds like it is not worth the effort to change. As for duplicating the bug number, I don't think that matters. `git log --oneline` shows a short SHA the title line which is everything in the commit message until the first empty line. So duplicating the bug number in the first line doesn't really help, since both of these lines already show up. Old format: shell git log --oneline `git svn find-rev r153963` -10 503293b Move additionalIdentifiers into DFGCommonData as only the optimising JITs use them https://bugs.webkit.org/show_bug.cgi?id=119705 2dbc921 Stop making unnecessary copy of CodeBlock Identifier Vector https://bugs.webkit.org/show_bug.cgi?id=119702 c0c68df [cairo] memory corruption with putImageData and accelerated canvas. https://bugs.webkit.org/show_bug.cgi?id=118621 0502819 Layout Test fast/overflow/scrollbar-click-retains-focus.html is failing on Apple Mac WK1 and GTK. https://bugs.webkit.org/show_bug.cgi?id=104104 c19a87b Use const AtomicStringImpl* in DocumentOrderedMap https://bugs.webkit.org/show_bug.cgi?id=119700 02c59d8 The LayoutMilestones didLayout callback should only fire for the main frame https://bugs.webkit.org/show_bug.cgi?id=119457 2cb3317 Remove didNewFirstVisuallyNonEmptyLayout from WebKit2 https://bugs.webkit.org/show_bug.cgi?id=119658 6cb5165 Define DOM_KEY_LOCATION_* constants on KeyboardEvent https://bugs.webkit.org/show_bug.cgi?id=119341 597845d Remove glu's libtest rule from checker.py https://bugs.webkit.org/show_bug.cgi?id=119674 35852cd Multiple CSP tests complain about undefined strings in echo-object-data.pl and echo-script-src.pl https://bugs.webkit.org/show_bug.cgi?id=119692 New format: shell git log --oneline `git svn find-rev r154274` -10 c3bd590 https://webkit.org/b/119882 Speed up moving cursor/selection up or down past non-rendered elements. 6c326ac https://webkit.org/b/119933 [Qt] Fix tst_QObjectBridge::connectAndDisconnect() fail 381c093 https://webkit.org/b/12 Chrome::client() should return a
Re: [webkit-dev] Proposal: Add support for Promises
The blink people are running into a bunch of issues by implementing them on the C++ side as opposed to inside the VM. I don’t think we can reason by analogy here. Is there a specific problem you’re concerned about? Geoff ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Proposal: Add support for Promises
On Sun, Aug 25, 2013 at 11:41 AM, Geoffrey Garen gga...@apple.com wrote: The blink people are running into a bunch of issues by implementing them on the C++ side as opposed to inside the VM. I don’t think we can reason by analogy here. Is there a specific problem you’re concerned about? The tension in Blink is between making it easy to subclass Promise in WebIDL versus making it easy for the garbage collector to trace object graphs that includes Promises. These considerations are different in WebKit because the integration between WebCore and JavaScriptCore works differently than the integration between Blink and V8. I'm happy to explain these issues in more detail if you would find that helpful, but I agree with ggaren that there's probably not much to learn from the Blink implementation because the design pressures are different than in WebKit. Adam ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] New WebKit Reviewer: Mario Sanchez Prada
Congrats Mario !! Gyuyoung. On Sat, Aug 24, 2013 at 5:14 AM, Romain Perier romain.per...@gmail.comwrote: 350 patches in 3 years ~=1 patch all 3 days, nice ! Congrats (beer, champagne, etc);) Le 23 août 2013 à 18:09, Denis Nomiyama d.nomiy...@samsung.com a écrit : Congrats Mario! -Original Message- From: webkit-dev-boun...@lists.webkit.org [mailto:webkit-dev- boun...@lists.webkit.org] On Behalf Of Brian Holt Sent: 23 August 2013 16:11 To: webkit-dev@lists.webkit.org Subject: Re: [webkit-dev] New WebKit Reviewer: Mario Sanchez Prada Congratulations Mario! -Original Message- From: webkit-dev-boun...@lists.webkit.org [mailto:webkit-dev- boun...@lists.webkit.org] On Behalf Of Bruno de Oliveira Abinader Sent: 23 August 2013 16:07 To: Christophe Dumez; webkit-dev@lists.webkit.org Subject: Re: [webkit-dev] New WebKit Reviewer: Mario Sanchez Prada Congrats, Mario! :-) From: Christophe Dumez ch.du...@sta.samsung.com Date: Friday, August 23, 2013 10:53 AM To: webkit-dev@lists.webkit.org webkit-dev@lists.webkit.org Subject: [webkit-dev] New WebKit Reviewer: Mario Sanchez Prada Hi WebKit folks, I am happy to announce that Mario Sanchez Prada mario.pr...@samsung.com is now a WebKit reviewer. Mario has contributed over 350 patches to WebKit over the past 3 years, mostly around Accessibility and the WebKitGTK+2 API. Please join me in congratulating Mario for his new status! Kr, -- Christophe Dumez - Samsung Telecommunications America ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
[webkit-dev] (no subject)
Hi all: It seems that WebCore/platform/graphics/win/ MediaPlayerPrivateFullscreenWindow.cpp should not exclude for WinCairo port. ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
