[webkit-dev] Proposal: Stop EWS bot commenting in bugs

2014-01-15 Thread Sam Weinig
Hi Everyone,

I am becoming increasingly annoyed by the comments made in bugs.webkit.org bugs 
by our non-human helpers, the EWS bots.  I don’t find the addition of a comment 
indicating that a patch has failed on a bot, over the existing indication in 
the bubble, to be worth the noise it creates.

I propose that we stop allowing the bots to comment, and leave that space for 
the developers.

- Sam

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


Re: [webkit-dev] Proposal: Stop EWS bot commenting in bugs

2014-01-15 Thread Alexey Proskuryakov

+1

This is blocked on improving Bugzilla EWS bubbles, making it humanly possible 
to find out without a comment which tests regressed.

- WBR, Alexey Proskuryakov


15 янв. 2014 г., в 19:54, Sam Weinig wei...@apple.com написал(а):

 Hi Everyone,
 
 I am becoming increasingly annoyed by the comments made in bugs.webkit.org 
 bugs by our non-human helpers, the EWS bots.  I don’t find the addition of a 
 comment indicating that a patch has failed on a bot, over the existing 
 indication in the bubble, to be worth the noise it creates.
 
 I propose that we stop allowing the bots to comment, and leave that space for 
 the developers.
 
 - Sam
 
 ___
 webkit-dev mailing list
 webkit-dev@lists.webkit.org
 https://lists.webkit.org/mailman/listinfo/webkit-dev

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


Re: [webkit-dev] Proposal: Stop EWS bot commenting in bugs

2014-01-15 Thread Ryosuke Niwa
I find Mac EWS's listing the failing tests to be very useful especially
because it uploads the results to Bugzilla.

I do agree that comments about build failures are much less useful.

- R. Niwa


On Wed, Jan 15, 2014 at 7:54 PM, Sam Weinig wei...@apple.com wrote:

 Hi Everyone,

 I am becoming increasingly annoyed by the comments made in 
 bugs.webkit.orgbugs by our non-human helpers, the EWS bots.  I don’t find the 
 addition of
 a comment indicating that a patch has failed on a bot, over the existing
 indication in the bubble, to be worth the noise it creates.

 I propose that we stop allowing the bots to comment, and leave that space
 for the developers.

 - Sam

 ___
 webkit-dev mailing list
 webkit-dev@lists.webkit.org
 https://lists.webkit.org/mailman/listinfo/webkit-dev

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


Re: [webkit-dev] Proposal: Stop EWS bot commenting in bugs

2014-01-15 Thread Sam Weinig
Could we compromise for now, and remove all the non-test failing EWS comments 
(e.g. build failure, style failure)?

- Sam

On Jan 15, 2014, at 8:04 PM, Ryosuke Niwa rn...@webkit.org wrote:

 I find Mac EWS's listing the failing tests to be very useful especially 
 because it uploads the results to Bugzilla.
 
 I do agree that comments about build failures are much less useful.
 
 - R. Niwa
 
 
 On Wed, Jan 15, 2014 at 7:54 PM, Sam Weinig wei...@apple.com wrote:
 Hi Everyone,
 
 I am becoming increasingly annoyed by the comments made in bugs.webkit.org 
 bugs by our non-human helpers, the EWS bots.  I don’t find the addition of a 
 comment indicating that a patch has failed on a bot, over the existing 
 indication in the bubble, to be worth the noise it creates.
 
 I propose that we stop allowing the bots to comment, and leave that space for 
 the developers.
 
 - Sam
 
 ___
 webkit-dev mailing list
 webkit-dev@lists.webkit.org
 https://lists.webkit.org/mailman/listinfo/webkit-dev
 

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


Re: [webkit-dev] Proposal: Stop EWS bot commenting in bugs

2014-01-15 Thread Ryosuke Niwa
We could do that, or add some JS hack to Bugzilla so that it hides EWS
comments by default but makes them expandable.

- R. Niwa


On Wed, Jan 15, 2014 at 8:09 PM, Sam Weinig wei...@apple.com wrote:

 Could we compromise for now, and remove all the non-test failing EWS
 comments (e.g. build failure, style failure)?

 - Sam

 On Jan 15, 2014, at 8:04 PM, Ryosuke Niwa rn...@webkit.org wrote:

 I find Mac EWS's listing the failing tests to be very useful especially
 because it uploads the results to Bugzilla.

 I do agree that comments about build failures are much less useful.

 - R. Niwa


 On Wed, Jan 15, 2014 at 7:54 PM, Sam Weinig wei...@apple.com wrote:

 Hi Everyone,

 I am becoming increasingly annoyed by the comments made in
 bugs.webkit.org bugs by our non-human helpers, the EWS bots.  I don’t
 find the addition of a comment indicating that a patch has failed on a bot,
 over the existing indication in the bubble, to be worth the noise it
 creates.

 I propose that we stop allowing the bots to comment, and leave that space
 for the developers.

 - Sam

 ___
 webkit-dev mailing list
 webkit-dev@lists.webkit.org
 https://lists.webkit.org/mailman/listinfo/webkit-dev




___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


Re: [webkit-dev] Proposal: Stop EWS bot commenting in bugs

2014-01-15 Thread Joseph Pecoraro
I would also like to see a reduction in EWS spam.

It is not just the comment clutter, but also quite a bit of emails.

- Joe

On Jan 15, 2014, at 8:17 PM, Ryosuke Niwa rn...@webkit.org wrote:

 We could do that, or add some JS hack to Bugzilla so that it hides EWS 
 comments by default but makes them expandable.
 
 - R. Niwa
 
 
 On Wed, Jan 15, 2014 at 8:09 PM, Sam Weinig wei...@apple.com wrote:
 Could we compromise for now, and remove all the non-test failing EWS comments 
 (e.g. build failure, style failure)?
 
 - Sam
 
 On Jan 15, 2014, at 8:04 PM, Ryosuke Niwa rn...@webkit.org wrote:
 
 I find Mac EWS's listing the failing tests to be very useful especially 
 because it uploads the results to Bugzilla.
 
 I do agree that comments about build failures are much less useful.
 
 - R. Niwa
 
 
 On Wed, Jan 15, 2014 at 7:54 PM, Sam Weinig wei...@apple.com wrote:
 Hi Everyone,
 
 I am becoming increasingly annoyed by the comments made in bugs.webkit.org 
 bugs by our non-human helpers, the EWS bots.  I don’t find the addition of a 
 comment indicating that a patch has failed on a bot, over the existing 
 indication in the bubble, to be worth the noise it creates.
 
 I propose that we stop allowing the bots to comment, and leave that space 
 for the developers.
 
 - Sam
 
 ___
 webkit-dev mailing list
 webkit-dev@lists.webkit.org
 https://lists.webkit.org/mailman/listinfo/webkit-dev
 
 
 
 ___
 webkit-dev mailing list
 webkit-dev@lists.webkit.org
 https://lists.webkit.org/mailman/listinfo/webkit-dev

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


Re: [webkit-dev] Proposal: Stop EWS bot commenting in bugs

2014-01-15 Thread Gyuyoung Kim
+1, I would prefer to see EWS log only when I want to see it.

Gyuyoung.


On Thu, Jan 16, 2014 at 1:24 PM, Joseph Pecoraro pecor...@apple.com wrote:

 I would also like to see a reduction in EWS spam.

 It is not just the comment clutter, but also quite a bit of emails.

 - Joe

 On Jan 15, 2014, at 8:17 PM, Ryosuke Niwa rn...@webkit.org wrote:

 We could do that, or add some JS hack to Bugzilla so that it hides EWS
 comments by default but makes them expandable.

 - R. Niwa


 On Wed, Jan 15, 2014 at 8:09 PM, Sam Weinig wei...@apple.com wrote:

 Could we compromise for now, and remove all the non-test failing EWS
 comments (e.g. build failure, style failure)?

 - Sam

 On Jan 15, 2014, at 8:04 PM, Ryosuke Niwa rn...@webkit.org wrote:

 I find Mac EWS's listing the failing tests to be very useful especially
 because it uploads the results to Bugzilla.

 I do agree that comments about build failures are much less useful.

 - R. Niwa


 On Wed, Jan 15, 2014 at 7:54 PM, Sam Weinig wei...@apple.com wrote:

 Hi Everyone,

 I am becoming increasingly annoyed by the comments made in
 bugs.webkit.org bugs by our non-human helpers, the EWS bots.  I don’t
 find the addition of a comment indicating that a patch has failed on a bot,
 over the existing indication in the bubble, to be worth the noise it
 creates.

 I propose that we stop allowing the bots to comment, and leave that
 space for the developers.

 - Sam

 ___
 webkit-dev mailing list
 webkit-dev@lists.webkit.org
 https://lists.webkit.org/mailman/listinfo/webkit-dev




 ___
 webkit-dev mailing list
 webkit-dev@lists.webkit.org
 https://lists.webkit.org/mailman/listinfo/webkit-dev



 ___
 webkit-dev mailing list
 webkit-dev@lists.webkit.org
 https://lists.webkit.org/mailman/listinfo/webkit-dev


___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


Re: [webkit-dev] Proposal: Stop EWS bot commenting in bugs

2014-01-15 Thread Timothy Hatcher
It isn't just about seeing the comment on the page, it also gets emailed.

I agree, no bot comments would be better. The stye bot spew is particularly 
bad, mainly because it dumps all the file paths it tested not just what fails.

— Timothy Hatcher

On Jan 15, 2014, at 8:17 PM, Ryosuke Niwa rn...@webkit.org wrote:

 We could do that, or add some JS hack to Bugzilla so that it hides EWS 
 comments by default but makes them expandable.
 
 - R. Niwa
 
 
 On Wed, Jan 15, 2014 at 8:09 PM, Sam Weinig wei...@apple.com wrote:
 Could we compromise for now, and remove all the non-test failing EWS comments 
 (e.g. build failure, style failure)?
 
 - Sam
 
 On Jan 15, 2014, at 8:04 PM, Ryosuke Niwa rn...@webkit.org wrote:
 
 I find Mac EWS's listing the failing tests to be very useful especially 
 because it uploads the results to Bugzilla.
 
 I do agree that comments about build failures are much less useful.
 
 - R. Niwa
 
 
 On Wed, Jan 15, 2014 at 7:54 PM, Sam Weinig wei...@apple.com wrote:
 Hi Everyone,
 
 I am becoming increasingly annoyed by the comments made in bugs.webkit.org 
 bugs by our non-human helpers, the EWS bots.  I don’t find the addition of a 
 comment indicating that a patch has failed on a bot, over the existing 
 indication in the bubble, to be worth the noise it creates.
 
 I propose that we stop allowing the bots to comment, and leave that space 
 for the developers.
 
 - Sam
 
 ___
 webkit-dev mailing list
 webkit-dev@lists.webkit.org
 https://lists.webkit.org/mailman/listinfo/webkit-dev
 
 
 
 ___
 webkit-dev mailing list
 webkit-dev@lists.webkit.org
 https://lists.webkit.org/mailman/listinfo/webkit-dev

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


Re: [webkit-dev] Proposal: Stop EWS bot commenting in bugs

2014-01-15 Thread Alexey Proskuryakov
(re-sent from a correct address)

I think that it's good to try not dumping build failures into comments right 
away, and to see what happens.

As for not showing style bot failures, it seems almost certain that this will 
make them substantially more annoying to work with. Can you describe the 
workflow for patch author and reviewer to deal with style bot warnings when 
they are not inline? Manually finding relevant lines by number can't work.

I agree with Tim that dumping all tested paths along with style warnings is 
silly. How hard would it be it to get rid of that?

- WBR, Alexey Proskuryakov

15 янв. 2014 г., в 20:34, Ryosuke Niwa rn...@webkit.org написал(а):

 FWIW, I've posted a patch to implement the compromise Sam proposed: 
 https://bugs.webkit.org/show_bug.cgi?id=127079
 
 It would be nice to update the code-view.js so that it could show style 
 errors inline next to code but that could be done in a separate patch.
 
 - R. Niwa
 
 
 On Wed, Jan 15, 2014 at 8:29 PM, Gyuyoung Kim gyuyoung@webkit.org wrote:
 +1, I would prefer to see EWS log only when I want to see it.
 
 Gyuyoung.
 
 
 On Thu, Jan 16, 2014 at 1:24 PM, Joseph Pecoraro pecor...@apple.com wrote:
 I would also like to see a reduction in EWS spam.
 
 It is not just the comment clutter, but also quite a bit of emails.
 
 - Joe
 
 On Jan 15, 2014, at 8:17 PM, Ryosuke Niwa rn...@webkit.org wrote:
 
 We could do that, or add some JS hack to Bugzilla so that it hides EWS 
 comments by default but makes them expandable.
 
 - R. Niwa
 
 
 On Wed, Jan 15, 2014 at 8:09 PM, Sam Weinig wei...@apple.com wrote:
 Could we compromise for now, and remove all the non-test failing EWS 
 comments (e.g. build failure, style failure)?
 
 - Sam
 
 On Jan 15, 2014, at 8:04 PM, Ryosuke Niwa rn...@webkit.org wrote:
 
 I find Mac EWS's listing the failing tests to be very useful especially 
 because it uploads the results to Bugzilla.
 
 I do agree that comments about build failures are much less useful.
 
 - R. Niwa
 
 
 On Wed, Jan 15, 2014 at 7:54 PM, Sam Weinig wei...@apple.com wrote:
 Hi Everyone,
 
 I am becoming increasingly annoyed by the comments made in bugs.webkit.org 
 bugs by our non-human helpers, the EWS bots.  I don’t find the addition of 
 a comment indicating that a patch has failed on a bot, over the existing 
 indication in the bubble, to be worth the noise it creates.
 
 I propose that we stop allowing the bots to comment, and leave that space 
 for the developers.
 
 - Sam
 
 ___
 webkit-dev mailing list
 webkit-dev@lists.webkit.org
 https://lists.webkit.org/mailman/listinfo/webkit-dev
 
 
 
 ___
 webkit-dev mailing list
 webkit-dev@lists.webkit.org
 https://lists.webkit.org/mailman/listinfo/webkit-dev
 
 
 ___
 webkit-dev mailing list
 webkit-dev@lists.webkit.org
 https://lists.webkit.org/mailman/listinfo/webkit-dev
 
 
 
 ___
 webkit-dev mailing list
 webkit-dev@lists.webkit.org
 https://lists.webkit.org/mailman/listinfo/webkit-dev

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


Re: [webkit-dev] Proposal: Stop EWS bot commenting in bugs

2014-01-15 Thread Ryosuke Niwa
On Wed, Jan 15, 2014 at 10:54 PM, Alexey Proskuryakov a...@webkit.org wrote:

 (re-sent from a correct address)

 I think that it's good to try not dumping build failures into comments
 right away, and to see what happens.

 As for not showing style bot failures, it seems almost certain that this
 will make them substantially more annoying to work with. Can you describe
 the workflow for patch author and reviewer to deal with style bot warnings
 when they are not inline? Manually finding relevant lines by number can't
 work.

 I agree with Tim that dumping all tested paths along with style warnings
 is silly. How hard would it be it to get rid of that?


The workflow is to click on the bubble to see the style errors. e.g.
https://webkit-queues.appspot.com/results/6544662978363392

- R. Niwa
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev