Re: [webkit-dev] Shape-inside removal, bug #130698

2014-03-26 Thread Zoltan Horvath
Hi there,

The patch is landed in http://trac.webkit.org/changeset/166301
I already did the first step to simplify our geometry codebase in
http://trac.webkit.org/changeset/166316

Thumbs up for our shiny shape-outside! :-)

Cheers,
Zoltan


On Tue, Mar 25, 2014 at 12:59 PM, Zoltan Horvath zol...@webkit.org wrote:

 Hi there,

 CSS Shapes Level 1 (CR [1]) only contains shape-outside. We are focusing our 
 effort on finalizing the implementation of shape-outside, so it's worth to 
 remove shape-inside code at this point for now.

 A list of reasons for the removal:

 - Shape-inside is only part of Shapes Level 2, which needs to be improved on 
 some topics.
 - Shape-inside is lack of new shapes support (e.g. inset).
 - Deprecated shapes (r165472) are removed from the code (e.g. rectangle), 
 which affects shape-inside.
 - The current shape-inside code spreads across the layout code.
 - The current shape-inside implementation is experimental in some areas, and 
 the partially implemented code can have security implications.
 - Removal of shape-inside opens possibilities for code complexity and 
 performance optimizations for shape-outside. (e.g. simpler geometry code)

 I've got the patch reviewed in bug #130698 [2] ready for landing. If there 
 are no objections, I'll land the patch tomorrow morning.

 Cheers,
 Zoltan

 [1] http://www.w3.org/TR/2014/CR-css-shapes-1-20140320/
 [2] https://bugs.webkit.org/show_bug.cgi?id=130698


___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


Re: [webkit-dev] Anyone else having these problems with run-webkit-tests?

2014-03-26 Thread Bem Jones-Bey
On Mar 24, 2014, at 15:54 , Dirk Pranke 
dpra...@chromium.orgmailto:dpra...@chromium.org wrote:




On Mon, Mar 24, 2014 at 3:32 PM, Bem Jones-Bey 
bjone...@adobe.commailto:bjone...@adobe.com wrote:

On Mar 24, 2014, at 14:54 , Dirk Pranke 
dpra...@chromium.orgmailto:dpra...@chromium.org wrote:




On Sun, Mar 23, 2014 at 12:52 PM, Benjamin Poulain 
benja...@webkit.orgmailto:benja...@webkit.org wrote:
Same here :(


On 3/23/14, 12:15 PM, Darin Adler wrote:
When I use run-webkit-tests to run the entire test suite, on a debug build of 
TOT WebKit, on Mavericks, I’m having the following problems:

- Towards the end of the run, the tests run slowly, over a second per test on 
my 3.5GHz i7 iMac with tons of memory, which is about 10X too slow I think. The 
sample shows the vast majority of the time is spent in JavaScript garbage 
collection. This is running mostly the svg/custom tests.
Yep. The time from 31k to 33k is a long as from 0 to 31k :(

- Towards the end of the run, instead of the 8 parallel copies of 
DumpRenderTree, only 1 copy of DumpRenderTree seems to run. This is running 
mostly the svg/custom tests.
I think the problem is we can only run DumpRenderTree in parallel on different 
folders. Toward the end, everything left is one or two slow folders.


The problem is partially that the sharding is folder-at-a-time, partially that 
the svg folder is big and slow, and partially that svg comes near the end of 
the alphabet (i.e., we don't start the big slow directory until close to the 
end of run, so there ends up being one big long pole).

At some point we added code to run-webkit-tests to have a list of slow 
directories that got started towards the beginning. I don't remember if we did 
that before or after the Blink fork, but it would be easy to port it over from 
Blink if it was after.

I'm pretty sure this was after the Blink fork. I did a quick look through the 
history, and I found this:

http://src.chromium.org/viewvc/blink?revision=152697view=revision

Is that the correct change? If it will make tests run faster in WebKit land as 
well, I'm more than happy to port it myself. :-)


Yup, that's the one. Obviously the whole virtual test suite thing is less 
relevant, but you can use it for any directory you want.

Well, I tried that patch, replacing virtual with svg, and it doesn't seem 
to have any effect on the speed of the run for me. But I'm also not 100% sure 
that I am seeing the slowness issue that others are reporting. (I also get 18 
copies of DRT, not 8, so)

- Bem

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev