[webkit-dev] Alex Christensen is now a reviewer

2014-07-01 Thread Benjamin Poulain

Hi WebKittens,

After much deliberation around Alex's inability to eat his own head, 
Alex is now becoming a WebKit reviewer.


Alex is experienced in many core areas of WebKit. He has been hacking on 
the CSS JIT, WebGL, Web Timing, and Pointer Lock. He is also one of the 
courageous souls who fix Windows issues.


Congratulations Alex!

Benjamin
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


Re: [webkit-dev] Picture element implementation

2014-07-01 Thread Maciej Stachowiak

In fairness I should note that enabling by default in nightlies doesn’t 
necessarily mean anyone will ship it right away. But it’s still a good thing to 
do to get better test coverage.

 - Maciej

> On Jul 1, 2014, at 1:26 PM, Benjamin Poulain  wrote:
> 
> The barrier on entry is rather low to enable something in the nightly. It is 
> your responsibility to make sure we don't get tons of bug reports, crashes, 
> or security issues.
> 
> You need to have okay test coverage and make sure the tests work on all the 
> ports (if relevant for the given platforms obviously).
> 
> Then you just make a patch and post the link to the bug on the mailing list. 
> :)
> 
> Benjamin
> 
> On 7/1/14, 1:58 AM, Yoav Weiss wrote:
>> I've landed support for the sizes part of the syntax, currently on
>> HTMLImageElement only, behind an off-by-default compile time flag.
>> What is the proper procedure to request permission to turn on the flag
>> by default?
>> 
>> 
>> On Sun, Jun 15, 2014 at 11:31 PM, Yoav Weiss > > wrote:
>> 
>> 
>>On Mon, Mar 31, 2014 at 10:59 PM, Benjamin Poulain
>>mailto:benja...@webkit.org>> wrote:
>> 
>>On 3/31/14, 9:32 AM, Yoav Weiss wrote:
>> 
>>I'm currently implementing the picture element
>>>> in Blink, to extend
>>the srcset
>> 
>>implementation and handle more responsive images use-cases
>>
>> >
>> >.
>> 
>> 
>>I'd be interested in working with the WebKit project in
>>order to port
>>that work into WebKit, once it's done. Is the project
>>interested in the
>>feature?
>> 
>> 
>>I think it is worth experimenting with those. Please use a
>>compile time flag for the picture element, it still is unclear
>>how popular/useful this feature is going to be.
>> 
>> 
>>A patch for the 'sizes' part of the picture specification is waiting
>>for review at https://bugs.webkit.org/show_bug.cgi?id=133620
>>Feedback will be highly appreciated :)
>> 
>> 
> 
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


Re: [webkit-dev] Picture element implementation

2014-07-01 Thread Benjamin Poulain
The barrier on entry is rather low to enable something in the nightly. 
It is your responsibility to make sure we don't get tons of bug reports, 
crashes, or security issues.


You need to have okay test coverage and make sure the tests work on all 
the ports (if relevant for the given platforms obviously).


Then you just make a patch and post the link to the bug on the mailing 
list. :)


Benjamin

On 7/1/14, 1:58 AM, Yoav Weiss wrote:

I've landed support for the sizes part of the syntax, currently on
HTMLImageElement only, behind an off-by-default compile time flag.
What is the proper procedure to request permission to turn on the flag
by default?


On Sun, Jun 15, 2014 at 11:31 PM, Yoav Weiss mailto:y...@yoav.ws>> wrote:


On Mon, Mar 31, 2014 at 10:59 PM, Benjamin Poulain
mailto:benja...@webkit.org>> wrote:

On 3/31/14, 9:32 AM, Yoav Weiss wrote:

I'm currently implementing the picture element
> in Blink, to extend
the srcset

implementation and handle more responsive images use-cases

>.


I'd be interested in working with the WebKit project in
order to port
that work into WebKit, once it's done. Is the project
interested in the
feature?


I think it is worth experimenting with those. Please use a
compile time flag for the picture element, it still is unclear
how popular/useful this feature is going to be.


A patch for the 'sizes' part of the picture specification is waiting
for review at https://bugs.webkit.org/show_bug.cgi?id=133620
Feedback will be highly appreciated :)




___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


Re: [webkit-dev] Picture element implementation

2014-07-01 Thread Yoav Weiss
I've landed support for the sizes part of the syntax, currently on
HTMLImageElement only, behind an off-by-default compile time flag.
What is the proper procedure to request permission to turn on the flag by
default?


On Sun, Jun 15, 2014 at 11:31 PM, Yoav Weiss  wrote:

>
> On Mon, Mar 31, 2014 at 10:59 PM, Benjamin Poulain 
> wrote:
>
>> On 3/31/14, 9:32 AM, Yoav Weiss wrote:
>>
>>> I'm currently implementing the picture element
>>>  in Blink, to extend the srcset
>>>
>>> implementation and handle more responsive images use-cases
>>> >> vuLeAM9fJww/UHnMz7QLRWgJ>.
>>>
>>>
>>> I'd be interested in working with the WebKit project in order to port
>>> that work into WebKit, once it's done. Is the project interested in the
>>> feature?
>>>
>>
>> I think it is worth experimenting with those. Please use a compile time
>> flag for the picture element, it still is unclear how popular/useful this
>> feature is going to be.
>>
>>
>>
> A patch for the 'sizes' part of the picture specification is waiting for
> review at https://bugs.webkit.org/show_bug.cgi?id=133620
> Feedback will be highly appreciated :)
>
>
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev