Re: [webkit-dev] WebCore.exp.in
I think it’s a great idea to do this. But once we are ready to throw the switch I would like to review the difference between what’s going to be exported without the .exp files and what will be exported afterwards to look for problems. We did something like that with JavaScriptCore. If we manage to do this correctly that diff should be pretty small. — Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] FFT normalization in RealtimeAnalyser
Fixed in r172816. Dean > On 15 Aug 2014, at 1:56 am, Info wrote: > > This seems to be a bug... that has been fixed in Chromium: see > chromium\src\third_party\WebKit\Source\modules\webaudio > > > Zitat von Info : > >> In order to understand the idiotic differences between the data ranges of >> the AnalyzerNode's getFloatFrequencyData() and getByteFrequencyData() APIs I >> finally found myself analyzing the WebKit sources: >> https://github.com/WebKit/webkit/blob/master/Source/WebCore/Modules/webaudio/RealtimeAnalyser.cpp >> >> What surprises me there is the: >>const double magnitudeScale = 1.0 / DefaultFFTSize; >> which is used to normalize the FFT results (see >> RealtimeAnalyser::doFFTAnalysis()). >> >> Should the correct scaling factor not rather be: 2/actualFftSize? >> >> >> ___ >> webkit-dev mailing list >> webkit-dev@lists.webkit.org >> https://lists.webkit.org/mailman/listinfo/webkit-dev >> > > > > > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] WebCore.exp.in
That sounds like an excellent project! Symbols files are so annoying. On Wednesday, August 20, 2014, Alex Christensen wrote: > I'm attempting to remove WebCore.exp.in, WebKitExports.def.in, and the > associated build steps of processing these files. I'd like to continue > (more carefully than I did earlier) unless anyone has any objections. This > would involve the use of the new WEBCORE_EXPORT macro instead of > maintaining 3 lists of mangled names (Mac/iOS, Win32, Win64). > > http://trac.webkit.org/changeset/172798 was progress. I'll be more > careful and try not to break the build as I go. > > Alex > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > https://lists.webkit.org/mailman/listinfo/webkit-dev > -- - R. Niwa ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
[webkit-dev] WebCore.exp.in
I’m attempting to remove WebCore.exp.in, WebKitExports.def.in, and the associated build steps of processing these files. I’d like to continue (more carefully than I did earlier) unless anyone has any objections. This would involve the use of the new WEBCORE_EXPORT macro instead of maintaining 3 lists of mangled names (Mac/iOS, Win32, Win64). http://trac.webkit.org/changeset/172798 was progress. I’ll be more careful and try not to break the build as I go. Alex ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
