[webkit-dev] Keep ResourceBuffer?

2014-10-23 Thread Darin Adler
Hi folks. I’ve noticed that we have an unused abstraction in the loader code. ResourceBuffer is a cover for a SharedBuffer, with comments and remnants of an older effort to make it some kind of abstraction. But at the moment it’s just overhead and no abstraction. Does anyone object to my

Re: [webkit-dev] Keep ResourceBuffer?

2014-10-23 Thread Geoffrey Garen
I think Brady explained to me — a year ago? — what ResourceBuffer’s goal was. Brady, do you remember? Geoff On Oct 23, 2014, at 9:42 AM, Darin Adler da...@apple.com wrote: Hi folks. I’ve noticed that we have an unused abstraction in the loader code. ResourceBuffer is a cover for a

Re: [webkit-dev] Keep ResourceBuffer?

2014-10-23 Thread Antti Koivisto
Note that ResourceBuffer is virtual and wraps a ShareableResource on WebKit2 side. ShareableResource exists to do memory mapped IPC. The current factoring is confusing and cleaning this up is definitely a good idea. However it will require a bit more than just changing ResourceBuffers to

[webkit-dev] Fuzzinator reloaded

2014-10-23 Thread Renata Hodovan
Hi Folks, I only needed a year to write the second chapter of the first Fuzzinator blogpost, but now it is out! If you are interested you can read it here: http://webkit.sed.hu/blog/20141023/fuzzinator-reloaded Cheers, Reni ___ webkit-dev mailing

Re: [webkit-dev] Keep ResourceBuffer?

2014-10-23 Thread Brady Eidson
On Oct 23, 2014, at 9:56 AM, Geoffrey Garen gga...@apple.com wrote: I think Brady explained to me — a year ago? — what ResourceBuffer’s goal was. Brady, do you remember? Two goals. Use #1: On Oct 23, 2014, at 10:13 AM, Antti Koivisto koivi...@iki.fi wrote: Note that

Re: [webkit-dev] CSS4 Media Queries

2014-10-23 Thread Tab Atkins Jr.
On Fri, Oct 17, 2014 at 4:55 PM, Dean Jackson d...@apple.com wrote: Hi floks, I'm going to start implementing a small part of CSS4 Media Queries. I'll put it behind a feature flag. I'm starting with http://dev.w3.org/csswg/mediaqueries-4/#inverted because Apple wants to discuss it at the

Re: [webkit-dev] CSS4 Media Queries

2014-10-23 Thread Dean Jackson
On 23 Oct 2014, at 5:08 pm, Tab Atkins Jr. jackalm...@gmail.com wrote: On Fri, Oct 17, 2014 at 4:55 PM, Dean Jackson d...@apple.com wrote: Hi floks, I'm going to start implementing a small part of CSS4 Media Queries. I'll put it behind a feature flag. I'm starting with

Re: [webkit-dev] Keep ResourceBuffer?

2014-10-23 Thread Darin Adler
On Oct 23, 2014, at 10:13 AM, Antti Koivisto koivi...@iki.fi wrote: Note that ResourceBuffer is virtual and wraps a ShareableResource on WebKit2 side. ShareableResource exists to do memory mapped IPC. Really? I don’t see any code actually creating the class in WebKit2. There is a class

Re: [webkit-dev] Keep ResourceBuffer?

2014-10-23 Thread Antti Koivisto
In that case remove away. Did I mention this code is confusing? antti On Thu, Oct 23, 2014 at 8:11 PM, Darin Adler da...@apple.com wrote: On Oct 23, 2014, at 10:13 AM, Antti Koivisto koivi...@iki.fi wrote: Note that ResourceBuffer is virtual and wraps a ShareableResource on WebKit2