Re: [webkit-dev] Abandoned Tests
Hi Myles, These tests don’t fail — they are all skipped on mac, win, gtk, and efl. -Brent > On Jan 21, 2015, at 9:24 PM, Myles C. Maxfield wrote: > > On which platforms do they fail? > > —Myles >> On Jan 21, 2015, at 8:48 PM, Brent Fulgham wrote: >> >> I’ve been reviewing the various Windows layout tests, and have run across a >> few tests that seem to be leftovers from the Chromium project. I think all >> ports currently skip these tests: >> >> 1. fast/dom/title-directionality-removeChild.html >> 2. fast/dom/title-directionality.html >> 3. fast/events/drag-image-filename.html >> 4. fast/autoresize >> 5. fast/overflow/scrollbar-restored-and-then-locked.html >> >> If no one is using these tests, or plans to, I would like to remove them and >> the disconnected bits of code in DRT/WKTR that were originally meant to >> drive this code. >> >> If I don’t hear anything by this time next week, I’ll remove the code. >> >> Thanks, >> >> -Brent >> ___ >> webkit-dev mailing list >> webkit-dev@lists.webkit.org >> https://lists.webkit.org/mailman/listinfo/webkit-dev > ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Abandoned Tests
On which platforms do they fail? —Myles > On Jan 21, 2015, at 8:48 PM, Brent Fulgham wrote: > > I’ve been reviewing the various Windows layout tests, and have run across a > few tests that seem to be leftovers from the Chromium project. I think all > ports currently skip these tests: > > 1. fast/dom/title-directionality-removeChild.html > 2. fast/dom/title-directionality.html > 3. fast/events/drag-image-filename.html > 4. fast/autoresize > 5. fast/overflow/scrollbar-restored-and-then-locked.html > > If no one is using these tests, or plans to, I would like to remove them and > the disconnected bits of code in DRT/WKTR that were originally meant to drive > this code. > > If I don’t hear anything by this time next week, I’ll remove the code. > > Thanks, > > -Brent > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
[webkit-dev] Abandoned Tests
I’ve been reviewing the various Windows layout tests, and have run across a few tests that seem to be leftovers from the Chromium project. I think all ports currently skip these tests: 1. fast/dom/title-directionality-removeChild.html 2. fast/dom/title-directionality.html 3. fast/events/drag-image-filename.html 4. fast/autoresize 5. fast/overflow/scrollbar-restored-and-then-locked.html If no one is using these tests, or plans to, I would like to remove them and the disconnected bits of code in DRT/WKTR that were originally meant to drive this code. If I don’t hear anything by this time next week, I’ll remove the code. Thanks, -Brent ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
[webkit-dev] Implementing ES6 class syntax in JSC
Hello WebKittens, I'm implementing ES6 class syntax behind a build flag in https://webkit.org/b/140491. Please let me know if you have any concerns or comments. - R. Niwa ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
[webkit-dev] Problem with a crash using JSC code
Hi! I am now implementing with Youenn the Streams API standard [1] in WebKit. You can find the first patch at [2] (it's r? now). While we get that patch reviewed and landed we are adding more tests and working out the problems. One of them is one crash that I cannot hunt, with the following backtrace: http://fpaste.org/172619/60635142/ You can find the code under the lines to make it easier. What is going on is: 1. There's a call to the ReadableStream object, delegated to the JSReadableStreamSource as a result of the object creation. 2. There's a call to the JSReadableStream::read method, delegating in the ReadableStream that ends up pulling again and that second call crashes. It is probably something stupid I am not taking into account, but I have already been fighting this for a couple of days and cannot make it work properly. Any help? Thanks a lot in advance! [1] https://streams.spec.whatwg.org/ [2] https://bugs.webkit.org/show_bug.cgi?id=138967 signature.asc Description: This is a digitally signed message part ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
[webkit-dev] CSS Grid Layout Status Review (Jan 2015)
Hi, this is a new status review (last one was in August 2014 [1]) of the CSS Grid Layout [2] implementation done by Igalia. We'll summarize the work done during the past months and the plans for the future. Of course, we'll be really happy to get any kind of feedback from the community. The meta-bug to follow the evolution of this feature is: http://wkb.ug/60731 Main tasks done since August: * Track Sizing Algorithm (http://wkb.ug/60731): * Tracks no longer shrink with undefined remaining space. * Fixed the grow beyond growth limits use case. * Do not use items spanning through flex tracks when sizing content sized tracks. * Sizing content sized tracks is no longer order-dependent. * Support of percentages of indefinite sizes in minmax(). * Auto-placement (http://wkb.ug/103316): * Support sparse & dense packing modes. * Stack mode was finally dropped from the spec. * Alignment & justification (http://wkb.ug/133224 & http://wkb.ug/133222): * Upgrade self alignment properties (justify-self/items, align-self/items) to the last CSS3 spec. * Testing: * Improve test coverage, which lead to some bug reports and fixes. * Outside WebKit: Started to create the W3C test suite for grid [3]. Still on early stages, check the test plan [4] for more information. * Bugfixing: * Fixed different bugs reported by fuzzinator. * Generic bugfixing. Ongoing tasks: * Track Sizing Algorithm (http://wkb.ug/60731): * Initialization of track sizes from non spanning items. * Add and enforce the growth limit >= base size constraint. * Improve sizing computations of tracks growing beyond limits. * Fix behavior under min/max-width and min/max-content. * Add support for mark as infinitely growable and unmark. * Rewrite some of the loops that are incorrectly nested. * Alignment & justification (http://wkb.ug/133224 and http://wkb.ug/133222): * Due to some performance concerns, CSS3 upgrade of alignment properties is stalled. * There're several patches pending to fully support the Box Alignment specification in WebKit. * Testing: * Outside WebKit: Continue working on the W3C test suite in order to cover the whole spec. Then, import the test suite into WebKit. Plans for the future: * Absolutely positioned grid children. * Alignment & justification * Implementation of the Box Alignment spec for Grid Layout. * Dealing with orthogonal flows. * Writing modes. * Adapting the track sizing and item positioning to any writing mode and direction. * Implementing support for orthogonal flows. * Handling grid's and item's margin, border and padding in different writing modes and directions. * Support "auto" keyword for repeat() function. * Allow to grow the implicit grid before the explicit grid (supporting properly negative indexes for grid line numbers). * Implement fragmentation support once the spec is definitive regarding this topic. * Performance analysis and optimizations. * Grid support on Web Inspector. This is a high level summary, you can check the different bugs for more details. Please don't hesitate to ask any question. We hope you find this information useful. BTW, you can already test CSS Grid Layout using the WebKit nightly builds (remember to use "-webkit" prefix) [5]. Best regards, Rego [1] https://lists.webkit.org/pipermail/webkit-dev/2014-August/026756.html [2] http://dev.w3.org/csswg/css-grid/ [3] http://test.csswg.org/shepherd/search/spec/css-grid-1/ [4] http://rawgit.com/w3c/csswg-test/master/css-grid-1/test-plan/index.html [5] http://nightly.webkit.org/ ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
