Hi all,
I noticed many patches to fix newly introduced unused
parameter warnings on GTK and EFL ports nowadays.
(ToT EFL WebKit is warning free right now.)
CMake ports now handle unused parameters as warnings, not build
errors everywhere. (-Werror and -Wno-error=unused-parameter )
Mac port
On Jan 26, 2015, at 6:40 AM, Osztrogonác Csaba o...@inf.u-szeged.hu wrote:
Hi all,
I noticed many patches to fix newly introduced unused
parameter warnings on GTK and EFL ports nowadays.
(ToT EFL WebKit is warning free right now.)
CMake ports now handle unused parameters as warnings,
I have found serious bugs in WebKit with unused parameter warnings; I found
some when first turning on the warning. I don’t have a specific story to tell,
but I remember there was more than one case.
So far it’s been impractical to turn on this warning for our Objective-C code,
since we can’t
On Jan 26, 2015, at 9:28 AM, Darin Adler da...@apple.com wrote:
I have found serious bugs in WebKit with unused parameter warnings; I found
some when first turning on the warning. I don’t have a specific story to
tell, but I remember there was more than one case.
So far it’s been
On Jan 26, 2015, at 10:11 AM, Filip Pizlo fpi...@apple.com wrote:
So I actually do the opposite of pushing the configuration conditionals to
the edges - I put them into the innards.
Yes, this explains why the unused argument warnings are so frustrating for you!
I don’t know what it says for
Are there reasons any or all of these shouldn't be written as macros?
Yes: Macros are terrible.
Darin mentioned to me in person a way to resolve the problems I listed. I’ll
follow up with a patch soon.
Geoff___
webkit-dev mailing list
On Mon, Jan 26, 2015 at 2:31 PM, Geoffrey Garen gga...@apple.com wrote:
And I do agree that it can be inconvenient to deal with these warnings in
heavily #ifdef’d code. I think there are some good strategies for avoiding
that, and I’d like to talk about specific irritating cases so I can
The latest patch at https://bugs.webkit.org/show_bug.cgi?id=138967
resolves the crash (some JSC::Strong were missing).
I fear that the patch may be a bit too big to get a thorough review though.
The patch could be split into meaningful but not testable sub-patches
(module stuff, JS integration
8 matches
Mail list logo
