Re: [webkit-dev] [Conditional=] vs. #if in IDL files

2015-03-10 Thread Steven Coul (scoul)
A rebuild from scratch with no ccache is 48m approx. So 34 seconds isn’t so 
useful.

My “normal” build case involves pulling updates from webkit.org once or twice a 
day and rebuilding WTF/JSCore/WebCore with my patch set. I also do a clean 
rebuild prior to my local commits since it’s the best way to avoid having to 
revert or fix stuff too often.

Over the last 10 weeks, these builds have averaged 6m24s. So 34 seconds there 
is more significant.

Steve "Harry" Coul
sc...@cisco.com



On Mar 10, 2015, at 11:09 AM, Darin Adler  wrote:

>> On Mar 9, 2015, at 5:02 PM, Steven Coul (scoul)  wrote:
>> 
>> The IDL processing time went from 139 seconds real time to 105.
> 
> 34 seconds sounds like substantial savings. What’s the total build time for 
> you on that computer?
> 
> — Darin



signature.asc
Description: Message signed with OpenPGP using GPGMail
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


Re: [webkit-dev] [Conditional=] vs. #if in IDL files

2015-03-10 Thread Darin Adler
> On Mar 9, 2015, at 5:02 PM, Steven Coul (scoul)  wrote:
> 
> The IDL processing time went from 139 seconds real time to 105.

34 seconds sounds like substantial savings. What’s the total build time for you 
on that computer?

— Darin
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


Re: [webkit-dev] NEON_INTRINSICS

2015-03-10 Thread Carlos Garcia Campos
El lun, 09-03-2015 a las 14:48 -0700, Maciej Stachowiak escribió:
> Is anyone actually shipping it or planning to ship it? I don’t have a problem 
> with it if it’s being used, but from the thread it didn’t sound like anyone 
> was actually using it.

Or people were using it in their forks and never contributed the build
fix back upstream :-/

>  - Maciej
> 
> > On Mar 9, 2015, at 1:51 PM, Benjamin Poulain  wrote:
> > 
> > This is quite different from legacy features we remove all the time. This 
> > simple valuable code that happen to be untested because of the lack of 
> > ARMv7 infrastructure on the public bots.
> > 
> > Regarding maintenance, I'd be happy to fix bugs in that code.
> > 
> > Benjamin
> > 
> > On 3/9/15 11:34 AM, Maciej Stachowiak wrote:
> >> Requiring a perf bot to be set up before removing unmaintained code
> >> seems like a really high bar. What would it take to do a one-shot
> >> test of whether NEON_INTRINSICS is a perf benefit? Would it show up
> >> on PLT or on JS perf benchmarks if you compiled with it? If it’s not
> >> a speedup in its existing form, then it’s probably not worth keeping
> >> around. If it is, then that might be incentive for someone to get it
> >> production-ready and on by default for relevant platforms.
> >> 
> >> Regards, Maciej
> >> 
> >>> On Mar 8, 2015, at 6:56 PM, Benjamin Poulain 
> >>> wrote:
> >>> 
> >>> That code looks straightforward, the maintenance cost is likely
> >>> low. We just really need a test bot to run that code.
> >>> 
> >>> I suggest we wait until we have a ARMv7 perf bot and re-evaluate
> >>> NEON_INTRINSICS.
> >>> 
> >>> On 05/03/2015 22:27, Carlos Garcia Campos wrote:
>  Yesterday a patch was submitted to fix the build with
>  NEON_INTRINSICS, and Ossy pointed out that the build has been
>  broken since r170433, and nobody has noticed it until now. So
>  that makes me wonder if anybody is actually using that and if it
>  even works, because otherwise we should probably remove the
>  NEON_INTRINSICS code.
>  
>  So, is there anybody actually using that (I guess patched
>  downstream)?
>  
>  
>  ___ webkit-dev
>  mailing list webkit-dev@lists.webkit.org
>  https://lists.webkit.org/mailman/listinfo/webkit-dev
> >>> 
> >>> ___ webkit-dev mailing
> >>> list webkit-dev@lists.webkit.org
> >>> https://lists.webkit.org/mailman/listinfo/webkit-dev
> >> 
> > 
> 
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev


___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev