Re: [webkit-dev] Support "registerProtocolHandler" in WebKit2

2015-05-21 Thread Gyuyoung Kim
>On the face of it, the registerProtocolHandler API seems more general than
necessary, but the actual spec for it has a whitelist of specific schemes,
most of which seem reasonable for this kind of >purpose:
https://html.spec.whatwg.org/#custom-handlers

Yes, the custom-handlers specification only allows us to use specific
schemes, and current WebCore implementation was implemented based on the
spec.
Current supported schemes are only below,

"bitcoin", "geo", "im", "irc", "ircs", "magnet", "mailto", "mms",
"news", "nntp", "sip", "sms", "smsto", "ssh", "tel", "urn", "webcal",
"wtai", "xmpp"


>> (I am more dubious of the content handler aspect.)

>Agreed, especially as it requires the service to download the resource
>again. For that use case we need something smarter where you can pass
>along an object/stream of sorts I think.

I also don't want to support the "content handler" feature at the moment.
The feature might be more clear and mature. The patch of Bug 92749 only
supports registerProtocolHandler,
and unregisterProtocolHandler and isProtocolHandlerRegistered are supported
as optional.

 https://bugs.webkit.org/show_bug.cgi?id=92749

Gyuyoung.


On Fri, May 22, 2015 at 12:50 PM, Anne van Kesteren 
wrote:

> On Fri, May 22, 2015 at 12:26 PM, Maciej Stachowiak  wrote:
> > (I am more dubious of the content handler aspect.)
>
> Agreed, especially as it requires the service to download the resource
> again. For that use case we need something smarter where you can pass
> along an object/stream of sorts I think.
>
>
> --
> https://annevankesteren.nl/
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev
>
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


Re: [webkit-dev] Support "registerProtocolHandler" in WebKit2

2015-05-21 Thread Anne van Kesteren
On Fri, May 22, 2015 at 12:26 PM, Maciej Stachowiak  wrote:
> (I am more dubious of the content handler aspect.)

Agreed, especially as it requires the service to download the resource
again. For that use case we need something smarter where you can pass
along an object/stream of sorts I think.


-- 
https://annevankesteren.nl/
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


Re: [webkit-dev] Support "registerProtocolHandler" in WebKit2

2015-05-21 Thread Maciej Stachowiak

> On May 21, 2015, at 7:38 PM, Anne van Kesteren  wrote:
> 
> On Fri, May 22, 2015 at 1:25 AM, Anders Carlsson  wrote:
>> Sam Weinig 2015-05-15 10:12:54 PDT:
>>> Support for navigator.registerProtocolHandler/unregisterProtocolHandler is 
>>> not something we want to support in WebKit2 at this time as we are not 
>>> confident it is a good Web API. This might be a good conversation for 
>>> webkit-dev.
>> 
>> I agree with Sam.
> 
> So what else should web-based email or IRC clients or some such use to
> integrate with sites that offer mailto and irc URLs? Especially for
> email it seems like a worthwhile thing to solve. And that there's no
> cross-browser way to do it in 2015 is somewhat of a shame.

I think it’s useful to have an API for the "mailto" use case. A lot of people 
use webmail as their default mail client, and it seems nice to make mailto: 
links do the right thing for them. We do allow changing the default Mail reader 
to a native app, at least on Mac. I would almost consider having 
navigator.registerProtocolHandler just for that use case.

On the face of it, the registerProtocolHandler API seems more general than 
necessary, but the actual spec for it has a whitelist of specific schemes, most 
of which seem reasonable for this kind of purpose: 
https://html.spec.whatwg.org/#custom-handlers 


I am curious what Sam and Anders dislike about this API, and whether it might 
be something we’d want to support at least with a more restricted set of 
schemes.

(I am more dubious of the content handler aspect.)

Regards,
Maciej

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


Re: [webkit-dev] Support "registerProtocolHandler" in WebKit2

2015-05-21 Thread Anne van Kesteren
On Fri, May 22, 2015 at 1:25 AM, Anders Carlsson  wrote:
> Sam Weinig 2015-05-15 10:12:54 PDT:
>> Support for navigator.registerProtocolHandler/unregisterProtocolHandler is 
>> not something we want to support in WebKit2 at this time as we are not 
>> confident it is a good Web API. This might be a good conversation for 
>> webkit-dev.
>
> I agree with Sam.

So what else should web-based email or IRC clients or some such use to
integrate with sites that offer mailto and irc URLs? Especially for
email it seems like a worthwhile thing to solve. And that there's no
cross-browser way to do it in 2015 is somewhat of a shame.


-- 
https://annevankesteren.nl/
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


Re: [webkit-dev] Support "registerProtocolHandler" in WebKit2

2015-05-21 Thread Gyuyoung Kim
Hi Anders,

yes, Sam didn't like to support this feature. However, as I said, I think
this feature has been shipped by Firefox and Chrome browsers.
Besides It seems to me that web application will need to use this feature
in near future. However I know we can't support new feature
without WK2 owner's agreement.

I wonder if it is impossible to add new feature to WK2 as an experimental
feature with #ifdef guard or other better method.

Gyuyoung.

On Fri, May 22, 2015 at 1:25 AM, Anders Carlsson  wrote:

>
> On May 20, 2015, at 11:32 PM, Benjamin Poulain 
> wrote:
>
>  Looks llke nobody objects.
>
>
> That’s not true. From the bug:
>
> Sam Weinig  2015-05-15 10:12:54 PDT
>
> Support for navigator.registerProtocolHandler/unregisterProtocolHandler is 
> not something we want to support in WebKit2 at this time as we are not 
> confident it is a good Web API. This might be a good conversation for 
> webkit-dev.
>
>
>
> I agree with Sam.
>
> - Anders
>
>
>
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev
>
>
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


Re: [webkit-dev] Support "registerProtocolHandler" in WebKit2

2015-05-21 Thread Anders Carlsson

> On May 20, 2015, at 11:32 PM, Benjamin Poulain  wrote:
> 
> Looks llke nobody objects. 

That’s not true. From the bug:

Sam Weinig  2015-05-15 10:12:54 PDT
Support for navigator.registerProtocolHandler/unregisterProtocolHandler is not 
something we want to support in WebKit2 at this time as we are not confident it 
is a good Web API. This might be a good conversation for webkit-dev.


I agree with Sam.

- Anders


___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


Re: [webkit-dev] Support "registerProtocolHandler" in WebKit2

2015-05-21 Thread Gyuyoung Kim
Hi Benjamin,

> Looks llke nobody objects. Please make sure to #ifdef everything and
disable the feature on OS X and iOS.

Ok, let me add #ifdef guard for WK2 ports which don't use this feature.


There are already basic test cases for this feature. But I think this isn't
enough to test all use cases.
  -
http://trac.webkit.org/browser/trunk/LayoutTests/fast/dom/NavigatorContentUtils

After landing WK2 implementation, I'm going to improve the test cases or
add new tests for some use cases.

Thanks,
Gyuyoung.


On Thu, May 21, 2015 at 3:32 PM, Benjamin Poulain 
wrote:

>  Looks llke nobody objects. Please make sure to #ifdef everything and
> disable the feature on OS X and iOS.
>
> What is your plan for testing?
>
>
> On 5/19/15 6:31 PM, Gyuyoung Kim wrote:
>
>  Hello,
>
>  I would like to listen what do you think to support
> 'registerProtocolHandler' in WebKit2.
>
>  This feature is to execute web content through registered custom
> protocol.
> - For example, web content can register "mailto" custom protocol using
> this feature,
> 
> navigator.registerProtocolHandler("mailto",
>   "https://mail.naver.com/";,
>   "Web Mail");
> 
>
>  
> 
> Web Protocol Handler Sample - Test
> 
> 
> Send an email : mailto://";>this !
> 
> 
>
>  Besides this feature has been supported by Mozilla and Chromium (From
> Mozilla 3.0, Chromium 13).
>   -
> https://developer.mozilla.org/en-US/docs/Web/API/Navigator/registerProtocolHandler
>   - https://developer.mozilla.org/en/docs/Web-based_protocol_handlers
>
>  The feature is included in the W3C recommendation 28 released on Oct.
> 2014.
>   - W3C spec : http://www.w3.org/TR/html5/webappapis.html#custom-handlers
>
>  IIRC, some WebKit1 ports supported this feature though, those ports were
> deprecated. Now WebKit port supports this feature no more.
>
>  There is a very old bug to support this feature though, it wasn't
> maintained so far. Recently I updated it based on latest WebKit.
> - https://bugs.webkit.org/show_bug.cgi?id=92749
>
>  Feel free to give me any feedback about this feature.
>
>  Gyuyoung.
>
>
> ___
> webkit-dev mailing 
> listwebkit-dev@lists.webkit.orghttps://lists.webkit.org/mailman/listinfo/webkit-dev
>
>
>
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev
>
>
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev