Re: [webkit-dev] JavaScriptCore slowdown

2015-08-04 Thread Rodney Dowdall 

Hello

I tracked down this problem to a stall in our ports rendering code when 
it tries to send a message to our main app.  Fixing the stall results in 
a bubblemark score of 243, which is on par with the other browsers I 
have on my system.  Thanks for all of the suggestions.


Regards,
Rodney


On 06/29/2015 03:16 AM, Sergio Villar Senin wrote:

On 28/06/15 16:27, Rodney Dowdall wrote:

The only other question I have is if there is some sort of throttle on
the JavaScript callbacks.  The reason I ask is because no matter what I
do, the following page:

http://bubblemark.com/dhtml.htm

I only get 60 fps.  For this page the "fps" is a bit of misnomer because
they are just measuring the number of times they get a call in to their
JavaScript code.  It doesn't seem to matter how many balls I draw on the
screen, I always get 60 fps .

Not completly sure about the mac port but I think it does the same as
gtk, i.e, they used that magic value of 60fps as a reference for the
accelerated compositor to know when to generate new frames.

BR
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Stack Alignment error in LLINT

2015-08-04 Thread Rodney Dowdall 
So I tracked this down to the way I have to build the debug library for 
QNX due to size issues.  The issue goes away if I build the Release 
version.  Just as a note, exceptions do not impact the stack alignment.  
I compiled a 32 bit Linux x86 version of Webkit, and it had no issues.


Thanks for the help,
Rodney


On 07/27/2015 01:15 PM, Michael Saboff wrote:

Rodney,

The “align the stack” code for 32 bit platforms is found in 
Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm 
(http://trac.webkit.org/browser/trunk/Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm)
 beginning at line 218.  There isn’t an if / elsif for Linux or QNX.  This 
stack aligning code is at the top of the code that I think is generating your 
SIGTRAP.  Unfortunately I don’t think that the offline assembler that 
“assembles” the LLINT code has an OS specific type for X86 QNX.  You can try 
locally in your build adding “or X86” to the end of the “if X86_WIN” to see if 
that takes care of your issue.

It would also be interesting to know if Linux build with exceptions has the 
problem as well.

- Michael


On Jul 27, 2015, at 8:50 AM, Rodney Dowdall  wrote:

Thanks for the response Michael.  Where does the code that does the padding 
live?  It may be that I need to add something in there.  I can try changing 
what the stack alignment should be, but from what I understand the QNX OS 
should align to 16.  Maybe it is the exceptions that are causing the problem.  
I could try building a 32 bit Linux build with exceptions on to see if I get 
the same problem.

Regards,
Rodney

On 07/27/2015 11:24 AM, Michael Saboff wrote:

Rodney,

JavaScriptCore assumes that the stack is 16 byte aligned.  This may be more 
restrictive than some OS / ABIs, but there is code to pad appropriately for 
some platforms. You didn’t say what OS you are running on, but maybe there 
needs to be a code added for your OS.  Turning on C++ exceptions could be 
responsible, as that could be changing stack layout.  I don’t know of any 
platform that turns on C++ exceptions, so you may be in uncharted waters.

Your build is 2 months old, the current revision is 187434.  You could also try 
a more recent build.

- Michael


On Jul 27, 2015, at 8:07 AM, Rodney Dowdall  wrote:

Hello

I am seeing a SIGTRAP generated in the LLINT code when I try and load up a 
page.  It happens as soon as the page tries to execute JavaScript.  The target 
is an 32 bit x86 machine.  The SIGTRAP appears to happen when it is checking 
the stack alignment.  I have tried compiling the code with the gcc option 
-mstackrealign and without it.  The SIGTRAP is generated in the same spot with 
or without the option.  C++ exceptions are turned on (they have to be with this 
particular compiler.  The compiler is gcc based).  The version of Webkit that I 
am building from is 184845.


Here is the assembly execution that causes the SIGTRAP:

  vmEntryToJavaScript:
b9a80ef7:   push %ebp
b9a80ef8:   mov %esp,%ebp
b9a80efa:   push %esi
b9a80efb:   push %edi
b9a80efc:   push %ebx
b9a80efd:   mov 0xc(%ebp),%ebx
b9a80f00:   mov 0x8(%ebp),%edi
b9a80f03:   mov %ebp,%esp
b9a80f05:   sub $0x20,%esp
b9a80f08:   mov %ebx,(%esp)
b9a80f0b:   mov 0x1498(%ebx),%edx
b9a80f11:   mov %edx,0x4(%esp)
b9a80f15:   mov 0x1494(%ebx),%edx
b9a80f1b:   mov %edx,0x8(%esp)
b9a80f1f:   mov 0x10(%ebp),%esi
b9a80f22:   mov 0x20(%esi),%edx
b9a80f25:   add $0x4,%edx
b9a80f28:   shl $0x3,%edx
b9a80f2b:   mov %esp,%eax
b9a80f2d:   sub %edx,%eax
b9a80f2f:   cmp 0x2384(%ebx),%eax
b9a80f35:   jae 0xb9a80f71 

b9a80f71:   mov %eax,%esp
b9a80f73:   mov $0x4,%eax
b9a80f78:   sub $0x1,%eax
b9a80f7b:   mov 0x4(%esi,%eax,8),%ecx
b9a80f7f:   mov %ecx,0xc(%esp,%eax,8)
b9a80f83:   mov (%esi,%eax,8),%ecx
b9a80f86:   mov %ecx,0x8(%esp,%eax,8)
b9a80f8a:   test %eax,%eax
b9a80f8c:   jne 0xb9a80f78 

b9a80f9e:   sub $0x1,%ecx
b9a80fa1:   movl $0xfffc,0x2c(%esp,%ecx,8)
b9a80fa9:   movl $0x0,0x28(%esp,%ecx,8)
b9a80fb1:   cmp %ecx,%edx
b9a80fb3:   jne 0xb9a80f9e 
b9a80fb5:   mov 0x28(%esi),%eax
b9a80fb8:   test %edx,%edx
b9a80fba:   je 0xb9a80fd0 

b9a80f78:   sub $0x1,%eax
b9a80f7b:   mov 0x4(%esi,%eax,8),%ecx
b9a80f7f:   mov %ecx,0xc(%esp,%eax,8)
b9a80f83:   mov (%esi,%eax,8),%ecx
b9a80f86:   mov %ecx,0x8(%esp,%eax,8)
b9a80f8a:   test %eax,%eax
b9a80f8c:   jne 0xb9a80f78 

b9a80f78:   sub $0x1,%eax
b9a80f7b:   mov 0x4(%esi,%eax,8),%ecx
b9a80f7f:   mov %ecx,0xc(%esp,%eax,8)
b9a80f83:   mov (%esi,%eax,8),%ecx
b9a80f86:   mov %ecx,0x8(%esp,%eax,8)
b9a80f8a:   test %eax,%eax
b9a80f8c:   jne 0xb9a80f78 

b9a80f78:   sub $0x1,%eax
b9a80f7b:   mov 0x4(%esi,%eax,8),%ecx
b9a80f7f:   mov %ecx,0xc(%esp,%eax,8)
b9a80f83:   mov (%esi,%eax,8),%ecx
b9a80f86:   mov %ecx,0x8(%esp,%eax,8)
b9a80f8a:   test %eax,%eax
b9a80f8c:   jne 0xb9a80f78 
b9a80f8e:   mov 0x10(%esi),%edx
b9a80f91:   sub $0x1,%edx
b9a80f94:   mov 0x20(%esi),%ecx
b9a80f97:   sub $0x1,%ecx
b9a80f9a:   cmp %ecx,%edx
b9a80f9c:   je 0xb9a80fb5 

b9a80fd0:   mov %esp,0x1498(%ebx)
b9a8

Re: [webkit-dev] Committer Nomination: Dewei Zhu

2015-08-04 Thread Anders Carlsson 
+1

- Anders


___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

[webkit-dev] Committer Nomination: Dewei Zhu

2015-08-04 Thread Ryosuke Niwa 
Hi all,

I'd like to nominate Dewei Zhu to be a WebKit committer.  Dewei has written
and has been maintaining a framework to automate benchmarks
(run-benchmark).  He has 13 patches reviewed (
http://trac.webkit.org/search?q=dewei) by Stephanie Lewis and I.

I trust him to follow WebKit policies and processes.

- R. Niwa
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

[webkit-dev] Saam Barati is now a reviewer

2015-08-04 Thread Mark Lam 
You may have seen my commit making this so, but just to make it official ...

Hi everyone,

Just want to announce that Saam Barati is now a reviewer.  You can now bug him 
for reviews. =)

Mark
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Saam Barati is now a reviewer

2015-08-04 Thread Michael Saboff 
Congratulations Saam.

I see you already r+’ed a patch!

- Michael

> On Aug 4, 2015, at 11:48 AM, Filip Pizlo  wrote:
> 
> Congrats Saam!
> 
> -Filip
> 
> 
>> On Aug 4, 2015, at 11:47 AM, Mark Lam  wrote:
>> 
>> You may have seen my commit making this so, but just to make it official ...
>> 
>> Hi everyone,
>> 
>> Just want to announce that Saam Barati is now a reviewer.  You can now bug 
>> him for reviews. =)
>> 
>> Mark
>> ___
>> webkit-dev mailing list
>> webkit-dev@lists.webkit.org
>> https://lists.webkit.org/mailman/listinfo/webkit-dev
> 
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Saam Barati is now a reviewer

2015-08-04 Thread Yusuke SUZUKI 
Congrats!!!


On Tue, Aug 4, 2015 at 12:00 PM, Michael Saboff  wrote:

> Congratulations Saam.
>
> I see you already r+’ed a patch!
>
> - Michael
>
> > On Aug 4, 2015, at 11:48 AM, Filip Pizlo  wrote:
> >
> > Congrats Saam!
> >
> > -Filip
> >
> >
> >> On Aug 4, 2015, at 11:47 AM, Mark Lam  wrote:
> >>
> >> You may have seen my commit making this so, but just to make it
> official ...
> >>
> >> Hi everyone,
> >>
> >> Just want to announce that Saam Barati is now a reviewer.  You can now
> bug him for reviews. =)
> >>
> >> Mark
> >> ___
> >> webkit-dev mailing list
> >> webkit-dev@lists.webkit.org
> >> https://lists.webkit.org/mailman/listinfo/webkit-dev
> >
> > ___
> > webkit-dev mailing list
> > webkit-dev@lists.webkit.org
> > https://lists.webkit.org/mailman/listinfo/webkit-dev
>
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev
>
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Saam Barati is now a reviewer

2015-08-04 Thread SaamBarati1 
Thanks everyone!

Saam



> On Aug 4, 2015, at 12:00 PM, Michael Saboff  wrote:
> 
> Congratulations Saam.
> 
> I see you already r+’ed a patch!
> 
> - Michael
> 
>> On Aug 4, 2015, at 11:48 AM, Filip Pizlo  wrote:
>> 
>> Congrats Saam!
>> 
>> -Filip
>> 
>> 
>>> On Aug 4, 2015, at 11:47 AM, Mark Lam  wrote:
>>> 
>>> You may have seen my commit making this so, but just to make it official ...
>>> 
>>> Hi everyone,
>>> 
>>> Just want to announce that Saam Barati is now a reviewer.  You can now bug 
>>> him for reviews. =)
>>> 
>>> Mark
>>> ___
>>> webkit-dev mailing list
>>> webkit-dev@lists.webkit.org
>>> https://lists.webkit.org/mailman/listinfo/webkit-dev
>> 
>> ___
>> webkit-dev mailing list
>> webkit-dev@lists.webkit.org
>> https://lists.webkit.org/mailman/listinfo/webkit-dev
> 
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Saam Barati is now a reviewer

2015-08-04 Thread Filip Pizlo 
Congrats Saam!

-Filip


> On Aug 4, 2015, at 11:47 AM, Mark Lam  wrote:
> 
> You may have seen my commit making this so, but just to make it official ...
> 
> Hi everyone,
> 
> Just want to announce that Saam Barati is now a reviewer.  You can now bug 
> him for reviews. =)
> 
> Mark
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] [webkit-changes] [187867] trunk/Tools

2015-08-04 Thread Geoffrey Garen 
Oops!

I forgot that we had already gone through the nomination process for Saam.

Sam and I were talking about making Saam a reviewer right when you landed this 
patch. We counted his patches at 75, though, and we thought we couldn’t 
nominate him yet.

It looks like we miscounted, though, and Saam’s true patch count is 91.

Geoff

> On Aug 4, 2015, at 11:07 AM, Geoffrey Garen  wrote:
> 
> Mark,
> 
> While I am excited about Saam becoming a reviewer soon, this is the wrong 
> process.
> 
> Please roll out this change and follow the procedure explained at 
> https://www.webkit.org/coding/commit-review-policy.html 
> .
> 
> Thanks,
> Geoff
> 
>> On Aug 4, 2015, at 11:03 AM, mark@apple.com  
>> wrote:
>> 
>> Revision
>> 187867 Author
>> mark@apple.com Date
>> 2015-08-04 11:03:30 -0700 (Tue, 04 Aug 2015)
>> Log Message
>> 
>> Unreviewed. Make Saam Barati a WebKit reviewer.
>> 
>> * Scripts/webkitpy/common/config/contributors.json:
>> Modified Paths
>> 
>> trunk/Tools/ChangeLog 
>> trunk/Tools/Scripts/webkitpy/common/config/contributors.json 
>> 
>> Diff
>> 
>>  <>Modified: trunk/Tools/ChangeLog (187866 => 187867)
>> 
>> --- trunk/Tools/ChangeLog2015-08-04 17:48:59 UTC (rev 187866)
>> +++ trunk/Tools/ChangeLog2015-08-04 18:03:30 UTC (rev 187867)
>> @@ -1,3 +1,9 @@
>> +2015-08-04  Mark Lam  mailto:mark@apple.com>>
>> +
>> +Unreviewed. Make Saam Barati a WebKit reviewer.
>> +
>> +* Scripts/webkitpy/common/config/contributors.json:
>> +
>>  2015-08-04  Xabier Rodriguez Calvar  > >
>>  
>>  Unreviewed, updated Streams API watchlist.
>>  <>Modified: trunk/Tools/Scripts/webkitpy/common/config/contributors.json 
>> (187866 => 187867)
>> 
>> --- trunk/Tools/Scripts/webkitpy/common/config/contributors.json 
>> 2015-08-04 17:48:59 UTC (rev 187866)
>> +++ trunk/Tools/Scripts/webkitpy/common/config/contributors.json 
>> 2015-08-04 18:03:30 UTC (rev 187867)
>> @@ -2450,14 +2450,6 @@
>>  "ryuan"
>>   ]
>>},
>> -  "Saam Barati" : {
>> - "emails" : [
>> -"saambara...@gmail.com "
>> - ],
>> - "nicks" : [
>> -"saamyjoon"
>> - ]
>> -  },
>>"Sadrul Habib Chowdhury" : {
>>   "emails" : [
>>  "sad...@chromium.org "
>> @@ -4663,6 +4655,14 @@
>>  "weinig"
>>   ]
>>},
>> +  "Saam Barati" : {
>> + "emails" : [
>> +"saambara...@gmail.com "
>> + ],
>> + "nicks" : [
>> +"saamyjoon"
>> + ]
>> +  },
>>"Sergio Villar Senin" : {
>>   "emails" : [
>>  "svil...@igalia.com ",
>> ___
>> webkit-changes mailing list
>> webkit-chan...@lists.webkit.org 
>> https://lists.webkit.org/mailman/listinfo/webkit-changes 
>> 

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] [webkit-changes] [187867] trunk/Tools

2015-08-04 Thread Geoffrey Garen 
Mark,

While I am excited about Saam becoming a reviewer soon, this is the wrong 
process.

Please roll out this change and follow the procedure explained at 
https://www.webkit.org/coding/commit-review-policy.html.

Thanks,
Geoff

> On Aug 4, 2015, at 11:03 AM, mark@apple.com wrote:
> 
> Revision
> 187867 Author
> mark@apple.com Date
> 2015-08-04 11:03:30 -0700 (Tue, 04 Aug 2015)
> Log Message
> 
> Unreviewed. Make Saam Barati a WebKit reviewer.
> 
> * Scripts/webkitpy/common/config/contributors.json:
> Modified Paths
> 
> trunk/Tools/ChangeLog 
> trunk/Tools/Scripts/webkitpy/common/config/contributors.json 
> 
> Diff
> 
>  <>Modified: trunk/Tools/ChangeLog (187866 => 187867)
> 
> --- trunk/Tools/ChangeLog 2015-08-04 17:48:59 UTC (rev 187866)
> +++ trunk/Tools/ChangeLog 2015-08-04 18:03:30 UTC (rev 187867)
> @@ -1,3 +1,9 @@
> +2015-08-04  Mark Lam  mailto:mark@apple.com>>
> +
> +Unreviewed. Make Saam Barati a WebKit reviewer.
> +
> +* Scripts/webkitpy/common/config/contributors.json:
> +
>  2015-08-04  Xabier Rodriguez Calvar   >
>  
>  Unreviewed, updated Streams API watchlist.
>  <>Modified: trunk/Tools/Scripts/webkitpy/common/config/contributors.json 
> (187866 => 187867)
> 
> --- trunk/Tools/Scripts/webkitpy/common/config/contributors.json  
> 2015-08-04 17:48:59 UTC (rev 187866)
> +++ trunk/Tools/Scripts/webkitpy/common/config/contributors.json  
> 2015-08-04 18:03:30 UTC (rev 187867)
> @@ -2450,14 +2450,6 @@
>  "ryuan"
>   ]
>},
> -  "Saam Barati" : {
> - "emails" : [
> -"saambara...@gmail.com "
> - ],
> - "nicks" : [
> -"saamyjoon"
> - ]
> -  },
>"Sadrul Habib Chowdhury" : {
>   "emails" : [
>  "sad...@chromium.org "
> @@ -4663,6 +4655,14 @@
>  "weinig"
>   ]
>},
> +  "Saam Barati" : {
> + "emails" : [
> +"saambara...@gmail.com "
> + ],
> + "nicks" : [
> +"saamyjoon"
> + ]
> +  },
>"Sergio Villar Senin" : {
>   "emails" : [
>  "svil...@igalia.com ",
> ___
> webkit-changes mailing list
> webkit-chan...@lists.webkit.org 
> https://lists.webkit.org/mailman/listinfo/webkit-changes 
> 
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev