Re: [webkit-dev] Change WTFCrash to not trash the crash site register state.

Makes sense to me. -Filip > On Feb 8, 2016, at 12:33 PM, Mark Lam wrote: > > A store to 0xbbadbeef will still require the use of a register (at least on > ARM). The breakpoint instruction uses no registers (hence, we don’t have to > choose which register to sacrifice).

Re: [webkit-dev] Change WTFCrash to not trash the crash site register state.

A store to 0xbbadbeef will still require the use of a register (at least on ARM). The breakpoint instruction uses no registers (hence, we don’t have to choose which register to sacrifice). We can still identify the crash as an assertion by looking fro the EXC_BREAKPOINT instead of the

Re: [webkit-dev] Change WTFCrash to not trash the crash site register state.

I like this idea. I’ve wanted this for a while. Can you explain why your approach doesn’t inline a store to 0xbbadbeef, so that this aspect of the current behavior is preserved? -Filip > On Feb 8, 2016, at 11:55 AM, Mark Lam wrote: > > Hi WebKit folks, > > For

[webkit-dev] Change WTFCrash to not trash the crash site register state.

Hi WebKit folks, For non-debug OS(DARWIN) builds, I would like to change WTFCrash()’s implementation into an inlined function that has a single inlined asm statement that issues a breakpoint trap. The intent is to crash directly in the caller’s frame and preserve the register values at the