Re: [webkit-dev] Proposal: Adopt Web Inspector coding style for all WebKit JS/CSS source code

[manoj0011989]

Sent from my HTC

- Reply message -
From: "Filip Pizlo" 
To: "Ryosuke Niwa" 
Cc: "WebKit-Dev Development" 
Subject: [webkit-dev] Proposal: Adopt Web Inspector coding style for all WebKit 
JS/CSS source code
Date: Thu, Jul 7, 2016 10:47 AM

I like the idea of adop ting inspezctor style for JS builtins!

It might also be good to adopt it for JS tests that we write ourselves, with an 
escape hatch if you need to violate style to test some feature. For example, it 
should be a goal to follow inspector style for the JetStream harness code, and 
probably for all of ES6SampleBench. New JS tests in JavaScriptCore/tests/stress 
that we write ourselves probably should follow inspector style, because it's 
code that we have to read and understand and I can't think of a reason not to 
be consistent. Thoughts?

-Filip

> On Jul 6, 2016, at 7:53 PM, Ryosuke Niwa  wrote:
> 
>> On Wed, Jul 6, 2016 at 7:34 PM, Dean Jackson  wrote:
>> I propose we make it official that the Web Inspector Coding Style is what 
>> must be used for all JavaScript and CSS that count as source code in the 
>> project.
>> https://trac.webkit.org/wiki/WebInspectorCodingStyleGuide
>> 
>> Now that JavaScript is used in more places (JS builtins, some parts of the 
>> DOM, media controls) it would be nice to make it all consistent. Note that 
>> the page above can't decide if it is just JS or both JS and CSS, but I think 
>> it should be both.
> 
> It's hard to tell which parts of the above guide would apply to
> non-Inspector JS code because it has a bunch of Inspector specific
> guidelines such as layering guides and references to
> https://trac.webkit.org/browser/trunk/Source/WebInspectorUI/UserInterface/Views/Variables.css
> 
> We should probably extract the parts that matter into a separate MD
> file or a section in the wiki page before we proceed with this
> discussion.
> 
> - R. Niwa
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

[webkit-dev] Reseting runtime-flag enabled features and IndexedDB

[Yoav Weiss]

After encountering flakiness as a result of runtime flags leaking between
tests, I wrote a patch 
that resets all feature flags to their default values between tests.

The problem I encountered was that IndexedDB was turned off by default in
RuntimeEnabledFeatures, but was (and still is) manually turned on by
WebView (on both mac and win) and by WebKit2. That meant that reseting it
to the default value between tests caused a lot of tests to fail (as they
were relying on it being on). At the same time, I'm not sure that flipping
the default to true won't have an undesired impact on other ports which may
have the feature turned off.

So, I'd love some advice on that front. Do the other ports have that
feature disabled as I suspect? If so, would it be a problem to turn it on
for those ports?

Thanks,
Yoav
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev