Re: [webkit-dev] Proposal: Use #pragma once instead of header guards

2016-07-14 Thread Brady Eidson

> On Jul 14, 2016, at 11:17 AM, Frédéric WANG  wrote:
> 
> FYI, I just performed that change as part of a general cleanup of MathML
> headers:
> 
> https://trac.webkit.org/changeset/203228
> 
> The code style guidelines still mention the old-style header guards so
> it should probably be updated:
> 
> https://webkit.org/code-style-guidelines/#names-header-guards 
> 

Header guard style should be updated to be "#pragma once"
https://bugs.webkit.org/show_bug.cgi?id=159785 


~Brady

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


Re: [webkit-dev] Proposal: Use #pragma once instead of header guards

2016-07-14 Thread Frédéric WANG
FYI, I just performed that change as part of a general cleanup of MathML
headers:

https://trac.webkit.org/changeset/203228

The code style guidelines still mention the old-style header guards so
it should probably be updated:

https://webkit.org/code-style-guidelines/#names-header-guards

Le 10/03/2016 à 02:27, Anders Carlsson a écrit :
> Hi floks,
>
> Currently we use 
>
> #ifndef Header_h
> #define Header_h
>
> … 
>
> #endif
>
> I propose that we instead start using
>
> #pragma once
>
> which does the same thing. It can be faster on some compilers, is less error 
> prone and is one line instead of three! All compilers we use support #pragma 
> once.
>
> Thoughts?
> - Anders
>
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev




signature.asc
Description: OpenPGP digital signature
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


Re: [webkit-dev] Rounded dots in dotted border

2016-07-14 Thread Myles C. Maxfield
I have interest in fixing this :)

(Unless you want to first, of course! Please go right ahead if you are thinking 
of fixing this)

--Myles

> On Jul 14, 2016, at 6:21 AM, Konstantin Tokarev  wrote:
> 
> Hello,
> 
> Document [1] says defines "dotted" style as "a series of round dots", however 
> CG and Cairo implementations draw dots as squares.
> 
> Are there any plans to implement rounded dots?
> 
> 
> [1] https://www.w3.org/TR/css3-background/#border-style
> 
> -
> 
> P.S. Some context in case anyone is interested:
> 
> I was rewriting drawLine() implementation in Qt port which was broken by 
> r177686 (remember skewed border in Bugzilla with Cairo? That thing), and 
> found that implementations of drawLine() share the same logic and differ in 
> minor details only. However, out old code was drawing rounded dots, and I 
> feel it would be more appropriate to implement this logic in shared code, or 
> drop it completely if other ports are not planning to do this.
> 
> -- 
> Regards,
> Konstantin
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


Re: [webkit-dev] Is anyone here interested in improving rebaseline-server?

2016-07-14 Thread Konstantin Tokarev


14.07.2016, 18:44, "Michael Catanzaro" :
> On Thu, 2016-07-14 at 18:03 +0300, Konstantin Tokarev wrote:
>>  Is anybody here using rebaseline-server as well, or everyone is using
>>  garden-o-matic?
>
> Hm, I didn't know about these tools; is there documentation for them?

https://trac.webkit.org/wiki/Rebaseline
https://trac.webkit.org/wiki/RebaselineServer

>
> I've always rebased tests manually

Hope you never had to rebase hundreds at once :)

>
> Michael

-- 
Regards,
Konstantin
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


Re: [webkit-dev] Is anyone here interested in improving rebaseline-server?

2016-07-14 Thread Michael Catanzaro
On Thu, 2016-07-14 at 18:03 +0300, Konstantin Tokarev wrote:
> Is anybody here using rebaseline-server as well, or everyone is using
> garden-o-matic?

Hm, I didn't know about these tools; is there documentation for them?

I've always rebased tests manually

Michael
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


[webkit-dev] Is anyone here interested in improving rebaseline-server?

2016-07-14 Thread Konstantin Tokarev
Hello,

Recently I was using rebaseline-server a lot to do large-scale local 
rebaseline, and I've collected a list of glitches and inconveniences in its UI 
which make work less effecive than it could be, and would be nice to get fixed.

Is anybody here using rebaseline-server as well, or everyone is using 
garden-o-matic?

-- 
Regards,
Konstantin
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


Re: [webkit-dev] Rounded dots in dotted border

2016-07-14 Thread Zalan Bujtas
Hi,
There’s a bit of a history here.
https://bugs.webkit.org/show_bug.cgi?id=95203
I don’t see anyone working on this issue, but Myles might have plans.
 
Zalan.
> On Jul 14, 2016, at 6:21 AM, Konstantin Tokarev  wrote:
> 
> Hello,
> 
> Document [1] says defines "dotted" style as "a series of round dots", however 
> CG and Cairo implementations draw dots as squares.
> 
> Are there any plans to implement rounded dots?
> 
> 
> [1] https://www.w3.org/TR/css3-background/#border-style
> 
> -
> 
> P.S. Some context in case anyone is interested:
> 
> I was rewriting drawLine() implementation in Qt port which was broken by 
> r177686 (remember skewed border in Bugzilla with Cairo? That thing), and 
> found that implementations of drawLine() share the same logic and differ in 
> minor details only. However, out old code was drawing rounded dots, and I 
> feel it would be more appropriate to implement this logic in shared code, or 
> drop it completely if other ports are not planning to do this.
> 
> -- 
> Regards,
> Konstantin
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


[webkit-dev] Rounded dots in dotted border

2016-07-14 Thread Konstantin Tokarev
Hello,

Document [1] says defines "dotted" style as "a series of round dots", however 
CG and Cairo implementations draw dots as squares.

Are there any plans to implement rounded dots?


[1] https://www.w3.org/TR/css3-background/#border-style

-

P.S. Some context in case anyone is interested:

I was rewriting drawLine() implementation in Qt port which was broken by 
r177686 (remember skewed border in Bugzilla with Cairo? That thing), and found 
that implementations of drawLine() share the same logic and differ in minor 
details only. However, out old code was drawing rounded dots, and I feel it 
would be more appropriate to implement this logic in shared code, or drop it 
completely if other ports are not planning to do this.

-- 
Regards,
Konstantin
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev