Re: [webkit-dev] Another WPT bite

2017-05-15 Thread Ryosuke Niwa
On Mon, May 15, 2017 at 10:07 PM, Anne van Kesteren wrote: > On Tue, May 16, 2017 at 5:45 AM, Ryosuke Niwa wrote: >>> I think the main problem with not running a server is that behavior >>> for file URLs is not defined. And browsers tend to impose different

Re: [webkit-dev] Another WPT bite

2017-05-15 Thread youenn fablet
It makes sense to run WPT tests as HTTP URLs for conformance/regression purposes. It is fine to run WPT tests as file based URLs for development purposes. Tooling should make it possible to run WPT tests as HTTP URLs for development purposes with minimum to no cost. We are not there yet. Le lun.

Re: [webkit-dev] Another WPT bite

2017-05-15 Thread Anne van Kesteren
On Tue, May 16, 2017 at 5:45 AM, Ryosuke Niwa wrote: >> I think the main problem with not running a server is that behavior >> for file URLs is not defined. And browsers tend to impose different >> restrictions there. So you might end up debugging something only to >> later

Re: [webkit-dev] Where do we put WPT tests to be exported

2017-05-15 Thread youenn fablet
I see two main cases: - Writer of the patch is making sure to upstream WPT test changes at WebKit landing time. It is ok to make the changes directly in LayoutTests/imported/w3c/web-platform-tests/ - Writer plans to upstream WPT test changes at some point but wants more time. It is better to

[webkit-dev] Where do we put WPT tests to be exported

2017-05-15 Thread Ryosuke Niwa
Hi all, Youenn is working on a patch to automatically create a GitHub PR to export tests from a WebKit patch which includes changes to web-platform-tests [1]. That raises a question as to where we should put new tests or modified tests intended to be exported to web-platform-tests from WebKit.

Re: [webkit-dev] Another WPT bite

2017-05-15 Thread Ryosuke Niwa
On Sun, May 14, 2017 at 12:35 AM, Anne van Kesteren wrote: > On Sun, May 14, 2017 at 8:24 AM, Maciej Stachowiak wrote: >> For the engineer use case, we can make a command-line tool to launch the >> server and load the test. But it's kind of sad that in ~95% of