Re: [webkit-dev] WPT tests and runtime-enabled features

[youenn fablet]

Hi Ali,

Yes this is something we should have a solution for. Right now, we have two
ways:
- Enabling the runtime-enabled flag only in DumpRenderTree/WebKitTestRunner
- Updating WebKit testharnessreport.js to call internal APIs for some/all
WPT tests

Ideally, we should be able to set additional configuration information to
WPT tests without modifying them.
A configuration file alongside the WPT test might be feasible and could
supersede the 
technique.
Folder-based hierarchical configuration might be nice but I am unsure
whether that would meet the complexity tradeoff bar.
Nothing yet started there so any help would be greatly appreciated!
y

Le ven. 2 juin 2017 à 13:37, Ali Juma  a écrit :

> Hi all,
>
> While a feature is in development behind a runtime-enabled flag, is there
> a way to write tests in web-platform-tests that enable the feature when
> they're run as part of LayoutTests? Adding "" tags would technically work but seems a bit
> questionable.
>
> The point of this would be to be able to use web platform tests as
> regression tests while developing a feature, allowing the tests to be
> upstreamed sooner and saving having to write them outside of
> web-platform-tests first and then move them over later.
>
> Thanks,
> Ali
>
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

[webkit-dev] WPT tests and runtime-enabled features

[Ali Juma]

Hi all,

While a feature is in development behind a runtime-enabled flag, is there a
way to write tests in web-platform-tests that enable the feature when
they're run as part of LayoutTests? Adding "" tags would technically work but seems a bit
questionable.

The point of this would be to be able to use web platform tests as
regression tests while developing a feature, allowing the tests to be
upstreamed sooner and saving having to write them outside of
web-platform-tests first and then move them over later.

Thanks,
Ali
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] "ReflectOnly" IDL equivalent

[Ryosuke Niwa]

On Fri, Jun 2, 2017 at 9:18 AM, Chris Dumez  wrote:
> Hi,
>
> No, I do not believe WebKit supports ReflectOnly and this is not standard
> IDL either.
>
> The way to do it in WebKit would be to use a regular DOMString attribute, as
> in the specification and implement this logic in the c++ getter for this
> attribute. See HTMLElement::dir() for an example.
>
> We could also consider adding support for something like ReflectOnly in our
> bindings generator considering that this seems to be used quite a bit in the
> HTML specification and it would decrease code complexity a little.
> I’d actually be in favor of that.

I'd suggest other names like "ReflectEnum" or even "Reflect"
where EnumType is the name of enum that defines the list of values.

"ReflectOnly" doesn't tell us on what "only" applies. If I didn't know
the context, it sounds like something that does less work than regular
"Reflect".

- R. Niwa
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] "ReflectOnly" IDL equivalent

[Chris Dumez]

Hi,

No, I do not believe WebKit supports ReflectOnly and this is not standard IDL 
either.

The way to do it in WebKit would be to use a regular DOMString attribute, as in 
the specification and implement this logic in the c++ getter for this 
attribute. See HTMLElement::dir() for an example.

We could also consider adding support for something like ReflectOnly in our 
bindings generator considering that this seems to be used quite a bit in the 
HTML specification and it would decrease code complexity a little.
I’d actually be in favor of that.

--
 Chris Dumez




> On Jun 1, 2017, at 10:57 PM, Yoav Weiss  wrote:
> 
> I'm working on the link preload feature and as part of that want to align it 
> to the spec from an IDL perspective.
> The `as` attribute is defined  as 
> an "enumerated attribute", which reflects only a finite set of known values. 
> That is important for feature detection purposes, so that developers can know 
> which `as` values are supported by the implementation.
> 
> In Blink this is done using `ReflectOnly 
> `
>  (pending CL ), and I'm 
> wondering what is the WebKit equivalent to implement attributes that are 
> limited to known values 
> .
> 
> Thanks! :)
> Yoav
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

[webkit-dev] WebKit project in Coverity

[Carlos Alberto Lopez Perez]

Hi,

Coverity is an static analysis tool that allows to find bugs and
vulnerabilities on the source code via static analysis.

For open source projects, they offer free usage of their platform.

The WebKit project is already registered there since a while. [1]
To read the reports in detail or run new scans you have to be
member of the WebKit project in Coverity.


I happen to be one of the admins there, and I will happily grant you
access to this platform if you are a WebKit committer (listed in
contributors.json).

So if you are interested in this, just send me an email requesting
access.

Regards
---

[1] https://scan.coverity.com/projects/webkit



signature.asc
Description: OpenPGP digital signature
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev