Re: [webkit-dev] WebKit nightly stops

2017-06-19 Thread Yusuke SUZUKI
Thanks! It works fine to me :D Regards, Yusuke Suzuki On Tue, Jun 20, 2017 at 9:05 AM, Ling Ho wrote: > Hello Yusuke, > > Thanks for reporting the problem! I believe the issue is now fixed. > > ... > ling > > > On 6/16/17 12:23 PM, Yusuke SUZUKI wrote: > > Hi WebKittens! > >

Re: [webkit-dev] Why does our std::optional lack the has_value() function?

2017-06-19 Thread Yusuke SUZUKI
Feel free to review it :) https://bugs.webkit.org/show_bug.cgi?id=173582 Regards, Yusuke Suzuki On Tue, Jun 20, 2017 at 1:48 PM, JF Bastien wrote: > Ours was imported from: https://github.com/akrzemi1/Optional > at: 727c729dd1d9f06f225868280e50154594d7e59d > > And it was

Re: [webkit-dev] Why does our std::optional lack the has_value() function?

2017-06-19 Thread JF Bastien
Ours was imported from: https://github.com/akrzemi1/Optional at: 727c729dd1d9f06f225868280e50154594d7e59d And it was subsequently added in:

Re: [webkit-dev] Why does our std::optional lack the has_value() function?

2017-06-19 Thread Yusuke SUZUKI
I think it is just missing in the original code. Seeing the original repository, we can find that these things are added. We can rebaseline our copy by applying these changes. https://github.com/akrzemi1/Optional/commits/master Regards, Yusuke Suzuki On Tue, Jun 20, 2017 at 1:45 PM, Darin

[webkit-dev] Why does our std::optional lack the has_value() function?

2017-06-19 Thread Darin Adler
I noticed we don’t have has_value() in our version of std::optional. Does anyone know why? — Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] WebKit nightly stops

2017-06-19 Thread Ling Ho
Hello Yusuke, Thanks for reporting the problem! I believe the issue is now fixed. ... ling On 6/16/17 12:23 PM, Yusuke SUZUKI wrote: Hi WebKittens! I've found that WebKit nightly build stops after June 13. Is there any issues? And thank you for maintainers of the buildbots! WebKit nigthly

Re: [webkit-dev] Intent to remove the WebCore::IconDatabase (GTK needs to make a decision)

2017-06-19 Thread Geoffrey Garen
Another minor comment: it seems like this new API returns raw data. It seems like the native way to use this would result in running untrusted data from the network through image decoders outside the Web Process sandbox. Do we have a way to avoid that? >>> >>> This came up

Re: [webkit-dev] Intent to remove the WebCore::IconDatabase (GTK needs to make a decision)

2017-06-19 Thread Dan Bernstein
On Jun 19, 2017, at 10:20 AM, Geoffrey Garen wrote: >>> Another minor comment: it seems like this new API returns raw data. It >>> seems like the native way to use this would result in running untrusted >>> data from the network through image decoders outside the Web

Re: [webkit-dev] Intent to remove the WebCore::IconDatabase (GTK needs to make a decision)

2017-06-19 Thread Geoffrey Garen
>> Another minor comment: it seems like this new API returns raw data. It seems >> like the native way to use this would result in running untrusted data from >> the network through image decoders outside the Web Process sandbox. Do we >> have a way to avoid that? > > This came up while