Re: [webkit-dev] How we enable template functions

2017-08-22 Thread JF Bastien
I'd suggest considering what it'll look like when we're migrating to concepts in C++20. Here's an example for our bitwise_cast: https://github.com/jfbastien/bit_cast/blob/master/bit_cast.h#L10 Notice the 3 ways to enable. There's also the option of using enable_if on the return value, or as a

Re: [webkit-dev] How we enable template functions

2017-08-22 Thread Chris Dumez
I personally prefer std::enable_if<>. For e.g. template::value> Class Foo { } I don’t like that something inside the body of a class / function would cause a template to be enabled or not. --  Chris Dumez > On Aug 22, 2017, at 8:34 PM, Keith Miller wrote: > >

[webkit-dev] How we enable template functions

2017-08-22 Thread Keith Miller
Hello fellow WebKittens, I’ve noticed over time that we don’t have standard way that we enable versions of template functions/classes (flasses?). For the most part it seems that people use std::enable_if, although, it seems like it is attached to every possible place in the function/class. I

Re: [webkit-dev] "webkit-patch upload --no-review" submits to EWS by default

2017-08-22 Thread Keith Miller
Does it make sense to have a --wip option that’s basically --no-review / don’t run EWS? There are times I upload clearly broken patches for early analysis that don’t need to be run on EWS. Cheers, Keith > On Aug 14, 2017, at 2:16 PM, Daniel Bates wrote: > > Hi all, > >

Re: [webkit-dev] Question regarding per-file BSD license text

2017-08-22 Thread Geoffrey Garen
> My understanding is that if a non-Apple contributor adds a new file, their > affiliation should only be reflected in the copyright line and NOT in the BSD > license text itself (which reads "APPLE INC."), because the latter is a > "per-file copy of a project-wide license". Could someone

[webkit-dev] Question regarding per-file BSD license text

2017-08-22 Thread Kirsling, Ross
Hi all, I have a simple question about the license text included in each source file. My understanding is that if a non-Apple contributor adds a new file, their affiliation should only be reflected in the copyright line and NOT in the BSD license text itself (which reads "APPLE INC."), because