Re: [webkit-dev] How we enable template functions

2017-08-23 Thread Keith Miller
> On Aug 23, 2017, at 12:21 PM, Konstantin Tokarev wrote: > > > > 23.08.2017, 21:15, "Keith Miller" >: >> You can totally have the enable_if in the template list: >> >> #define ENABLE_TEMPLATE_IF(condition) typename = typename >> std::enable_if::type >> >> t

Re: [webkit-dev] "webkit-patch upload --no-review" submits to EWS by default

2017-08-23 Thread Keith Miller
I think it’s fine to not have a shorthand. I can just make an alias for the shorthand version myself. Cheers, Keith > On Aug 23, 2017, at 12:11 PM, Aakash Jain wrote: > > We can have "--wip" flag equivalent to " --no-review --no-ews". > > But I feel that it might not be clear to many people t

[webkit-dev] Webkit Nightly build is broken

2017-08-23 Thread Alex Skachkov
Hi all, I can’t found any new Webkit Nightly build in https://webkit.org/nightly/archives/ later then r220267 August 4, 2017. It seems that Webkit Nightly build is broken, is it possible to fix it? Best regards, Oleksandr Skachkov _

Re: [webkit-dev] How we enable template functions

2017-08-23 Thread Konstantin Tokarev
23.08.2017, 21:15, "Keith Miller" : > You can totally have the enable_if in the template list: > > #define ENABLE_TEMPLATE_IF(condition) typename = typename > std::enable_if::type > > template::value))> > int foo() { return 0; } > > template::value))> > double foo() { return 0; } > > int myFunct

Re: [webkit-dev] "webkit-patch upload --no-review" submits to EWS by default

2017-08-23 Thread Aakash Jain
We can have "--wip" flag equivalent to " --no-review --no-ews". But I feel that it might not be clear to many people that it also means skip EWS. Many people might expect EWS to be run while passing --wip flag. The name "wip" doesn't clear imply skipping EWS. Maybe we can come up with a better

Re: [webkit-dev] "webkit-patch upload --no-review" submits to EWS by default

2017-08-23 Thread Ryosuke Niwa
On Wed, Aug 23, 2017 at 9:11 AM, Andy Estes wrote: > > > On Aug 22, 2017, at 8:10 PM, Keith Miller wrote: > > Does it make sense to have a --wip option that’s basically --no-review / > don’t run EWS? There are times I upload clearly broken patches for early > analysis that don’t need to be run on

Re: [webkit-dev] How we enable template functions

2017-08-23 Thread Keith Miller
You can totally have the enable_if in the template list: #define ENABLE_TEMPLATE_IF(condition) typename = typename std::enable_if::type template::value))> int foo() { return 0; } template::value))> double foo() { return 0; } int myFunction() { return foo(); } Compiles fine for me. There

Re: [webkit-dev] "webkit-patch upload --no-review" submits to EWS by default

2017-08-23 Thread Andy Estes
> On Aug 22, 2017, at 8:10 PM, Keith Miller wrote: > > Does it make sense to have a --wip option that’s basically --no-review / > don’t run EWS? There are times I upload clearly broken patches for early > analysis that don’t need to be run on EWS. `webkit-patch --no-review --no-ews` should d

Re: [webkit-dev] How we enable template functions

2017-08-23 Thread Mark Lam
One application of enable_if I’ve needed in the past is where I want specialization of a template function with the same argument signatures, but returning a different type. The only way I know to make that happen is to use enable_if in the return type, e.g. std::enable_if, T>::type doStuf