[webkit-dev] Breakpoints in #included .cpp files [Was: Growing tired of long build times? Check out this awesome new way to speed up your build... soon (HINT: It's not buying a new computer)]

2017-08-29 Thread Simon Fraser
> On Aug 28, 2017, at 9:46 PM, Geoffrey Garen wrote: > >> The line numbers and filenames will be total nonsense if we just concatenate >> multiple source files together. But that's very easy to fix if the script >> that concatenates the sources also adds a #line statement

Re: [webkit-dev] Growing tired of long build times? Check out this awesome new way to speed up your build... soon (HINT: It's not buying a new computer)

2017-08-29 Thread Maciej Stachowiak
> On Aug 29, 2017, at 6:40 PM, Sam Weinig wrote: > > > >> On Aug 29, 2017, at 6:36 PM, Maciej Stachowiak > > wrote: >> >> >> >>> On Aug 29, 2017, at 5:54 PM, Sam Weinig >> > wrote: >>>

Re: [webkit-dev] Growing tired of long build times? Check out this awesome new way to speed up your build... soon (HINT: It's not buying a new computer)

2017-08-29 Thread Sam Weinig
> On Aug 29, 2017, at 6:36 PM, Maciej Stachowiak wrote: > > > >> On Aug 29, 2017, at 5:54 PM, Sam Weinig > > wrote: >> >> >> >>> On Aug 29, 2017, at 12:46 PM, Geoffrey Garen >> >

Re: [webkit-dev] Growing tired of long build times? Check out this awesome new way to speed up your build... soon (HINT: It's not buying a new computer)

2017-08-29 Thread Maciej Stachowiak
> On Aug 29, 2017, at 5:54 PM, Sam Weinig wrote: > > > >> On Aug 29, 2017, at 12:46 PM, Geoffrey Garen > > wrote: >> >>> This isn’t the scenario I find myself in most often. A much more common >>> scenario is working on a

Re: [webkit-dev] Growing tired of long build times? Check out this awesome new way to speed up your build... soon (HINT: It's not buying a new computer)

2017-08-29 Thread Sam Weinig
> On Aug 29, 2017, at 12:46 PM, Geoffrey Garen wrote: > >> This isn’t the scenario I find myself in most often. A much more common >> scenario is working on a change; touch one or two files, and then compile >> and test/debug. Rinse and repeat. > > We’ve already tested

Re: [webkit-dev] Growing tired of long build times? Check out this awesome new way to speed up your build... soon (HINT: It's not buying a new computer)

2017-08-29 Thread Carlos Alberto Lopez Perez
On 29/08/17 02:37, Keith Miller wrote: > Bundling happens as part of the CMake configuration process, in the > CMake build. In the Xcode build it’s more complicated since we cannot > dynamically choose the files we are going to compile. The onlysolution > I know of is to pre-list a bunch of files

Re: [webkit-dev] Unified source builds: A new rule for static variables

2017-08-29 Thread Keith Miller
In addition to what Darin said, I think using a consistent name makes the most sense. If “Internal” is what we would use for some of the places we should use it everywhere. Cheers, Keith > On Aug 29, 2017, at 5:29 PM, Darin Adler wrote: > >> On Aug 29, 2017, at 4:32 PM,

Re: [webkit-dev] Growing tired of long build times? Check out this awesome new way to speed up your build... soon (HINT: It's not buying a new computer)

2017-08-29 Thread Michael Catanzaro
On Tue, Aug 29, 2017 at 3:22 PM, Olmstead, Don wrote: Sure but in a corporate environment it can be a really big win. All of our developers have their machines hooked up to the distributed build system and we also have servers hanging out that can be used in the build.

Re: [webkit-dev] Growing tired of long build times? Check out this awesome new way to speed up your build... soon (HINT: It's not buying a new computer)

2017-08-29 Thread Keith Miller
> On Aug 29, 2017, at 4:20 PM, Alicia Boya García wrote: > > On 08/30/2017 12:00 AM, Keith Miller wrote: > >> The automated system should handle your concern about bundling similar .cpp >> files together. The proposed system bundles by directory and also sorts the >> files

Re: [webkit-dev] Unified source builds: A new rule for static variables

2017-08-29 Thread Ryosuke Niwa
On Tue, Aug 29, 2017 at 2:14 PM, Keith Miller wrote: > > >> On Aug 29, 2017, at 11:37 AM, Maciej Stachowiak wrote: >> >> >> >>> On Aug 29, 2017, at 11:31 AM, Darin Adler wrote: >>> >>> Sent from my iPhone >>> On Aug 29, 2017, at

Re: [webkit-dev] Growing tired of long build times? Check out this awesome new way to speed up your build... soon (HINT: It's not buying a new computer)

2017-08-29 Thread Alicia Boya García
On 08/30/2017 12:00 AM, Keith Miller wrote: > The automated system should handle your concern about bundling similar .cpp > files together. The proposed system bundles by directory and also sorts the > files in those directories when dividing up the files. Is there any reason to > think that

Re: [webkit-dev] Growing tired of long build times? Check out this awesome new way to speed up your build... soon (HINT: It's not buying a new computer)

2017-08-29 Thread Dan Bernstein
> On Aug 29, 2017, at 3:16 PM, Geoffrey Garen wrote: > > Interesting. > > The majority cases here are 7 or fewer files. I don’t see much difference > between these cases and our existing benchmark for one file, where Keith > described the build time delta as "barely

Re: [webkit-dev] Growing tired of long build times? Check out this awesome new way to speed up your build... soon (HINT: It's not buying a new computer)

2017-08-29 Thread Geoffrey Garen
Interesting. The majority cases here are 7 or fewer files. I don’t see much difference between these cases and our existing benchmark for one file, where Keith described the build time delta as "barely noticeable". For the minority cases that are 23 - 75 files, these challenge Keith’s

Re: [webkit-dev] Growing tired of long build times? Check out this awesome new way to speed up your build... soon (HINT: It's not buying a new computer)

2017-08-29 Thread Keith Miller
As far as the static renaming problem, Darin convinced me in the other thread that we probably don’t need such a heavy handed approach. At least in JSC, there are a number of variables that have generic names that should be put into a namespace but the majority probably don’t need to be

Re: [webkit-dev] Growing tired of long build times? Check out this awesome new way to speed up your build... soon (HINT: It's not buying a new computer)

2017-08-29 Thread Konstantin Tokarev
29.08.2017, 14:44, "Alicia Boya García" : > On 08/29/2017 06:20 AM, Daniel Bates wrote: > >>  Do we know what is the cause(es) for the slow clean builds? I am assuming >> that much of the speed up from the "unified source" comes from clang being >> able to use an in-memory

Re: [webkit-dev] Growing tired of long build times? Check out this awesome new way to speed up your build... soon (HINT: It's not buying a new computer)

2017-08-29 Thread Dan Bernstein
> On Aug 29, 2017, at 1:39 PM, Geoffrey Garen wrote: > >> I see. The right question to ask would have been how much change occurs in >> their working copy between consecutive incremental builds. > > If you want to help make our benchmark righter, please do share any data

Re: [webkit-dev] Unified source builds: A new rule for static variables

2017-08-29 Thread Keith Miller
> On Aug 29, 2017, at 11:37 AM, Maciej Stachowiak wrote: > > > >> On Aug 29, 2017, at 11:31 AM, Darin Adler wrote: >> >> Sent from my iPhone >> >>> On Aug 29, 2017, at 11:22 AM, Keith Miller wrote: >>> >>> I doubt anyone is going

Re: [webkit-dev] Growing tired of long build times? Check out this awesome new way to speed up your build... soon (HINT: It's not buying a new computer)

2017-08-29 Thread Konstantin Tokarev
29.08.2017, 23:54, "Alicia Boya García" : > I'm all for stable bundle .cpp files. Automatic generation can be nice > for the first time... and once in while we can try to modify the bundles > to try to make the build even faster, but really most of the time bundle > contents

Re: [webkit-dev] Growing tired of long build times? Check out this awesome new way to speed up your build... soon (HINT: It's not buying a new computer)

2017-08-29 Thread Alicia Boya García
I'm all for stable bundle .cpp files. Automatic generation can be nice for the first time... and once in while we can try to modify the bundles to try to make the build even faster, but really most of the time bundle contents should not change unless new files are added and everybody should get

Re: [webkit-dev] Growing tired of long build times? Check out this awesome new way to speed up your build... soon (HINT: It's not buying a new computer)

2017-08-29 Thread Geoffrey Garen
> I see. The right question to ask would have been how much change occurs in > their working copy between consecutive incremental builds. If you want to help make our benchmark righter, please do share any data you have about the average content of an incremental build that is distinct from a

Re: [webkit-dev] Growing tired of long build times? Check out this awesome new way to speed up your build... soon (HINT: It's not buying a new computer)

2017-08-29 Thread Saam Barati
> On Aug 29, 2017, at 1:22 PM, Olmstead, Don wrote: > > Sure but in a corporate environment it can be a really big win. All of our > developers have their machines hooked up to the distributed build system and > we also have servers hanging out that can be used in the

Re: [webkit-dev] Growing tired of long build times? Check out this awesome new way to speed up your build... soon (HINT: It's not buying a new computer)

2017-08-29 Thread Olmstead, Don
Sure but in a corporate environment it can be a really big win. All of our developers have their machines hooked up to the distributed build system and we also have servers hanging out that can be used in the build. This sort of thing doesn't require anyone to change how they write their code

Re: [webkit-dev] Growing tired of long build times? Check out this awesome new way to speed up your build... soon (HINT: It's not buying a new computer)

2017-08-29 Thread Konstantin Tokarev
29.08.2017, 22:48, "Geoffrey Garen" : >>> We have some preliminary data that says incremental builds will be OK, but >>> not a full benchmark. >>> >>> Here’s a full benchmark I propose to test incremental builds: >>> >>> Start 7 days ago in SVN history. Do a clean build. >>>

Re: [webkit-dev] Growing tired of long build times? Check out this awesome new way to speed up your build... soon (HINT: It's not buying a new computer)

2017-08-29 Thread Dan Bernstein
> On Aug 29, 2017, at 12:48 PM, Geoffrey Garen wrote: > >>> We have some preliminary data that says incremental builds will be OK, but >>> not a full benchmark. >>> >>> Here’s a full benchmark I propose to test incremental builds: >>> >>> Start 7 days ago in SVN

Re: [webkit-dev] Growing tired of long build times? Check out this awesome new way to speed up your build... soon (HINT: It's not buying a new computer)

2017-08-29 Thread Geoffrey Garen
>> We have some preliminary data that says incremental builds will be OK, but >> not a full benchmark. >> >> Here’s a full benchmark I propose to test incremental builds: >> >> Start 7 days ago in SVN history. Do a clean build. >> >> SVN update forward by 24 hours. Do an incremental

Re: [webkit-dev] Growing tired of long build times? Check out this awesome new way to speed up your build... soon (HINT: It's not buying a new computer)

2017-08-29 Thread Geoffrey Garen
> This isn’t the scenario I find myself in most often. A much more common > scenario is working on a change; touch one or two files, and then compile and > test/debug. Rinse and repeat. We’ve already tested this case. The worst case slowdown, if you touch a small file that's in the same

Re: [webkit-dev] Code style: Propose using C++11 uniform initializer syntax in member initializer lists

2017-08-29 Thread Michael Catanzaro
Perhaps we should just start using uniform initializer syntax everywhere. ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Unified source builds: A new rule for static variables

2017-08-29 Thread Michael Catanzaro
On Tue, Aug 29, 2017 at 1:37 PM, Maciej Stachowiak wrote: I tend to agree with this. I think keeping names of static functions globally unique is reasonable, so long as we have an automated way to check. This seems better than namespaces. With namespaces, it's still possible

Re: [webkit-dev] Growing tired of long build times? Check out this awesome new way to speed up your build... soon (HINT: It's not buying a new computer)

2017-08-29 Thread Sam Weinig
> On Aug 29, 2017, at 11:03 AM, Geoffrey Garen wrote: > >> I worry about adopting unity build because while it makes clean builds >> faster, it also slows down incremental builds. As a developer, I rarely do >> clean builds, I mostly do incremental builds so this would

Re: [webkit-dev] Growing tired of long build times? Check out this awesome new way to speed up your build... soon (HINT: It's not buying a new computer)

2017-08-29 Thread Michael Catanzaro
I'd like to propose a variation on Keith's proposal. I think we should manually determine which files should be built together, rather than writing CMake code to do that automatically. Let's consider an example of what use of the FILENAME namespace, as Keith proposes, might look like. I

Re: [webkit-dev] Growing tired of long build times? Check out this awesome new way to speed up your build... soon (HINT: It's not buying a new computer)

2017-08-29 Thread Konstantin Tokarev
  29.08.2017, 21:32, "Maciej Stachowiak" :  On Aug 29, 2017, at 9:10 AM, Chris Dumez wrote: I worry about adopting unity build because while it makes clean builds faster, it also slows down incremental builds. As a developer, I rarely do clean builds, I mostly do

Re: [webkit-dev] Unified source builds: A new rule for static variables

2017-08-29 Thread Maciej Stachowiak
> On Aug 29, 2017, at 11:31 AM, Darin Adler wrote: > > Sent from my iPhone > >> On Aug 29, 2017, at 11:22 AM, Keith Miller wrote: >> >> I doubt anyone is going to run such a script before they go to upload a >> patch to bugzilla. > > EWS was what

Re: [webkit-dev] Growing tired of long build times? Check out this awesome new way to speed up your build... soon (HINT: It's not buying a new computer)

2017-08-29 Thread Maciej Stachowiak
> On Aug 29, 2017, at 9:10 AM, Chris Dumez wrote: > > I worry about adopting unity build because while it makes clean builds > faster, it also slows down incremental builds. As a developer, I rarely do > clean builds, I mostly do incremental builds so this would likely make

Re: [webkit-dev] Unified source builds: A new rule for static variables

2017-08-29 Thread Darin Adler
Sent from my iPhone > On Aug 29, 2017, at 11:22 AM, Keith Miller wrote: > > I doubt anyone is going to run such a script before they go to upload a > patch to bugzilla. EWS was what I was hoping for; likely to be sufficient. But it could also be integrated into the

Re: [webkit-dev] Growing tired of long build times? Check out this awesome new way to speed up your build... soon (HINT: It's not buying a new computer)

2017-08-29 Thread Keith Miller
> On Aug 29, 2017, at 11:03 AM, Geoffrey Garen wrote: > >> I worry about adopting unity build because while it makes clean builds >> faster, it also slows down incremental builds. As a developer, I rarely do >> clean builds, I mostly do incremental builds so this would

Re: [webkit-dev] Unified source builds: A new rule for static variables

2017-08-29 Thread Keith Miller
> On Aug 29, 2017, at 10:15 AM, Darin Adler wrote: > > If we decide that we can’t support file scope identifiers then we should > figure out the most practical way to do it. Of course this affects constants > and variables, too, not just functions. > > I think this special

Re: [webkit-dev] Growing tired of long build times? Check out this awesome new way to speed up your build... soon (HINT: It's not buying a new computer)

2017-08-29 Thread Konstantin Tokarev
29.08.2017, 21:19, "Olmstead, Don" : > Did you happen to look at any sort of distributed build system? We use > distributed builds here for WebKit and a full rebuild is pretty reasonable. > That would negate the need to change how everything is done to get a unity >

Re: [webkit-dev] Growing tired of long build times? Check out this awesome new way to speed up your build... soon (HINT: It's not buying a new computer)

2017-08-29 Thread Dan Bernstein
> On Aug 29, 2017, at 11:03 AM, Geoffrey Garen wrote: > >> I worry about adopting unity build because while it makes clean builds >> faster, it also slows down incremental builds. As a developer, I rarely do >> clean builds, I mostly do incremental builds so this would

Re: [webkit-dev] Growing tired of long build times? Check out this awesome new way to speed up your build... soon (HINT: It's not buying a new computer)

2017-08-29 Thread Olmstead, Don
Did you happen to look at any sort of distributed build system? We use distributed builds here for WebKit and a full rebuild is pretty reasonable. That would negate the need to change how everything is done to get a unity build going. From: webkit-dev

Re: [webkit-dev] Code style: Propose using C++11 uniform initializer syntax in member initializer lists

2017-08-29 Thread Daniel Bates
Posted patch to update Code Style Guidelines at < https://bugs.webkit.org/show_bug.cgi?id=176058>. Dan On Mon, Aug 28, 2017 at 9:24 PM, Daniel Bates wrote: > Hi all, > > I am writing to propose using C++11 uniform initializer syntax in member > initializer lists. The

Re: [webkit-dev] Growing tired of long build times? Check out this awesome new way to speed up your build... soon (HINT: It's not buying a new computer)

2017-08-29 Thread Geoffrey Garen
> I worry about adopting unity build because while it makes clean builds > faster, it also slows down incremental builds. As a developer, I rarely do > clean builds, I mostly do incremental builds so this would likely make my > experience worse? We have some preliminary data that says

Re: [webkit-dev] Unified source builds: A new rule for static variables

2017-08-29 Thread Darin Adler
If we decide that we can’t support file scope identifiers then we should figure out the most practical way to do it. Of course this affects constants and variables, too, not just functions. I think this special FILENAME namespace isn’t all that helpful or needed. If a file contains a class

Re: [webkit-dev] Growing tired of long build times? Check out this awesome new way to speed up your build... soon (HINT: It's not buying a new computer)

2017-08-29 Thread Keith Miller
> On Aug 29, 2017, at 9:10 AM, Chris Dumez wrote: > > I worry about adopting unity build because while it makes clean builds > faster, it also slows down incremental builds. As a developer, I rarely do > clean builds, I mostly do incremental builds so this would likely make

Re: [webkit-dev] Growing tired of long build times? Check out this awesome new way to speed up your build... soon (HINT: It's not buying a new computer)

2017-08-29 Thread Ben Kelly
On Tue, Aug 29, 2017 at 12:10 PM, Chris Dumez wrote: > I worry about adopting unity build because while it makes clean builds > faster, it also slows down incremental builds. As a developer, I rarely do > clean builds, I mostly do incremental builds so this would likely make my

Re: [webkit-dev] Growing tired of long build times? Check out this awesome new way to speed up your build... soon (HINT: It's not buying a new computer)

2017-08-29 Thread Chris Dumez
> On Aug 29, 2017, at 9:24 AM, Keith Miller wrote: > >> * We could not use any namespaces and just fix name clashes as they arise, >> but only if we have some more predictable way to determine which files will >> be built together regardless of port or build

Re: [webkit-dev] Growing tired of long build times? Check out this awesome new way to speed up your build... soon (HINT: It's not buying a new computer)

2017-08-29 Thread Keith Miller
> On Aug 28, 2017, at 8:10 PM, Michael Catanzaro wrote: > > On Mon, Aug 28, 2017 at 7:37 PM, Keith Miller wrote: >> Given that most of the build time in incremental builds is scanning >> dependencies, this change is probably only barely

Re: [webkit-dev] Unified source builds: A new rule for static variables

2017-08-29 Thread Keith Miller
> On Aug 29, 2017, at 9:04 AM, Chris Dumez wrote: > > I indeed think this will require “using” statements or explicit namespace at > call sites. Yeah, this is basically what’s required. Unfortunately, if you ‘using namespace’ in a namespace all subsequent copies of that

Re: [webkit-dev] Growing tired of long build times? Check out this awesome new way to speed up your build... soon (HINT: It's not buying a new computer)

2017-08-29 Thread Chris Dumez
I worry about adopting unity build because while it makes clean builds faster, it also slows down incremental builds. As a developer, I rarely do clean builds, I mostly do incremental builds so this would likely make my experience worse? Unity builds also require a lot of code churn to resolve

Re: [webkit-dev] Unified source builds: A new rule for static variables

2017-08-29 Thread Chris Dumez
I indeed think this will require “using” statements or explicit namespace at call sites. I don’t think anonymous namespaces are suitable for resolving naming conflicts due to unity builds since the functions and up in the same compilation unit. --  Chris Dumez > On Aug 29, 2017, at 9:00

Re: [webkit-dev] Unified source builds: A new rule for static variables

2017-08-29 Thread Darin Adler
How does this work? Without a “using” how does it know to search this namespace? Is this superior to using anonymous namespaces instead of “static”? — Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org

Re: [webkit-dev] Growing tired of long build times? Check out this awesome new way to speed up your build... soon (HINT: It's not buying a new computer)

2017-08-29 Thread Geoffrey Garen
> I wonder whether the unified sources builds would still allow us to > keep using compiler caches like ccache. Our plan is to use ccache. > Second question/caveat is, wouldn't the bundle build penalize too much > incremental builds? If your data is correct we would get a <20% build > time

Re: [webkit-dev] Growing tired of long build times? Check out this awesome new way to speed up your build... soon (HINT: It's not buying a new computer)

2017-08-29 Thread Myles C. Maxfield
I often use the “Show Preprocessed Source” option in Xcode. Will I be able to continue using this? > On Aug 29, 2017, at 8:10 AM, Sergio Villar Senin wrote: > > O Lun, 28-08-2017 ás 17:37 -0700, Keith Miller escribiu: >> Hello fellow Webkittens, >> >> Are you growing tired

Re: [webkit-dev] Growing tired of long build times? Check out this awesome new way to speed up your build... soon (HINT: It's not buying a new computer)

2017-08-29 Thread Sergio Villar Senin
O Lun, 28-08-2017 ás 17:37 -0700, Keith Miller escribiu: > Hello fellow Webkittens, > > Are you growing tired of long cat naps while waiting 45 minutes for > WebKit to build? (I’ve definitely never done this 蘿!) > Do you want WebKit to build up to 3-4x faster on a clean build?* > Does seeing your

Re: [webkit-dev] CSS Typed OM

2017-08-29 Thread Sergio Villar Senin
O Mar, 22-08-2017 ás 07:54 +1000, Dean Jackson escribiu: > > > > On 19 Aug 2017, at 5:44 am, Olmstead, Don > > wrote: > > > > I'd like to begin an implementation of CSS Typed OM (CSSOM) and > > wanted to gauge interest for supporting the feature. > > Go for it! While

Re: [webkit-dev] Growing tired of long build times? Check out this awesome new way to speed up your build... soon (HINT: It's not buying a new computer)

2017-08-29 Thread Michael Catanzaro
On Mon, Aug 28, 2017 at 11:46 PM, Geoffrey Garen wrote: Our plan is to use #include. That has worked in the past. Geoff Um yes, that would be better. :) ___ webkit-dev mailing list webkit-dev@lists.webkit.org

Re: [webkit-dev] Growing tired of long build times? Check out this awesome new way to speed up your build... soon (HINT: It's not buying a new computer)

2017-08-29 Thread Alicia Boya García
On 08/29/2017 06:20 AM, Daniel Bates wrote: > Do we know what is the cause(es) for the slow clean builds? I am assuming > that much of the speed up from the "unified source" comes from clang being > able to use an in-memory #include cache to avoid disk I/O and re-parsing of a > seen header.