Re: [webkit-dev] RFC: Removing feature flag defaults in build-webkit

2017-09-21 Thread Keith Miller
This seems like a good progress change we could make. I’m on board! Cheers, Keith > On Sep 21, 2017, at 11:54 AM, Tim Horton wrote: > > Hi, all! > > Would anybody mind if build-webkit stopped being a source of default values > of feature flags? > > We have defaults

Re: [webkit-dev] RFC: Removing feature flag defaults in build-webkit

2017-09-21 Thread Michael Catanzaro
FWIW the build-webkit arguments to enable/disable features are useless for CMake ports, since we have a --cmakeargs argument that works just as well. So the rest of FeatureList.pm can be removed whenever the XCode build is ready for that to happen. On Thu, Sep 21, 2017 at 3:32 PM, Tim Horton

Re: [webkit-dev] RFC: Removing feature flag defaults in build-webkit

2017-09-21 Thread Tim Horton
> On Sep 21, 2017, at 13:25, Michael Catanzaro wrote: > > On Thu, Sep 21, 2017 at 2:26 PM, Tim Horton wrote: >> Sure. And someday I think we should go down that path, but generating the >> xcconfigs will be trickier (but also a positive

Re: [webkit-dev] RFC: Removing feature flag defaults in build-webkit

2017-09-21 Thread Michael Catanzaro
On Thu, Sep 21, 2017 at 2:26 PM, Tim Horton wrote: Sure. And someday I think we should go down that path, but generating the xcconfigs will be trickier (but also a positive because people already have trouble with them) because they involve more bizarre conditions.

Re: [webkit-dev] RFC: Removing feature flag defaults in build-webkit

2017-09-21 Thread Tim Horton
> On Sep 21, 2017, at 12:04, Konstantin Tokarev wrote: > > > > 21.09.2017, 22:01, "Tim Horton" : >>> On Sep 21, 2017, at 11:57, Konstantin Tokarev wrote: >>> >>> 21.09.2017, 21:54, "Tim Horton" :

Re: [webkit-dev] RFC: Removing feature flag defaults in build-webkit

2017-09-21 Thread Konstantin Tokarev
21.09.2017, 22:01, "Tim Horton" : >>  On Sep 21, 2017, at 11:57, Konstantin Tokarev wrote: >> >>  21.09.2017, 21:54, "Tim Horton" : >>>  Hi, all! >>> >>>  Would anybody mind if build-webkit stopped being a source of default

Re: [webkit-dev] RFC: Removing feature flag defaults in build-webkit

2017-09-21 Thread Tim Horton
> On Sep 21, 2017, at 11:57, Konstantin Tokarev wrote: > > > > 21.09.2017, 21:54, "Tim Horton" : >> Hi, all! >> >> Would anybody mind if build-webkit stopped being a source of default values >> of feature flags? >> >> We have defaults for

Re: [webkit-dev] RFC: Removing feature flag defaults in build-webkit

2017-09-21 Thread Konstantin Tokarev
21.09.2017, 21:54, "Tim Horton" : > Hi, all! > > Would anybody mind if build-webkit stopped being a source of default values > of feature flags? > > We have defaults for feature flags in FeatureDefines.xcconfig for Xcode, > WebKitFeatures.cmake (and Options*.cmake for

[webkit-dev] RFC: Removing feature flag defaults in build-webkit

2017-09-21 Thread Tim Horton
Hi, all! Would anybody mind if build-webkit stopped being a source of default values of feature flags? We have defaults for feature flags in FeatureDefines.xcconfig for Xcode, WebKitFeatures.cmake (and Options*.cmake for platform overrides) for CMake, and FeatureDefines.h for everyone. This