Re: [webkit-dev] Experimental features enabled by default

2018-06-26 Thread Tim Horton


> On Jun 26, 2018, at 18:55, Michael Catanzaro  wrote:
> 
> 
> Hi,
> 
> We're a lot closer after r233227!
> 
> There is still IsSecureContextAttributeEnabled. Shall we switch the default 
> value of that one to use DEFAULT_EXPERIMENTAL_FEATURES_ENABLED instead of 
> true?

Not sure, waiting for other people to get back to me. There’s some indication 
that this one, indeed, should follow DEFAULT_EXPERIMENTAL_FEATURES_ENABLED, but 
I want to make sure :)

> We should also move CSSAnimationTriggersEnabled to the experimental features 
> section of the file, and add the category tag. FullScreenEnabled and 
> EncryptedMediaAPIEnabled should also be moved down in the file.

Will have to peek at these!

> Then we can just update the comment to indicate that custom values like 
> DEFAULT_SERVICE_WORKERS_ENABLED are fine as long as they're thoughtful and 
> consider ENABLE(EXPERIMENTAL_FEATURES), and that will take care of the other 
> cases.

Makes sense.

> Michael
> 
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


Re: [webkit-dev] Experimental features enabled by default

2018-06-26 Thread Michael Catanzaro



Hi,

We're a lot closer after r233227!

There is still IsSecureContextAttributeEnabled. Shall we switch the 
default value of that one to use DEFAULT_EXPERIMENTAL_FEATURES_ENABLED 
instead of true?


We should also move CSSAnimationTriggersEnabled to the experimental 
features section of the file, and add the category tag. 
FullScreenEnabled and EncryptedMediaAPIEnabled should also be moved 
down in the file.


Then we can just update the comment to indicate that custom values like 
DEFAULT_SERVICE_WORKERS_ENABLED are fine as long as they're thoughtful 
and consider ENABLE(EXPERIMENTAL_FEATURES), and that will take care of 
the other cases.


Michael

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


Re: [webkit-dev] JavaScriptCore on Fuchsia

2018-06-26 Thread Yusuke SUZUKI
Sounds very cool!

On Wed, Jun 27, 2018 at 6:01 AM Adam Barth  wrote:

> As part of developing Fuchsia [1] (a new open-source operating
> system), we ported JavaScriptCore to run on Fuchsia [2].  At the time,
> our intent was to use this code within the Fuchsia source tree but not
> to make it available for developers writing applications for Fuchsia.
> However, recently, we've gotten a number of requests from customers
> who would like to use JavaScriptCore in their Fuchsia applications.
>
> I'd like your advice about the best way to maintain JavaScriptCore
> support for Fuchsia.  Here are some possibilities I can imagine, but
> we're open to other possibilities as well:
>
> 1. Maintain a fork of JavaScriptCore somewhere on googlesource.com
> that supports Fuchsia and instruct customers to obtain the Fuchsia
> port of JavaScriptCore from googlesource.com.
>
> 2. Maintain a branch of JavaScriptCore in svn.webkit.org that supports
> Fuchsia.
>
> 3. Maintain support for JavaScriptCore in the mainline of svn.webkit.org.
>
> For reference, here's the patch we applied to WTF and JavaScriptCore
> to enable Fuchsia support:
>
> https://gist.github.com/abarth/b4fc909d83be5133cd7a5af209757e96


We are working on making JSC portable by introducing JSCOnly[1], so given
very small changes for Fushcia are super exciting (positive) results to me!

Looking through the patch in the gist, the ToT JSC moves
MachineStackMarker.cpp's
platform dependent part to WTF to make JSC further platform-independent.
So I think changes in JSC are further small: the required work for Fushcia
port is
mainly extending WTF for Fushcia OS.

My suggestion is introducing Fushcia port, adding both PLATFORM(FUSHCIA)
and OS(FUSHCIA) ifdefs.
Use OS(FUSHCIA) when the change is b/c of Fushcia's APIs. And use
PLATFORM(FUSHCIA) to change
the policy of the released build (e.g. enabling / disabling FTL JIT etc.).
By doing so, JSCOnly port also becomes available in Fushcia. And it means
that Fushcia port can benefit
from JSCOnly port's work for making WTF and JSC portable.

[1]: https://lists.webkit.org/pipermail/webkit-dev/2015-November/027785.html

>
>
> This patch is based on webkit@206446, but we'd obviously rebase the
> patch onto top-of-tree before contributing it.
>
> I'm happy to answer any questions you might have that would help you
> provide the best advice.  If you would prefer to communicate off-list,
> I'm happy to do that as well.
>
> Thanks in advance,
> Adam
>
> [1] https://fuchsia.googlesource.com/docs/+/master/README.md
> [2] Actually, if you look at
> https://fuchsia.googlesource.com/third_party/webkit, you'll see that
> we've ported WebCore as well, but this email concerns only
> JavaScriptCore.
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev
>
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


Re: [webkit-dev] JavaScriptCore on Fuchsia

2018-06-26 Thread Filip Pizlo


> On Jun 26, 2018, at 2:28 PM, Adam Barth  wrote:
> 
> On Tue, Jun 26, 2018 at 2:08 PM Filip Pizlo  wrote:
>> This looks super interesting!
> 
> Thanks.  :)
> 
>> I have some questions:
>> 
>> - Does your JSC port enable all of JSC’s optimization features, like the FTL 
>> JIT and concurrent GC?
> 
> Nope.  I believe we just have the interpreter working.
> 
>>- Is it a goal to enable basically everything we enable, long term?
> 
> The Fuchsia project itself doesn't have any particular goals for
> JavaScriptCore.  It's possible that our customers who want to use
> JavaScriptCore on Fuchsia will have goals for additional functionality
> in the future, but assuming we host the code on svn.webkit.org, I
> would imagine recommending that those customers interact directly with
> the WebKit project.

Gotcha.

> 
>> - Is this 32-bit, 64-bit, or both?
> 
> Fuchsia supports only 64-bit architectures.  We have no interest in
> 32-bit support in JavaScriptCore.

Music to my ears.

> 
>> - Is this mainly for ARM, x86, some other CPU, or lots of CPUs?
> 
> Fuchsia supports x86_64 and aarch64.

Lovely.

> 
>> - Do you plan to do significant work on JSC, or do you mainly want to just 
>> stay up to date with what we’re doing?
> 
> I'd like to foster a healthy dynamic between the WebKit project and
> our mutual customers.  It's hard for me to predict to where those
> customers will fall on that spectrum, but I would not anticipate the
> Fuchsia project itself making significant contributions to JSC.
> However, I would anticipate us maintaining the integration between
> JavaScriptCore and Fuchsia.
> 
>> More thoughts inline:
>> 
>>> On Jun 26, 2018, at 2:00 PM, Adam Barth  wrote:
>>> 
>>> As part of developing Fuchsia [1] (a new open-source operating
>>> system), we ported JavaScriptCore to run on Fuchsia [2].  At the time,
>>> our intent was to use this code within the Fuchsia source tree but not
>>> to make it available for developers writing applications for Fuchsia.
>>> However, recently, we've gotten a number of requests from customers
>>> who would like to use JavaScriptCore in their Fuchsia applications.
>>> 
>>> I'd like your advice about the best way to maintain JavaScriptCore
>>> support for Fuchsia.  Here are some possibilities I can imagine, but
>>> we're open to other possibilities as well:
>>> 
>>> 1. Maintain a fork of JavaScriptCore somewhere on googlesource.com
>>> that supports Fuchsia and instruct customers to obtain the Fuchsia
>>> port of JavaScriptCore from googlesource.com.
>> 
>> I’d be OK with this.
>> 
>>> 2. Maintain a branch of JavaScriptCore in svn.webkit.org that supports 
>>> Fuchsia.
>> 
>> In my opinion, SVN branches are not significantly better than (1), and in 
>> many ways they are worse.  I wouldn’t advocate for this.
> 
> Make sense.
> 
>>> 3. Maintain support for JavaScriptCore in the mainline of svn.webkit.org.
>> 
>> I think that I’d be OK with this, too.  This seems better than (1) if you 
>> want to stay up-to-date.
> 
> Thanks!

Based on this, I think that it’s ideal for it to be in svn.webkit.org 
.

-Filip


> 
> Adam
> 
> 
>>> For reference, here's the patch we applied to WTF and JavaScriptCore
>>> to enable Fuchsia support:
>>> 
>>> https://gist.github.com/abarth/b4fc909d83be5133cd7a5af209757e96
>>> 
>>> This patch is based on webkit@206446, but we'd obviously rebase the
>>> patch onto top-of-tree before contributing it.
>>> 
>>> I'm happy to answer any questions you might have that would help you
>>> provide the best advice.  If you would prefer to communicate off-list,
>>> I'm happy to do that as well.
>>> 
>>> Thanks in advance,
>>> Adam
>>> 
>>> [1] https://fuchsia.googlesource.com/docs/+/master/README.md
>>> [2] Actually, if you look at
>>> https://fuchsia.googlesource.com/third_party/webkit, you'll see that
>>> we've ported WebCore as well, but this email concerns only
>>> JavaScriptCore.
>>> ___
>>> webkit-dev mailing list
>>> webkit-dev@lists.webkit.org
>>> https://lists.webkit.org/mailman/listinfo/webkit-dev
>> 

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


Re: [webkit-dev] JavaScriptCore on Fuchsia

2018-06-26 Thread Adam Barth
On Tue, Jun 26, 2018 at 2:08 PM Filip Pizlo  wrote:
> This looks super interesting!

Thanks.  :)

> I have some questions:
>
> - Does your JSC port enable all of JSC’s optimization features, like the FTL 
> JIT and concurrent GC?

Nope.  I believe we just have the interpreter working.

> - Is it a goal to enable basically everything we enable, long term?

The Fuchsia project itself doesn't have any particular goals for
JavaScriptCore.  It's possible that our customers who want to use
JavaScriptCore on Fuchsia will have goals for additional functionality
in the future, but assuming we host the code on svn.webkit.org, I
would imagine recommending that those customers interact directly with
the WebKit project.

> - Is this 32-bit, 64-bit, or both?

Fuchsia supports only 64-bit architectures.  We have no interest in
32-bit support in JavaScriptCore.

> - Is this mainly for ARM, x86, some other CPU, or lots of CPUs?

Fuchsia supports x86_64 and aarch64.

> - Do you plan to do significant work on JSC, or do you mainly want to just 
> stay up to date with what we’re doing?

I'd like to foster a healthy dynamic between the WebKit project and
our mutual customers.  It's hard for me to predict to where those
customers will fall on that spectrum, but I would not anticipate the
Fuchsia project itself making significant contributions to JSC.
However, I would anticipate us maintaining the integration between
JavaScriptCore and Fuchsia.

> More thoughts inline:
>
> > On Jun 26, 2018, at 2:00 PM, Adam Barth  wrote:
> >
> > As part of developing Fuchsia [1] (a new open-source operating
> > system), we ported JavaScriptCore to run on Fuchsia [2].  At the time,
> > our intent was to use this code within the Fuchsia source tree but not
> > to make it available for developers writing applications for Fuchsia.
> > However, recently, we've gotten a number of requests from customers
> > who would like to use JavaScriptCore in their Fuchsia applications.
> >
> > I'd like your advice about the best way to maintain JavaScriptCore
> > support for Fuchsia.  Here are some possibilities I can imagine, but
> > we're open to other possibilities as well:
> >
> > 1. Maintain a fork of JavaScriptCore somewhere on googlesource.com
> > that supports Fuchsia and instruct customers to obtain the Fuchsia
> > port of JavaScriptCore from googlesource.com.
>
> I’d be OK with this.
>
> > 2. Maintain a branch of JavaScriptCore in svn.webkit.org that supports 
> > Fuchsia.
>
> In my opinion, SVN branches are not significantly better than (1), and in 
> many ways they are worse.  I wouldn’t advocate for this.

Make sense.

> > 3. Maintain support for JavaScriptCore in the mainline of svn.webkit.org.
>
> I think that I’d be OK with this, too.  This seems better than (1) if you 
> want to stay up-to-date.

Thanks!

Adam


> > For reference, here's the patch we applied to WTF and JavaScriptCore
> > to enable Fuchsia support:
> >
> > https://gist.github.com/abarth/b4fc909d83be5133cd7a5af209757e96
> >
> > This patch is based on webkit@206446, but we'd obviously rebase the
> > patch onto top-of-tree before contributing it.
> >
> > I'm happy to answer any questions you might have that would help you
> > provide the best advice.  If you would prefer to communicate off-list,
> > I'm happy to do that as well.
> >
> > Thanks in advance,
> > Adam
> >
> > [1] https://fuchsia.googlesource.com/docs/+/master/README.md
> > [2] Actually, if you look at
> > https://fuchsia.googlesource.com/third_party/webkit, you'll see that
> > we've ported WebCore as well, but this email concerns only
> > JavaScriptCore.
> > ___
> > webkit-dev mailing list
> > webkit-dev@lists.webkit.org
> > https://lists.webkit.org/mailman/listinfo/webkit-dev
>
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


Re: [webkit-dev] JavaScriptCore on Fuchsia

2018-06-26 Thread Filip Pizlo
Hi Adam,

This looks super interesting!

I have some questions:

- Does your JSC port enable all of JSC’s optimization features, like the FTL 
JIT and concurrent GC?
- Is it a goal to enable basically everything we enable, long term?

- Is this 32-bit, 64-bit, or both?

- Is this mainly for ARM, x86, some other CPU, or lots of CPUs?

- Do you plan to do significant work on JSC, or do you mainly want to just stay 
up to date with what we’re doing?

More thoughts inline:

> On Jun 26, 2018, at 2:00 PM, Adam Barth  wrote:
> 
> As part of developing Fuchsia [1] (a new open-source operating
> system), we ported JavaScriptCore to run on Fuchsia [2].  At the time,
> our intent was to use this code within the Fuchsia source tree but not
> to make it available for developers writing applications for Fuchsia.
> However, recently, we've gotten a number of requests from customers
> who would like to use JavaScriptCore in their Fuchsia applications.
> 
> I'd like your advice about the best way to maintain JavaScriptCore
> support for Fuchsia.  Here are some possibilities I can imagine, but
> we're open to other possibilities as well:
> 
> 1. Maintain a fork of JavaScriptCore somewhere on googlesource.com
> that supports Fuchsia and instruct customers to obtain the Fuchsia
> port of JavaScriptCore from googlesource.com.

I’d be OK with this.

> 
> 2. Maintain a branch of JavaScriptCore in svn.webkit.org that supports 
> Fuchsia.

In my opinion, SVN branches are not significantly better than (1), and in many 
ways they are worse.  I wouldn’t advocate for this.

> 
> 3. Maintain support for JavaScriptCore in the mainline of svn.webkit.org.

I think that I’d be OK with this, too.  This seems better than (1) if you want 
to stay up-to-date.

-Filip

> 
> For reference, here's the patch we applied to WTF and JavaScriptCore
> to enable Fuchsia support:
> 
> https://gist.github.com/abarth/b4fc909d83be5133cd7a5af209757e96
> 
> This patch is based on webkit@206446, but we'd obviously rebase the
> patch onto top-of-tree before contributing it.
> 
> I'm happy to answer any questions you might have that would help you
> provide the best advice.  If you would prefer to communicate off-list,
> I'm happy to do that as well.
> 
> Thanks in advance,
> Adam
> 
> [1] https://fuchsia.googlesource.com/docs/+/master/README.md
> [2] Actually, if you look at
> https://fuchsia.googlesource.com/third_party/webkit, you'll see that
> we've ported WebCore as well, but this email concerns only
> JavaScriptCore.
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


[webkit-dev] JavaScriptCore on Fuchsia

2018-06-26 Thread Adam Barth
As part of developing Fuchsia [1] (a new open-source operating
system), we ported JavaScriptCore to run on Fuchsia [2].  At the time,
our intent was to use this code within the Fuchsia source tree but not
to make it available for developers writing applications for Fuchsia.
However, recently, we've gotten a number of requests from customers
who would like to use JavaScriptCore in their Fuchsia applications.

I'd like your advice about the best way to maintain JavaScriptCore
support for Fuchsia.  Here are some possibilities I can imagine, but
we're open to other possibilities as well:

1. Maintain a fork of JavaScriptCore somewhere on googlesource.com
that supports Fuchsia and instruct customers to obtain the Fuchsia
port of JavaScriptCore from googlesource.com.

2. Maintain a branch of JavaScriptCore in svn.webkit.org that supports Fuchsia.

3. Maintain support for JavaScriptCore in the mainline of svn.webkit.org.

For reference, here's the patch we applied to WTF and JavaScriptCore
to enable Fuchsia support:

https://gist.github.com/abarth/b4fc909d83be5133cd7a5af209757e96

This patch is based on webkit@206446, but we'd obviously rebase the
patch onto top-of-tree before contributing it.

I'm happy to answer any questions you might have that would help you
provide the best advice.  If you would prefer to communicate off-list,
I'm happy to do that as well.

Thanks in advance,
Adam

[1] https://fuchsia.googlesource.com/docs/+/master/README.md
[2] Actually, if you look at
https://fuchsia.googlesource.com/third_party/webkit, you'll see that
we've ported WebCore as well, but this email concerns only
JavaScriptCore.
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


[webkit-dev] wpt.fyi survey

2018-06-26 Thread Mark Dittmer
Greetings web platform testers and builders!

You probably received the WPT survey not long ago, and, since everyone
loves filling out *even more* surveys, I'm sending out a survey about
wpt.fyi.

Survey link  (
https://goo.gl/forms/ppfjAUIw5YIU46ge2)

This survey is *not* about web platform tests themselves, or the
infrastructure used to write and run them. It *is* about the test results
dashboard, wpt.fyi, and how it can be more useful to you. The survey is
short and will drive the priorities of the team that owns wpt.fyi, so
please fill it out and make your voice heard!

Thanks!

//Mark
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev