Re: [webkit-dev] Clarifying feature flags

2018-11-05 Thread Simon Fraser
> On Nov 5, 2018, at 6:01 PM, don.olmst...@sony.com wrote: > > I'm really interested in other people's thoughts on this. > Agreed that this would be great to clean up. We’ve accrued a lot of junk in this area. Simon ___ webkit-dev mailing list

Re: [webkit-dev] dump-class-layout script not working

2018-11-05 Thread Simon Fraser
I assume you've actually done a debug build? Your command line works for me: 100$ $ ./Tools/Scripts/dump-class-layout --architecture=x86_64 -c Debug JavaScriptCore JSString +0 < 24> JSString +0 < 8> JSC::JSCell JSC::JSCell +0 < 1> JSC::HeapCell JSC::HeapCell +0 < 4>

Re: [webkit-dev] dump-class-layout script not working

2018-11-05 Thread Joseph Pecoraro
> On Nov 4, 2018, at 3:43 AM, Frank Jaeger wrote: > > Hello. First of all I'm really sorry if this is the wrong mailing list to > post to, webkit-help would have probably been better but it doesn't seem very > active. > > I run into some problems while trying to use the dump-class-layout

[webkit-dev] Clarifying feature flags

2018-11-05 Thread Don . Olmstead
Hi WebKittens, After I saw that CSS_PAINTING_API wasn't exposed in CMake I took a stab at looking into the different ENABLE_ flags inside WebKit's source to try and get what's exposed on the XCode side synced. I ended up searching through the source code and found around 200 different ENABLE_

[webkit-dev] R: dump-class-layout script not working

2018-11-05 Thread Frank Jaeger
Hi Simon, thanks for your help. I am running the script on macOS Mojave 10.14 and I'm pretty sure I have the lldb python bindings installed. Or otherwise it should fail when importing them at the beginning of the script, right? From what I understood by reading the script's code, it is directly

Re: [webkit-dev] dump-class-layout script not working

2018-11-05 Thread Simon Fraser
Dump-class-layout uses the lldb python bindings. Maybe those are not available on your platform? I think we’ve only ever tried it on macOS. What platform are you trying on? Simon > On Nov 4, 2018, at 12:43 PM, Frank Jaeger wrote: > > Hello. First of all I'm really sorry if this is the wrong

Re: [webkit-dev] Experimental and (new) Internal feature flags

2018-11-05 Thread Manuel Rego Casasnovas
On 25/09/18 01:00, Ryosuke Niwa wrote: > On Mon, Sep 24, 2018 at 1:26 AM Frédéric Wang > wrote: > > On 12/09/2018 23:48, Dean Jackson wrote: > > What about testing? > > > > > > You can turn both experimental and internal features on via >