Re: [webkit-dev] Lots of spam on Bugzilla

2019-01-15 Thread Michael Catanzaro
On Wed, Dec 5, 2018 at 11:30 AM, Michael Catanzaro 
 wrote:
Wow, I never noticed this. I thought Apple folks were using 
superpowers to obsolete comments!


Hi,

Recently a spammer added me to his Bugzilla user watchlist (Preferences 
-> Email Preferences -> User Watching on the bottom left) to follow me 
across Bugzilla, and has been manually sending me spam emails. I 
suppose it's retaliation for my tagging several Bugzilla comments as 
Spam, now that I know how. (I've asked the WebKit admins to ban his 
account.) Hopefully I'm just unlucky, but you might want to check the 
list of accounts watching you for suspicious accounts!


Michael

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


Re: [webkit-dev] AppleWin/WinCairo Resources

2019-01-15 Thread Alex Christensen
I don’t think there’s a fundamental reason why the resources and code can’t be 
moved.  Just make sure everything still works

> On Jan 7, 2019, at 10:45 AM, stephan.sz...@sony.com wrote:
> 
> Hi,
>  
> While working with (non-legacy) WebKit for WinCairo, we realized that we need 
> to support loading the missingImage and similar resources.
>  
> On https://bugs.webkit.org/show_bug.cgi?id=188175#c6 
> , Fujii-san mentioned that 
> it’d probably be the time to fix the fixme at
> https://github.com/WebKit/webkit/blob/c4b88ee56e4f77201ffdcaf6a5988cbc43e199f3/Source/WebKitLegacy/win/WebKitDLL.cpp#L171
>  
> 
> for loadResourceIntoBuffer.  Is there any reason that sharing the loading 
> code, the actual resource files, rc file or resource.h would be a problem 
> (especially for AppleWin)? And, if we want to share them, are there 
> suggestions about where to move those files? Could we move it down to WebCore 
> to be shared?
>  
> Thanks,
> Stephan
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org 
> https://lists.webkit.org/mailman/listinfo/webkit-dev 
> 
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


Re: [webkit-dev] Can we jettison Sputnik?

2019-01-15 Thread Saam barati
Hi Ross,

> On Jan 15, 2019, at 11:50 AM, ross.kirsl...@sony.com wrote:
> 
> Hi everybody,
>  
> I’d like to verify whether there’s any specific reason that the 
> LayoutTests/sputnik directory continues to exist.
>  
> According to Wikipedia, “All current Sputnik tests have been incorporated 
> into ECMA's Test262 test suite.” (Here “current” evidently means June 2011.) 
> And indeed, when making fixes to address Test262 failures in JSC, it’s quite 
> awkward to have to update the Sputnik expectations to reflect any new 
> “failures”—particularly given that it’s not sufficient to simply build JSC in 
> order to run them.
I think it’s a good idea to remove these. (An aside: in general, I’m also not a 
fan of JS tests that don’t rely on the DOM existing in LayoutTests.)

>  
> Would anyone object to a patch deleting this directory outright? The only 
> concern that occurs to me is that Test262 is not currently integrated into 
> EWS.
Maybe we should integrate these into EWS? The main downside is IIRC, these take 
a while to run. I think it’s ok to remove these even if we never add Test262 to 
EWS since we still run Test262 on bots post-commit.

- Saam

>  
> Thanks!
> Ross
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org 
> https://lists.webkit.org/mailman/listinfo/webkit-dev 
> 
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


[webkit-dev] Can we jettison Sputnik?

2019-01-15 Thread Ross . Kirsling
Hi everybody,

I’d like to verify whether there’s any specific reason that the 
LayoutTests/sputnik directory continues to exist.

According to Wikipedia, “All current Sputnik tests have been incorporated into 
ECMA's Test262 test suite.” (Here “current” evidently means June 2011.) And 
indeed, when making fixes to address Test262 failures in JSC, it’s quite 
awkward to have to update the Sputnik expectations to reflect any new 
“failures”—particularly given that it’s not sufficient to simply build JSC in 
order to run them.

Would anyone object to a patch deleting this directory outright? The only 
concern that occurs to me is that Test262 is not currently integrated into EWS.

Thanks!
Ross
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


Re: [webkit-dev] Reducing globals

2019-01-15 Thread Michael Catanzaro

This:

On Thu, Nov 29, 2018 at 8:15 PM, Alex Christensen 
 wrote:
Specifically, I’m looking into reducing the number of members in 
the NetworkProcessCreationParameters structure.  Many of them need to 
go to NetworkSessionCreationParameters instead.  Could those 
maintaining the libsoup and libcurl networking implementations please 
lend a hand and move the members enclosed in USE(SOUP) or USE(CURL)?  
I have done similar moves in 
https://trac.webkit.org/changeset/238654/webkit and 
https://trac.webkit.org/changeset/238630/webkit if you would like a 
pattern to follow.


I'll try.

Michael

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


Re: [webkit-dev] Reducing globals

2019-01-15 Thread Claudio Saavedra
On Thu, 2018-12-20 at 17:12 -0800, Alex Christensen wrote:
> It’s been three weeks.  Is anyone maintaining the soup or curl
> loading code?

If the main concern is the usage of NetworkProcess::singleton(), turns
out that in the end this patch is all that is needed 
https://bugs.webkit.org/show_bug.cgi?id=193444 to stop using it in the
soup code.

Was there anything else that needs cleaning up?

Claudio


___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev