Re: [webkit-dev] IPC implementation help in haiku's webkit port

[Chris Dumez]

Alex is likely right that you are ending up with some kind of IPC deadlock 
since the IPC is synchronous.

But also,

> On May 27, 2019, at 11:49 PM, Rajagopalan Gangadharan  
> wrote:
> 
> 
> Please check the source references for more info:
> NetworkProcessProxy: [ 
> https://github.com/RAJAGOPALAN-GANGADHARAN/webkit/blob/6bf81d79669be06b4efd9d8ced4139cbe07216b2/Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp#L150
>  
> ]

You’re passing 0 instead of the webPID with the IPC here.___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] IPC implementation help in haiku's webkit port

[Alex Christensen]

It sounds like your design requires work on the main thread to create a 
connection to another process which is causing a deadlock when the main thread 
is waiting for another reply.  If I were working on this I would compare with 
an existing implementation to see what process and thread each step is running 
on.

> On May 27, 2019, at 11:49 PM, Rajagopalan Gangadharan  
> wrote:
> 
> Hello Everybody,
> 
> I stumbled upon a problem in an attempt to port webkit to haiku. Before 
> everything I would like to take few moments to explain about state of the 
> port. 
> 
> 1) We have a well maintained WebKitLegacy port on haiku. 
> 2) Now in the process of porting latest webkit to haiku currently at fixing 
> IPC. We didnt want to use BSD sockets and would like to use Native messaging 
> framework [BMessage : https://www.haiku-os.org/docs/api/classBMessage.html 
>  ] because our native 
> application waits for BMessage in its main thread as a result we cant wait 
> for both sockets and BMessage on same thread. Also we would like to maintain 
> the haiku ecosystem :) .
> 
> 3) We need process id of the intended process we would like to connect to 
> send data [BMessenger: https://www.haiku-os.org/docs/api/classBMessenger.html 
>  ] So instead of 
> exchanging socket id's we would just exchange pid's
> 
> 4) We were able to successfully deliver and process the messages. Currently 
> we were able to proceed until creating a connection between network process 
> and webprocess(NetworkConnectionToWebProcess).
> 
> Now where we are stuck is that After creating a connection between network 
> process and webprocess we would have to reply back to webprocess about the 
> connection info( pid of network process in our case ). I see the reply is an 
> alias of DelayedReply(CompletionHandler) according to the 
> derived sources.
> Unfortunately the webprocess is indefinitely waiting for reply from 
> webprocessproxy for which we are unable to "reply" .
> 
> Could anyone point me where I would have went wrong or what could be done to 
> fix this and any better ways for implementing this.
> 
> Please check the source references for more info:
> NetworkProcessProxy: [ 
> https://github.com/RAJAGOPALAN-GANGADHARAN/webkit/blob/6bf81d79669be06b4efd9d8ced4139cbe07216b2/Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp#L150
>  
> ]
> 
> NetworkProcess [ 
> https://github.com/RAJAGOPALAN-GANGADHARAN/webkit/blob/6bf81d79669be06b4efd9d8ced4139cbe07216b2/Source/WebKit/NetworkProcess/haiku/NetworkProcessHaiku.cpp#L98
>  
> 
>  ]
> 
> ConnectionHaiku : 
> [https://github.com/RAJAGOPALAN-GANGADHARAN/webkit/blob/ipc-iteration2/Source/WebKit/Platform/IPC/haiku/ConnectionHaiku.cpp
>  
> 
>  ]
> 
> Attachment : [ 
> https://github.com/RAJAGOPALAN-GANGADHARAN/webkit/blob/ipc-iteration2/Source/WebKit/Platform/IPC/haiku/AttachmentHaiku.cpp
>  
> 
>  ]
> I believe these places are currently in focus 
> For further reference please check 
> [https://github.com/RAJAGOPALAN-GANGADHARAN/webkit/tree/ipc-iteration2 
> ]
> 
> Thank you
> Regards
> G.Rajagopalan
> 
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Is anyone maintaining Nicosia scrolling code?

[Antti Koivisto]

On Sat, Feb 23, 2019 at 1:30 PM  wrote:

> On Sat, Feb 23, 2019, at 2:47 AM, Simon Fraser wrote:
> > There’s a bunch of code in Source/WebCore/page/scrolling/nicosia/ that
> > I keep breaking with scrolling tree refactoring. Most of it it stubs.
> > Is anyone maintaining this code, because it obviously doesn’t work, and
> > I’d like to remove the maintenance burden.
> >
>
> I added the stubs there, and was planning to start adding actual
> implementations there in the following weeks, now that a new release cycle
> was just entered.
>
> I wouldn't mind disabling or removing the code temporarily in order to
> enable you an easier time refactoring around it.


Please do. It is unreasonable to push maintenance burden of this dead code
to people who are working on async scrolling. See
https://bugs.webkit.org/show_bug.cgi?id=198292 for an example.


   antti


> But given that the async scrolling capability is something we plan to add
> support for in the WPE and GTK ports, I'd appreciate some input about the
> scope and the timeframe of your work and possibility of sharing as much of
> the implementation as possible between different ports.
>
> Cheers,
> Zan
>
> > Simon
> >
> > ___
> > webkit-dev mailing list
> > webkit-dev@lists.webkit.org
> > https://lists.webkit.org/mailman/listinfo/webkit-dev
> >
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev
>
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

[webkit-dev] IPC implementation help in haiku's webkit port

[Rajagopalan Gangadharan]

Hello Everybody,

I stumbled upon a problem in an attempt to port webkit to haiku. Before
everything I would like to take few moments to explain about state of the
port.

1) We have a well maintained WebKitLegacy port on haiku.
2) Now in the process of porting latest webkit to haiku currently at fixing
IPC. We didnt want to use BSD sockets and would like to use Native
messaging framework [BMessage :
https://www.haiku-os.org/docs/api/classBMessage.html ] because our native
application waits for BMessage in its main thread as a result we cant wait
for both sockets and BMessage on same thread. Also we would like to
maintain the haiku ecosystem :) .

3) We need process id of the intended process we would like to connect to
send data [BMessenger:
https://www.haiku-os.org/docs/api/classBMessenger.html ] So instead of
exchanging socket id's we would just exchange pid's

4) We were able to successfully deliver and process the messages. Currently
we were able to proceed until creating a connection between network process
and webprocess(NetworkConnectionToWebProcess).

Now where we are stuck is that After creating a connection between network
process and webprocess we would have to reply back to webprocess about the
connection info( pid of network process in our case ). I see the reply is
an alias of DelayedReply(CompletionHandler) according to the
derived sources.
Unfortunately the webprocess is indefinitely waiting for reply from
webprocessproxy for which we are unable to "reply" .

Could anyone point me where I would have went wrong or what could be done
to fix this and any better ways for implementing this.

Please check the source references for more info:
NetworkProcessProxy: [
https://github.com/RAJAGOPALAN-GANGADHARAN/webkit/blob/6bf81d79669be06b4efd9d8ced4139cbe07216b2/Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp#L150
]

NetworkProcess [
https://github.com/RAJAGOPALAN-GANGADHARAN/webkit/blob/6bf81d79669be06b4efd9d8ced4139cbe07216b2/Source/WebKit/NetworkProcess/haiku/NetworkProcessHaiku.cpp#L98
]

ConnectionHaiku : [
https://github.com/RAJAGOPALAN-GANGADHARAN/webkit/blob/ipc-iteration2/Source/WebKit/Platform/IPC/haiku/ConnectionHaiku.cpp
 ]

Attachment : [
https://github.com/RAJAGOPALAN-GANGADHARAN/webkit/blob/ipc-iteration2/Source/WebKit/Platform/IPC/haiku/AttachmentHaiku.cpp
 ]
I believe these places are currently in focus
For further reference please check [
https://github.com/RAJAGOPALAN-GANGADHARAN/webkit/tree/ipc-iteration2]

Thank you
Regards
G.Rajagopalan
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev