Re: [webkit-dev] [CMake] Bump cmake_minimum_required version to 3.10

2019-06-27 Thread Fujii Hironori
Good news! Use CMake 3.14.5 to avoid another incremental build issue. Bug 198850 – [CMake][Win] WTF_CopyHeaders copies files everytime in incremental builds if Visual Studio generator is used https://bugs.webkit.org/show_bug.cgi?id=198850 On Fri, Jun 28, 2019 at 1:21 AM Brent Fulgham wrote: >

Re: [webkit-dev] Windows 32-bit support?

2019-06-27 Thread Yusuke Suzuki
> On Jun 26, 2019, at 7:57 AM, Arunprasad Rajkumar > wrote: > > Hi Yusuke, > > I could see that the following comment from > https://trac.webkit.org/changeset/245906/webkit > , > > >> We also disable this op_wide16 feature in Windows CLoop,

Re: [webkit-dev] [CMake] Bump cmake_minimum_required version to 3.10

2019-06-27 Thread Konstantin Tokarev
27.06.2019, 20:19, "Michael Catanzaro" : > On Thu, Jun 27, 2019 at 11:20 AM, Brent Fulgham > wrote: >>  Apple is in the process of bringing up VS2019 now. I would be in >>  favor of moving the minimum to 3.14 so we can safely support VS2019 >>  compiles. > > The 3.14 target is too aggressive for

Re: [webkit-dev] [CMake] Bump cmake_minimum_required version to 3.10

2019-06-27 Thread Michael Catanzaro
On Thu, Jun 27, 2019 at 11:20 AM, Brent Fulgham wrote: Apple is in the process of bringing up VS2019 now. I would be in favor of moving the minimum to 3.14 so we can safely support VS2019 compiles. The 3.14 target is too aggressive for WPE/GTK, unfortunately. You could use a different cmake_

Re: [webkit-dev] [CMake] Bump cmake_minimum_required version to 3.10

2019-06-27 Thread Brent Fulgham
Apple is in the process of bringing up VS2019 now. I would be in favor of moving the minimum to 3.14 so we can safely support VS2019 compiles. -Brent > On Jun 24, 2019, at 8:21 PM, Fujii Hironori wrote: > > Hi, > > I'm going to bump cmake_minimum_required version to 3.10 for > shining new fea

Re: [webkit-dev] [CMake] Bump cmake_minimum_required version to 3.10

2019-06-27 Thread Adrian Perez de Castro
Hello, On Thu, 27 Jun 2019 08:36:22 +0200, Xan wrote: > Sorry about that. We'll take care of it ASAP. > > Cheers, > Xan > > On Thu, Jun 27, 2019, 06:23 Fujii Hironori wrote: > > > jsc-i368 EWS is still failing. > > Who is igalia-jsc-i386-ews bot maintainer? Done, this EWS has now CMake 3.13