[webkit-dev] iOS EWS behind by 3 days??

2019-11-04 Thread Ryosuke Niwa
Hi all, Does anyone know what's happening with iOS EWS? They're ~3 days behind now: https://ews-build.webkit.org/#/builders/24 - R. Niwa ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] EWS Comments on Bugzilla (Was: EWS now parses error logs in case of build failure)

2019-11-04 Thread Ryosuke Niwa
On Mon, Nov 4, 2019 at 9:40 AM Alexey Proskuryakov wrote: > > Can you elaborate on that, how exactly is e-mailing on first failure > useful to reviewers? > > Getting rid of Bugzilla comments was one of the goals of EWS rewrite, > based on engineering feedback about noise in bugs and in e-mail,

Re: [webkit-dev] EWS Comments on Bugzilla (Was: EWS now parses error logs in case of build failure)

2019-11-04 Thread Alexey Proskuryakov
Can you elaborate on that, how exactly is e-mailing on first failure useful to reviewers? Getting rid of Bugzilla comments was one of the goals of EWS rewrite, based on engineering feedback about noise in bugs and in e-mail, and I wholeheartedly agree with this feedback. So I think that

Re: [webkit-dev] [Styling] () for a lambda without arguments (Was Space between [] and () in C++ lambdas)

2019-11-04 Thread Alex Christensen
When the lambda is mutable or has a trailing return type, the () is currently required by the C++ grammar, so we can’t say to always omit (). We could say to always have it, to only have it when necessary, or have no code style guideline. I think we should always have spaces before and after,