Re: [webkit-dev] Proposal: add Privacy to WebKit Project Goals

2020-02-16 Thread Maciej Stachowiak
> On Feb 16, 2020, at 8:43 PM, Brent Fulgham wrote: > > > >> On Feb 16, 2020, at 12:39 PM, Maciej Stachowiak > > wrote: >> >> >> There hasn’t been any feedback on this, so below is a proposed change (in >> PrettyPatch HTML format) to >

Re: [webkit-dev] Clearing old reviews from the queue

2020-02-16 Thread Dean Jackson
> On 16 Feb 2020, at 17:46, Alexey Proskuryakov wrote: > > > >> 16 февр. 2020 г., в 7:52, Dean Jackson написал(а): >> >> Does anyone oppose clearing all review requests that are older than 6 >> months? (or 1 year?) > > Looking at ancient patches in the review queue, quite a few look like

Re: [webkit-dev] Proposal: add Privacy to WebKit Project Goals

2020-02-16 Thread Brent Fulgham
> On Feb 16, 2020, at 12:39 PM, Maciej Stachowiak wrote: > > > There hasn’t been any feedback on this, so below is a proposed change (in > PrettyPatch HTML format) to >. > > In addition to adding Privacy as a goal, I also added

Re: [webkit-dev] Clearing old reviews from the queue

2020-02-16 Thread Alexey Proskuryakov
> 16 февр. 2020 г., в 7:52, Dean Jackson написал(а): > > Does anyone oppose clearing all review requests that are older than 6 months? > (or 1 year?) Looking at ancient patches in the review queue, quite a few look like they should still work (e.g. adding new tests). So said that we are not

Re: [webkit-dev] Proposal: add Privacy to WebKit Project Goals

2020-02-16 Thread Maciej Stachowiak
There hasn’t been any feedback on this, so below is a proposed change (in PrettyPatch HTML format) to . In addition to adding Privacy as a goal, I also added Battery Life, and tweaked a few of the existing goals. Thoughts? project-new.html WebKit is an

Re: [webkit-dev] Clearing old reviews from the queue

2020-02-16 Thread Ryosuke Niwa
Sounds reasonable to me although I’d suggest older than 1 year instead of 6 months since I don’t think 6 months is long enough to render a patch completely obsolete in many cases. - R. Niwa On Sun, Feb 16, 2020 at 07:53 Dean Jackson wrote: > Does anyone oppose clearing all review requests that

Re: [webkit-dev] Request for position on Badging API

2020-02-16 Thread Ryosuke Niwa
For the record, we have two concerns raised internally at Apple: * The integration of this API with push service worker would require running scripts in order to update the badge. This will pose a serious power consumption issue. * We don’t want every website to start using this API to increase

Re: [webkit-dev] Request for position on Badging API

2020-02-16 Thread Dean Jackson
Not speaking for all of WebKit, and definitely not all of Apple, but I think this seems like a good idea. I'm not sure I get the distinction between app badges and document badges though. I'd also like to see some specification text describing how the browser should ignore multiple set/clear

[webkit-dev] Clearing old reviews from the queue

2020-02-16 Thread Dean Jackson
Does anyone oppose clearing all review requests that are older than 6 months? (or 1 year?) I tried to use the bugzilla API to do this, but I couldn't work out how to detect the attachment state properly. I looked at the source code for the queue page and it uses custom SQL :) (It's easy to do