Re: [webkit-dev] Changing the svn commit hook to allow tabs for tests.

2020-04-03 Thread Keith Miller
Resurrecting this from the dead because it came up in: 
https://bugs.webkit.org/show_bug.cgi?id=209979

> On May 10, 2019, at 5:34 PM, Alexey Proskuryakov  wrote:
> 
> 
>> 10 мая 2019 г., в 13:50, Darin Adler > > написал(а):
>> 
>>> On May 10, 2019, at 1:13 PM, Keith Miller >> > wrote:
>>> 
>>> I’m not sure I know what you mean by allow a whole-directory exception. Do 
>>> you mean a top level directory? Or some kind of parameter we pass to the 
>>> hook to ignore some directory for that run?
>> 
>> I meant that we could add something the pre-commit hook could see in 
>> Subversion that would create an exception for a whole directory, rather than 
>> something inside the hook itself. Perhaps a specially named file, or a 
>> Subversion attribute on a specially named file, or something more clever. If 
>> Subversion had attributes on directories, it could be that.
> 
> Subversion supports properties on directories, we use those for svn:ignore as 
> an example. It is correct that the pre-commit hook doesn't currently check 
> parent directory properties.
> 
> An alternative is to just set it on all files in the directory.

Cool, where is the commit hook located? Ideally, the commit hook would check 
recursively if any of the directories below the file (or the file itself) have 
the allow-tabs property. If that’s too slow or otherwise problematic, just the 
containing directory would also be reasonable. Thoughts?

Cheers,
Keith

> 
>>> you can’t commit with git-svn as it doesn’t support svn properties (or at 
>>> least I wasn’t able to figure it out)
>> 
>> Ah, that’s a big blocker if lots of people are using git-svn — I certainly 
>> use it.
> 
> Looks like it may now work with recent versions of git (as in since 2015), 
> https://stackoverflow.com/questions/1271449/how-to-set-subversion-properties-with-git-svn
>  
> 
>  :
> 
> git-svn: support for git-svn propset
> 
> This change allows git-svn to support setting subversion properties.
> 
> It is useful for manually setting properties when committing to a subversion 
> repo that requiresproperties to be set without requiring moving your 
> changeset to separate subversion checkout in order to set props.
> 
> There is a nit to point out: the code does not support adding props unless 
> there are also content changes to the files as well.
> This is demonstrated in the testcase.
> 
> - Alexey
> 
>> — Darin
>> ___
>> webkit-dev mailing list
>> webkit-dev@lists.webkit.org 
>> https://lists.webkit.org/mailman/listinfo/webkit-dev
> 
> 

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


Re: [webkit-dev] Introducing a minimum ICU version for WebKit

2020-04-03 Thread Ryosuke Niwa
On Fri, Apr 3, 2020 at 4:25 PM Kirsling, Ross 
wrote:

> Hi everybody,
>
>
>
> Just sending out an email blast for visibility regarding
> https://bugs.webkit.org/show_bug.cgi?id=209694.
>
>
>
> This patch:
>
>- Upgrades the Mac ICU headers under Source/WTF/icu from ICU 55 to ICU
>62, matching Mojave
>- Introduces a minimum ICU version of 60.2 throughout the codebase, as
>required by GTK for Ubuntu 18.04 LTS
>
>
>
> As written in the ChangeLog, the immediate motivations are:
>
>1. To properly establish a minimum ICU version for WebKit as a whole
>(responding to a pain point identified in
>https://bugs.webkit.org/show_bug.cgi?id=209579)
>2. To support the development of ECMA-402 Intl API features, which JSC
>is quite behind on
>(and which often boil down to exposing ICU functionality to JavaScript)
>
>
>
> The only remaining concern of which I am aware is that AppleWin’s ICU
> headers, stored in WebKitAuxiliaryLibrary.zip, need to be upgraded from ICU
> 49 to 62 (to match the lib files stored in WebKitSupportLibrary.zip). We do
> have a potential workaround for this (i.e. having CMake copy the Mac
> headers to WebKitLibraries/win) but it is feared that this may break
> Apple-internal builds and we would certainly like to avoid a revert if
> possible. Any help on this front would be greatly appreciated.
>
>
FWIW, I've been told that Brent / Per might be able to help you there but
might need some more time due to other more urgent commitments.

- R. Niwa
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


[webkit-dev] Introducing a minimum ICU version for WebKit

2020-04-03 Thread Kirsling, Ross
Hi everybody,

Just sending out an email blast for visibility regarding 
https://bugs.webkit.org/show_bug.cgi?id=209694.

This patch:

  *   Upgrades the Mac ICU headers under Source/WTF/icu from ICU 55 to ICU 62, 
matching Mojave
  *   Introduces a minimum ICU version of 60.2 throughout the codebase, as 
required by GTK for Ubuntu 18.04 LTS

As written in the ChangeLog, the immediate motivations are:

  1.  To properly establish a minimum ICU version for WebKit as a whole
(responding to a pain point identified in 
https://bugs.webkit.org/show_bug.cgi?id=209579)
  2.  To support the development of ECMA-402 Intl API features, which JSC is 
quite behind on
(and which often boil down to exposing ICU functionality to JavaScript)

The only remaining concern of which I am aware is that AppleWin’s ICU headers, 
stored in WebKitAuxiliaryLibrary.zip, need to be upgraded from ICU 49 to 62 (to 
match the lib files stored in WebKitSupportLibrary.zip). We do have a potential 
workaround for this (i.e. having CMake copy the Mac headers to 
WebKitLibraries/win) but it is feared that this may break Apple-internal builds 
and we would certainly like to avoid a revert if possible. Any help on this 
front would be greatly appreciated.

Thanks,
Ross
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev