Re: [webkit-dev] Making WTF::StringImpl and WTF::AtomString thread-safe

2020-12-02 Thread Sam Weinig via webkit-dev
Hey Geoff and Chris, > On Dec 1, 2020, at 9:21 AM, Geoff Garen via webkit-dev > wrote: > > A few thoughts here: > > 1. It’s not just ref counting. > > To make String thread-safe, you also need to address all other data members. > That means all state in m_hashAndFlags, including the

Re: [webkit-dev] Making WTF::StringImpl and WTF::AtomString thread-safe

2020-12-02 Thread Chris Lord via webkit-dev
On 2020-12-01 18:21, Geoff Garen wrote: > A few thoughts here: > > 1. It’s not just ref counting. > > To make String thread-safe, you also need to address all other data > members. That means all state in m_hashAndFlags, including the > 8bit/16bit state. > > It appears that your testing