Re: [webkit-dev] Let's use -Werror on EWS?

2021-05-25 Thread Michael Catanzaro via webkit-dev
On Tue, May 25 2021 at 06:22:41 AM -0500, Michael Catanzaro via webkit-dev wrote: I'm hoping there are not very many warnings, since I've been cleaning warnings I see for several years now. There will probably be a few, though, which could be caused by (a) EWS using non-default build options

Re: [webkit-dev] Let's use -Werror on EWS?

2021-05-25 Thread Michael Catanzaro via webkit-dev
On Mon, May 24 2021 at 07:36:03 PM -0700, Darin Adler via webkit-dev wrote: I do not know why we do not already use -Werror on GTK and WPE and I support using it there after fixing all the warnings. I'd be willing to enable it at the CMake level if it was conditional on

Re: [webkit-dev] Let's use -Werror on EWS?

2021-05-25 Thread Michael Catanzaro via webkit-dev
On Mon, May 24 2021 at 06:32:03 PM -0700, Darin Adler via webkit-dev wrote: But we can’t just turn on -Werror until after we fix all the warnings! Who will do that project. I'm hoping there are not very many warnings, since I've been cleaning warnings I see for several years now. There will