Re: [webkit-dev] Removing deprecatedFrameEncoding

should be following blindly. It's especially so in this case, where limitations on how non-ASCII bytes are interpreted do not solve any problem except for formal compatibility with some universally ignored text in RFC 2616. - WBR, Alexey Proskuryakov

Re: [webkit-dev] Removing deprecatedFrameEncoding

potential benefit to offset that. - WBR, Alexey Proskuryakov ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Removing deprecatedFrameEncoding

the regression. Besides client locale, there is UTF-8. That's actually the preferred option, which gets tried first. Only servers that send non-Unicode file names need out of band information. - WBR, Alexey Proskuryakov ___ webkit-dev mailing list webkit-dev

Re: [webkit-dev] Removing deprecatedFrameEncoding

not in this case. This regression has been fixed yesterday, WebKit nighties should use referring frame encoding again. - WBR, Alexey Proskuryakov ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Removing deprecatedFrameEncoding

, waiting for complaints is not very practical for this kind of bugs - for multiple reason, it often takes extremely long time until someone files a bug. - WBR, Alexey Proskuryakov ___ webkit-dev mailing list webkit-dev@lists.webkit.org http

Re: [webkit-dev] Removing deprecatedFrameEncoding

there are sites that misbehave; I'd like to know about these to investigate what's going on, and potentially tweak the approach. It is not useful or interesting to discuss this behavior in a theoretical context where non-ASCII characters in Content-Disposition are not allowed at all. - WBR, Alexey

Re: [webkit-dev] Removing deprecatedFrameEncoding

in an update to RFC 6266? If we don't agree on that, I don't see the point of discussing one minuscule detail of a design which is entirely different from the RFC. - WBR, Alexey Proskuryakov ___ webkit-dev mailing list webkit-dev@lists.webkit.org http

Re: [webkit-dev] Removing deprecatedFrameEncoding

style gobbledygook really has no purpose here, and only complicates life for implementors, site authors and admins alike. We know that it works in practice. - WBR, Alexey Proskuryakov ___ webkit-dev mailing list webkit-dev@lists.webkit.org http

Re: [webkit-dev] Removing deprecatedFrameEncoding

and intermediaries. Internet infrastructure would not collapse if UTF-8 was sent in a response header. - WBR, Alexey Proskuryakov ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Removing deprecatedFrameEncoding

with the existing request for comments. - WBR, Alexey Proskuryakov ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] WebKit modularization

licenses - e.g. DOMWindowXML.idl is LGPL, while DOMWindow.idl is BSD. 4) More files means longer build times. I think that most of the patches landed under this umbrella should be reconsidered, and most immediately those that had license wrong. - WBR, Alexey Proskuryakov

Re: [webkit-dev] WebKit modularization

one to go through patches in a specific area they reviewed recently. I'm deeply concerned about the way this refactoring is implemented - it doesn't have much of a meaningful purpose overall, and patches are reviewed carelessly. - WBR, Alexey Proskuryakov

Re: [webkit-dev] The Care and Feeding of WebCore Modules

be that some of the code will be merged back into files like Window.idl if the feature ever matures, not the other way around. - WBR, Alexey Proskuryakov ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman

Re: [webkit-dev] The Care and Feeding of WebCore Modules

::canCachePageContainingThisFrame makes the code less hackable, and is likely to become a disadvantage. - WBR, Alexey Proskuryakov 29.02.2012, в 23:31, Maciej Stachowiak написал(а): Here's an update of my lists based on the notes from you, Adam and others: == Existing Modules == gamepad

Re: [webkit-dev] PageCache and modularization (was Re: The Care and Feeding of WebCore Modules)

of suspend/resume functions it provides comes at the cost of unpredictable order they are invoked in, and of very strict limitations on what these functions can do. - WBR, Alexey Proskuryakov ___ webkit-dev mailing list webkit-dev@lists.webkit.org http

Re: [webkit-dev] PageCache and modularization (was Re: The Care and Feeding of WebCore Modules)

05.03.2012, в 11:29, Adam Barth написал(а): For better or worse, Geolocation doesn't support suspend/resume (yet?) https://bugs.webkit.org/show_bug.cgi?id=43956 Pages that use Geolocation should be able to use the page cache - WBR, Alexey Proskuryakov

Re: [webkit-dev] Feature Announcement: Adding iframe seamless

can't see any benefit of landing tests first. The downside is quite material - it's much more difficult for reviewer of actual code change to see what test coverage is. Additional bug/commit noise has its costs, too. - WBR, Alexey Proskuryakov ___ webkit

Re: [webkit-dev] Following up on removing -khtml- and -apple- CSS vendor prefixes

potential of site breakage, this seems worth a separate setting with pre-made plumbing for site-specific quirks, so that ports seeing release blocking regressions on important sites wouldn't have to undo this change entirely. - WBR, Alexey Proskuryakov

[webkit-dev] Contributor meeting hackathon: Move methods from layoutTestController

We're capturing ideas for which LayoutTestController methods could be moved to Internals here: https://trac.webkit.org/wiki/Internals_Hackathon. Even found some that are completely unused in tests! - WBR, Alexey Proskuryakov ___ webkit-dev mailing

[webkit-dev] Eliminate potential null pointer dereference?

/changeset/114678/trunk/Source/WebCore/css/CSSStyleSelector.cpp. We should not try to confuse ourselves with unusual for loop forms, and there is no explanation at all of why these changes are needed. No regression tests either. - WBR, Alexey Proskuryakov

Re: [webkit-dev] Default viewport value on WAP DTDs

that introduction of new doctype based modes should go through HTML5 first - if WebKit needs this, then other browsers need it, too. Also, it's not clear what the distinction between mobile and non-mobile is. Is Safari on an 11 MacBook Air a mobile browser? - WBR, Alexey Proskuryakov

Re: [webkit-dev] webkit2 with v8

::injectInternalsObject(context); #endif This is of course something non-Qt developers have to worry about, see e.g. https://bugs.webkit.org/show_bug.cgi?id=87783#c14. - WBR, Alexey Proskuryakov 31.05.2012, в 9:38, Balazs Kelemen написал(а): I continued to work on this, more complete patches have been

Re: [webkit-dev] webkit2 with v8

to maintain etc. - WBR, Alexey Proskuryakov ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Can we distinguish imported tests in LayoutTests/css3 ?

that getting rid of some boilerplate in autogenerated code is a worthy goal, given that it will make tests more fragile. - WBR, Alexey Proskuryakov ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] removing js-test-post.js WAS: Can we distinguish imported tests in LayoutTests/css3 ?

what you mean by this. The make-new-script-test tool includes js-test-pre.js and js-test-post.js, and it's the only way to autogenerate the boilerplate that I'm aware of. - WBR, Alexey Proskuryakov ___ webkit-dev mailing list webkit-dev

Re: [webkit-dev] removing js-test-post.js WAS: Can we distinguish imported tests in LayoutTests/css3 ?

12.06.2012, в 10:51, Alexey Proskuryakov написал(а): I'm sympathetic to this argument. In this case, the only way it makes the tests more fragile is that it makes them depend on us firing the onload event. I feel like so many things would break if you break onload, that it's not really

Re: [webkit-dev] DRT/WTR should clear the cache at the beginning of each test?

will undoubtedly have this unimplemented for a long time. - WBR, Alexey Proskuryakov 08.08.2012, в 10:47, Ojan Vafai написал(а): See https://bugs.webkit.org/show_bug.cgi?id=93195. media/W3C/video/networkState/networkState_during_progress.html and media/video-poster-blocked-by-willsendrequest.html

Re: [webkit-dev] Passing null or undefined object as input url for XMLHttpRequest open()

elaborate on why this seems incorrect to you? Generally speaking, special casing just null and undefined to bypass toString conversion would be unusual and surprising. - WBR, Alexey Proskuryakov ___ webkit-dev mailing list webkit-dev@lists.webkit.org http

[webkit-dev] Bug numbers in TestExpectations

for both cases in Skipped files. It appears that the rigid format that requires putting a bug URL is causing more harm than good in practice. I suggest making the URL optional. - WBR, Alexey Proskuryakov ___ webkit-dev mailing list webkit-dev

[webkit-dev] Should we close the tree? (was: Re: the new TestExpectations syntax is landing soon)

Now tracked as https://bugs.webkit.org/show_bug.cgi?id=97182. I think that we should close the tree if resolving this takes any significant time. Not being able to see how exactly tests are failing on other platforms is unacceptable. - WBR, Alexey Proskuryakov 20.09.2012, в 3:54

Re: [webkit-dev] Is there a rule to use UNUSED_PARAM ?

are the same (i.e. in .h files), as there is no other place one could discover parameter's meaning if it were unnamed. - WBR, Alexey Proskuryakov ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Tips on why run-webkit-tests is not working for me?

xcrun make here, and installing command line utilities is a workaround. - WBR, Alexey Proskuryakov ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Discussing bug 98539 - Refactor resource loading to allow for out-of-process loading and memory caching

priority is not, on the other hand. Anyway, as Brady mentioned, this is not related to this refactoring. - WBR, Alexey Proskuryakov ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] DRT/WTR should clear the cache at the beginning of each test?

are for, and it would be difficult to make enough explicit tests to compensate for such loss of coverage. It would certainly be very unfortunate to lose test coverage without even an attempt to compensate for that. - WBR, Alexey Proskuryakov ___ webkit-dev

Re: [webkit-dev] DRT/WTR should clear the cache at the beginning of each test?

change - I think that this is a result of the desire to get green bots without doing real WebCore work to fix underlying bugs. - WBR, Alexey Proskuryakov ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo

Re: [webkit-dev] DRT/WTR should clear the cache at the beginning of each test?

is expected to change how your browser behaves, so it's OK for tests to depend on that. But visiting site A is not expected to affect behavior on site B, even though cache state was affected by site A. - WBR, Alexey Proskuryakov ___ webkit-dev mailing list

[webkit-dev] EWS commenting about ancient patches

On several occasions over the last few days, I noticed EWS commenting in bugs that didn't have any recent activity, e.g. https://bugs.webkit.org/show_bug.cgi?id=87527. Is EWS picking ancient patches, or is it posting comments to wrong bugs? - WBR, Alexey Proskuryakov

Re: [webkit-dev] Adding Web MIDI API support to WebCore

system that has to provide APIs for every peripheral a computer has. Or if it is now, then it needs to be structured a very different way - implementing APIs for everything from MIDI to OpenGL to HTTP to encryption in a monolithic project just doesn't make sense. - WBR, Alexey Proskuryakov

Re: [webkit-dev] Adding Web MIDI API support to WebCore

, this could be a good feature not not add. - WBR, Alexey Proskuryakov ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Breaking other ports

of chromium release branch before you first commented on bugs.webkit.org. I hope this explains the matter. - WBR, Alexey Proskuryakov ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Common build system (was Re: WebKit Wishes)

an already existing solution. To me personally, this means that Xcode project files need to be fully usable. - WBR, Alexey Proskuryakov ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Exporting symbols (was Re: Common build system (was Re: WebKit Wishes))

somewhat less of an issue for JavaScriptCore, because its exports are mostly used from cross-platform code. - WBR, Alexey Proskuryakov ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Exporting symbols (was Re: Common build system (was Re: WebKit Wishes))

, and I don't know how big an effect on performance increasing the number of exports would have. It's something to keep an eye on, not a reason to avoid trying. - WBR, Alexey Proskuryakov ___ webkit-dev mailing list webkit-dev@lists.webkit.org https

Re: [webkit-dev] Exporting symbols (was Re: Common build system (was Re: WebKit Wishes))

properly -- avoid trying what? A common EXPORT macro that is set as appropriate by each port? Yes, you are parsing it correctly :) - WBR, Alexey Proskuryakov ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo

Re: [webkit-dev] WebKit Wishes

by this? Perhaps they can be solved on a case by case basis. I remember some prior discussions of this in Bugzilla, but my recollection is that things people tried to add did not fit network loading abstraction anyway. - WBR, Alexey Proskuryakov

Re: [webkit-dev] restricting the number of new windows created in response to a user gesture

want to add something even in the case no port would be interested? Per discussion in https://bugs.webkit.org/show_bug.cgi?id=114021, we appear interested in this. - WBR, Alexey Proskuryakov ___ webkit-dev mailing list webkit-dev@lists.webkit.org https

[webkit-dev] Some loading tests disturbance coming

is platform specific and so are many of the results). Please let me know if there are issues with my plan, or if you would like to coordinate timing. - WBR, Alexey Proskuryakov ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org

[webkit-dev] Removing USE_WEBPROCESS_EVENT_SIMULATION

ports? - WBR, Alexey Proskuryakov ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Proposed feature: Network Service Discovery

networked printers in your office? Please click OK to get rid of this dialog, and finally start the browser game you want to play. - WBR, Alexey Proskuryakov ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman

Re: [webkit-dev] Loading and unloading webkit, threading, AtomicString and crashes

this issue, DEFINE_STATIC_LOCAL should be used. In a somewhat dated checkout I have on this machine, I found 5 instances of static AtomicString in WebCore, and none in WebKit/win. - WBR, Alexey Proskuryakov ___ webkit-dev mailing list webkit-dev

Re: [webkit-dev] EDITBUGS permission?

...@cablelabs.com Done. - WBR, Alexey Proskuryakov ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Proposal: Use ICU in WebKit code

to whether we use ICU directly or through an abstraction layer. - WBR, Alexey Proskuryakov ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

[webkit-dev] New feature: SubtleCrypto

this work. The spec is in http://dvcs.w3.org/hg/webcrypto-api/raw-file/tip/spec/Overview.html - it's still under development, but is quickly gaining support from browser vendors. - WBR, Alexey Proskuryakov ___ webkit-dev mailing list webkit-dev

Re: [webkit-dev] Test flakiness.

accessibility tests with --child-processes=1 --verbose options, and to start bisecting if that makes the issue reliable. Another useful approach is to make the tests run multiple times with --child-processes=1 --verbose —repeat-each=10. - WBR, Alexey Proskuryakov

Re: [webkit-dev] When to use auto? (I usually consider it harmful)

== m_nameToIdentifierMap.end()) return false; - WBR, Alexey Proskuryakov ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] When to use auto? (I usually consider it harmful)

pretty good to me. It would be great to make it a formal requirement. We can always add to it later if things get annoying. - WBR, Alexey Proskuryakov ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo

Re: [webkit-dev] When to use auto? (I usually consider it harmful)

, and a super careful reviewer could catch it. Overall, it would strain reviewers more, I think. - WBR, Alexey Proskuryakov ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Apple Mac EWS 10.9 upgrade?

a different version of the OS. - WBR, Alexey Proskuryakov ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Proposal: Stop EWS bot commenting in bugs

+1 This is blocked on improving Bugzilla EWS bubbles, making it humanly possible to find out without a comment which tests regressed. - WBR, Alexey Proskuryakov 15 янв. 2014 г., в 19:54, Sam Weinig wei...@apple.com написал(а): Hi Everyone, I am becoming increasingly annoyed

Re: [webkit-dev] Proposal: Stop EWS bot commenting in bugs

the workflow for patch author and reviewer to deal with style bot warnings when they are not inline? Manually finding relevant lines by number can't work. I agree with Tim that dumping all tested paths along with style warnings is silly. How hard would it be it to get rid of that? - WBR, Alexey

Re: [webkit-dev] Proposal: Stop EWS bot commenting in bugs

15 янв. 2014 г., в 23:02, Ryosuke Niwa rn...@webkit.org написал(а): I think that it's good to try not dumping build failures into comments right away, and to see what happens. As for not showing style bot failures, it seems almost certain that this will make them substantially more

Re: [webkit-dev] Proposal: Stop EWS bot commenting in bugs

might be best, as it also gives some control over whether to get pinged - keep the bug open if you care, close it if it's not urgent, and you cannot afford distraction now. I filed https://bugs.webkit.org/show_bug.cgi?id=127203 about this. - WBR, Alexey Proskuryakov 16 янв. 2014 г., в 15:09

Re: [webkit-dev] EFL EWS Bot output

and that has binary data in it, so it overrides the type. Another solution would be for webkitpy or webkit-queues to automagically strip escape sequences from the output. - WBR, Alexey Proskuryakov ___ webkit-dev mailing list webkit-dev@lists.webkit.org https

[webkit-dev] EWS doesn't lie!

mode. Other bots only verify that the patch builds, and don't run tests. No bots use debug mode as far as I know, so debug-only build failures and assertions will not be detected. Please run tests locally to catch as many of those as possible. - WBR, Alexey Proskuryakov

Re: [webkit-dev] JavascriptCore API: Typed arrays

extension. https://bugs.webkit.org/show_bug.cgi?id=120112 is the bug that tracks adding such an API. - WBR, Alexey Proskuryakov ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Adding flag to optionally run check-webkit-style as part of prepare-Changelog and svn-create-patch

of existing code, which is not always appropriate. So, refusing to create a ChangeLog unless I disable the style checker would be quite annoying. - WBR, Alexey Proskuryakov ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org

Re: [webkit-dev] Comment on the bug email author/reviewer before reverting a patch

(re-sent from correct address) 11 июля 2014 г., в 3:59, Maciej Stachowiak m...@apple.com написал(а): So it seems like the extra request for people using “webkitbot rollout” is to add diagnostic information to the rollout bug, and wait a reasonable period before cq+ing it. Is that something

Re: [webkit-dev] Mac WK2 EWS bots having issues

Some of the bugs tracking the issues are https://bugs.webkit.org/show_bug.cgi?id=122475 and https://bugs.webkit.org/show_bug.cgi?id=134793. - Alexey 14 июля 2014 г., в 7:23, Osztrogonác Csaba o...@inf.u-szeged.hu написал(а): Hi, It seems the Mac WK2 EWS bots are very flakey nowadays,

Re: [webkit-dev] Mixed content checking

23 июля 2014 г., в 17:08, Michael Catanzaro mcatanz...@igalia.com написал(а): One problem with these settings is that frames are treated as mixed passive content rather than mixed active content. For the WebKitGTK+ API I want frames to be treated as active content, which is what most major

Re: [webkit-dev] Mac WK2 EWS bots having issues

30 июля 2014 г., в 3:16, Osztrogonác Csaba o...@inf.u-szeged.hu написал(а): If there is no volunteer for fixing it in the near future, I'm going to propose a patch making the Mac WK2 EWS not comment bugzilla and set cq- for random patches. I've been already looking into this, and fixed some

Re: [webkit-dev] Mac WK2 EWS bots having issues

30 июля 2014 г., в 3:16, Osztrogonác Csaba o...@inf.u-szeged.hu написал(а): You can check the SPAM history with this bugzilla query: http://goo.gl/qepg2l (30 days history) Thank you for posting this. What's interesting is that right now, the latest result is accurate, the patch actually

Re: [webkit-dev] Mac WK2 EWS bots having issues

30 июля 2014 г., в 11:17, Alexey Proskuryakov a...@webkit.org написал(а): https://bugs.webkit.org/show_bug.cgi?id=135418 media/track/add-and-remove-track.html and media/media-fragments/TC0001.html are flaky on Mac WK2 EWS, asserting under TestRunner::removeAllWebNotificationPermissions

Re: [webkit-dev] WebKit2 EWS bots are sick

25 авг. 2014 г., в 1:54, Benjamin Poulain benja...@webkit.org написал(а): It looks like the WebKit2 EWS bots are having a bad time. They keep timing out on a bunch of tests. Can anyone restart them? The bots restart themselves frequently. Looks like there must be a real problem that makes

[webkit-dev] WebKit Dashboard metrics

Hi, You may have noticed some patches for WebKit Dashboard metrics page landed recently. The page is now live at http://build.webkit.org/dashboard/metrics.html. It's a tool that collects historical information from Buildbot and answers these questions: - How much of the time did trunk build

Re: [webkit-dev] DOMWindow::isCurrentlyDisplayedInFrame does not forbid PostMessageTimer for subframe

Hi! Could you please file a bug at bugs.webkit.org? If you have a reproducible test case where any bad behavior happens, that would be most useful. I think that the proposed fix would break a case where we currently match Firefox: main.html: - button

[webkit-dev] Fooling with EWS and commit queue

Hi, I started making changes to the logic of EWS and commit queue, please e-mail me if something breaks, or even if something begins to behave more strangely than it did before. - Alexey ___ webkit-dev mailing list webkit-dev@lists.webkit.org

[webkit-dev] New EWS status bubbles in Bugzilla

Hi, WebKit Bugzilla has new EWS status bubbles now, which will hopefully make it more clear what's going on with a patch. Mysterious yellow bubbles that could mean anything were eliminated, and most importantly, there is now detailed information presented on hover: Please try it out, and

Re: [webkit-dev] New EWS status bubbles in Bugzilla

29 сент. 2014 г., в 23:12, Carlos Garcia Campos carlo...@webkit.org написал(а): Please try it out, and let me know if something breaks, or is not as good as it could be! Looks great! thanks. I've noticed that now we use red also for patches that don't apply. I liked that there was a

Re: [webkit-dev] New EWS status bubbles in Bugzilla

On 30 сент. 2014 г., at 0:56, Carlos Garcia Campos carlo...@webkit.org wrote: Thinking about this now, we could replace bubbles with text when no queue has results (i.e. at least one queue has failed to apply, and those that didn't still haven't started processing - we can reasonably expect

Re: [webkit-dev] Downtime for Bugzilla upgrade on Thursday, October 16 from 8-10 AM PDT

The bug got actually created despite the error, https://bugs.webkit.org/show_bug.cgi?id=138043. - Alexey 24 окт. 2014 г., в 3:54, Philippe Normand ph...@igalia.com написал(а): Hi! I'm using the XML-RPC API (via git-bz) and when attaching a patch to a bug I get the following error:

Re: [webkit-dev] size_t vs unsigned in WTF::Vector API ?

This is not exactly about Vector, but if one uses FileReader.prototype.readAsArrayBuffer() on a large file, I think that it overflows ArrayBuffer. WebKit actually crashes when uploading multi-gigabyte files to YouTube, Google Drive and other similar services, although I haven't checked

Re: [webkit-dev] size_t vs unsigned in WTF::Vector API ?

be a primitive type but a class that carefully checked that you never overflowed 53 bits. -Filip On Nov 19, 2014, at 12:54 PM, Alexey Proskuryakov a...@webkit.org wrote: This is not exactly about Vector, but if one uses FileReader.prototype.readAsArrayBuffer() on a large file, I think

Re: [webkit-dev] size_t vs unsigned in WTF::Vector API ?

19 нояб. 2014 г., в 13:58, Filip Pizlo fpi...@apple.com написал(а): With Vector though, I don't know how we would differentiate code paths that need large allocations from ones that don't. Nearly anything that is exposed as a JS API or deals with external world can hit sizes over 4Gb.

Re: [webkit-dev] size_t vs unsigned in WTF::Vector API ?

19 нояб. 2014 г., в 14:58, Alexey Proskuryakov a...@webkit.org написал(а): These and related uses are all over the place - see also Vectors in FormDataBuilder, data returned from FrameLoader::loadResourceSynchronously, plug-in code that loads from network, SharedBuffer etc. Another way

Re: [webkit-dev] size_t vs unsigned in WTF::Vector API ?

20 нояб. 2014 г., в 10:45, Filip Pizlo fpi...@apple.com написал(а): - uint64_t everywhere. This way, we'll solve practical problems with large resources once and for all. Also, this may prove to be necessary to solve even YouTube/Google Drive uploads, I do not know that yet. How does

Re: [webkit-dev] size_t vs unsigned in WTF::Vector API ?

24 нояб. 2014 г., в 1:28, Antti Koivisto koivi...@iki.fi написал(а): I don't think this is really 32bit vs 64bit platform issue. The vast majority of 64bit systems our users have (that is iOS devices) can't use memory buffers sized anywhere near the 32bit limit even in theory. Also when

Re: [webkit-dev] review times

03 дек. 2014 г., в 2:32, Daniel Lazarenko dani...@opera.com написал(а): Whatsoever it would be nice find a new reviewer for my patch. Does anybody want to take it? Just to be clear about this part, the reviewer should not be just anybody. This patch is part of an effort to implement a new

Re: [webkit-dev] run-webkit-tests question; hashes when comparing ref test output

23 янв. 2015 г., в 10:01, Ryosuke Niwa rn...@webkit.org написал(а): We could add a new test expectation like ImageDiff to suppress these or we could expose a new internals or testRunner methods to mark a test as such. Good idea! An ImageHashMismatch expectation seems like a reasonable way to

Re: [webkit-dev] run-webkit-tests question; hashes when comparing ref test output

22 янв. 2015 г., в 11:30, Simon Fraser simon.fra...@apple.com написал(а): This happens when the expected and actual images are very close, but not identical. ImageDiff has some built-in rounding that effectively acts as a small tolerance, so the hashes are different, but ImageDiff

Re: [webkit-dev] run-webkit-tests question; hashes when comparing ref test output

22 янв. 2015 г., в 17:57, Darin Adler da...@apple.com написал(а): What about the test I cited? svg/css/svg-resource-fragment-identifier-img-src.html This particular test is buggy - it is a hidpi test, so it dumps results as a 1600x1200 image, but its -expected.html is not hidpi, and is

Re: [webkit-dev] Running W3C tests using wptserve

31 янв. 2015 г., в 11:57, youenn fablet youe...@gmail.com написал(а): Currently, only two tests are run within that folder: - web-platform-tests/domparsing/DOMParser-parseFromString-html.html - web-platform-tests/domparsing/insert-adjacent.html Should there be any issus with those tests,

Re: [webkit-dev] Running W3C tests using wptserve

correctly. Is it possible to get access to the corresponding WebKitBuild/Release/layout-test-results, in particular wptwk_process_log.out.txt? Also, does it happen on all bots or only windows bot? 2015-02-01 4:41 GMT+01:00 Alexey Proskuryakov a...@webkit.org: 31 янв. 2015 г., в 11:57

Re: [webkit-dev] [Proposal] Remove support for 'multipart/x-mixed-replace' main resources

24 апр. 2015 г., в 9:06, Brady Eidson beid...@apple.com написал(а): Killing the feature would lead to a confusing experience for such users. Additionally, I think that outright killing multipart main resources would cause unnecessarily confusing experience for WebKit developers. One of the

Re: [webkit-dev] Switching servers for EWS and flakiness dashboard [Caution: Message contains Suspicious URL content]

I tried running the style queue from command line, and it processed some patches, errored out on some others, and then hit a different error. I restarted the queue normally then, and it has processed all patches except for https://bugs.webkit.org/attachment.cgi?id=257920action=prettypatch. We

Re: [webkit-dev] Windows EWS not working?

(re-sending from the right e-mail address for the list) > 7 нояб. 2015 г., в 16:56, Darin Adler написал(а): > > I was looking at the patch in this bug: > > https://bugs.webkit.org/show_bug.cgi?id=150967 > > The patch was posted 20 hours ago. EWS has processed this for all

Re: [webkit-dev] Mac EWS Updates!

Normally, we try to configure EWS with OS versions that most engineers no longer use on their machines, to maximize the chances of catching problems that one can't catch locally. It would certainly be ideal to cover the full spectrum, as many contributors don't have Macs at all. - Alexey >

Re: [webkit-dev] How to deal with 1-pixel differences in reftests ?

Hi, I do not think that there is a way to algorithmically define what an acceptable difference is. Here are a few cases where it's critical to detect small differences: - color management, e.g. testing different code paths that should match precisely; - finding uninitialized memory use bugs

Re: [webkit-dev]

Hello Yoav, Is there any technology on the horizon that would simplify doing this kind of optimization? If done manually, this seems: - complicated, so only a few sites will do this; - very likely to go stale, as the content changes, but preload instructions do not get updated; - related to the

Re: [webkit-dev] Commit queue issues

02 сент. 2015 г., в 5:41, Philippe Normand написал(а): > It seems the commit queue cannot land patches? > > https://bugs.webkit.org/show_bug.cgi?id=148702 This should be resolved now. I see that you already marked this patch for cq+ again; I'll see if any others are stuck.

Re: [webkit-dev] Commit queue issues

> 2 сент. 2015 г., в 9:59, Alexey Proskuryakov <a...@webkit.org> написал(а): > > > 02 сент. 2015 г., в 5:41, Philippe Normand <ph...@igalia.com> написал(а): > >> It seems the commit queue cannot land patches? >> >> https://bugs.webkit.org/show_b

<    1   2   3   4   5   >