Food for thought... Skia's "skdiff" tool generates two diff images for each
image pair:
- 1. every pixel which is different at all between images 1 & 2 shows up
as white
- 2. every pixel shows the color difference between images 1 & 2 (much
more subtle)
For an example of what this lo
On Thu, Jun 14, 2012 at 4:44 PM, Peter Kasting wrote:
> On Thu, Jun 14, 2012 at 1:39 PM, Elliot Poger wrote:
>
>> Can someone please remind me why IMAGE+TEXT even exists?
>>
>> Wouldn't it be simpler to just mark a test as follows?
>>
>>- IMAGE :
On Wed, Jun 13, 2012 at 6:53 PM, Dirk Pranke wrote:
>
> * We'll probably rename IMAGE+TEXT to IMAGE_AND_TEXT.
>
>
Can someone please remind me why IMAGE+TEXT even exists?
Wouldn't it be simpler to just mark a test as follows?
- IMAGE : allow image failure; go red if there is a text failure
Can someone please add EditBugs permission for my bugs.webkit.org account (
epo...@chromium.org)?
Another WebKit committer and I both tried it, using the steps Eric pasted
in April, but it failed... I think maybe the add-users-to-groups tool is
broken?
$ Tools/Scripts/webkit-patch add-users-to-gr
In deciding whether to just let the PNGs get shrunk over time or to do a
pass over all of them at once, I think we should decide what we are trying
to optimize for. (Download time for initial checkout of the webkit tree?
Time for existing developers to update their trees? Storage space in the
re
What is it that causes some tests to require baseline images (and not text
files) for comparison, while others require text and not image baselines?
(I know that I can specifically SKIP comparison against IMAGE and/or TEXT
using test_expectations.txt... but even without the use of
test_expectation
Filed https://bugs.webkit.org/show_bug.cgi?id=75548 ('[rollup] remove
chromium-cg-mac baselines')
On Wed, Jan 4, 2012 at 10:37 AM, Adam Barth wrote:
> On Wed, Jan 4, 2012 at 6:10 AM, Elliot Poger wrote:
> > I agree that it is reasonable (and a good idea) to remove the
I agree that it is reasonable (and a good idea) to remove the
chromium-cg-mac expectations from WebKit now, and I am willing to take the
lead on doing so (although I will need help from WebKit committers).
Please let me know if anyone agrees/disagrees with the following steps to
do so:
1. remove
;garden-o-matic
does nothing?')
Thus I am still unable to rebaseline tests across multiple platforms.
Is there a technique that actually works, with tools that exist today?
On Tue, Nov 8, 2011 at 4:08 PM, Adam Barth wrote:
> On Tue, Nov 8, 2011 at 1:00 PM, Elliot Poger wrote:
> >
> On Tue, Nov 8, 2011 at 12:24 PM, Adam Barth wrote:
> > On Tue, Nov 8, 2011 at 12:20 PM, Tony Chang wrote:
> >> On Tue, Nov 8, 2011 at 12:00 PM, Elliot Poger
> wrote:
> >>> Perhaps I should approach this from a different angle:
> >>> What is the
s, to the WebKit repo
On Tue, Nov 8, 2011 at 2:48 PM, Eric Seidel wrote:
> I believe that tool just got nuked. Seems the Wiki page should as well:
> https://bugs.webkit.org/show_bug.cgi?id=71833
>
> On Tue, Nov 8, 2011 at 9:09 AM, Adam Barth wrote:
> > On Tue, Nov 8, 2011 a
s, to the WebKit repo
On Tue, Nov 8, 2011 at 2:48 PM, Eric Seidel wrote:
> I believe that tool just got nuked. Seems the Wiki page should as well:
> https://bugs.webkit.org/show_bug.cgi?id=71833
>
> On Tue, Nov 8, 2011 at 9:09 AM, Adam Barth wrote:
> > On Tue, Nov 8, 2011 a
We finally have correct baseline images checked in for Chromium-Skia on
SnowLeopard (hooray). Now we face the daunting task of rebaselining for
Chromium-Skia on Leopard.
The problem is that chromium-mac-leopard has ~4500 image diffs compared to
chromium-mac. The vast majority of these diffs are
the information.
> - Ryosuke
>
> On Fri, Oct 7, 2011 at 11:53 AM, Simon Fraser wrote:
>
>> On Oct 7, 2011, at 11:45 AM, Elliot Poger wrote:
>>
>> > I was having problems with lots of image mismatches running WebKit
>> layout tests on a headless MacPro (
I was having problems with lots of image mismatches running WebKit layout
tests on a headless MacPro (10.6.8). (The image diffs were very minor
adjustments in scroll bar shading.)
Eventually, out of frustration, I tried running the same test on that
headless MacPro as well as my desktop MacPro (a
15 matches
Mail list logo
