Re: [webkit-dev] svn-create-patch acting oddly lately

2009-07-20 Thread Joseph Pecoraro
It's kind of sad that we have so many ways of finding the SVN root. The code in that link isn't right. You need to look at the UUID to get the right answer. See scm.py. Yes, I saw scm.py's solution literally yesterday while I was learning how to use bugzilla-tool because I switched to git.

Re: [webkit-dev] svn-* scripts

2009-08-21 Thread Joseph Pecoraro
to deal with the patch. These are the only changes I know of. If there are any others its possible they may be WebKit specific. - Joseph Pecoraro ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi

Re: [webkit-dev] ENABLE(INSPECTOR) check in Console::lastWMLErrorMessage

2010-04-29 Thread Joseph Pecoraro
Hello Ryan, Looks like it should add ENABLE(INSPECTOR) check in Console::lastWMLErrorMessage() (/trunk/WebCore/page/Console.cpp) Thanks. Could you file a bug using this link? http://webkit.org/new-inspector-bug Please include any relevant error messages you're getting, such as a compiler

Re: [webkit-dev] ENABLE(INSPECTOR) check in Console::lastWMLErrorMessage

2010-04-29 Thread Joseph Pecoraro
On Apr 29, 2010, at 12:53 AM, Joseph Pecoraro wrote: Looks like it should add ENABLE(INSPECTOR) check in Console::lastWMLErrorMessage() (/trunk/WebCore/page/Console.cpp) Thanks. Ryan, I've created a bug and put up a few patches (2 desired behaviors): https://bugs.webkit.org/show_bug.cgi?id

Re: [webkit-dev] Meaning of PLATFORM(MAC) and platform/cocoa?

2010-07-05 Thread Joseph Pecoraro
It seems like a good idea to share as much code as we can between ports rather than forking files. Absolutely, that was the original reason behind platform/cocoa! To that end, would it be possible for someone to explain the exact meaning of PLATFORM(MAC) and the intended use of the

Re: [webkit-dev] WebKit blog post proposal: Remote debugging with Web Inspector.

2010-08-09 Thread Joseph Pecoraro
On Aug 9, 2010, at 12:48 PM, Pavel Feldman wrote: See the screencast at http://screencast.com/t/YTI2OTY4YTEt. It has Chromium nightly to the left + WebKit nightly to the right. WebKit nightly connects remotely to Chromium over HTTP on the port 9222 and does remote debugging including DOM

Re: [webkit-dev] Remote debugger

2011-02-18 Thread Joseph Pecoraro
Hello Sergiy, I've got a bunch of links for different areas where work has been done. Some information on the protocol and is outlined in the following links. I don't think they are up to date; I think things have improved and evolved since then. Pavel and Ilya may be able to comment more on

Re: [webkit-dev] ChangeLog format

2013-08-22 Thread Joseph Pecoraro
On Aug 22, 2013, at 12:46 AM, Carlos Garcia Campos carlo...@webkit.org wrote: El jue, 22-08-2013 a las 00:41 -0700, Mark Rowe escribió: On 2013-08-21, at 11:11 PM, Carlos Garcia Campos carlo...@webkit.org wrote: I see, I thought ChangeLog parser was used everywhere. So, I guess the

Re: [webkit-dev] Windows a Release Build Broken

2013-12-27 Thread Joseph Pecoraro
Windows bots on build.webkit.org are now green. Thanks for pointing me to the fixes in bugzilla comments. - Joe On Dec 25, 2013, at 9:23 PM, Brent Fulgham bfulg...@apple.com wrote: The changes in Bug 126091 breaks the Windows Release build. https://bugs.webkit.org/show_bug.cgi?id=126091

Re: [webkit-dev] Proposal: Stop EWS bot commenting in bugs

2014-01-15 Thread Joseph Pecoraro
I would also like to see a reduction in EWS spam. It is not just the comment clutter, but also quite a bit of emails. - Joe On Jan 15, 2014, at 8:17 PM, Ryosuke Niwa rn...@webkit.org wrote: We could do that, or add some JS hack to Bugzilla so that it hides EWS comments by default but makes

[webkit-dev] Heads up: FALLTHROUGH annotations for switches with fallthroughs

2014-01-26 Thread Joseph Pecoraro
Hello! I'm slowly enabling -Wimplicit-fallthrough on projects in the Mac / iOS ports. http://trac.webkit.org/changeset/162793 http://clang.llvm.org/docs/LanguageExtensions.html#the-clang-fallthrough-attribute This means that if you write any switch statements with implicit fallthroughs it will

Re: [webkit-dev] Heads up: FALLTHROUGH annotations for switches with fallthroughs

2014-01-26 Thread Joseph Pecoraro
: I like this! Out of curiosity, will it be needed for cases like: switch (input) { case 1: // fallthrough? case 2: // Handle both 1 and 2 break; default: // default } Thanks, ~Brady On Jan 26, 2014, at 1:41 AM, Joseph Pecoraro pecor...@apple.com wrote: Hello

Re: [webkit-dev] WebKit Remote Web Inspector

2014-06-20 Thread Joseph Pecoraro
Hello, Yes, this is possible. There are currently two paths to making Web Inspector work across processes. 1. ENABLE(INSPECTOR_SERVER) Currently enabled by GTK and EFL. The UIProcess process establishes an HTTP Web/WebSocket server. The index page is a listing page which advertises

[webkit-dev] EFL and GTK EWS bots having issues

2014-07-11 Thread Joseph Pecoraro
It seems the EFL and GTK EWS bots are having trouble for a few days now: http://webkit-queues.appspot.com - GTK EWS bot has Unable to build without patch” with: ninja: error: build.ninja:3225: lexing error - EFL EWS bot doesn’t seem to be processing patches. Who would be

Re: [webkit-dev] WKWebView Inspector in my own app

2014-08-11 Thread Joseph Pecoraro
On Aug 11, 2014, at 3:23 AM, Koen Bok k...@madebysofa.com wrote: I am looking how to show the inspector in my own mac desktop app with WKWebViews. You are correct that currently the only supported way to inspect a WKWebView is through Safari with an entitlement in your app (see the WWDC

Re: [webkit-dev] WKWebView Inspector in my own app

2014-08-11 Thread Joseph Pecoraro
On Aug 11, 2014, at 12:10 PM, Joseph Pecoraro pecor...@apple.com wrote: On Aug 11, 2014, at 3:23 AM, Koen Bok k...@madebysofa.com mailto:k...@madebysofa.com wrote: I am looking how to show the inspector in my own mac desktop app with WKWebViews. You are correct that currently

Re: [webkit-dev] [webkit-help] Issue with Web Inspector debugger breakpoint handling (on Wincairo)

2015-10-02 Thread Joseph Pecoraro
> Here are the simple steps to reproduce it, > 1. Launch WinCairo and go to google.com > 2. Open Web inspector and open the script source of any .js script > 3. Set a breakpoint anywhere > 4. Reload the web page > > What we see is the spinner spinning

Re: [webkit-dev] [webkit-help] Issue with Web Inspector debugger breakpoint handling (on Wincairo)

2015-10-02 Thread Joseph Pecoraro
I suggest reopening and restarting investigation on: Promise reactions in the Inspector page do not run when the debugger is paused on the inspected page The bug already has some analysis. You could use that to verify if your case is the same and investigate a fix.

Re: [webkit-dev] Inspector code

2017-02-24 Thread Joseph Pecoraro
Whoever hosts the Web Inspector frontend page has the real connection to the backend. The host provides an InspectorFrontendHost global object to the frontend page that can be used to send messages through that already established connection. Likewise when the host wants to trigger operations

Re: [webkit-dev] REQUEST_ANIMATION_FRAME on all ports?

2017-01-16 Thread Joseph Pecoraro
I also like the idea that we should remove flags for core web features that have been stable for a while. There were no objections raise on this thread to remove the REQUEST_ANIMATION_FRAME flag. Patch up on: https://bugs.webkit.org/show_bug.cgi?id=156980

Re: [webkit-dev] Another WPT bite

2017-05-12 Thread Joseph Pecoraro
> On May 12, 2017, at 2:39 PM, Ryosuke Niwa wrote: > > On Fri, May 12, 2017 at 12:04 PM, Alexey Proskuryakov > wrote: > >> We don't have a concept of "first class", but I hope that when choosing >> between looking into a simple test

[webkit-dev] Proposal: Remove Vibration API

2017-05-09 Thread Joseph Pecoraro
There is code in the tree for the Vibration API guarded by ENABLE(VIBRATION). I propose we remove it: Remove Vibration API There have been concerns that the Vibration API can be used for fingerprinting and has the potential for abuse by web content:

Re: [webkit-dev] dump-class-layout script not working

2018-11-05 Thread Joseph Pecoraro
> On Nov 4, 2018, at 3:43 AM, Frank Jaeger wrote: > > Hello. First of all I'm really sorry if this is the wrong mailing list to > post to, webkit-help would have probably been better but it doesn't seem very > active. > > I run into some problems while trying to use the dump-class-layout

Re: [webkit-dev] Can we remove XXX.order files in the tree

2019-10-17 Thread Joseph Pecoraro
I put up patches a few year ago: [Cocoa] Remove or update order files It was approved at the time, but I was asked to measure performance and I'm still not sure how to do that. I'm still in favor of removing them! - Joe > On Oct 17, 2019, at 3:06 PM, Saam Barati

Re: [webkit-dev] Accidental binary bloating via C/C++ class/struct + Objective-C

2020-01-13 Thread Joseph Pecoraro
This is a great idea! - Joe > On Jan 13, 2020, at 5:52 PM, Yusuke Suzuki wrote: > > Hello WebKittens, > > I recently striped 830KB binary size in WebKit just by using a work-around. > This email describes what happened so far, to prevent from happening again. > > ## Problem > > When C/C++

Re: [webkit-dev] Caio Lima is now a WebKit reviewer

2021-03-24 Thread Joseph Pecoraro via webkit-dev
Congrats Caio!! - Joe > On Mar 18, 2021, at 3:42 PM, Saam Barati via webkit-dev > wrote: > > Hi folks, > > I'm happy to announce that Caio Lima is now a WebKit reviewer. Send your > JavaScriptCore reviews his way! > > Congrats, Caio. > > - Saam >