Re: [webkit-dev] OWNERS policy

2018-02-22 Thread Maciej Stachowiak
> On Feb 21, 2018, at 11:06 PM, Carlos Garcia Campos > wrote: > > El mié, 21-02-2018 a las 13:49 -0800, Ryosuke Niwa escribió: >> If there was any confusion, WebKit2 Owner's policy is still active >> and in effect. > > And maybe it's time to get rid of it? I never liked

Re: [webkit-dev] Buildbot upgrade on build.webkit.org

2018-01-08 Thread Maciej Stachowiak
> On Jan 8, 2018, at 1:33 PM, Aakash Jain wrote: > > Hi Everyone, > > I filed the Buildbot bug regarding Waterfall view not displaying steps > information by default: https://github.com/buildbot/buildbot/issues/3884 >

Re: [webkit-dev] HSTS user tracking

2018-01-05 Thread Maciej Stachowiak
Brent Fulgham or John Wilander would know the details. - Maciej > On Jan 5, 2018, at 8:04 AM, Michael Catanzaro wrote: > > > Hi devs, > > Any info about how to mitigate this problem would be appreciated. Thanks! > > Michael > >

Re: [webkit-dev] Hosting precompiled `jsc` binaries for Linux

2017-12-12 Thread Maciej Stachowiak
> <https://github.com/v8/v8/wiki/Handling-of-Ports> > > Or the MIPS version of NaCl? > > I agree this is the same. If I was building an installer that included these > ports, I’d prefer to get the downloads through Google/V8 too, if possible. > > On Tue, Dec 12,

Re: [webkit-dev] Hosting precompiled `jsc` binaries for Linux

2017-12-12 Thread Maciej Stachowiak
> On Dec 12, 2017, at 11:42 AM, Mathias Bynens wrote: > > On Tue, Dec 12, 2017 at 8:38 PM, JF Bastien > wrote: > > On Tue, Dec 12, 2017 at 11:27 AM Mathias Bynens > wrote: > Ideally,

Re: [webkit-dev] Upstreaming from LayoutTests to web-platform-tests, coordinating Blink+WebKit

2017-11-17 Thread Maciej Stachowiak
> On Nov 17, 2017, at 7:53 AM, Frédéric WANG <fred.w...@free.fr> wrote: > > On 17/11/2017 16:26, Maciej Stachowiak wrote: >> WebKit has a lot of tests that were regression tests for a specific >> bug fix, not as conformance tests (though they might b useful for

Re: [webkit-dev] Upstreaming from LayoutTests to web-platform-tests, coordinating Blink+WebKit

2017-11-17 Thread Maciej Stachowiak
> On Nov 17, 2017, at 7:05 AM, Frédéric WANG wrote: > > Hi Philip, > > We (at Igalia) are strong supporters of WPT tests and we've appreciated a lot > the effort made by Youenn and others to make them possible in WebKit. They > are very important for interoperability and

Re: [webkit-dev] Upstreaming from LayoutTests to web-platform-tests, coordinating Blink+WebKit

2017-11-17 Thread Maciej Stachowiak
> On Nov 17, 2017, at 7:15 AM, Konstantin Tokarev wrote: > > > > 16.11.2017, 20:10, "Alexey Proskuryakov" : >> Migrating WebKit tests seems undesirable to me, as that would make us lose >> all their modification history. As mentioned before, WPT tests are

Re: [webkit-dev] Formatting style for inline comments in Python code

2017-11-03 Thread Maciej Stachowiak
> On Nov 3, 2017, at 8:59 AM, Aakash Jain <aakash_j...@apple.com> wrote: > > > >> On Nov 2, 2017, at 8:45 PM, Maciej Stachowiak <m...@apple.com >> <mailto:m...@apple.com>> wrote: >> >> >> >>> On Nov 2, 2017, at 5:41 PM,

Re: [webkit-dev] Formatting style for inline comments in Python code

2017-11-02 Thread Maciej Stachowiak
> On Nov 2, 2017, at 5:41 PM, Aakash Jain <aakash_j...@apple.com> wrote: > > > >> On Oct 26, 2017, at 10:21 AM, Maciej Stachowiak <m...@apple.com >> <mailto:m...@apple.com>> wrote: >> >> >> >>> On Oct 26, 2017, at

Re: [webkit-dev] Formatting style for inline comments in Python code

2017-10-26 Thread Maciej Stachowiak
> On Oct 26, 2017, at 10:20 AM, Eric Carlson wrote: > > > >> On Oct 26, 2017, at 9:50 AM, Brian Burg > > wrote: >> >> >> >>> 2017/10/26 午前9:21、Alexey Proskuryakov >> >のメール: >>>

Re: [webkit-dev] Proposal: Remove ENABLE(MATHML)

2017-10-25 Thread Maciej Stachowiak
> On Oct 25, 2017, at 1:44 AM, Frédéric WANG <fred.w...@free.fr> wrote: > > On 24/10/2017 18:50, Maciej Stachowiak wrote: >> I don't have a strong opinion on whether we should support disabling >> MathML. My point is just that if we support disabling it, it sh

Re: [webkit-dev] Proposal: Remove ENABLE(MATHML)

2017-10-24 Thread Maciej Stachowiak
> On Oct 24, 2017, at 12:14 AM, Frédéric WANG <fred.w...@free.fr> wrote: > > On 23/10/2017 18:11, Maciej Stachowiak wrote: >> >> Is there any way we can convert MathML to a runtime switch? It seems >> like the main consideration is rendering quality given ava

Re: [webkit-dev] Proposal: Remove ENABLE(MATHML)

2017-10-23 Thread Maciej Stachowiak
> On Oct 23, 2017, at 9:04 AM, Konstantin Tokarev wrote: > > > > 23.10.2017, 18:43, "Frédéric WANG" >: >> Hi, >> >> There have been some discussions recently on >> https://bugs.webkit.org/show_bug.cgi?id=177744 regarding the

Re: [webkit-dev] Forward.h's Vector

2017-09-13 Thread Maciej Stachowiak
> On Sep 13, 2017, at 8:11 AM, JF Bastien wrote: > > Hello WebCritters, > > I’m moving some code around, and one particular header I have is included > everywhere in JSC so I’d like it to be lightweight and include as few other > headers as possible. It unfortunately

Re: [webkit-dev] Get rid of RefPtr, replace with std::optional?

2017-09-01 Thread Maciej Stachowiak
> On Sep 1, 2017, at 10:07 AM, Brady Eidson <beid...@apple.com> wrote: > > > >> On Sep 1, 2017, at 9:46 AM, Maciej Stachowiak <m...@apple.com> wrote: >>> >>> Does RefPtr do anything for us today that std::optional doesn’t? >> &

Re: [webkit-dev] Growing tired of long build times? Check out this awesome new way to speed up your build... soon (HINT: It's not buying a new computer)

2017-08-30 Thread Maciej Stachowiak
> On Aug 30, 2017, at 2:15 AM, Konstantin Tokarev wrote: > > > > 30.08.2017, 03:01, "Michael Catanzaro" : >> On Tue, Aug 29, 2017 at 6:20 PM, Alicia Boya García >> wrote: >>> As long as the sets are generated consistently that

Re: [webkit-dev] Growing tired of long build times? Check out this awesome new way to speed up your build... soon (HINT: It's not buying a new computer)

2017-08-29 Thread Maciej Stachowiak
> On Aug 29, 2017, at 6:40 PM, Sam Weinig <wei...@apple.com> wrote: > > > >> On Aug 29, 2017, at 6:36 PM, Maciej Stachowiak <m...@apple.com >> <mailto:m...@apple.com>> wrote: >> >> >> >>> On Aug 29, 2017, at 5:54 P

Re: [webkit-dev] Growing tired of long build times? Check out this awesome new way to speed up your build... soon (HINT: It's not buying a new computer)

2017-08-29 Thread Maciej Stachowiak
> On Aug 29, 2017, at 5:54 PM, Sam Weinig wrote: > > > >> On Aug 29, 2017, at 12:46 PM, Geoffrey Garen > > wrote: >> >>> This isn’t the scenario I find myself in most often. A much more common >>> scenario is working on a

Re: [webkit-dev] Unified source builds: A new rule for static variables

2017-08-29 Thread Maciej Stachowiak
> On Aug 29, 2017, at 11:31 AM, Darin Adler wrote: > > Sent from my iPhone > >> On Aug 29, 2017, at 11:22 AM, Keith Miller wrote: >> >> I doubt anyone is going to run such a script before they go to upload a >> patch to bugzilla. > > EWS was what

Re: [webkit-dev] Growing tired of long build times? Check out this awesome new way to speed up your build... soon (HINT: It's not buying a new computer)

2017-08-29 Thread Maciej Stachowiak
> On Aug 29, 2017, at 9:10 AM, Chris Dumez wrote: > > I worry about adopting unity build because while it makes clean builds > faster, it also slows down incremental builds. As a developer, I rarely do > clean builds, I mostly do incremental builds so this would likely make

Re: [webkit-dev] Growing tired of long build times? Check out this awesome new way to speed up your build... soon (HINT: It's not buying a new computer)

2017-08-28 Thread Maciej Stachowiak
> On Aug 28, 2017, at 9:20 PM, Daniel Bates wrote: > > Thank you for looking into speeding up the build. > > How does the speed gain with your proposed "unified source" approach compare > to using CMake + Ninja to build currently (I think builder Apple El Capitan > CMake

Re: [webkit-dev] CSS Typed OM

2017-08-21 Thread Maciej Stachowiak
I don't have a strong opinion on the spec itself, but I'd like to encourage you to do it using a runtime flag as recommend by the feature policy. - Maciej > On Aug 18, 2017, at 12:44 PM, Olmstead, Don wrote: >

Re: [webkit-dev] WEB_TIMING enabled on all ports - let's remove the flag?

2017-08-02 Thread Maciej Stachowiak
> On Aug 2, 2017, at 2:18 AM, Ryosuke Niwa wrote: > > On Tue, Aug 1, 2017 at 10:41 PM, Adrien Destugues > wrote: >>> Some others I see: >>> >>> ENABLE_GEOLOCATION >>> ENABLE_INDEXED_DATABASE >>> ENABLE_CSS_SCROLL_SNAP >>> ENABLE_WEBGL >>>

Re: [webkit-dev] WebVR on WebKit

2017-08-02 Thread Maciej Stachowiak
Though WebVR is not the most elegant API for VR, it's a least common denominator, and it seems like other browsers are on board. So I think it's worth at least experimenting with. (Other opinions may vary; this is just my personal view not an Official Apple Position or anything). I'm guessing

Re: [webkit-dev] Removing support for CSS regions

2017-08-02 Thread Maciej Stachowiak
> On Aug 2, 2017, at 2:40 AM, Andreas Kling wrote: > >> >> On 2 Aug 2017, at 01:03, Ryosuke Niwa wrote: >> >> On Mon, Jul 31, 2017 at 1:49 AM, Andreas Kling wrote: >>> Some time has passed, and it seems that adoption of CSS regions on

Re: [webkit-dev] WEB_TIMING enabled on all ports - let's remove the flag?

2017-08-01 Thread Maciej Stachowiak
> On Aug 1, 2017, at 6:55 PM, Adrian Perez de Castro <ape...@igalia.com> wrote: > > Hello, > > On Tue, 01 Aug 2017 18:11:53 -0400, Maciej Stachowiak <m...@apple.com > <mailto:m...@apple.com>> wrote: > >>> On Aug 1, 2017, at 5:55

Re: [webkit-dev] WEB_TIMING enabled on all ports - let's remove the flag?

2017-08-01 Thread Maciej Stachowiak
> On Aug 1, 2017, at 6:32 PM, Konstantin Tokarev <annu...@yandex.ru> wrote: > > > > 02.08.2017, 01:12, "Maciej Stachowiak" <m...@apple.com > <mailto:m...@apple.com>>: >>> On Aug 1, 2017, at 5:55 PM, Konstantin Tokarev <annu...@yandex

Re: [webkit-dev] WEB_TIMING enabled on all ports - let's remove the flag?

2017-08-01 Thread Maciej Stachowiak
> On Aug 1, 2017, at 5:55 PM, Konstantin Tokarev wrote: > > > > 02.08.2017, 00:49, "Sam Weinig" : >>> On Aug 1, 2017, at 6:57 AM, Dean Jackson wrote: >>> On 24 Jul 2017, at 22:44, Brian Burg wrote: Hi

Re: [webkit-dev] WEB_TIMING enabled on all ports - let's remove the flag?

2017-08-01 Thread Maciej Stachowiak
> On Aug 1, 2017, at 9:57 AM, Dean Jackson wrote: > > > >> On 24 Jul 2017, at 22:44, Brian Burg wrote: >> >> Hi WebKittens, >> >> In WebKit, the various web-exposed timing APIs–Resource Timing, User Timing, >> and Navigation Timing are guarded by the

Re: [webkit-dev] What's the rationale for not including config.h in any header files?

2017-07-31 Thread Maciej Stachowiak
> On Jul 31, 2017, at 5:04 PM, Michael Catanzaro wrote: > > On Mon, Jul 31, 2017 at 9:27 PM, Darin Adler wrote: >> I don’t think we should add lots of includes of “config.h”, though. I think >> we can come up with something better. > > Like what? The

Re: [webkit-dev] Using "auto <function()> -> returnType" breaks prepare-ChangeLog

2017-07-28 Thread Maciej Stachowiak
> On Jul 28, 2017, at 10:58 AM, Sam Weinig wrote: > > > >> On Jul 28, 2017, at 10:31 AM, JF Bastien > > wrote: >> >> >> >>> On Jul 28, 2017, at 10:29, Sam Weinig >> > wrote:

Re: [webkit-dev] NPAPI support to remain?

2017-07-14 Thread Maciej Stachowiak
> On Jul 13, 2017, at 6:23 PM, Michael Catanzaro wrote: > > Hi, > > It seems WebKit is the last modern web engine still supporting NPAPI. Is > Apple planning to continue supporting NPAPI and WebKitPluginProcess for the > foreseeable future? Or is it something that

Re: [webkit-dev] Service workers

2017-07-14 Thread Maciej Stachowiak
> On Jul 13, 2017, at 6:19 PM, Michael Catanzaro wrote: > > Hi, > > We've noticed that service worker support has more than once been a > consideration for embedded device manufacturers when choosing between WebKit > and Chromium for their products. I see the feature

Re: [webkit-dev] Intent to remove the WebCore::IconDatabase (GTK needs to make a decision)

2017-06-16 Thread Maciej Stachowiak
> On Jun 15, 2017, at 8:01 PM, Brady Eidson <beid...@apple.com> wrote: > > Slight reordering. > >> On Jun 15, 2017, at 5:27 PM, Maciej Stachowiak <m...@apple.com> wrote: >> >> >> This is slightly tangential, but a comment on the model: it

Re: [webkit-dev] Intent to remove the WebCore::IconDatabase (GTK needs to make a decision)

2017-06-15 Thread Maciej Stachowiak
This is slightly tangential, but a comment on the model: it doesn't seem like there's a way for clients to check what range of icons are available and only then choose which to load. Even though Safari may not have needed this to move over, if you wanted to do something rigorous like load the

Re: [webkit-dev] Should we ever use std::function instead of WTF::Function?

2017-06-13 Thread Maciej Stachowiak
In case it turns out not to be possible to reduce the number of concepts (besides eliminating std::function), maybe it would help to change the names and behaviors of these classes to match better. Function, SharedFunction and ScopedFunction would have a much more obvious relationship to each

Re: [webkit-dev] "ReflectOnly" IDL equivalent

2017-06-10 Thread Maciej Stachowiak
> On Jun 9, 2017, at 10:08 PM, Chris Dumez wrote: > > >>> On Jun 9, 2017, at 11:47 AM, Sam Weinig wrote: >>> >>> >>> >>> On Jun 2, 2017, at 11:32 AM, Ryosuke Niwa wrote: >>> On Fri, Jun 2, 2017 at 9:18 AM, Chris Dumez

Re: [webkit-dev] Where do we put WPT tests to be exported

2017-05-21 Thread Maciej Stachowiak
> On May 18, 2017, at 2:08 PM, Philip Jägenstedt wrote: > > On Tue, May 16, 2017 at 5:38 PM youenn fablet > wrote: > > There was a suggestion that LayoutTests/imported/w3c/web-platform-tests be > moved to a shorter path like

Re: [webkit-dev] Another WPT bite

2017-05-16 Thread Maciej Stachowiak
> On May 16, 2017, at 1:16 AM, Ryosuke Niwa wrote: > > On Mon, May 15, 2017 at 11:57 PM, Anne van Kesteren wrote: >> On Tue, May 16, 2017 at 7:29 AM, Ryosuke Niwa wrote: >>> Given we're talking about how these tests are ran inside WebKit,

Re: [webkit-dev] Where do we put WPT tests to be exported

2017-05-16 Thread Maciej Stachowiak
> On May 15, 2017, at 9:08 PM, youenn fablet wrote: > > I see two main cases: > - Writer of the patch is making sure to upstream WPT test changes at WebKit > landing time. It is ok to make the changes directly in > LayoutTests/imported/w3c/web-platform-tests/ > - Writer

Re: [webkit-dev] Another WPT bite

2017-05-14 Thread Maciej Stachowiak
> On May 13, 2017, at 5:26 PM, Michael[tm] Smith <m...@w3.org> wrote: > > Maciej Stachowiak <m...@apple.com>, 2017-05-13 14:58 -0700: >> ... From what I gather, there are a lot of tests where only the paths to >> the test harness end up requiring the

Re: [webkit-dev] Another WPT bite

2017-05-13 Thread Maciej Stachowiak
> On May 12, 2017, at 7:49 PM, a...@webkit.org wrote: > > >> 12 мая 2017 г., в 19:38, Brian Burg > > написал(а): >> >>> I think that I explained it very clearly, but let me try again. >>> >>> When there is a test failure that I need to communicate

Re: [webkit-dev] Another WPT bite

2017-05-12 Thread Maciej Stachowiak
> On May 12, 2017, at 2:39 PM, Ryosuke Niwa wrote: > > On Fri, May 12, 2017 at 12:04 PM, Alexey Proskuryakov wrote: >> >> 12 мая 2017 г., в 11:52, Ben Kelly написал(а): >> >> On Fri, May 12, 2017 at 2:26 PM, Rick Byers

[webkit-dev] Also in the tradition of massive renames

2017-05-10 Thread Maciej Stachowiak
I'd like to propose the following directory renames for consideration: Source/WebKit --> Source/WebKitLegacy (or alternately, LegacyWebKit for autocomplete happiness, but maybe not if we keep the LayoutTests name) Source/WebKit2 --> Source/WebKit Reasons: - Matches the current names of the

Re: [webkit-dev] Rename LayoutTests

2017-05-10 Thread Maciej Stachowiak
ebkit.org <mailto:rn...@webkit.org>> > wrote: >>> On Wed, May 10, 2017 at 12:02 AM, Maciej Stachowiak <m...@apple.com >>> <mailto:m...@apple.com>> wrote: >>>> IntegrationTests doesn't distinguish them from performance tests, or API >>

Re: [webkit-dev] Rename LayoutTests

2017-05-10 Thread Maciej Stachowiak
A few more coats of paint for the bike shed: > On May 9, 2017, at 10:45 PM, Ryosuke Niwa <rn...@webkit.org> wrote: > > On Tue, May 9, 2017 at 10:23 PM, Maciej Stachowiak <m...@apple.com > <mailto:m...@apple.com>> wrote: > > On May 9, 2017, at 9:0

Re: [webkit-dev] Rename LayoutTests

2017-05-10 Thread Maciej Stachowiak
> On May 9, 2017, at 10:43 PM, Dan Bernstein <m...@apple.com> wrote: > > >> On May 9, 2017, at 10:23 PM, Maciej Stachowiak <m...@apple.com >> <mailto:m...@apple.com>> wrote: >> >>> JSTests, and >> >> Could go under Jav

Re: [webkit-dev] Rename LayoutTests

2017-05-09 Thread Maciej Stachowiak
> On May 9, 2017, at 9:07 PM, Michael Catanzaro <mcatanz...@igalia.com> wrote: > > On Tue, May 9, 2017 at 11:01 PM, Maciej Stachowiak <m...@apple.com> wrote: >> How about just Tests? >> Or alternately, RegressionTests. But I like just plain Tests. > &g

Re: [webkit-dev] Rename LayoutTests

2017-05-09 Thread Maciej Stachowiak
How about just Tests? Or alternately, RegressionTests. But I like just plain Tests. > On May 9, 2017, at 8:51 PM, Michael Catanzaro wrote: > >> On Tue, May 9, 2017 at 9:23 PM, Ryosuke Niwa wrote: >> AutomatedTests - As opposed to ManualTests. > > The

Re: [webkit-dev] Idiom for functions with all return values in a switch case

2017-05-09 Thread Maciej Stachowiak
> On May 9, 2017, at 12:05 PM, Alfonso Guerra wrote: > > > > On May 9, 2017 2:07 PM, "Michael Catanzaro" > wrote: > Hi, > > Consider this function: > >        static WKAutoplayEvent

Re: [webkit-dev] Idiom for functions with all return values in a switch case

2017-05-09 Thread Maciej Stachowiak
> On May 9, 2017, at 11:35 AM, Michael Catanzaro <mcatanz...@igalia.com> wrote: > > On Tue, May 9, 2017 at 1:13 PM, Maciej Stachowiak <m...@apple.com> wrote: >> I think this second option may suppress the warning when you have forgotten >> to list one of th

Re: [webkit-dev] Idiom for functions with all return values in a switch case

2017-05-09 Thread Maciej Stachowiak
> On May 9, 2017, at 11:06 AM, Michael Catanzaro wrote: > > Hi, > > Consider this function: > > static WKAutoplayEvent toWKAutoplayEvent(WebCore::AutoplayEvent event) > { > switch (event) { > case >

Re: [webkit-dev] Another WPT bite

2017-05-09 Thread Maciej Stachowiak
> On May 9, 2017, at 8:11 AM, Geoffrey Garen wrote: > >> What we're suggesting is to give preferential treatments to >> testharness.js over js-test.js / js-test-pre.js when you were already >> planning to write a test with the latter two scripts. > > OK, I think this makes

Re: [webkit-dev] Another WPT bite

2017-05-09 Thread Maciej Stachowiak
> On May 9, 2017, at 8:44 AM, youenn fablet wrote: > > > Besides other issues mentioned, testharness tends to result in more verbose > tests compared to js-test, at least for simple cases. > > For synchronous tests, I am not sure there is any big difference one way or >

Re: [webkit-dev] Another WPT bite

2017-05-09 Thread Maciej Stachowiak
> On May 8, 2017, at 11:15 PM, Ryosuke Niwa wrote: > > On Mon, May 8, 2017 at 11:01 PM, Brady Eidson > wrote: > > On May 8, 2017, at 10:44 PM, Ryosuke Niwa < > rn...@webkit.org > > wrote: >>> On

Re: [webkit-dev] Clang tidy

2017-05-09 Thread Maciej Stachowiak
> On May 8, 2017, at 9:09 PM, Ryosuke Niwa <rn...@webkit.org> wrote: > > On Wed, May 3, 2017 at 8:31 PM, Maciej Stachowiak <m...@apple.com > <mailto:m...@apple.com>> wrote: > On May 3, > 2017, at 6:31 PM, Olmstead, Don < > don.olmst...@sony.co

Re: [webkit-dev] User agent woes

2017-05-08 Thread Maciej Stachowiak
> On May 8, 2017, at 1:30 PM, Michael Catanzaro <mcatanz...@igalia.com> wrote: > > On Mon, May 8, 2017 at 3:13 PM, Maciej Stachowiak <m...@apple.com> wrote: >> The ideal scenario would be for Google Hangouts to correctly handle WebKit >> UA strings on X1

Re: [webkit-dev] User agent woes

2017-05-08 Thread Maciej Stachowiak
> On May 7, 2017, at 8:11 PM, Michael Catanzaro wrote: > > Hi Maciej, > > I agree with basically everything you wrote, except I recommend not using OS > X as the operating system string in the default user agent except when > actually running on macOS. We tried this

Re: [webkit-dev] User agent woes

2017-05-07 Thread Maciej Stachowiak
> On May 6, 2017, at 5:19 PM, Michael Catanzaro wrote: > > Hi, > > You're probably aware that WebKitGTK+ has user agent quirks to make various > popular websites work, most notably google.com. For our list of quirks, see: > >

Re: [webkit-dev] Clang tidy

2017-05-03 Thread Maciej Stachowiak
> On May 3, 2017, at 6:31 PM, Olmstead, Don wrote: > > I took some time today to see how clang-tidy can be run on WebKit code and > openedhttps://bugs.webkit.org/show_bug.cgi?id=171632 > with some examples on how to >

Re: [webkit-dev] Heads up: ICU source compatibility breakage in 59.1 release

2017-05-02 Thread Maciej Stachowiak
I agree, better to add private cast macros (which are no-ops on the appropriate version of ICU) to convert incoming/outgoing public API types, and leave the actual public API types alone. > On May 2, 2017, at 10:40 AM, Myles C. Maxfield wrote: > > The fact that we use

Re: [webkit-dev] PAL Strategy

2017-05-01 Thread Maciej Stachowiak
> On May 1, 2017, at 1:48 PM, Brady Eidson wrote: > > >> On May 1, 2017, at 12:41 PM, Michael Catanzaro wrote: >> >> I thought the original intent for PAL was to replace WebCore/platform, so I >> assume the criterion would be "stuff currently in

Re: [webkit-dev] !!Tests for equality comparison

2017-04-28 Thread Maciej Stachowiak
Sent from my iPhone > On Apr 28, 2017, at 1:00 PM, JF Bastien <jfbast...@apple.com> wrote: > > >> On Apr 28, 2017, at 12:12, Maciej Stachowiak <m...@apple.com> wrote: >> >> >> Here's some comments in the other direction: >> >&g

Re: [webkit-dev] !!Tests for equality comparison

2017-04-28 Thread Maciej Stachowiak
I think allowing both forms is worse than mandating one form. It's true that in different situations one or the other may read better, but it's distracting to have differences that are matters of author taste rather than conveying meaningful information. "This is a numeric check, not a boolean

Re: [webkit-dev] !!Tests for equality comparison

2017-04-28 Thread Maciej Stachowiak
Here's some comments in the other direction: - If there are times we recommend x != 0 instead of !x, it should maybe be based on whether the condition is better expressed as "not zero" or "false". In the numTestsForEqualityComparison, that's clearly a "not zero" check given the naming of the

Re: [webkit-dev] Compile time increase over time

2017-04-24 Thread Maciej Stachowiak
For the macOS and iOS ports, we have the additional problem of overhead from the build system. Our make+xcodebuild based system takes a surprisingly long time even for a no-op build, or for a small incremental "just changed this one implementation file" build. There's also some indication

Re: [webkit-dev] Proposal: upstream the WPE port

2017-04-22 Thread Maciej Stachowiak
The GTK+ port has been a good WebKit citizen. And Igalia has a strong track record of WebKit contributions. So I am generally supportive of upstreaming the WPE port, as I expect it to be a net positive for the project. I can see we will need to work out issues around the API that is exposed.

Re: [webkit-dev] Proposal to limit the size of the captured exception stack

2017-03-17 Thread Maciej Stachowiak
> On Mar 17, 2017, at 11:09 AM, Mark Lam wrote: > > Thanks for the reminder to back observations up with data. I was previously > running some tests that throws StackOverflowErrors a lot (which tainted my > perspective), and I made a hasty conclusion which isn’t good.

Re: [webkit-dev] Port For Android

2017-03-07 Thread Maciej Stachowiak
Android is not a supported platforms for current WebKit and has not been in a while. You will not be able to build for Android without a major porting effort. Android WebKit was originally a fork of an old version that may not have even been fully merged back before we purged it. Recent

Re: [webkit-dev] VM::setExclusiveThread()

2017-02-28 Thread Maciej Stachowiak
Good news that it doesn't affect Speedometer. Does this have any effect on pure JS benchmarks running in the browser (e.g. JetStream)? - Maciej > On Feb 28, 2017, at 10:48 AM, Filip Pizlo wrote: > > Sounds good! > > I agree that a 20% regression on a microbenchmark of the

Re: [webkit-dev] Upstreaming Tests from WebKit to Web Platform Tests

2017-02-07 Thread Maciej Stachowiak
> On Feb 6, 2017, at 5:15 PM, Alexey Proskuryakov wrote: > > >> 6 февр. 2017 г., в 12:28, Ryosuke Niwa > > написал(а): >> >> The concern I've heard about is not how run-webkit-tests run the tests. It's >> about how a test is

Re: [webkit-dev] WebCore/platform standalone library

2017-01-14 Thread Maciej Stachowiak
> On Jan 14, 2017, at 12:39 PM, Myles C. Maxfield wrote: > > Here’s a quick rundown of where we stand. Please correct me if any of this is > inaccurate. > > There are a few separate issues: > Path on disk of PAL folder: Sounds like everyone more-or-less agrees that >

Re: [webkit-dev] WebCore/platform standalone library

2017-01-11 Thread Maciej Stachowiak
; something we’re hoping will be beneficial to all the ports. > > From: webkit-dev-boun...@lists.webkit.org > [mailto:webkit-dev-boun...@lists.webkit.org] On Behalf Of Maciej Stachowiak > Sent: Wednesday, January 11, 2017 2:05 PM > To: Antti Koivisto <koivi...@iki.fi> >

Re: [webkit-dev] WebCore/platform standalone library

2017-01-11 Thread Maciej Stachowiak
ood > candidate because it’s small, simple, yet also has platform-dependent > implementations. > > We would love your feedback on this approach to help make the dream a reality! > > Thanks, > Myles and Don > >> On Mar 22, 2015, at 4:40 PM, Gavin Barraclough <b

Re: [webkit-dev] Thread naming policy in WebKit

2017-01-05 Thread Maciej Stachowiak
> On Jan 5, 2017, at 8:07 PM, Yusuke SUZUKI <utatane@gmail.com> wrote: > > On Fri, Jan 6, 2017 at 10:37 AM, Maciej Stachowiak <m...@apple.com > <mailto:m...@apple.com>> wrote: > >> On Jan 5, 2017, at 9:37 AM, Brady Eidson <beid...@apple

Re: [webkit-dev] Thread naming policy in WebKit

2017-01-05 Thread Maciej Stachowiak
> On Jan 5, 2017, at 9:37 AM, Brady Eidson wrote: > > >> On Jan 5, 2017, at 12:48 AM, Yusuke SUZUKI > > wrote: >> >> On Thu, Jan 5, 2017 at 5:43 PM, Darin Adler > > wrote: >> I

Re: [webkit-dev] Naming preference: SetForScope vs. TemporaryChange

2016-12-27 Thread Maciej Stachowiak
> On Dec 26, 2016, at 9:04 AM, Saam Barati wrote: > > Right. I see what you're saying. The name doesn't confuse me with respect to > these semantics but I see that's it's subtly wrong. > > The use case I was thinking of is this: > ` > class Foo { >Foo() :

Re: [webkit-dev] Naming preference: SetForScope vs. TemporaryChange

2016-12-25 Thread Maciej Stachowiak
gnments in the scope of one of these things so it will be clear enough as actually used. Regards, Maciej > > - Saam > >> On Dec 23, 2016, at 6:50 AM, Maciej Stachowiak <m...@apple.com> wrote: >> >> >> A few more coats of paint for the bike shed: >>

Re: [webkit-dev] Naming preference: SetForScope vs. TemporaryChange

2016-12-23 Thread Maciej Stachowiak
A few more coats of paint for the bike shed: It's a little unusual to have a class name that's a verb phrase instead of a noun phrase. And in this case if you interpret "Set" as a noun you'll get entirely the wrong idea. Some alternatives that avoid this, but has the better clarity of "Scope"

[webkit-dev] Please hold off on commits

2016-11-05 Thread Maciej Stachowiak
Hello everyone, At Apple, we are experiencing an unplanned outage in our continuous integration lab. This interferes with proper functioning buildbots, performance tests and EWS. Currently we expect the outage will last throughout the weekend and possibly into early next week. Last time we

Re: [webkit-dev] Terminology for giving up ownership: take, release, move

2016-09-07 Thread Maciej Stachowiak
> On Sep 6, 2016, at 8:20 PM, Darin Adler <da...@apple.com> wrote: > >> On Sep 6, 2016, at 6:43 PM, Maciej Stachowiak <m...@apple.com> wrote: >> >> RefPtr does also have regular release() though. I'm not sure if this is for >> a practical reason or jus

Re: [webkit-dev] Terminology for giving up ownership: take, release, move

2016-09-06 Thread Maciej Stachowiak
> On Sep 6, 2016, at 5:27 PM, Darin Adler <da...@apple.com> wrote: > >> On Sep 6, 2016, at 4:48 PM, Maciej Stachowiak <m...@apple.com> wrote: >> >> STL smart pointers have a 0-argument reset for non-returning remove instead, >> and co

Re: [webkit-dev] Terminology for giving up ownership: take, release, move

2016-09-06 Thread Maciej Stachowiak
I thought about why release() seems subtly wrong to me for collections, but not for smart pointers. Specifically, release() puts the focus on giving up ownership, but the in the case of a collection, the most important thing is removal from the collection, where giving up ownership is a detail

Re: [webkit-dev] Terminology for giving up ownership: take, release, move

2016-09-05 Thread Maciej Stachowiak
> On Sep 5, 2016, at 3:30 PM, Dan Bernstein wrote: > >> >> On Sep 5, 2016, at 10:13 AM, Darin Adler wrote: >> >> Hi folks. >> >> WebKit has some critical functions that involve asking an object to give up >> ownership of something so the caller can take

Re: [webkit-dev] Terminology for giving up ownership: take, release, move

2016-09-05 Thread Maciej Stachowiak
> On Sep 5, 2016, at 3:18 PM, Ryosuke Niwa wrote: > > On Mon, Sep 5, 2016 at 2:48 PM, Ryosuke Niwa > wrote: >> On Mon, Sep 5, 2016 at 2:47 PM, Filip Pizlo wrote: >>> >>> On Sep 5, 2016, at 2:35 PM, Ryosuke Niwa

Re: [webkit-dev] Terminology for giving up ownership: take, release, move

2016-09-05 Thread Maciej Stachowiak
> On Sep 5, 2016, at 2:35 PM, Ryosuke Niwa wrote: > > On Mon, Sep 5, 2016 at 10:13 AM, Darin Adler > wrote: >> Hi folks. >> >> WebKit has some critical functions that involve asking an object to give up >> ownership of something so

Re: [webkit-dev] Terminology for giving up ownership: take, release, move

2016-09-05 Thread Maciej Stachowiak
> On Sep 5, 2016, at 10:13 AM, Darin Adler wrote: > > Hi folks. > > WebKit has some critical functions that involve asking an object to give up > ownership of something so the caller can take ownership. > > In the C++ standard library itself, this is called move, as in

Re: [webkit-dev] Using ResourceTiming API for testing

2016-04-25 Thread Maciej Stachowiak
> On Apr 24, 2016, at 8:54 AM, Yoav Weiss wrote: > > Hey, > > As part of implementing support for `` more tests are > needed to make sure resources are properly reused. The easiest way to test > that is using the ResourceTiming API, which is currently implemented behind > an

Re: [webkit-dev] Suggestion: runtime disable Fetch API until it's complete enough for real web-apps

2016-03-31 Thread Maciej Stachowiak
> On Mar 31, 2016, at 11:14 AM, youenn fablet wrote: > > Hi, > > I like the idea of a runtime flag. > I would wait to enable fetch use until it passes sufficient numbers of > web-platform-test tests. > This can be tested in http://w3c-test.org/tools/runner/index.html >

[webkit-dev] Suggestion: runtime disable Fetch API until it's complete enough for real web-apps

2016-03-31 Thread Maciej Stachowiak
The recently released Safari Technology Preview has gotten more people living on builds close to trunk, which is cool. Some people pointing out that the current state of Fetch API causes problems - it's not quite complete enough for real web apps that want to use it, but its presence breaks

Re: [webkit-dev] mobile Safari WebGL crash

2015-12-27 Thread Maciej Stachowiak
This doesn't sound like correct or expected behavior to me. Can you please file a bug at http://bugs.webkit.org/ with steps to reproduce? - Maciej > On Dec 23, 2015, at 7:58 AM, Roman Sementsov wrote: > > Hello, > I'm Blend4Web developer and currently trying to

Re: [webkit-dev] Proposal for serializing alpha channel values; request for algorithm help

2015-11-03 Thread Maciej Stachowiak
Minimal strings should round trip ok, but will it still be accurate enough if the client attempts to do math with them? It's at least theoretically possible someone may try to multiply by the alpha value. - Maciej > On Nov 2, 2015, at 12:28 AM, Gavin Barraclough

Re: [webkit-dev] PSA: you should use WTF::Lock and WTF::Condition instead of WTF::SpinLock, WTF::Mutex, WTF::ThreadCondition, std::mutex, std::condition_variable, or std::condition_variable_any

2015-08-21 Thread Maciej Stachowiak
On Aug 21, 2015, at 12:11 PM, Michael Catanzaro mcatanz...@igalia.com wrote: On Wed, 2015-08-19 at 13:08 -0700, Filip Pizlo wrote: TL;DR. Don’t use WTF::SpinLock, WTF::Mutex, std::mutex, WTF::ThreadCondition, std::condition_variable, or std::condition_variable_any. They waste CPU time

Re: [webkit-dev] JSC framework API proposal: setting a handler for enqueuing tasks

2015-07-07 Thread Maciej Stachowiak
the client app to know the VM nesting level. It would be better if that was tracked and micro tasks could run on exiting the outermost VM and/or (2) would become the original proposal. On Jul 6, 2015, at 4:44 PM, Maciej Stachowiak m...@apple.com mailto:m...@apple.com wrote: Should JS

Re: [webkit-dev] JSC framework API proposal: setting a handler for enqueuing tasks

2015-07-06 Thread Maciej Stachowiak
Should JS be defining an event loop abstraction that WebCore then uses? That would be weird, because the required behavior of the even loop in web content is chock full of issues that are not at all related to JavaScript. JSC doesn't even know enough to run microtasks at all the right times

Re: [webkit-dev] Support registerProtocolHandler in WebKit2

2015-05-21 Thread Maciej Stachowiak
On May 21, 2015, at 7:38 PM, Anne van Kesteren ann...@annevk.nl wrote: On Fri, May 22, 2015 at 1:25 AM, Anders Carlsson ander...@apple.com wrote: Sam Weinig 2015-05-15 10:12:54 PDT: Support for navigator.registerProtocolHandler/unregisterProtocolHandler is not something we want to support

Re: [webkit-dev] Force Click events

2015-05-08 Thread Maciej Stachowiak
Beth gave a bunch of details of the feature, but I would like to expand a bit on our standards plans, and cross-platform potential of this feature: (1) We definitely plan to take this proposal to standards bodies. We decided to implement a prototype first, so we could ensure we have something

Re: [webkit-dev] Force Click events

2015-05-08 Thread Maciej Stachowiak
Beth gave a bunch of details of the feature, but I would like to expand a bit on our standards plans, and cross-platform potential of this feature: (1) We definitely plan to take this proposal to standards On May 8, 2015, at 3:25 AM, Jonathan Rimmer jon.rim...@gmail.com wrote: [I

Re: [webkit-dev] Client Hints

2015-05-06 Thread Maciej Stachowiak
On May 6, 2015, at 4:49 AM, Yoav Weiss y...@yoav.ws wrote: On Wed, May 6, 2015 at 8:41 AM, Ryosuke Niwa rn...@webkit.org mailto:rn...@webkit.org wrote: On Tue, May 5, 2015 at 11:35 PM, Yoav Weiss y...@yoav.ws mailto:y...@yoav.ws wrote: On Wed, May 6, 2015 at 8:14 AM, Ryosuke Niwa

<    1   2   3   4   5   6   7   8   9   10   >