Re: [webkit-dev] Commissioning an enhancement to QtWebkit

2009-09-17 Thread Maciej Stachowiak
The proper place for work proposals like this would be the webkit-j...@lists.webkit.org list. - Maciej On Sep 17, 2009, at 9:24 AM, Garth Dahlstrom wrote: Hi Everyone, I'm interested in commissioning an enhancement to QtWebkit port, the work would be donated to the webkit project

Re: [webkit-dev] Limiting slow unload handlers (Re: Back/forward cache for pages with unload handlers)

2009-09-17 Thread Maciej Stachowiak
On Sep 17, 2009, at 12:14 PM, Darin Fisher wrote: On Thu, Sep 17, 2009 at 2:28 AM, Maciej Stachowiak m...@apple.com wrote: On Sep 17, 2009, at 12:35 AM, Darin Fisher wrote: For a ping to be used as I suggested, you would need to set the href to a javascript URL

Re: [webkit-dev] Limiting slow unload handlers (Re: Back/forward cache for pages with unload handlers)

2009-09-17 Thread Maciej Stachowiak
On Sep 17, 2009, at 12:23 PM, Brady Eidson wrote: On Sep 17, 2009, at 2:28 AM, Maciej Stachowiak wrote: Here's what would need to happen to let loads from unload run to completion: 1) Implement a way to track all entities that start loads during unload (all owners of ResourceHandles

Re: [webkit-dev] Limiting slow unload handlers (Re: Back/forward cache for pages with unload handlers)

2009-09-17 Thread Maciej Stachowiak
On Sep 17, 2009, at 1:14 PM, Brady Eidson wrote: On Sep 17, 2009, at 12:54 PM, Maciej Stachowiak wrote: On Sep 17, 2009, at 12:23 PM, Brady Eidson wrote: On Sep 17, 2009, at 2:28 AM, Maciej Stachowiak wrote: Here's what would need to happen to let loads from unload run to completion

Re: [webkit-dev] Limiting slow unload handlers (Re: Back/forward cache for pages with unload handlers)

2009-09-17 Thread Maciej Stachowiak
On Sep 17, 2009, at 2:09 PM, Darin Fisher wrote: On Thu, Sep 17, 2009 at 12:52 PM, Maciej Stachowiak m...@apple.com wrote: On Sep 17, 2009, at 12:14 PM, Darin Fisher wrote: On Thu, Sep 17, 2009 at 2:28 AM, Maciej Stachowiak m...@apple.com wrote: On Sep 17, 2009, at 12:35 AM

Re: [webkit-dev] Limiting slow unload handlers (Re: Back/forward cache for pages with unload handlers)

2009-09-17 Thread Maciej Stachowiak
On Sep 17, 2009, at 2:16 PM, John Abd-El-Malek wrote: I think the image trick is more attractive than a ping because it's easier for web developers to use. But I'm not convinced it's the cleanest method we can come up with. If we are expecting web developers to change, then I'd

Re: [webkit-dev] Limiting slow unload handlers (Re: Back/forward cache for pages with unload handlers)

2009-09-17 Thread Maciej Stachowiak
On Sep 17, 2009, at 3:35 PM, Brady Eidson wrote: On Sep 17, 2009, at 2:17 PM, Ojan Vafai wrote: On Thu, Sep 17, 2009 at 2:11 PM, John Abd-El-Malek j...@google.com wrote: On Thu, Sep 17, 2009 at 2:09 PM, Darin Fisher da...@chromium.org wrote: On Thu, Sep 17, 2009 at 12:52 PM, Maciej

Re: [webkit-dev] Runtime setting for incomplete features

2009-09-21 Thread Maciej Stachowiak
On Sep 18, 2009, at 1:30 PM, Jeremy Orlow wrote: On Fri, Sep 18, 2009 at 12:59 PM, Alexey Proskuryakov a...@webkit.org wrote: 18.09.2009, в 12:24, Jeremy Orlow написал(а): I'm not sure if we've hit any compatibility issues with this yet, but it seems quite plausible that someone would

Re: [webkit-dev] Runtime setting for incomplete features

2009-09-23 Thread Maciej Stachowiak
On Sep 23, 2009, at 5:24 PM, Drew Wilson wrote: Following up on this, because I missed Maciej's response. On Mon, Sep 21, 2009 at 1:22 PM, Maciej Stachowiak m...@apple.com wrote: Fair enough. But I would be against user-level preferences that add or remove entire APIs. Rather

Re: [webkit-dev] Skipping Flakey Tests

2009-09-28 Thread Maciej Stachowiak
On Sep 28, 2009, at 4:40 PM, Eric Seidel wrote: On Fri, Sep 25, 2009 at 2:42 PM, Maciej Stachowiak m...@apple.com wrote: I like Dave Levin's idea that the first action should be to instrument the tests so we can find out why they intermittently fail. Especially if the failure

Re: [webkit-dev] Skipping Flakey Tests

2009-09-28 Thread Maciej Stachowiak
, 2009 at 2:42 PM, Maciej Stachowiak m...@apple.com wrote: I like Dave Levin's idea that the first action should be to instrument the tests so we can find out why they intermittently fail. Especially if the failure is reproducible on the bots but not on developer systems. I like this idea

Re: [webkit-dev] Review Flag Requestee field

2009-10-05 Thread Maciej Stachowiak
On Oct 5, 2009, at 12:23 PM, Eric Seidel wrote: It seems that the requestee field is a source of confusion for new contributers. Especially so when the new contributor comes from another project where the requestee field may be required (Google, and mozilla I'm told). I would like us

Re: [webkit-dev] MathML Project - Interested?

2009-10-05 Thread Maciej Stachowiak
On Oct 5, 2009, at 1:04 PM, Alex Milowski wrote: I'd like to work on this MathML project in conjunction with those of you who might be interested in using it in the near future. I'd also welcome any help. If you are interested, even as an observer, let me know. I'm very interested in

Re: [webkit-dev] Runtime setting for incomplete features

2009-10-05 Thread Maciej Stachowiak
On Oct 5, 2009, at 6:20 PM, Sam Weinig wrote: On Mon, Oct 5, 2009 at 5:46 PM, Drew Wilson atwil...@google.com wrote: I'm surprised to see these objections coming up now, weeks after the original discussion, and only after my patch has landed in the tree. Sorry, I seemed to have

Re: [webkit-dev] Runtime setting for incomplete features

2009-10-05 Thread Maciej Stachowiak
On Oct 5, 2009, at 9:54 PM, Mark Rowe wrote: On 2009-10-05, at 21:48, Darin Fisher wrote: It is a matter of our process that we do not change the configuration when promoting builds. The bits that passed the test get promoted. I'm happy to absorb this cost in the V8 bindings. I don't

Re: [webkit-dev] Runtime setting for incomplete features

2009-10-06 Thread Maciej Stachowiak
concerned, that's ok for testing, even though we would not want to ship that way. If the state is so bad that we don't even want people testing, then the feature should be compiled out entirely. In my opinion, anyway. - Maciej -- ukai On Tue, Oct 6, 2009 at 2:04 PM, Maciej Stachowiak m

Re: [webkit-dev] Guided bug reporting on bugs.webkit.org

2009-10-08 Thread Maciej Stachowiak
On Oct 8, 2009, at 12:37 AM, Simon Hausmann wrote: On Tuesday 06 October 2009 Vestbo Tor.Arne (Nokia-D-Qt/Oslo), wrote: [...] I guess the usefulness of something like this deepens on how we view the WebKit bugzilla. Is it for developers only? For users of WebKit API (C,ObjC,GTK,Qt). For

Re: [webkit-dev] propose an API to return Range in textarea etc. form control nodes (similar functionality as document.caretRangeFromPoint)

2009-10-12 Thread Maciej Stachowiak
On Oct 12, 2009, at 1:08 AM, Anne van Kesteren wrote: On Fri, 09 Oct 2009 19:04:52 +0200, Xiaomei Ji x...@chromium.org wrote: Maybe I should propose Document.wordFromPoint() which directly returns the word under the mouse (and handles both the DOM node and non-DOM form control nodes).

Re: [webkit-dev] propose an API to return Range in textarea etc. form control nodes (similar functionality as document.caretRangeFromPoint)

2009-10-12 Thread Maciej Stachowiak
On Oct 12, 2009, at 9:37 AM, Xiaomei Ji wrote: For a use case that pinpoint a word from a page, the context information needed besides word might be the language that the word is in. And yes, as you said, if the hit node is needed, elementFromPoint should do. Hit testing isn't cheap -

Re: [webkit-dev] Limiting slow unload handlers (Re: Back/forward cache for pages with unload handlers)

2009-10-14 Thread Maciej Stachowiak
On Oct 14, 2009, at 6:43 PM, John Abd-El-Malek wrote: To resurrect this thread. I'm looking in implementing some of the methods that we discussed so that web developers have no excuse in simulating sleeps in unload handlers. ... -Image trick (image loads started from unload handlers

Re: [webkit-dev] propose an API to return Range in textarea etc. form control nodes (similar functionality as document.caretRangeFromPoint)

2009-10-16 Thread Maciej Stachowiak
are concerned. These things are implementation details of WebKit. - Maciej Thanks, Xiaomei On Mon, Oct 12, 2009 at 1:50 PM, Maciej Stachowiak m...@apple.com wrote: On Oct 12, 2009, at 1:08 AM, Anne van Kesteren wrote: On Fri, 09 Oct 2009 19:04:52 +0200, Xiaomei Ji x...@chromium.org

Re: [webkit-dev] Selection highlight painting (gaps?)

2009-10-20 Thread Maciej Stachowiak
On Oct 19, 2009, at 2:03 PM, Peter Kasting wrote: On Mon, Oct 19, 2009 at 1:58 PM, Joe Mason j...@notcharles.ca wrote: Perhaps the browser should have Copy text and Copy all objects options (in which case either WebKit needs to support both modes, or the browser would need to filter the copied

Re: [webkit-dev] Test coverage for FrameLoader

2009-10-20 Thread Maciej Stachowiak
On Oct 20, 2009, at 12:50 PM, Adam Barth wrote: The usual WebKit policy is not to accept functional changes without regression tests. I'd like to ask that this policy be enforced strictly for FrameLoader. For example, I don't think we should be taking changes like this without tests:

Re: [webkit-dev] Selection highlight painting (gaps?)

2009-10-22 Thread Maciej Stachowiak
On Oct 22, 2009, at 2:38 PM, Evan Martin wrote: On Mon, Oct 19, 2009 at 1:22 PM, David Hyatt hy...@apple.com wrote: I've actually been super frustrated with WebKit's selection behavior for a long time, precisely because it tries to let you select everything. In Concrete examples of

Re: [webkit-dev] Javascript and WebCore

2009-10-25 Thread Maciej Stachowiak
On Oct 25, 2009, at 2:01 PM, Alexander Cohen wrote: In the events of a tag, i needed to add checks to see what type of script was being called. A lot if not all of the time, we will usually find a javascript: in the event code so i can also look there for my defined scripting language

Re: [webkit-dev] Javascript and WebCore

2009-10-25 Thread Maciej Stachowiak
On Oct 25, 2009, at 2:36 PM, Alexander Cohen wrote: On Oct 25, 2009, at 5:23 PM, Maciej Stachowiak wrote: On Oct 25, 2009, at 2:01 PM, Alexander Cohen wrote: In the events of a tag, i needed to add checks to see what type of script was being called. A lot if not all of the time, we

Re: [webkit-dev] getting contents of noscript element through DOM

2009-10-26 Thread Maciej Stachowiak
On Oct 26, 2009, at 12:40 AM, Darin Adler wrote: On Oct 12, 2009, at 9:30 AM, mab2001 wrote: It seems that with WebKit, the contents of the noscript tag cannot be accessed through the DOM. FF and IE (haven't tested other browsers) allow access through the textContent property but in

Re: [webkit-dev] Performance of NamedAttrMap

2009-10-29 Thread Maciej Stachowiak
On Oct 29, 2009, at 2:30 PM, Jens Alfke wrote: I was looking at the performance of Element.getAttribute(), and I see that NamedAttrMap, which actually stores the attributes, is implemented as an unsorted array. This makes looking up an attribute an O(n) operation. Is there any reason this

Re: [webkit-dev] Performance of NamedAttrMap

2009-10-29 Thread Maciej Stachowiak
On Oct 29, 2009, at 3:03 PM, David Hyatt wrote: The order of the properties in both style declarations and in attribute maps is relevant for serialization that conforms to the original declared source order. I think this is a standards compliance issue for style declarations (besides

Re: [webkit-dev] Why are PassRefPtrs used as function parameters?

2009-10-29 Thread Maciej Stachowiak
On Oct 29, 2009, at 12:56 PM, Darin Adler wrote: On Oct 27, 2009, at 10:55 AM, Jens Alfke wrote: Looking at how refcounting is implemented in WebCore, I was surprised to find that there are a lot of functions/methods that take PassRefPtrs as parameters instead of regular pointers to

Re: [webkit-dev] Staging WebSocket protocol deployment

2009-11-13 Thread Maciej Stachowiak
On Nov 13, 2009, at 4:06 PM, Adam Barth wrote: On Fri, Nov 13, 2009 at 3:58 PM, Jeremy Orlow jor...@chromium.org wrote: +1 for AP's plan. There's nothing magical about ws and wss. We can change those names later if we change the protocol (just as easily as we can change webkit-ws). My

Re: [webkit-dev] Staging WebSocket protocol deployment

2009-11-17 Thread Maciej Stachowiak
On Nov 15, 2009, at 5:18 PM, Yuzo Fujishima wrote: Hi, I'm against prefixing with webkit- because of the following reasons. Reason 1: It connotes that the feature is experimental. That means there will be less developers seriously use that feature. Without serious use, we'll have less

Re: [webkit-dev] Staging WebSocket protocol deployment

2009-11-17 Thread Maciej Stachowiak
On Nov 15, 2009, at 3:19 PM, Adam Barth wrote: On Fri, Nov 13, 2009 at 6:01 PM, Adam Barth aba...@webkit.org wrote: Does the IETF WG have a timeline? My understanding is that IETF WG take at least a year to do anything. Here's the timeline for the HyBi WG:

Re: [webkit-dev] Reducing layout test flakiness

2009-11-21 Thread Maciej Stachowiak
On Nov 20, 2009, at 2:49 PM, Julie Parent wrote: In Chromium-land, we have been working to eliminate flaky layout tests. One thing that has helped us gain insight into flaky tests is the flakiness dashboard. I'd love to see this available for webkit.org as well. I'm happy to do the

Re: [webkit-dev] innerStaticHTML

2009-11-24 Thread Maciej Stachowiak
On Nov 24, 2009, at 7:14 PM, Adam Barth wrote: In the below message to the WHATWG, Ian suggests that vendors experiment with an API that makes it easier for web developers to programmatically add static HTML content to their pages without XSSing themselves:

Re: [webkit-dev] innerStaticHTML

2009-11-24 Thread Maciej Stachowiak
On Nov 24, 2009, at 10:37 PM, Adam Barth wrote: On Tue, Nov 24, 2009 at 8:39 PM, Maciej Stachowiak m...@apple.com wrote: On Nov 24, 2009, at 7:14 PM, Adam Barth wrote: In the below message to the WHATWG, Ian suggests that vendors experiment with an API that makes it easier for web

Re: [webkit-dev] innerStaticHTML

2009-11-25 Thread Maciej Stachowiak
On Nov 25, 2009, at 6:05 AM, Adam Barth wrote: On Tue, Nov 24, 2009 at 11:21 PM, Maciej Stachowiak m...@apple.com wrote: If we tie it to an element or attribute, people may be tempted to just do it in markup, which would be insecure. Maybe we should have a DOM API called

Re: [webkit-dev] innerStaticHTML

2009-11-25 Thread Maciej Stachowiak
On Nov 25, 2009, at 12:34 PM, Adam Barth wrote: On Wed, Nov 25, 2009 at 12:30 PM, Maciej Stachowiak m...@apple.com wrote: On Nov 25, 2009, at 6:05 AM, Adam Barth wrote: Maybe we should have a DOM API called webkitJailChildren(no-script-for-you) on Node that prevents future children from

Re: [webkit-dev] innerStaticHTML

2009-11-25 Thread Maciej Stachowiak
On Nov 25, 2009, at 1:33 PM, Adam Barth wrote: On Wed, Nov 25, 2009 at 1:25 PM, Maciej Stachowiak m...@apple.com wrote: On Nov 25, 2009, at 12:34 PM, Adam Barth wrote: On Wed, Nov 25, 2009 at 12:30 PM, Maciej Stachowiak m...@apple.com wrote: On Nov 25, 2009, at 6:05 AM, Adam Barth wrote

Re: [webkit-dev] innerStaticHTML

2009-11-25 Thread Maciej Stachowiak
On Nov 25, 2009, at 1:45 PM, Michal Zalewski wrote: The other way to skin this cat, by the way, is to implement the seamless attribute on iframes. That gives you a similar sort of design using the @sandbox attribute and solves many of your above concerns, e.g. by creating a new namespace for

Re: [webkit-dev] style-queue entering beta

2009-11-28 Thread Maciej Stachowiak
Sounds like a good idea in general. Some comments below: On Nov 28, 2009, at 2:21 AM, Adam Barth wrote: One of the bots that Eric and I have been working on is about to come online. This bot is a style bot that runs check-webkit-style on patches that have been nominated for review. I'd like

Re: [webkit-dev] style-queue entering beta

2009-11-28 Thread Maciej Stachowiak
On Nov 28, 2009, at 10:53 AM, Adam Barth wrote: On Sat, Nov 28, 2009 at 10:21 AM, Maciej Stachowiak m...@apple.com wrote: On Nov 28, 2009, at 2:21 AM, Adam Barth wrote: 1) Adding an extra flags is going to cause confusion. The style-queue does not add any flags to Bugzilla. Instead

Re: [webkit-dev] GlobalScript in WebKit

2009-11-30 Thread Maciej Stachowiak
I'm somewhat concerned about GlobalScript too. I am pretty wary of putting complex features in WebKit if it seems like they will be rejected by the standards process and become orphan WebKit-only technologies. Perhaps I am somewhat sensitive about this because it looks like the SQL

Re: [webkit-dev] GlobalScript in WebKit

2009-11-30 Thread Maciej Stachowiak
On Nov 30, 2009, at 9:55 AM, Dimitri Glazkov wrote: Reading this, I am reminded of a great commentary by Alex Russell, written nearly 3 years ago: http://alex.dojotoolkit.org/2007/12/the-w3c-cannot-save-us/ Despite of what I may think about SharedScript, I am certain that waiting -- whether

Re: [webkit-dev] GlobalScript in WebKit

2009-11-30 Thread Maciej Stachowiak
On Nov 30, 2009, at 1:51 PM, David Hyatt wrote: On Nov 30, 2009, at 3:33 PM, Maciej Stachowiak wrote: Based on this, I agree with Sam's opinion that we should wait and see how workers (and in particular SharedWorker) play out before we take up this feature. Regards, Maciej While I

Re: [webkit-dev] GlobalScript in WebKit

2009-11-30 Thread Maciej Stachowiak
On Nov 30, 2009, at 1:58 PM, David Hyatt wrote: On Nov 30, 2009, at 3:45 PM, Maciej Stachowiak wrote: WebKit (or at least the mainline) is not necessarily a great place for experiments. As our Project Goals say: WebKit is an engineering project, not a science project. http://webkit.org

Re: [webkit-dev] GlobalScript in WebKit

2009-11-30 Thread Maciej Stachowiak
On Nov 30, 2009, at 4:35 PM, Jeremy Orlow wrote: To be fair, app developers in general want to do everything synchronously but we (in standards land) have pushed back very hard because software research has shown that such interfaces are very difficult (if not impossible) to

Re: [webkit-dev] GlobalScript in WebKit

2009-11-30 Thread Maciej Stachowiak
On Nov 30, 2009, at 5:09 PM, Maciej Stachowiak wrote: On Nov 30, 2009, at 4:35 PM, Jeremy Orlow wrote: To be fair, app developers in general want to do everything synchronously but we (in standards land) have pushed back very hard because software research has shown

Re: [webkit-dev] GlobalScript in WebKit

2009-11-30 Thread Maciej Stachowiak
On Nov 30, 2009, at 5:37 PM, Dmitry Titov wrote: On Mon, Nov 30, 2009 at 5:21 PM, Maciej Stachowiak m...@apple.com wrote: By the way, we could enable the SharedScript programming model at much lower WebKit-level implementation cost and with much less API surface as follows: - Allow

Re: [webkit-dev] GlobalScript in WebKit

2009-11-30 Thread Maciej Stachowiak
On Nov 30, 2009, at 3:43 PM, Dmitry Titov wrote: I don't think it's correct to say that SharedWorkers are not useful and we need a SharedScript instead. They are different things and can address different use cases. For example, SharedWorker is great to make sure there is only one 'app

Re: [webkit-dev] GlobalScript in WebKit

2009-11-30 Thread Maciej Stachowiak
for both. -atw On Mon, Nov 30, 2009 at 6:08 PM, Maciej Stachowiak m...@apple.com wrote: On Nov 30, 2009, at 3:43 PM, Dmitry Titov wrote: I don't think it's correct to say that SharedWorkers are not useful and we need a SharedScript instead. They are different things and can address

Re: [webkit-dev] GlobalScript in WebKit

2009-11-30 Thread Maciej Stachowiak
the Gears flavor of shared workers and is planning to migrate to the HTML5 version once DB access is supported from within worker context in shipping browsers. So I guess that Gmail would be a candidate app that has asked for both. -atw On Mon, Nov 30, 2009 at 6:08 PM, Maciej Stachowiak m

Re: [webkit-dev] Adding read-only javascript properties via JavaScriptCore

2009-12-01 Thread Maciej Stachowiak
On Dec 1, 2009, at 2:01 PM, Ryan Grimm wrote: Hi Geoff, So I take it that I'm understanding the API correctly? I'm currently using the WebKit framework bundled with the latest version of Safari. Should I go ahead and file a bug report? Please do. Your understanding is correct, what

Re: [webkit-dev] Style guidelines, not hard rules

2009-12-01 Thread Maciej Stachowiak
On Dec 1, 2009, at 9:43 PM, Peter Kasting wrote: I'd like formal clarification about how we enforce our style guide. On https://bugs.webkit.org/show_bug.cgi?id=31806#c5 , Yong Li was notified that one of his patches violates a WebKit style rule (no {} on one-line conditional bodies). He

Re: [webkit-dev] localStorage quota limit

2009-12-02 Thread Maciej Stachowiak
On Dec 2, 2009, at 12:06 PM, Michael Nordman wrote: Arguably, seems like a bug that invalid string values are let thru the door to start with? ECMAScript Strings are essentially sequences of arbitrary 16-bit values. Sometimes Web apps take advantage of this to use a String as a hacky

Re: [webkit-dev] localStorage quota limit

2009-12-02 Thread Maciej Stachowiak
On Dec 2, 2009, at 8:14 PM, Darin Fisher wrote: What about Maciej's comment. JS strings are often use to store binary values. Obviously, if people stick to octets, then it should be fine, but perhaps some folks leverage all 16 bits? I think some people do use JavaScript strings this

Re: [webkit-dev] localStorage quota limit

2009-12-02 Thread Maciej Stachowiak
On Dec 2, 2009, at 9:07 PM, Darin Fisher wrote: On Wed, Dec 2, 2009 at 8:44 PM, Maciej Stachowiak m...@apple.com wrote: On Dec 2, 2009, at 8:14 PM, Darin Fisher wrote: What about Maciej's comment. JS strings are often use to store binary values. Obviously, if people stick to octets

Re: [webkit-dev] localStorage quota limit

2009-12-02 Thread Maciej Stachowiak
On Dec 2, 2009, at 10:51 PM, Darin Fisher wrote: Agreed. I was responding to your statement: It's not clear to me why Firefox or IE choose to reject instead of doing this. It seems likely to me that neither Firefox nor IE made a concerted choice to treat bad UTF-16 this way. It is

Re: [webkit-dev] Towards a More Convenient IWebUIDelegate

2009-12-02 Thread Maciej Stachowiak
On Dec 2, 2009, at 10:47 PM, Steve Falkenburg wrote: On Dec 2, 2009, at 9:53 PM, Brent Fulgham wrote: To add insult to injury, all of these interface classes also require each concrete implementation to implement a stub QueryInterface, AddRef, and RemoveRef method. Yes, this is one of

Re: [webkit-dev] Proposing style guide change regarding braces on conditional arms

2009-12-02 Thread Maciej Stachowiak
I used to dislike everything about this rule; my original preference before we codified our style guidelines was to always put braces around the body of a control statement, even if it is only one line. Over time, I've gotten used to it and I find this: if (condA) doA(); more

Re: [webkit-dev] improving String::append()

2009-12-03 Thread Maciej Stachowiak
On Dec 3, 2009, at 8:32 AM, Zoltan Herczeg wrote: Hi, according to my measurements, a large chunk of WebKit memory consumption comes from WebCore::TextResourceDecoder::decode (loader/TextResourceDecoder.cpp:818) which calls String::append (String.cpp:82). The comment there says: //

Re: [webkit-dev] Proposing style guide change regarding braces on conditional arms

2009-12-03 Thread Maciej Stachowiak
On Dec 3, 2009, at 5:48 PM, Michael Nordman wrote: what peter pitched and what mjs pitched are one and the same i think * When all arms of a conditional or loop are one physical line, do not use braces. If any arms are more than one physical line (even if they are one logical line), use

Re: [webkit-dev] TARGET_OS_EMBEDDED

2009-12-04 Thread Maciej Stachowiak
On Dec 4, 2009, at 5:51 AM, Zoltan Herczeg wrote: Hi, it would be a great to have a macro in WebKit, which would be enabled on embedded systems. We could replace macros like PLATFORM(SYMBIAN) in TextCodecQt.cpp to this new macro. However, TARGET_OS_EMBEDDED macro enables

Re: [webkit-dev] SVG Filters

2009-12-04 Thread Maciej Stachowiak
On Dec 4, 2009, at 11:02 AM, Dirk Schulze wrote: What kinds of tests do we have for the code already? Do we have code that tries to exercise edge cases? Do we have a fuzzer of some sort? -- Darin Every effect that was implemented has at least one test. They are mostly simple test

Re: [webkit-dev] Issues with WebWorkers that may block Safari support

2009-12-04 Thread Maciej Stachowiak
On Dec 4, 2009, at 1:40 PM, Drew Wilson wrote: Hi all, There have been various side discussions regarding the stability/ viability of Workers and SharedWorkers, and I wanted to make sure we understand all of the concerns, since as far as I know there isn't any one person who has been

Re: [webkit-dev] Issues with WebWorkers that may block Safari support

2009-12-04 Thread Maciej Stachowiak
On Dec 4, 2009, at 2:09 PM, Drew Wilson wrote: On Fri, Dec 4, 2009 at 2:00 PM, Maciej Stachowiak m...@apple.com wrote: On Dec 4, 2009, at 1:40 PM, Drew Wilson wrote: Hi all, There have been various side discussions regarding the stability/ viability of Workers and SharedWorkers

Re: [webkit-dev] More on test flakiness

2009-12-04 Thread Maciej Stachowiak
On Dec 2, 2009, at 2:43 PM, Julie Parent wrote: In a recent code review where I was minimizing some test flakiness, Darin said: I wish there was a way to isolate timing-dependent tests separately from the vast majority of tests that can run at any speed. I'd prefer to not have tests that

Re: [webkit-dev] SVG Filters

2009-12-07 Thread Maciej Stachowiak
On Dec 6, 2009, at 3:00 PM, Dirk Schulze wrote: Hi Maciej and Darin, you both suggested to add fuzz tests for SVG Filters. I looked at the fuzz test LayoutTest/svg/dom/fuzz-path-parser.html. As an analogy to this test, I would suggest an array with the effects to test, it's number of inputs

[webkit-dev] Bot redness :-(

2009-12-08 Thread Maciej Stachowiak
There's been some persistent bot redness the past few days. Here's the current problems I see: - storage/change-version-handle-reuse.html crashed on the Leopard Intel Debug bot - apparent threadsafety bug - some media tests are sporadically failing on SnowLeopard Intel Release - many

Re: [webkit-dev] Resolution on switch statement indentation

2009-12-09 Thread Maciej Stachowiak
On Dec 9, 2009, at 7:26 AM, Chris Marrin wrote: I saw another patch get rejected today because of switch statement indentation. We discussed this last week, and I saw a lot of support for my proposal of indenting case labels from their switch. But the discussion did not end in

Re: [webkit-dev] Resolution on switch statement indentation

2009-12-09 Thread Maciej Stachowiak
On Dec 9, 2009, at 10:11 AM, Chris Marrin wrote: On Dec 9, 2009, at 9:41 AM, Maciej Stachowiak wrote: I meant 4 spaces from the switch (i.e. 2 additional spaces from the case label). switch (x) { case foo: { fooFunc(); } case bar: barFunc(); } Ok, the example above seems

[webkit-dev] Should we ever change style guidelines? (was Re: Resolution on switch statement indentation)

2009-12-09 Thread Maciej Stachowiak
Hi Adam, On Dec 9, 2009, at 11:25 AM, Adam Treat wrote: Yep, that does distinguish. That being said, my personal preference would be either to keep the current rule and change the code to meet it or even better just eliminate the rule altogether since the community hasn't been following

Re: [webkit-dev] Patch to use V8 engine with Gtk port

2009-12-12 Thread Maciej Stachowiak
I think questioning someone's priorities in an open source project is generally not polite, unless there is some direct relationship between different tasks. For example, if someone introduce a new feature (let's say support for parts of the FooML language) and it had lots of bugs, it

Re: [webkit-dev] questions re: patch length

2009-12-14 Thread Maciej Stachowiak
Personal thoughts: On Dec 14, 2009, at 7:22 PM, Chris Jerdonek wrote: I have a few questions related to patch length: (1) Do reviewers take patch length into account when considering whether to review a patch? This is useful to know for those who would rather have a short patch reviewed

[webkit-dev] Sunspider 0.9.1 preview

2009-12-14 Thread Maciej Stachowiak
Hello folks, Over the past few days I made some changes to SunSpider to address some of the more serious issues reported. I focused on only changes that seem to make a significant difference to fairness and validity, so for example I did not remove accidental access to global variables.

Re: [webkit-dev] SharedScript: next steps and result of offline discussion.

2009-12-15 Thread Maciej Stachowiak
On Dec 15, 2009, at 11:09 AM, Michael Nordman wrote: On Mon, Dec 14, 2009 at 9:16 PM, Darin Fisher da...@chromium.org wrote: I think that use case has been de-emphasized. However, if we wanted to support it, we'd probably have to say that removeChild of an IFRAME element doesn't cause

Re: [webkit-dev] SharedScript: next steps and result of offline discussion.

2009-12-15 Thread Maciej Stachowiak
On Dec 15, 2009, at 12:38 PM, Dmitry Titov wrote: On Tue, Dec 15, 2009 at 12:06 PM, Maciej Stachowiak m...@apple.com wrote: On Dec 15, 2009, at 11:09 AM, Michael Nordman wrote: On Mon, Dec 14, 2009 at 9:16 PM, Darin Fisher da...@chromium.org wrote: I think that use case has been de

Re: [webkit-dev] Sunspider 0.9.1 preview

2009-12-15 Thread Maciej Stachowiak
On Dec 15, 2009, at 1:01 PM, Maciej Stachowiak wrote: On Dec 15, 2009, at 12:30 PM, Mike Belshe wrote: A couple of ideas: - can we make it so that if you try to cut-and-paste comparisons of 0.9 to 0.9.1 results, it will say these results are from a different version? Good idea

Re: [webkit-dev] Sunspider 0.9.1 preview

2009-12-15 Thread Maciej Stachowiak
On Dec 15, 2009, at 3:07 PM, Mike Belshe wrote: On Tue, Dec 15, 2009 at 1:01 PM, Maciej Stachowiak m...@apple.com wrote: - what would you think of reducing the setTimeout(..., 500) to something like setTimeout(..., 100)? This will cut the runtime of the test by ~80% :-) I

Re: [webkit-dev] strcmp result checking

2009-12-17 Thread Maciej Stachowiak
On Dec 17, 2009, at 9:24 AM, Simon Fraser wrote: On Dec 16, 2009, at 10:02 PM, Peter Kasting wrote: On Wed, Dec 16, 2009 at 9:12 PM, Alexey Proskuryakov a...@webkit.org wrote: As current style rules say that tests for zero/non-zero should all be done without equality comparisons.

Re: [webkit-dev] [webkit-changes] [52439] trunk/WebCore

2009-12-22 Thread Maciej Stachowiak
On Dec 21, 2009, at 12:22 PM, Eric Seidel wrote: I'm happy to move the commit-queue to use an SVN checkout instead if that would be a desired change. :) Yes please. - Maciej -eric On Mon, Dec 21, 2009 at 2:20 PM, David Kilzer ddkil...@webkit.org wrote: If you want to make sure you're

Re: [webkit-dev] Skipping Flakey Tests

2009-12-22 Thread Maciej Stachowiak
On Dec 22, 2009, at 10:31 AM, Darin Adler wrote: On Dec 21, 2009, at 6:14 PM, Dirk Pranke wrote: Given all that, Darin, what were you suggesting when you said Let's fix that? Lets add a feature so something in the tests tree can indicate a Chromium Windows result should be the base

Re: [webkit-dev] Implementation thoughts on HTML5 elements

2009-12-26 Thread Maciej Stachowiak
On Dec 25, 2009, at 10:39 AM, TAMURA, Kent wrote: I made a master bug of HTML5, like HTML5 Forms already has. [Bug 32934] Master bug of HTML5 features https://bugs.webkit.org/show_bug.cgi?id=32934 A while back I made an HTML5 keyword, for HTML5 features and compliance bugs. I think HTML5

[webkit-dev] Review backlog

2009-12-28 Thread Maciej Stachowiak
58 patches needing generic review: http://tinyurl.com/y98qfjs 39 patches needing specialized review (mostly [Gtk] or [Qt]): http://tinyurl.com/yjr2xru Let's try to pare these down. - Maciej ___ webkit-dev mailing list webkit-dev@lists.webkit.org

Re: [webkit-dev] layoutTest animations

2009-12-30 Thread Maciej Stachowiak
On Dec 30, 2009, at 4:27 AM, Mario Bensi wrote: Hello, In LayoutTests/animations/ I can find some test using webkit css/ animation 3D like : LayoutTests/animations/state-at-end-event-transform.html In script run-webkit-tests you remove animations/3d if 3D is not activated but 3d

Re: [webkit-dev] Calling JavaScript function from within DumpRenderTree

2010-01-02 Thread Maciej Stachowiak
On Jan 1, 2010, at 9:25 PM, Sam Weinig wrote: That said, a more javascripty way to do this would be to pass the function object to liveRegion.addNotificationListener itself. That way, in the test file, you would have, liveRegion.addNotificationListener(function(notification) { // do

Re: [webkit-dev] First Early Warning System (EWS) bot online

2010-01-05 Thread Maciej Stachowiak
On Jan 5, 2010, at 10:21 AM, Adam Barth wrote: On Tue, Jan 5, 2010 at 9:42 AM, tonikitoo (Antonio Gomes) toniki...@gmail.com wrote: Q) Why doesn't the EWS post a success message? I like positive re- enforcement. A) I'm worried about spamming bugs with too many happy status messages. If we

Re: [webkit-dev] First Early Warning System (EWS) bot online

2010-01-05 Thread Maciej Stachowiak
On Jan 5, 2010, at 12:47 PM, Adam Barth wrote: On Tue, Jan 5, 2010 at 11:51 AM, Maciej Stachowiak m...@apple.com wrote: s/required/requested/ Haha! I actually meant to type requested but my fingers typed required. Freudian slip? Looks like the orbital mind control lasers are a little

Re: [webkit-dev] DOMAttrModified events in WebKit

2010-01-05 Thread Maciej Stachowiak
On Jan 5, 2010, at 4:50 PM, Chris Marrin wrote: There is a bug posted (https://bugs.webkit.org/show_bug.cgi?id=8191) about the implementation of DOMAttrModified events. The implementation is quite far along and there are many posts begging for it, but it is stalled because of one

Re: [webkit-dev] PreloadScanner aggressiveness

2010-01-07 Thread Maciej Stachowiak
On Jan 7, 2010, at 12:09 PM, Mike Belshe wrote: Hi - I've been working on SPDY, but I think I may have found a good performance win for HTTP. Specifically, if the PreloadScanner, which is responsible for scanning ahead within an HTML document to find subresources, is throttled today.

Re: [webkit-dev] Running pixel tests on build.webkit.org

2010-01-09 Thread Maciej Stachowiak
On Jan 9, 2010, at 6:35 AM, Nikolas Zimmermann wrote: Am 08.01.2010 um 22:32 schrieb Evan Martin: On Thu, Jan 7, 2010 at 4:05 PM, Nikolas Zimmermann zimmerm...@physik.rwth-aachen.de wrote: How about we'd start only with svg/ pixel tests? Getting SVG pixel tests working across the ports

Re: [webkit-dev] webkit.org/pending-review

2010-01-14 Thread Maciej Stachowiak
On Jan 14, 2010, at 12:25 AM, Eric Seidel wrote: Oliver Hunt mentioned this evening that he found the webkit.org/pending-review page confusing because it lists both commit-queue? patches and review? patches. I agreed. I filed https://bugs.webkit.org/show_bug.cgi?id=33656 to track updating

Re: [webkit-dev] strdup in WebKit

2010-01-20 Thread Maciej Stachowiak
On Jan 20, 2010, at 2:07 AM, KwangYul Seo wrote: Hi, WebKit does not use malloc/free directly in favor of fastMalloc/fastFree. The only exception to this rule is strdup() which returns a memory that must be freed by free. Why don't we add fastStrDup which allocates a memory with

Re: [webkit-dev] Qtish API for JavaScriptCore, take two

2010-01-20 Thread Maciej Stachowiak
On Jan 20, 2010, at 7:08 AM, Kent Hansen wrote: Hello WebKit developers, A while ago, we, the team of Qt developers at Nokia and INdT, presented the idea of adding a Qt C++ API on top of JavaScriptCore [1]. The fundamental issue back then was that our implementation was not using the

Re: [webkit-dev] Tagging bug names with a platform name: limit to platform-specific patches

2010-01-20 Thread Maciej Stachowiak
On Jan 20, 2010, at 8:18 AM, Darin Adler wrote: Hi folks. We’ve never formalized this, but I believe that patches tagged with a particular platform name such as [Qt] Add new API for fluffy bunnies should be limited to one particular platform’s code. If the patch changes more

Re: [webkit-dev] location in the tree for third party python code?

2010-01-21 Thread Maciej Stachowiak
The MIT license is equivalent to the standard no-advertising-clause BSD license that we use in WebKit. It would be acceptable. - Maciej On Jan 21, 2010, at 6:11 PM, David Levin wrote: I didn't see a web page about it, but when you submit a patch, every single bullet mentions only BSD or

Re: [webkit-dev] Tagging bug names with a platform name: limit to platform-specific patches

2010-01-21 Thread Maciej Stachowiak
On Jan 21, 2010, at 3:37 AM, Anton Muhin wrote: On Thu, Jan 21, 2010 at 10:58 AM, Maciej Stachowiak m...@apple.com wrote: On Jan 20, 2010, at 8:18 AM, Darin Adler wrote: Hi folks. We’ve never formalized this, but I believe that patches tagged with a particular platform name

Re: [webkit-dev] IndexedDB API

2010-01-21 Thread Maciej Stachowiak
On Jan 21, 2010, at 9:53 PM, Jeremy Orlow wrote: A couple of us at Google are starting to look at implementing the IndexedDB API [1] in WebKit. We thought a good first step would be to create the IDL files. The first thing I noticed is that it and the Web SQL Database API [2] have quite

[webkit-dev] The tree is on fire

2010-01-22 Thread Maciej Stachowiak
Ever since this change: http://trac.webkit.org/changeset/53722 The Leopard and SnowLeopard tests have been failing fast/dom/Window/window-property-descriptors.html. Ironically, it looks like that patch landed new results in an attempt to fix that test, but it looks to me like the new results

Re: [webkit-dev] webkit team wiki page

2010-01-24 Thread Maciej Stachowiak
On Jan 24, 2010, at 2:02 PM, Adam Barth wrote: I changed it for two reasons: 1) The old format wasn't scaling to the current team size. The page as become an unwieldy wall of text. 2) The old format emphasized the industrial affiliation of the team members, which seemed counter to a

<    1   2   3   4   5   6   7   8   9   10   >