Re: [webkit-dev] Rationale for PlatformRefPtr?

2010-09-30 Thread Martin Robinson
On Thu, Sep 30, 2010 at 4:53 PM, Martin Robinson wrote: > On Thu, Sep 30, 2010 at 3:20 PM, Darin Adler wrote: >> For example, for Core Foundation and Cocoa we made RetainPtr. For JavaScript >> we made JSRetainPtr. For GTK I think we should have GTKRefPtr. >> Is there

Re: [webkit-dev] Request to add Build Bot

2010-09-24 Thread Martin Robinson
On Fri, Sep 24, 2010 at 8:50 AM, Brent Fulgham wrote: > I've finally gotten a system setup and configured to run as a build > bot for the WinCairo port.  Per the instructions in the wiki, I've > filed a bug (https://bugs.webkit.org/show_bug.cgi?id=46360) to add the > configuration to the build sys

Re: [webkit-dev] Making GRefPtr more general

2010-08-25 Thread Martin Robinson
On Tue, Aug 24, 2010 at 5:31 PM, Darin Adler wrote: > If overloading can be used to determine how to do the > "take a ref" and "release a ref" functions, then many different > subsystems can share a single PassRefPtr/RefPtr class. One complication in the GObject case, is that the argument type fo

Re: [webkit-dev] wscript in the root directory

2010-08-23 Thread Martin Robinson
On Mon, Aug 23, 2010 at 4:54 PM, Adam Barth wrote: > What is this wscript file in the root directory of WebKit?  If it's a > script, maybe we should move it to WebKitTools/Scripts? I believe that's a WAF build script. It seems to be used by the wx port. Martin ___

Re: [webkit-dev] Making GRefPtr more general

2010-08-23 Thread Martin Robinson
On Mon, Aug 23, 2010 at 10:06 AM, Eric Seidel wrote: > Would this then combine with the Mac/Win port's RetainPtr in some way? I think it makes a lot of sense to gradually combine our duplicate smart pointer logic into one base or templated class. They all seem to be in WTF, so even more so. Mart

[webkit-dev] Making GRefPtr more general

2010-08-23 Thread Martin Robinson
Recently there was a need to make the smart pointer wrapping GLib reference-counted types more general. In this case it was to extend it to Cairo. Here is the bug for that: https://bugs.webkit.org/show_bug.cgi?id=44354 It struck me that the name GRefPtr wasn't very applicable to this type any lon

Re: [webkit-dev] Canvas performance and memory usage

2010-08-10 Thread Martin Robinson
> Anyway I'm open to suggestions here. :) I came to very similar conclusions that you did and posted a WIP patch here: https://bugs.webkit.org/show_bug.cgi?id=43507 . I'm not sure if it is ready or good, but in particular removing the caching behavior for ::image() led to a lot of unexpected chang

Re: [webkit-dev] Some landed patches have incorrect date in commit messages and ChangeLog

2010-08-09 Thread Martin Robinson
On Mon, Aug 9, 2010 at 10:51 AM, Jian Li wrote: > Please make sure the correct date is used when you land your patch manually. This is one of my favorite features of webkit-patch, which seems to do the right thing at least in the case of git. Martin __

Re: [webkit-dev] Canvas performance and memory usage

2010-08-04 Thread Martin Robinson
On Wed, Aug 4, 2010 at 3:23 PM, Christophe Public wrote: > Thanks for the clarification. If this is the main reason, then it seems a > valuable optimization to do. Here's the bug for this issue: https://bugs.webkit.org/show_bug.cgi?id=43507 ___ webkit-d

Re: [webkit-dev] Canvas performance and memory usage

2010-08-03 Thread Martin Robinson
Resent from the proper address: On Tue, Aug 3, 2010 at 6:00 PM, Martin Robinson wrote: >> I notice that Qt added imageForRendering() and felt they could not use >> image() for some reason.  I'd be curious if a Qt expert could weigh in on >> that, since maybe with a redesig

Re: [webkit-dev] Sharing WebKit mocks across platforms

2010-07-31 Thread Martin Robinson
> Mr. Seidel, we might have found our next project. Speaking as someone who has spent a lot of time recently creating this boilerplate code, I would be willing to chip in serious time for this kind of effort. Martin ___ webkit-dev mailing list webkit-de

Re: [webkit-dev] I am about to break your tree.

2010-07-14 Thread Martin Robinson
On Wed, Jul 14, 2010 at 7:54 PM, Eric Seidel wrote: > We're removing redundant text nodes from the parsed DOM tree. > Unfortunately, given our current setup, there is no way for me to > generate results for all platforms which may have them forked. Awesome! I'll be here to generate new results wh

[webkit-dev] Determining platform in LayoutTests

2010-03-28 Thread Martin Robinson
Apologies in advance if this has been hashed out before, but a cursory search of the list history didn't turn anything up. It seems that in LayoutTests platform specific behavior is generally handled by examining the user agent. I'm currently in the process of fixing editing/selection/extend-selec

Re: [webkit-dev] Style for Gtk/Qt code

2009-12-21 Thread Martin Robinson
On Mon, Dec 21, 2009 at 8:25 AM, Eric Seidel wrote: > Can we get consensus on if the WebKit style applies to all sections of > code?  And if it does not, what style applies to the code it does not? This was recently an issue here as well: https://bugs.webkit.org/show_bug.cgi?id=20736 For the GTK

[webkit-dev] Exposing cURL proxy configuration per-request

2009-10-31 Thread Martin Robinson
elegate (essentially something like FrameLoaderClient::dispatchDecideProxyForRequest). Does this sound reasonable? Thanks in advance for the advice. Martin Robinson ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

<    1   2