[webkit-dev] Win EWS bots back online
Hey all, Just a heads up. The Windows EWS bots are back online. Let me know if you’re still seeing any issues with them. Thanks! Roger ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] C++11 (was Re: on coding-style)
> From the CMake thread, I got that MSVC 2010 will soon be the oldest version > supported. Is that correct? > It looks like that might be the case although I still need to test cmake on the AppleWin port to confirm that’s it’s okay. Assuming that we do make use of cmake I’m still not quite sure yet about the “soon”. We have one issue with the pthreads library being compiled in VS2005 that was blocking us from switching to VS2010 entirely. We have a resolution for that issue on its way but it will be some time yet before it gets pushed out. In the cmake thread, Patrick said that he had managed to get rid of the need for pthreads entirely to workaround that issue. If we can do that then yes I think “soon” would be accurate, but I’ll need to figure out what the impact of getting rid of pthreads is first. Roger On Apr 12, 2013, at 6:22 PM, Benjamin Poulain wrote: > On Fri, Apr 12, 2013 at 6:15 PM, Maciej Stachowiak wrote: > On Apr 12, 2013, at 4:09 PM, Karen Shaeffer wrote: > > As others have said, we are definitely eager to use C++11 across the board > but are limited by compiler support requirements. > > One thing that it would be useful to know: what are the compilers and minimum > required versions used for in-tree ports? Perhaps we could record this so we > can regularly evaluate which features are safe to use and what the blockers > are to wholesale adoption, if any. > > I think the worse thing we support right now is supporting MSVC 2005 (for > compiler support) and Windows XP (for library support). > > From the CMake thread, I got that MSVC 2010 will soon be the oldest version > supported. Is that correct? > > Benjamin > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Buildsystem cleanup
Hi Patrick, A few questions I have about the CMake system, being someone who's never used it before. -I would like to keep all of the unified properties settings that the VS2010 property sheets hierarchy provided. Can we still maintain that through CMake easily? -How does CMake handle different build targets. Would I have to open up different project files per configuration? -If I'm understanding things correctly the main differences with using CMake would be: 1. If a project configuration is changed run CMake / I guess whenever you update the source as well (just to be safe). We would want to change any build scripts to use CMake: perhaps build-webkit is the really the only one we have to worry about in the OpenSource tree. 2. If you're working on Windows, open up the solution with Visual Studio and do work as usual, unless you want to add files in which case you go through the CMake scripts again before moving on. Would all the project filters and solution dependencies would still be in tact? Or is the solution file something that we would maintain that would hook into the generated projects?. -I'm assuming there's a CMake flag for specifying which version of visual studio to generate project files for? Our opensource bots run VS2005 and our internal run VS2010 currently, and seeing as we're not ready to use only VS2010 yet we would need to be able to specify which. If my above concerns can be resolved and the example you posted works fine for us (I'll try to take a look at it soon), it's probably okay to start checking in stuff to get ready for the move to CMake. I don't think we really have the resources to get things hooked up on our end in the immediate future, but perhaps in the coming months. Also if we do end up switching over I would highly push for all other ports besides Mac to adopt CMake and require any new ports to use it as well. Thanks, Roger On Apr 9, 2013, at 9:34 AM, Patrick Gansterer wrote: > Hi, > > On Mon, 08 Apr 2013 18:10:29 -0700, Mark Rowe wrote: >> On 2013-04-08, at 17:45, Patrick Gansterer wrote: >>> Hmm, I'll try to set up an example for WTF + JavaScriptCore. Maybe you can >>> have a look at it then to check if I understand the concept correctly >>> before I move on to WebCore + WebKit? >> >> Sounds good. > > I pushed a quick & dirty example to [1], which shows a possible solution for > WTF and JavaScriptCore. > > You can test it with the following steps. The helper directory contains then > all "built" files. > > * Create a directory helper > * Copy all files from Source/cmake to helper/cmake > * Copy all files (including the support libraries) from WebKitLibraries to > helper/WebKitLibraries > * Create an independent directory and run the following commands in it: > $ cmake path/to/WebKit/Source/WTF/wtf -DPORT=WinApple > -DHELPER_DIR=path/to/helper > $ cmake --build . --target package > * You get a WTF.zip, which should be extracted in the directory helper > * Create an additional independent directory and run the following commands > in it: > $ cmake path/to/WebKit/Source/JavaScriptCore -DPORT=WinApple > -DHELPER_DIR=path/to/helper > $ cmake --build . --target package > * Yout get a JavaScriptCore.zip with the DLL > > I would be great if someone can verify that this solution will work for the > internal builds at Apple. > If I get positive feedback I'll can implement this for WebCore and WebKit > too. Is there someone who will review my patches for this? > Do you think it's possible to directly switch to CMake at Apple instead of > upstreaming the VS2010 files? IHMO the whole work can be done in a few days, > if someone at Apple is willing to work with me on it. > > [1] https://github.com/paroga/webkit > > -- Patrick ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Buildsystem cleanup
I wasn’t aware that the build worked without a VS2010 pThreads build. I was running into issues because of the pThreads dll having embedded manifest problems earlier. Did you do anything special to circumvent that issue? It won’t take much to switch it over but the problem was originally that I couldn’t get it to build without a newer compile of the pthreads library. Thus we were waiting for the pthreads folks to release a newer pthreads dll before doing the switch over. Also, I believe Brent Fulgham may have modified build-webkit to set environment variables appropriately because the VS2010 solution uses different ones than the VS2005 solution. I just have those variables set permanently and just build directly from the solution file. (Need to update those build.webkit.org instructions) On Apr 8, 2013, at 1:13 PM, Justin Haygood wrote: > What would it take to switch build-webkit, et al to the VS2010 build? (VS2010 > does work manually though, if you run build-webkit at least once, let it fail > since it can’t find VS2005/VS2008, and then build it from the solution file) > > From: webkit-dev-boun...@lists.webkit.org > [mailto:webkit-dev-boun...@lists.webkit.org] On Behalf Of Roger Fong > Sent: Monday, April 08, 2013 3:26 PM > To: Patrick Gansterer > Cc: WebKit Development > Subject: Re: [webkit-dev] Buildsystem cleanup > > Unfortunately this would cause a lot of complication in our internal build > setup that we currently don’t really have the resources to deal with right > now. > > It would be nice to unite all the build systems at some point in the future > but we’re going to push this one off for now. > > Also we’re planning on getting rid of the VS2005 eventually. > > On Apr 7, 2013, at 6:47 PM, Patrick Gansterer wrote: > > > Hi, > > since the Chromium code is getting removed step by step I think that the GYP > build system won't have a shiny future in the WebKit repository. In the GYP > vs. CMake match CMake gets an additional point: There is no WebKit port > working with GYP, but at least 3 with CMake. Accordantly to [1] GTK will give > CMake a try too. > Adopting the Mac port does not seam to be an easy task in the near future, > because of the very specific build requirements. > But what about the Windows ports? I updated the patch at [2] to work with a > more recent revision. Are there any chances to use CMake instead of the VS > solution files? At the moment it becomes even worst, since there are VS2005 > and VS2010 files in the tree, which duplicated many files. > The patch at [2] is only an initial example, since a complete implementation > would require more changes in the code. If CMake becomes an option, I'm > willing to provide an "complete" patch with all CMake files. > > -- Patrick > > [1] https://lists.webkit.org/pipermail/webkit-dev/2013-April/024399.html > [2] https://bugs.webkit.org/show_bug.cgi?id=72816 > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Buildsystem cleanup
Unfortunately this would cause a lot of complication in our internal build setup that we currently don’t really have the resources to deal with right now. It would be nice to unite all the build systems at some point in the future but we’re going to push this one off for now. Also we’re planning on getting rid of the VS2005 eventually. On Apr 7, 2013, at 6:47 PM, Patrick Gansterer wrote: > Hi, > > since the Chromium code is getting removed step by step I think that the GYP > build system won't have a shiny future in the WebKit repository. In the GYP > vs. CMake match CMake gets an additional point: There is no WebKit port > working with GYP, but at least 3 with CMake. Accordantly to [1] GTK will give > CMake a try too. > Adopting the Mac port does not seam to be an easy task in the near future, > because of the very specific build requirements. > But what about the Windows ports? I updated the patch at [2] to work with a > more recent revision. Are there any chances to use CMake instead of the VS > solution files? At the moment it becomes even worst, since there are VS2005 > and VS2010 files in the tree, which duplicated many files. > The patch at [2] is only an initial example, since a complete implementation > would require more changes in the code. If CMake becomes an option, I'm > willing to provide an "complete" patch with all CMake files. > > -- Patrick > > [1] https://lists.webkit.org/pipermail/webkit-dev/2013-April/024399.html > [2] https://bugs.webkit.org/show_bug.cgi?id=72816 > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Status of Windows Port?
We are also maintaining the WebKit1 Windows port at Apple. On Apr 4, 2013, at 3:09 PM, Justin Haygood wrote: > If Qt is the way to support Windows, it would need some work to make it easy > to integrate into an existing non-Qt Windows application. From memory, that > isn't the easiest thing in the world to do ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
