[webkit-dev] WPT first test policy proposal

[Tim Nguyen via webkit-dev]

Hello everyone,

I would like to start a discussion on a policy to enforce WPT usage as a first 
choice, that would be enforced via check-webkit-style on Changelog files.

Why use WPT?

Contributing to WPT has many benefits:
interoperability/compatibility issues with WPT we write may be detected by 
other browser vendors and we would get faster feedback and turnaround to fix 
them
creates/encourages discussion in case of disagreement with other browser vendors
WebKit greatly benefits from WPT coverage, it is time to provide our own 
coverage to other browsers
Improves WebKit’s score generally for WPT (which has tests mostly contributed 
by Chromium, Firefox at the moment)

Are there reasons to not use WPT?

Common reasons for not writing WPT that have been mentioned are:
"WPTs are less pleasant to write.”
This is not true imo, the WPT harness is documented 
(https://web-platform-tests.org/writing-tests/index.html 
), unlike WebKit 
internals, making it easier for new contributors to figure out things.

“When you actually move a regression test to WPT proper, commit history is 
lost, and you don't know what kind of user facing problem it's preventing any 
more.”
Use `` with a reference to the webkit bug. Ensure you 
actually export the WPT and merge the WPT PR as well!

There are things WPT can’t test
True (e.g. tree dumps). My proposal below covers that.

Here is my current proposal:

Every LayoutTests/ changelog adding new test files would contain:

WPT-exemption-reason:  NONE (OOPS!)

If that line is removed or no valid reason is provided, webkit-style would 
throw out an error. Valid reasons could be:

WPT-exemption-reason: urgency (webkit.org/b/XXX )
I’m personally not in favour of this reason existing, but some have expressed 
interest in it, this may be used in case of urgency (security fixes etc.), 
where a bug must be filed to port it to WPT (alternatively the test path could 
be added to a new allowlist file). Eventually this reason would be removed if 
two way sync with the WPT repo is available.

WPT-exemption-reason: test-harness-deficiency (webkit.org/b/XXX 
)
If the WebKit implementation of the WPT harness lacks a certain feature that 
should be implemented in the WPT harness, a new bug may be filed, or an 
existing bug may be referenced.
Maintainers of the WPT harness may watch this reason to prioritize work needed 
on the harness.

WPT-exemption-reason: requires-internals: NONE (OOPS!)
requires-internals should have a valid explanation of which internals are 
needed. (Tree dumps would be a valid reason, although usually reftests can 
cover those)

In addition: 

WPT-PR: https://github.com/web-platform-tests/wpt/pulls/XX 
 must be present in 
LayoutTests/imported/w3c/Changelog, this is to ensure tests are not lost at the 
next import.

This would also be enforced in webkit-style, although eventually this might be 
replaced by a fully automated process in the future similar to Chrome/Firefox.

Any feedback is absolutely welcome!

Cheers,
Tim___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Proposed changes to Bugzilla 'Resolution' categories

[Tim Nguyen via webkit-dev]

Hi!

Pretty sure WORKSFORME corresponds to “Behaves As Designed”, that’s how 
Mozilla’s bugzilla’s instance uses it at least.

Adding new resolution statuses seems fine, but maybe old ones (WORKSFORME, 
WONTFIX, INVALID, etc.) should be cleaned up/migrated too, otherwise folks 
(coming from other OSS projects using Bugzilla) will still keep using them. 
Maybe they could be disabled.

-Tim

> On 10 Feb 2022, at 20:55, Brent Fulgham via webkit-dev 
>  wrote:
> 
> 

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

[webkit-dev] Style guide: enforce `while (true)` over `for (;;)`

[Tim Nguyen via webkit-dev]

Hi everyone,

The WebKit codebase has an inconsistent mix of `while (true)` and `for (;;)`. 
Given 2/3 of the usages are `while (true)` and only 1/3 is `for (;;)` from code 
search, I would suggest enforcing `while (true)`. I also think it is generally 
more explicit and readable than `for (;;)`. If everyone agrees, I’ll enforce 
this via webkit-style, so we can end up in a consistent place.

What does everyone think?

Cheers,
Tim
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

[webkit-dev] Matt Woodrow is now a WebKit reviewer

[Tim Nguyen via webkit-dev]

Hi!

I’m happy to announce that Matt Woodrow is now a WebKit reviewer. 🎉

Matt has shown expertise in various CSS and Graphics areas such as CSS 
Grid/Subgrid, CSS Transforms, and OffscreenCanvas. Please feel free to reach 
out to Matt for reviews!

Cheers,
Tim___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

[webkit-dev] Oriol Brufau is now a reviewer!

[Tim Nguyen via webkit-dev]

Hi!

I’m happy to announce that Oriol Brufau is now a WebKit reviewer. 🎉

Oriol has shown great expertise on CSS cascade and serialization related 
things. Please feel free to reach out to Oriol for reviews!

Cheers,
Tim___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Approving / Rejects PRs on GitHub when not a reviewer?

[Tim Nguyen via webkit-dev]

(I already answered this, but that message failed to reach the mailing list, 
sorry to the folks receiving my reply twice)

Everyone in the WebKit Github organization gets a green checkmark afaik (that’s 
just how the Github UI works), so as of right now that means everyone in 
contributors.json with a Github username.

> On Nov 28, 2023, at 12:34 PM, Darin Adler via webkit-dev 
>  wrote:
> 
>> On Nov 28, 2023, at 3:02 PM, Chris Dumez wrote:
>> 
>> FYI, my understanding is that the person gets a *green* checkmark when the 
>> person is present in contributors.json (common case), even if not marked as 
>> a reviewer in that file.
> 
> Does anyone know why we chose green for all contributors rather than green 
> for reviewers?
> 
> — Darin
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

[webkit-dev] Anne Van Kesteren is now a WebKit reviewer

[Tim Nguyen via webkit-dev]

Hi everyone!

I’m delighted to announce that Anne Van Kesteren is now a WebKit reviewer!  🎉 

He’s been working on HTML parsing, CSS parsing and native theme related things.

Please feel free to reach out to him for reviews.

Cheers,
Tim
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

[webkit-dev] Matthieu Dubet is now a WebKit reviewer

[Tim Nguyen via webkit-dev]

Hi everyone!

I’m delighted to announce that Matthieu Dubet is now a WebKit reviewer!  🎉 

He’s been working on many complex CSS features, and many areas of the CSS 
engine.

Please feel free to reach out to him for reviews.

Cheers,
Tim
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev