Re: [webkit-dev] Commit Authorship on GitHub

Hi Jonathan! > On Dec 1, 2020, at 8:22 AM, Jonathan Bedard via webkit-dev > wrote: > > Hello contributors, > > I am in the process of modifying one of our Git mirrors of the repository for > permanent use. As part of that modification, I am repairing authorship of > historical commits based

Re: [webkit-dev] Commit Authorship on GitHub

> On Dec 1, 2020, at 11:57 AM, Jonathan Bedard wrote: > > > >> On Dec 1, 2020, at 1:55 PM, Yusuke Suzuki > > wrote: >> >> Hi Jonathan! >> >>> On Dec 1, 2020, at 8:22 AM, Jonathan Bedard via webkit-dev >>> mailto:webkit-dev@lists.webkit.org>> wrote: >>> >>> Hello

Re: [webkit-dev] Reminder: include everything that you use in implementation files

I think, without EWS / post-build bots using non-unified builds, this is difficult to achieve… -Yusuke > On Nov 12, 2020, at 4:16 AM, Adrian Perez de Castro via webkit-dev > wrote: > > Hello Peng, > > On Wed, 11 Nov 2020 12:05:18 -0800 "Peng (WebKit) Liu via webkit-dev" > wrote: > >> Any

Re: [webkit-dev] Caio Lima is now a WebKit reviewer

Congrats! -Yusuke > On Mar 18, 2021, at 3:42 PM, Saam Barati via webkit-dev > wrote: > > Hi folks, > > I'm happy to announce that Caio Lima is now a WebKit reviewer. Send your > JavaScriptCore reviews his way! > > Congrats, Caio. > > - Saam >

Re: [webkit-dev] Using C++20 in WebKit

I recently upgraded GCC requirement to 8.3.0 based on https://trac.webkit.org/wiki/WebKitGTK/GCCRequirement (https://trac.webkit.org/changeset/283348/webkit ) As a result, we can use some

Re: [webkit-dev] Using C++20 in WebKit

Carlos Alberto Lopez Perez via webkit-dev >> mailto:webkit-dev@lists.webkit.org>> wrote: >> >> On 06/12/2021 22:36, Yusuke Suzuki via webkit-dev wrote: >>> I recently upgraded GCC requirement to 8.3.0 based >>> on https://trac.webkit.org/wiki/WebKitGTK/GC

Re: [webkit-dev] Using C++20 in WebKit

That’s awesome! Thank you for your work! -Yusuke > On Mar 9, 2022, at 4:29 PM, Alex Christensen via webkit-dev > wrote: > > Apple and Sony are finishing updating our build infrastructure to Visual > Studio 2022, and we are considering requiring it to build WebKit starting > next week. If

Re: [webkit-dev] Using C++20 in WebKit

r look into it? >>> >>>> On Dec 7, 2021, at 2:38 PM, Carlos Alberto Lopez Perez via webkit-dev >>>> mailto:webkit-dev@lists.webkit.org>> wrote: >>>> >>>> On 06/12/2021 22:36, Yusuke Suzuki via webkit-dev wrote: >>>>&g

Re: [webkit-dev] ChangeLog Deprecation Plans

> On Apr 18, 2022, at 12:51 PM, Michael Catanzaro via webkit-dev > wrote: > > On Mon, Apr 18 2022 at 08:30:04 AM -0700, Jonathan Bedard via webkit-dev > wrote: >> 2) We need a way to comment on commit messages in review >> Current tooling sets the pull request description as the commit

Re: [webkit-dev] ChangeLog Deprecation Plans

> On Apr 18, 2022, at 5:38 PM, Michael Catanzaro wrote: > > > On Mon, Apr 18 2022 at 02:55:08 PM -0700, Yusuke Suzuki > wrote: >> I think this is important. We are using commit message / ChangeLog as a >> document tied to the change, and we are writing very detailed description to >> make

Re: [webkit-dev] JSC broken on s390x

Do you have a s390x machine which can be accessible to JSC developers? I think, probably, only someone having this machine access can fix the problem. -Yusuke > On Apr 19, 2022, at 5:23 AM, Michael Catanzaro via webkit-dev > wrote: > > Hi, > > I want to call attention to: > >

[webkit-dev] Justin Michaud is now a WebKit Reviewer

Hello WebKittens, I’m pleased to announce that Justin Michaud is now a WebKit Reviewer :) Justin started his WebKit contributions from CSS area and expanded it to JavaScriptCore too. He landed many great optimizations and improvements in JSC and fixed various super complicated compiler and

Re: [webkit-dev] Proposal: Immediate Deprecation of ChangeLogs

> On May 10, 2022, at 1:32 PM, Jonathan Bedard via webkit-dev > wrote: > > The last thing I’d like to note is that a full git-native commit message > policy now is something we can modify in the future if we find that reviewing > commit messages with “Quote reply” comments is not

Re: [webkit-dev] Proposal: Immediate Deprecation of ChangeLogs

while reviewing. Good thing is that we can bring interesting things to GitHub without changing underlying protocol much. Bad thing is it can be fragile. Anyway, I hope we can have a solution :) -Yusuke > On May 10, 2022, at 8:50 PM, Yusuke Suzuki via webkit-dev > wrote: > > >

Re: [webkit-dev] Style guide: enforce `while (true)` over `for (; ; )`

+1 -Yusuke > On Oct 5, 2022, at 5:07 PM, Tim Nguyen via webkit-dev > wrote: > > Hi everyone, > > The WebKit codebase has an inconsistent mix of `while (true)` and `for (;;)`. > Given 2/3 of the usages are `while (true)` and only 1/3 is `for (;;)` from > code search, I would suggest

Re: [webkit-dev] Remove the version labels in GitHub

I also would like to propose removing Version label asking in git-webkit when creating a bugzilla entry. This was not happening when using webkit-patch. Given that we have no consensus on adding this, I think this is a regression. -Yusuke > On Nov 14, 2022, at 2:38 PM, Darin Adler via

Re: [webkit-dev] Proposal on retiring JIT on Windows

r so many years. If we turn that off, I can't imagine it ever being > revived again. > > How come the discussion here is immediately about getting rid of such a large > swath of functionality instead of starting with consideration of the EWS > situation itself? > > Ross > From:

[webkit-dev] Proposal on retiring JIT on Windows

Hello, I would like to propose retiring JIT on Windows JavaScriptCore. Recently, Apple Windows EWS bots get removed. As a result, there is no test-running EWS bots on Windows. This can work for the other part of WebKit since other ports EWS bots are running tests. However this does not work

Re: [webkit-dev] Proposal on retiring JIT on Windows

onori wrote: > > It sounds reasonable. I don't object to removing Windows JIT support. > > How about LLInt? LLInt has some Windows specific code. > Can I revert the change if the JSC team breaks Windows port even though we > have no EWS nor maintainers? > > On Sun, Mar 26, 2023

Re: [webkit-dev] Removal of trailing whitespace

I agree that we should not do it because it pollutes change history of files, git-blame results, and review-diff in PR. But at the same time, I think there is no reason to add a new trailing whitespace via a new commit. It is nice if we can enforce this rule only for newly added code (via

[webkit-dev] GCC 10 upgrade and C++20 availability

Hello WebKittens, Now, based on milestone, we upgraded GCC requirement from 9.3 to 10.2. This further unlocks many C++20 features, like <=> operator and constinit You can see more C++20 features in https://en.cppreference.com/w/cpp/20 Best regards,

[webkit-dev] constinit: C++20 tip about constexpr initialization for global variables

Hello WebKittens, Now, our baseline is GCC 10, so I would like to introduce useful C++20 feature here, constinit. https://en.cppreference.com/w/cpp/language/constinit You can annotate the global variables etc. with `constinit`, like, ``` static constinit StaticStringImpl aboutBlankString {

Re: [webkit-dev] Replacing Cairo in WebKit with Skia

Nice, this sounds really good. Cairo performance was one of the limiting factors in WebKitGTK, and adopting some libraries which can use GPU is great improvement. One of questions is, should we rename WinCairo to something different? (Like, Win, or WinSkia). -Yusuke > On Feb 2, 2024, at 6:49