Re: [webkit-dev] How to get patch test at different platform before webkit-patch upload
Hi, Benjamin Thank you so much for advice and review. You are right that we can not expect different platform to render as same pixel images. I have modified source code based on comment. And modified TestExpectations(add line such as following) for chromium, gtk, win and qt. # Needs rebaseline because platform-specific webkit.org/b/78957 fast/text/decorations-with-ruby-underline-expand.html [ Failure ] Thank you again and looking forward review result. BR, Zheng (2013/02/17 11:07), Benjamin Poulain wrote: Hi, On Sat, Feb 16, 2013 at 5:45 PM, 徐征 <mailto:xz91...@yahoo.co.jp>> wrote: I am handling this issue (https://bugs.webkit.org/show_bug.cgi?id=78957) now. My question is I test my added test code locally, however, it seems failed on some other platform(get red on cr-linux). So can I(and how can I) test my added test code on some EWS before I upload some patch? The cr-linux bot is the only EWS running the pixel tests. Your test likely fails on everything but Mac. The problem is you assume the pixel test will be the same on all platform. Because the way fonts are rendered varies, the resulting images vary with each platform. In those cases, you can generate results for the platform you are working on, and mark the test for rebaseline in the "TestExpectations" files of the other platforms (in LayoutTest/platform/platformFooBar/TestExpectations). Cheers, Benjamin ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
[webkit-dev] How to get patch test at different platform before webkit-patch upload
Hi I am handling this issue (https://bugs.webkit.org/show_bug.cgi?id=78957) now. My question is I test my added test code locally, however, it seems failed on some other platform(get red on cr-linux). So can I(and how can I) test my added test code on some EWS before I upload some patch? BTW, is there anyone who can help review my patch? I need the review can be passed by next month based on my job. And I do not think it can be passed easily because I am a new one to this project. More Detail: The added test for this patch is passed on my local platform(Safari@Mountain Lion). And I don't want to add dozens of almost same patches to one issue. BR, Zheng ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] request of "canconfirm-bit"
Thank you. Darin I will add comments on the bug. BR, Zheng (2013/01/17 11:40), Darin Adler wrote: On Jan 16, 2013, at 2:54 PM, 徐征 wrote: So, how can I get assign for this issue(and make the status to ASSIGNED)? You don’t need to. You can add comments and post a patch without having the bug formally assigned to you. In fact, we don’t normally pay all that much attention to the Assigned To field. -- Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] request of "canconfirm-bit"
Thank you Adam and Darin So, how can I get assign for this issue(and make the status to ASSIGNED)? Should I get connect with reporter? Now I am reading http://www.webkit.org/quality/lifecycle.html. Zheng (2013/01/17 2:25), Darin Adler wrote: On Jan 16, 2013, at 9:19 AM, Adam Barth wrote: We more or less ignore the "is confirmed" bit in bugs.webkit.org. I believe it’s possible to rename UNCONFIRMED to NEW and delete NEW so we can get rid of this distinction that we don’t make use of. Might be worth doing at some point to reduce confusion. -- Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
[webkit-dev] request of "canconfirm-bit"
Hello everyone This is Zheng and nice to meet you. I want to confirm some issue(https://bugs.webkit.org/show_bug.cgi?id=78957) and try to create patch for it. However, it seems I need "canconfirm-bit" based on http://www.webkit.org/quality/bugzilla.html So, could someone give me the right to confirm and fix it. BR, Zheng ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
