Re: [webkit-dev] Windows Bots Are Green!

2015-02-23 Thread Adam Roben
Over the past few weeks I’ve spent a considerable amount of time reviewing and correcting a number of problems with the Windows testing infrastructure. We were skipping thousands of tests, including Accessibility, http tests, and large sections of forms, css, and svg tests. Some tests were

Re: [webkit-dev] When to use auto? (I usually consider it harmful)

2014-01-02 Thread Adam Roben
I found http://herbsutter.com/2013/08/12/gotw-94-solution-aaa-style-almost-always-auto/ very persuasive in my thinking about when to use auto. -Adam ___ webkit-dev mailing list webkit-dev@lists.webkit.org

Re: [webkit-dev] About USE(CROSS_PLATFORM_CONTEXT_MENUS)

2013-02-25 Thread Adam Roben
I was having a look at our Context Menu design when this USE flag got my attention. Can someone help me clarify the motivation for it? The motivation is explained pretty well in the ChangeLog for r73802, which introduced this flag. I'll try to give a little explanation here too.

Re: [webkit-dev] Version control survey results

2013-02-18 Thread Adam Roben
(For current svn users I assume using svn would become effectively impossible; the only tool I could find to do this is server-side and essentially maintains git and svn repositories in parallel.) FYI, any Git repository on GitHub also functions as a Subversion repository: $ svn checkout

Re: [webkit-dev] sln files with wrong line endings

2013-02-14 Thread Adam Roben
I'm pretty sure r142864 fixed this (perhaps unintentionally) by changing all line endings in DumpRenderTree.sln from CRLF to LF. On Thu, Feb 14, 2013 at 11:11 AM, Darin Adler da...@apple.com wrote: Typically in Subversion the fix for a problem like this is to set the eol-style explicitly;

Re: [webkit-dev] EditBug permission

2012-05-04 Thread Adam Roben
Could someone please add EditBug permission to my bugs.webkit.org (http://bugs.webkit.org/) account? Done. -Adam ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] github mirror

2012-04-24 Thread Adam Roben
On Wed, Apr 18, 2012 at 11:02 AM, Simon Hausmann simon.hausm...@nokia.com wrote: On Wednesday, April 18, 2012 06:53:46 AM ext Shezan Baig wrote: Hi WebKit, I've been using a fork of the following repo: https://github.com/WebKit/webkit However, yesterday there was discussion on #webkit that

Re: [webkit-dev] github mirror

2012-04-24 Thread Adam Roben
On Tue, Apr 24, 2012 at 9:03 AM, Adam Roben aro...@webkit.org wrote: On Wed, Apr 18, 2012 at 11:02 AM, Simon Hausmann simon.hausm...@nokia.com wrote: On Wednesday, April 18, 2012 06:53:46 AM ext Shezan Baig wrote: Hi WebKit, I've been using a fork of the following repo: https://github.com/WebKit

Re: [webkit-dev] github mirror

2012-04-24 Thread Adam Roben
On Wed, Apr 18, 2012 at 11:06 AM, Jarred Nicholls jar...@webkit.org wrote: (from correct address) On Wed, Apr 18, 2012 at 11:06 AM, Jarred Nicholls jar...@sencha.comwrote: On Wed, Apr 18, 2012 at 11:02 AM, Simon Hausmann simon.hausm...@nokia.com wrote: On Wednesday, April 18, 2012

Re: [webkit-dev] Using GitHub to Contribute to WebKit (Experimental)

2012-04-24 Thread Adam Roben
On Fri, Mar 16, 2012 at 5:40 PM, Adam Barth aba...@webkit.org wrote: On Fri, Mar 16, 2012 at 2:32 PM, Ryosuke Niwa rn...@webkit.org wrote: Can we do some Bugzilla integration as Jarred suggested? If you're excited about using GitHub, you should feel free to do that work. It sounds like

Re: [webkit-dev] github mirror

2012-04-24 Thread Adam Roben
On Tue, Apr 24, 2012 at 9:49 AM, Tor Arne Vestbø tor.arne.ves...@nokia.com wrote: On 18.04.12 17:02, Simon Hausmann wrote: On Wednesday, April 18, 2012 06:53:46 AM ext Shezan Baig wrote: Hi WebKit, I've been using a fork of the following repo: https://github.com/WebKit/webkit However,

Re: [webkit-dev] April face-to-face meetings for WebApps

2012-02-13 Thread Adam Roben
Thanks, we're aware of these dates and will keep them in mind. -Adam On Feb 7, 2012, at 10:16 PM, Ojan Vafai o...@chromium.org wrote: There are some possible WG meetings in April and they are wondering if there are any significant conflicts. Specifically, will there be a WebKit meetup this

Re: [webkit-dev] Some doubt about PluginView in WebCore

2011-12-20 Thread Adam Roben
On Dec 20, 2011, at 7:23 AM, huangxueqing wrote: As guys know, there two implement of plug-in in webkit, the first is located in WebKit/WebProcess/plugins and another in WebCore/plugins, safari5 use former and Chromium implement plug-in in separate process in webkit/support/glue/plugins.

Re: [webkit-dev] run-webkit-tests is moving to parallell testing by default (this weekend)

2011-12-05 Thread Adam Roben
On Dec 2, 2011, at 6:55 PM, Eric Seidel wrote: The SnowLeopard bot went from a 1 hr 4 min (!?!) cycle time, to 38 min (still !?!). I suspect our Mac test bots could use a dose of RAM. Many of them only have 3GB, since when you're running tests one by one you don't really need much more.

Re: [webkit-dev] [GTK] Buildslave changes

2011-11-30 Thread Adam Roben
On Nov 30, 2011, at 4:34 PM, Philippe Normand wrote: Can we get new buildbot credentials for the new slave or can we reuse the 32-bits Debug ones? It'd be great if we can coordinate on this migration soon :) Credentials are a slave name/password pair. If you're using the old slave name for

Re: [webkit-dev] Hanging builds

2011-11-29 Thread Adam Roben
On Nov 28, 2011, at 6:35 PM, Adam Roben wrote: On Nov 26, 2011, at 3:34 AM, Nikolas Zimmermann wrote: Good morning WebKit folks, I'm looking at build.webkit.org/waterfall, and see several bots which are idle, but still report building 1min pretending they would do something. Does any

Re: [webkit-dev] failed to upload a patch to bugs.webkit.org by webkit-patch!

2011-11-28 Thread Adam Roben
On Nov 28, 2011, at 10:13 AM, Hongbo Min wrote: Failed to assign bug to you (can't find assigned_to) control. Do you have EditBugs privileges at bugs.webkit.org? https://bugs.webkit.org/userprefs.cgi?tab=permissions If not, you should email webkit-committ...@lists.webkit.org or ask in

Re: [webkit-dev] Hanging builds

2011-11-28 Thread Adam Roben
On Nov 26, 2011, at 3:34 AM, Nikolas Zimmermann wrote: Good morning WebKit folks, I'm looking at build.webkit.org/waterfall, and see several bots which are idle, but still report building 1min pretending they would do something. Does any of our build.webkit.org masters know the cause of

Re: [webkit-dev] 8 Bit Strings Turned On in JavaScriptCore

2011-11-18 Thread Adam Roben
On Nov 18, 2011, at 2:14 PM, Michael Saboff wrote: Although the UChar* characters() method for the various string classes still works, all new code should check what flavor a string is constructed by using the new is8Bit() method on the various string classes. After determining the

[webkit-dev] Could use some help from SVG and Web Workers experts on leak hunting

2011-11-18 Thread Adam Roben
Hi all- Darin Adler's been helping me sift through the leaks we're seeing on the Lion Intel Leaks bot. (You can see the results of a recent run here: http://build.webkit.org/LeaksViewer/?url=%2Fresults%2FLion%20Intel%20Leaks%2Fr100768%20%28193%29%2F.) We could use some expert advice for two of

Re: [webkit-dev] NRWT Migration Update

2011-10-21 Thread Adam Roben
On Oct 21, 2011, at 7:33 AM, Eric Seidel wrote: The WK2 bot looks stable (possibly more stable than before) after the NRWT switchover: http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(WebKit2%20Tests)/r98091%20(15558)/results.html Awesome! I'll work on switching the --leaks

Re: [webkit-dev] NRWT Migration Update

2011-10-21 Thread Adam Roben
On Oct 21, 2011, at 9:41 AM, SravanKumar Sandela wrote: Can you please inform us, what are the major difference between NRWT and ORWT. I think it would of lot help for people like me who worked on ORWT long back and now to catch up with NRWT. This page gives a good explanation:

Re: [webkit-dev] Style guide should mention that we don't use anonymous namespace

2011-10-20 Thread Adam Roben
On Oct 19, 2011, at 9:56 PM, Ryosuke Niwa wrote: On Wed, Oct 19, 2011 at 6:32 PM, Adam Barth aba...@webkit.org wrote: On Wed, Oct 19, 2011 at 6:24 PM, Ryosuke Niwa rn...@webkit.org wrote: Also... VC++'s debugger happens to have some issues around unnamed namespaces:

Re: [webkit-dev] Reg: Build break on latest Trunk!

2011-10-12 Thread Adam Roben
On Oct 12, 2011, at 3:15 AM, just2 contribute wrote: Has anybody tried building the latest webkit-trunk for Safari on windows? I am getting some build errors while building WebCore :) Can anybody share the latest working SVN Revision Number that I can try?

Re: [webkit-dev] Features defines: Platform.h vs build system

2011-10-03 Thread Adam Roben
On Oct 3, 2011, at 10:51 AM, Darin Adler wrote: But a while back, Maciej outlined a concept for where to put these platform base include files; I don’t remember when that was or what the details were. I think the plan is outlined here: http://trac.webkit.org/wiki/Porting%20Macros%20plan.

Re: [webkit-dev] Making top-level style changes through window.internals

2011-09-29 Thread Adam Roben
On Sep 29, 2011, at 11:37 AM, Fady Samuel wrote: pageScaleFactor is a document level CSS scaling style. Often times, we'd like to be able to apply style at the document level when writing layout tests. As far as I'm aware, there's no way to do this in javascript in a layout test? Is this

Re: [webkit-dev] Help with a possible Webkit bug

2011-09-26 Thread Adam Roben
This isn't the right mailing list for a question like this. http://www.webkit.org/contact.html explains the different mailing lists. But probably the best thing to do in a case like this is to file a bug at http://webkit.org/new-bug. -Adam ___

Re: [webkit-dev] Not able to play flash with windows webkit

2011-09-23 Thread Adam Roben
On Sep 23, 2011, at 9:36 AM, vswap 65 wrote: After little more investigation I found that the issue is with the mimetype not with the flash plugin. When the NP flash plugini.e., npswf.dll is installed, webkit is loading the dll and playing the flash with if the mimetype is changed to

Re: [webkit-dev] Do you maintain OS(WINCE)?

2011-09-13 Thread Adam Roben
On Sep 13, 2011, at 12:07 PM, Leandro Pereira wrote: Antonio, On 09/13/2011 04:00 PM, Antonio Gomes wrote: I believe it was maintained by Torch Mobile, and, according to George Staikos, it is not part of the plans any more (Torch was acquired by RIM). AFAIR, Patrick Gansterer

Re: [webkit-dev] run-bindings-tests

2011-09-09 Thread Adam Roben
On Sep 9, 2011, at 10:52 AM, Eric Seidel wrote: On Thu, Sep 8, 2011 at 12:44 PM, Darin Adler da...@apple.com wrote: On Sep 8, 2011, at 12:29 PM, Eric Seidel wrote: I'm happy to write a run-all-tests script which runs all known tests that platform can handle. :) I think run-webkit-tests

Re: [webkit-dev] run-bindings-tests

2011-09-09 Thread Adam Roben
On Sep 9, 2011, at 10:59 AM, Adam Roben wrote: On Sep 9, 2011, at 10:52 AM, Eric Seidel wrote: On Thu, Sep 8, 2011 at 12:44 PM, Darin Adler da...@apple.com wrote: On Sep 8, 2011, at 12:29 PM, Eric Seidel wrote: I'm happy to write a run-all-tests script which runs all known tests

Re: [webkit-dev] make-script-test-wrappers not being maintained

2011-09-08 Thread Adam Roben
On Sep 8, 2011, at 10:58 AM, Eric Seidel wrote: We could also teach DumpRenderTree to lie about what / is, so we could include the scripts like this: script href=/fast/js/resources/js-test-pre.js By the time DRT sees that URL it will already have been resolved against the base URL of the

Re: [webkit-dev] Code Search for webkit.org

2011-09-08 Thread Adam Roben
On Sep 8, 2011, at 5:52 PM, Eric Seidel wrote: I'm curious how other developers search the WebKit code? I use http://codesearch.google.com/#search/q=package:webkit from time to time. If others do too, we should make it a redirect from cs.webkit.org (like we do for cia.webkit.org). Or

Re: [webkit-dev] PSA: Removing support for Apache 1.3 in WebKit

2011-07-12 Thread Adam Roben
On Jul 11, 2011, at 9:33 PM, Eric Seidel wrote: Eventually we might transition the cygwin port to Apache2 https://bugs.webkit.org/show_bug.cgi?id=22517 discusses this a little bit. -Adam ___ webkit-dev mailing list webkit-dev@lists.webkit.org

[webkit-dev] Update on commit messages (was: Re: Proposal: Commit messages should start with a one-line summary of the change)

2011-07-08 Thread Adam Roben
On Jul 1, 2011, at 10:38 AM, Adam Roben wrote: On Jun 30, 2011, at 7:52 PM, Darin Adler wrote: I do think that given the tools behavior you described, we should move the reviewer text after the bug title and patch description paragraph, even though you explicitly said that’s not what you

Re: [webkit-dev] New page for viewing test failures on build.webkit.org

2011-07-08 Thread Adam Roben
I've been working a bit more on TestFailures over the last few weeks, and it's grown a few new features [1]. I encourage you to check it out if you haven't, and even if you have! http://build.webkit.org/TestFailures/ -Adam 1. Including: * Basic support for detecting flaky tests * Basic

Re: [webkit-dev] Switching to new-run-webkit-tests

2011-07-07 Thread Adam Roben
On Jul 7, 2011, at 2:55 AM, Eric Seidel wrote: One of the Leopard Debug slaves (apple-mac-pro-6) is still wedged after the transition: http://build.webkit.org/builders/Leopard%20Intel%20Debug%20%28Tests%29/builds/32142/steps/layout-test/logs/stdio If someone could run killall httpd, or just

Re: [webkit-dev] Is there special setup needed to run the WebKit2 tests?

2011-07-07 Thread Adam Roben
On Jul 7, 2011, at 12:01 AM, Eric Seidel wrote: old-run-webkit-tests -2 --debug produces: 107 test cases (1%) had incorrect layout 1 test case (1%) crashed 8 test cases (1%) Web process crashed 24 test cases (1%) had stderr output new-run-webkit-tests -2 --debug (which is what I'm

Re: [webkit-dev] Switching to new-run-webkit-tests

2011-07-06 Thread Adam Roben
Now that more and more ports are switching to NRWT, it would be great for someone to explain what the best practices are for dealing with failing and flaky tests. -Adam ___ webkit-dev mailing list webkit-dev@lists.webkit.org

Re: [webkit-dev] Switching to new-run-webkit-tests

2011-07-06 Thread Adam Roben
On Jul 6, 2011, at 11:53 AM, Adam Roben wrote: Now that more and more ports are switching to NRWT, it would be great for someone to explain what the best practices are for dealing with failing and flaky tests. Two specific questions I have: 1) Are the ports that have switched to NRWT

Re: [webkit-dev] Best practices for failing a flaky tests (was Re: Switching to new-run-webkit-tests)

2011-07-06 Thread Adam Roben
On Jul 6, 2011, at 11:58 AM, Adam Barth wrote: I'm not sure we've quite figured that out yet. NRWT supports both Skipped lists and test_expectations.txt, which is a more expressive (but also more complex) version of Skipped lists. IMHO, we should wait for the dust to settle on the

Re: [webkit-dev] Fixing the Platform fields in Bugzilla

2011-07-05 Thread Adam Roben
On Jul 5, 2011, at 12:41 PM, Simon Fraser wrote: Can we clean this up? Definitely! It's easy to change the options for these two fields. I don't know what would be involved with replacing these two fields with something else entirely. Do you have a proposal? -Adam

Re: [webkit-dev] Proposal: Commit messages should start with a one-line summary of the change

2011-07-01 Thread Adam Roben
On Jun 30, 2011, at 7:52 PM, Darin Adler wrote: I don’t think it’s a good idea to add yet another thing to every change log entry. I wouldn't consider this something being added. Most ChangeLog entries (the good ones, anyway) already contain a description of the fix in addition to the bug

Re: [webkit-dev] Proposal: Commit messages should start with a one-line summary of the change

2011-07-01 Thread Adam Roben
On Jul 1, 2011, at 11:57 AM, Julien Chaffraix wrote: I don’t think it’s a good idea to add yet another thing to every change log entry. I wouldn't consider this something being added. Most ChangeLog entries (the good ones, anyway) already contain a description of the fix in addition to

[webkit-dev] Does NRWT let you indicate that a test should fail with a particular failure diff?

2011-07-01 Thread Adam Roben
When a test starts failing on a bot that uses old-run-webkit-tests, we typically check in expected failure results for that test (e.g., http://trac.webkit.org/changeset/90235). That way we can find out if the test's behavior changes in the future even though the test is still failing. This is

[webkit-dev] Does NRWT let you indicate that a test should fail with a particular failure diff?

2011-07-01 Thread Adam Roben
When a test starts failing on a bot that uses old-run-webkit-tests, we typically check in expected failure results for that test (e.g., http://trac.webkit.org/changeset/90235). That way we can find out if the test's behavior changes in the future even though the test is still failing. This is

[webkit-dev] Proposal: Commit messages should start with a one-line summary of the change

2011-06-30 Thread Adam Roben
.), and work much better when that is the case. Since our commit messages are almost always just a copy of our ChangeLog entries, this should apply to ChangeLog entries too. Specifically, I suggest one line be added to our ChangeLog template, yielding the following: 2011-06-30 Adam Roben aro

Re: [webkit-dev] Proposal: Commit messages should start with a one-line summary of the change

2011-06-30 Thread Adam Roben
On Jun 30, 2011, at 5:10 PM, Mark Rowe wrote: Most ChangeLog entries already have a one-line summary immediately after the Reviewed by line. I'm not sure that there's any benefit to reordering these parts of the ChangeLog. Most ChangeLog entries have the bug title after the Reviewed by

Re: [webkit-dev] Proposal: Commit messages should start with a one-line summary of the change

2011-06-30 Thread Adam Roben
On Jun 30, 2011, at 5:00 PM, Dirk Pranke wrote: Sounds good to me, except I wonder how often you'd get Fixed bug where where XXX is the bug summary. I think this is something that reviewers would have to encourage authors not to do, just like reviewers should be encouraging authors to

Re: [webkit-dev] Proposed Windows Drawing Change (WebNodeHighlight) Logic

2011-06-27 Thread Adam Roben
On Jun 27, 2011, at 1:55 AM, Simon Fraser wrote: This should go into a bug. Agreed. On Jun 26, 2011, at 4:12 PM, Brent Fulgham wrote: While investigating a separate issue, I noticed that I was hitting an assertion in the Cairo drawing layer because it was attempting to use an invalid

Re: [webkit-dev] New page for viewing test failures on build.webkit.org

2011-06-20 Thread Adam Roben
http://webkit.org/b/61059 is about. -Adam On Wed, Jun 1, 2011 at 12:22 PM, Adam Roben aro...@apple.com wrote: Hi all- Before I go on vacation for 2.5 weeks, I wanted to let you know about a new page I've been working on on build.webkit.org. You can see it here: http://build.webkit.org

Re: [webkit-dev] Different Versions of WebkitSupportLibrary.zip

2011-06-20 Thread Adam Roben
On Jun 1, 2011, at 8:38 PM, Brian Stuart wrote: Hi All, I am trying to build a fork of WebKit on windows that requires a version of WebKitSupportLibrary.zip different than the one currently available from http://developer.apple.com/opensource/internet/webkit_sptlib_agree.html In the

Re: [webkit-dev] Different Versions of WebkitSupportLibrary.zip

2011-06-20 Thread Adam Roben
and WebKitSupportLibrary.zip. Hopefully it will work with your old version of WebKit without requiring too many changes. -Adam On Jun 20, 2011, at 8:00 PM, Adam Roben wrote: On Jun 1, 2011, at 8:38 PM, Brian Stuart wrote: Hi All, I am trying to build a fork of WebKit on windows that requires

[webkit-dev] New page for viewing test failures on build.webkit.org

2011-06-01 Thread Adam Roben
Hi all- Before I go on vacation for 2.5 weeks, I wanted to let you know about a new page I've been working on on build.webkit.org. You can see it here: http://build.webkit.org/TestFailures/ The idea of the page is to provide a single place to go to find out what tests are failing on the

Re: [webkit-dev] Verifying changes to build.webkit.org-config/master.cfg locally

2011-05-23 Thread Adam Roben
On May 20, 2011, at 8:22 PM, Dmitry Lomov wrote: I am trying to make run-api-tests run at build time. I wonder what is the right way to verify my changes locally (aka what do I run to simulate build on bots locally?) Here are instructions I was given by Bill Siegrist (_wms) a while back:

Re: [webkit-dev] New feature - MHTML support

2011-05-12 Thread Adam Roben
On May 2, 2011, at 6:03 PM, Eric Seidel wrote: MHTML support was definitely discussed at length back in the early days of Safari Windows development in webkit.org. Maybe that desire has gone away since then. I feel very out-of-touch with current Safari-on-Windows needs. We've had requests

Re: [webkit-dev] Correct relative URL behavior

2011-05-04 Thread Adam Roben
On May 4, 2011, at 2:42 PM, Adam Barth wrote: I wish I could make script tests that didn't output PASS/FAIL What's stopping you? -Adam ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] new-run-webkit-tests new results.html format

2011-05-03 Thread Adam Roben
On May 3, 2011, at 4:01 PM, Ojan Vafai wrote: The results load considerably faster now. For runs where many tests fail, the filesize is considerably smaller than the old-run-webkit-tests filesize. Also, I've added in the image toggling behavior of old-run-webkit-tests and made the

Re: [webkit-dev] Some compile time data

2011-04-26 Thread Adam Roben
On Apr 26, 2011, at 1:30 PM, David Kilzer wrote: On Apr 25, 2011, at 4:59 PM, Stephanie Lewis wrote: One point brought up during the compile time discussion today was that if you pulled once a day, you were likely to have rebuild the world. I thought it would be interesting to see which

Re: [webkit-dev] Platform LayoutTests are out of control

2011-04-21 Thread Adam Roben
On Apr 21, 2011, at 2:41 AM, Brent Fulgham wrote: I think it's just been especially bad the last few days. I believe this is because Tony Chang has been working on converting existing pixel results to have embedded checksums, rather than out-of-line .checksum files. This is a one-time

Re: [webkit-dev] [webkit-changes] [83955] trunk

2011-04-15 Thread Adam Roben
On Apr 15, 2011, at 1:19 PM, Oliver Hunt wrote: Don't roll out patches that don't break any core builders, without making some attempt to diagnose the problem or providing information that will make it possible to fix the problem. The GTK bots are core builders. -Adam

[webkit-dev] All webkit.org services seem to be down

2011-04-06 Thread Adam Roben
Hi Bill- bugs.webkit.org, svn.webkit.org, www.webkit.org, trac.webkit.org all seem to be down. Is this expected? Any idea when they might return? Thanks! -Adam ___ webkit-dev mailing list webkit-dev@lists.webkit.org

Re: [webkit-dev] Many crashs of regresion tests in 64-bit Windows

2011-04-06 Thread Adam Roben
On Apr 6, 2011, at 12:25 PM, Pere Martir wrote: On Tue, Apr 5, 2011 at 7:10 PM, Adam Roben aro...@apple.com wrote: The best way to report a bug like this is to file a new bug at http://webkit.org/new-bug. In this case, this is a known issue (http://webkit.org/b/52913), so you don't need

Re: [webkit-dev] LayoutTest failures on Windows due to fonts/metric (yet again, any update?)

2011-04-06 Thread Adam Roben
On Apr 6, 2011, at 7:43 AM, Pere Martir wrote: I am working on Windows and I am planning to submit some patches (plugin loading) but I have problem make all regression tests (run-webkit-tests) pass without unmodified code. I followed all the instructions:

Re: [webkit-dev] Many crashs of regresion tests in 64-bit Windows

2011-04-05 Thread Adam Roben
On Apr 5, 2011, at 1:02 PM, Pere Martir wrote: 64-bit Window 7. run-webkit-tests reported that many tests crashed, in addition to many other failures due to the metric difference. Command line: Tools/Scripts/run-webkit-tests compositing/iframes Tests that caused DumpRenderTree tool

Re: [webkit-dev] Many crashs of regresion tests in 64-bit Windows

2011-04-05 Thread Adam Roben
On Apr 5, 2011, at 1:17 PM, Pere Martir wrote: On Tue, Apr 5, 2011 at 7:10 PM, Adam Roben aro...@apple.com wrote: The best way to report a bug like this is to file a new bug at http://webkit.org/new-bug. In this case, this is a known issue (http://webkit.org/b/52913), so you don't need

Re: [webkit-dev] Can we show failing test list on waterfall?

2011-04-02 Thread Adam Roben
On Apr 2, 2011, at 4:59 AM, Ryosuke Niwa rn...@webkit.org wrote: On Fri, Apr 1, 2011 at 2:54 PM, Adam Barth aba...@webkit.org wrote: Can we show the list of failing layout tests in buildbot's waterfall display so we don't have to click through to the results.html file? Also, can we change

[webkit-dev] Progress

2011-04-01 Thread Adam Roben
-Adam ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Progress

2011-04-01 Thread Adam Roben
On Apr 1, 2011, at 10:03 AM, Dimitri Glazkov wrote: I know that Adam Barth was the driving force behind this, since it was his turn at gardening WebKit (that's a Chromium thing http://www.chromium.org/developers/how-tos/webkit-merge-1). I wonder if we as a community would benefit from a

Re: [webkit-dev] Progress

2011-04-01 Thread Adam Roben
Major kudos to Adam (Barth) for all his gardening efforts this week! (Somehow this slipped out of my previous message.) -Adam ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] UA string changes blog draft

2011-03-25 Thread Adam Roben
On Mar 25, 2011, at 1:53 PM, Peter Kasting wrote: UA String Changes On WebKit Trunk Posted by Peter Kasting on Friday, March 25th, 2011 at 10:44 am Recently some changes to the UA string (tracked by https://bugs.webkit.org/show_bug.cgi?id=54556) have landed. These changes are designed to

[webkit-dev] New tool: Leaks Viewer

2011-03-18 Thread Adam Roben
Hi all- Over the last two weeks I've been working on a new tool for viewing leaks output from the SnowLeopard Intel Leaks bot. You can see it here: http://build.webkit.org/LeaksViewer/ (screenshot below). It uses the Inspector's Profiles panel code to present leak

Re: [webkit-dev] cairo build fails on r81169

2011-03-17 Thread Adam Roben
On 3/16/2011 11:36 PM, Brent Fulgham wrote: Can build-bot be trained to grab that file from another directory? Yes. Set the WEBKITSUPPORTLIBRARIESZIPDIR environment variable to a Windows-style absolute path pointing to the directory that contains WebKitSupportLibrary.zip. -Adam

Re: [webkit-dev] cairo build fails on r81169

2011-03-16 Thread Adam Roben
On 3/16/2011 4:18 PM, Adam Barth wrote: Please file a bug: https://bugs.webkit.org/enter_bug.cgi?product=WebKit I don't believe the cairo port has a buildbot (please correct me if I'm wrong). That means developers have no way of knowing if they breaking the port and will have trouble keeping

Re: [webkit-dev] SnowLeopard debug buildbot not there

2011-03-10 Thread Adam Roben
On Mar 10, 2011, at 3:40 PM, Adam Barth wrote: On Thu, Mar 10, 2011 at 12:33 PM, Mark Rowe mr...@apple.com wrote: On 2011-03-10, at 12:27, Adam Barth wrote: On Thu, Mar 10, 2011 at 12:11 PM, Mark Rowe mr...@apple.com wrote: On 2011-03-10, at 12:08, David Levin wrote: tL;dr Why isn't there a

Re: [webkit-dev] SnowLeopard debug buildbot not there

2011-03-10 Thread Adam Roben
By the way, I've been starting to look at leaks a little bit lately. I've filed these so far: http://webkit.org/b/55602 REGRESSION (r79817): Lots of leaks of FloatingObjects seen on SnowLeopard Intel Leaks bot -- this one has been fixed http://webkit.org/b/56045 Many leaks seen

Re: [webkit-dev] SnowLeopard debug buildbot not there

2011-03-10 Thread Adam Roben
On Mar 10, 2011, at 3:51 PM, Adam Roben wrote: I'm also planning to file a bug about CoreText-related leaks beneath GlyphPage::fill. http://webkit.org/b/56136 CoreText-related leaks seen beneath GlyphPage::fill -Adam ___ webkit-dev mailing

[webkit-dev] A tip for committers

2011-03-03 Thread Adam Roben
All committers are encouraged to follow the instructions I just added to http://trac.webkit.org/wiki/CommitterTips#Walkingyouthroughyourfirstcommit: Subversion has a handy feature called auto-props that will ensure that new binary files you add to the repository are given the correct MIME

Re: [webkit-dev] A tip for committers

2011-03-03 Thread Adam Roben
On Mar 3, 2011, at 11:40 AM, Oliver Hunt wrote: Can the style bot be made aware of .png at least and complain if you don't set the right flags? Subversion properties aren't captured in patches, so the style bot is too early in the process. We could add a pre-commit hook to check for the

Re: [webkit-dev] What is Alias on Bugzilla?

2011-03-02 Thread Adam Roben
On Mar 2, 2011, at 2:33 AM, Ryosuke Niwa wrote: I just realized that there's a new field labelled Alias on https://bugs.webkit.org/enter_bug.cgi?product=WebKit Why is this field added and what should I put in this field? The Alias field allows a bug to be referred to by something other

[webkit-dev] All Apple Mac and Windows testers now upload crash logs

2011-03-02 Thread Adam Roben
Hi all- All of Apple's Mac and Windows test bots should now be uploading crash logs to build.webkit.org [1]. The crash logs are linked to from results.html (e.g., http://build.webkit.org/results/Windows%20XP%20Debug%20(Tests)/r80125%20(25890)/results.html). If you see a crash on one of Apple's

[webkit-dev] Criteria for becoming a core builder

2011-03-02 Thread Adam Roben
Hi all- I'd like to understand better what the criteria are for a builder to become a core builder. We've been putting lot of effort into keeping the Windows testers green lately (especially the Windows 7 Release (Tests) builder), and it seems like it would be good for them to eventually join

Re: [webkit-dev] All Apple Mac and Windows testers now upload crash logs

2011-03-02 Thread Adam Roben
On Mar 2, 2011, at 1:41 PM, Eric Seidel wrote: Does this require special configuration on the bots, or should run-webkit-tests be copying crash logs into layout-test-results for all Snow Leopard machines? run-webkit-tests should be copying crash logs into layout-test-results for all Snow

Re: [webkit-dev] Criteria for becoming a core builder

2011-03-02 Thread Adam Roben
they haven't been green in weeks (even though I'm sure we wish it would be green). The Leopard Debug bots are non-core now. The Release ones are still core for the moment. -Adam On Wed, Mar 2, 2011 at 9:51 AM, Adam Roben aro...@apple.com wrote: Hi all- I'd like to understand better what the criteria

Re: [webkit-dev] All Apple Mac and Windows testers now upload crash logs

2011-03-02 Thread Adam Roben
On Mar 2, 2011, at 1:41 PM, Eric Seidel wrote: the EWS and commit-queue snow leopard machines do not seem to be copying crash logs into layout-test-results like I would expect: https://bugs.webkit.org/show_bug.cgi?id=51138 (each of those zips are made from /tmp/layout-test-results after the

Re: [webkit-dev] Towards a unified build system

2011-03-01 Thread Adam Roben
Reducing the number of build systems is a face-meltingly worthy goal. I have one small question: On Mar 1, 2011, at 4:21 AM, Adam Barth wrote: 3) Remove the xcodeproj files from svn.webkit.org and integrate the generation of xcodeproj files with the WebKit build / update scripts. At this

Re: [webkit-dev] when will pages group into different PageGroup

2011-02-24 Thread Adam Roben
On Feb 24, 2011, at 1:44 AM, tomorrow chen wrote: I'm reading source about Page class.I found there's related class named PageGroup,which seems to group different pages into different group by name. Different PageGroup has different user script and GroupSetting. I wonder when will the

Re: [webkit-dev] Leopard Debug

2011-02-24 Thread Adam Roben
On Feb 24, 2011, at 12:59 AM, Adam Barth wrote: As far I as I can tell, Leopard Debug is not consistently green: http://build.webkit.org/waterfall?show=Leopard%20Intel%20Debug%20(Build) In fact, it's been failing to build much more often than not for an extended period of time (i.e.,

Re: [webkit-dev] Slave lost on SnowLeopard Intel Release (Build)

2011-02-24 Thread Adam Roben
On Feb 24, 2011, at 4:11 AM, Ryosuke Niwa wrote: I realized that the build was 13 hours behind and wasn't making any progress in compiling r79464 so I force stopped the build but then the slave got lost along the way. In the retrospect, I should have been more careful. I apologize for

Re: [webkit-dev] More information for crashing tests now available on build.webkit.org

2011-02-07 Thread Adam Roben
On Feb 7, 2011, at 7:20 AM, Alejandro Garcia Castro wrote: On Fri, Feb 04, 2011 at 02:25:10PM -0500, Adam Roben wrote: Hi all- [...] Please file any bugs you find with this feature on bugs.webkit.org, and CC me. Please also file bugs for any ideas you have for making this more useful

[webkit-dev] More information for crashing tests now available on build.webkit.org

2011-02-04 Thread Adam Roben
Hi all- The results.html pages on build.webkit.org now make it much easier to triage crashing tests on Mac and Windows XP (Windows Vista/7 are blocked by http://webkit.org/b/44135). When a test crashes, you'll see something like this on Mac: fast/events/tabindex-focus-blur-all.html

Re: [webkit-dev] More information for crashing tests now available on build.webkit.org

2011-02-04 Thread Adam Roben
On Feb 4, 2011, at 2:25 PM, Adam Roben wrote: The new crash log link will take you to a textual crash log for that test. And on Windows, the crashing line of code is even included in the log, like this: FAULTING_SOURCE_CODE: 105: 106: void Instance::willDestroyRuntimeObject

Re: [webkit-dev] More information for crashing tests now available on build.webkit.org

2011-02-04 Thread Adam Roben
free to file a bug! -Adam On 11-02-04 02:25 PM, Adam Roben wrote: Hi all- The results.html pages on build.webkit.org now make it much easier to triage crashing tests on Mac and Windows XP (Windows Vista/7 are blocked by http://webkit.org/b/44135). When a test crashes, you'll see something

Re: [webkit-dev] safari extension script loading within injected file

2011-02-02 Thread Adam Roben
This list is for discussion of the development of the WebKit project itself, not questions about how to use WebKit (or a browser that uses WebKit, such as Safari). See http://webkit.org/contact.html for details. You'll have better luck asking in a Safari-specific venue, such as

[webkit-dev] svn.webkit.org and nightly.webkit.org down ahead of schedule?

2011-02-02 Thread Adam Roben
Hi Bill- svn.webkit.org is responding to pings, but svn up just hangs. And nightly.webkit.org responds to pings, but never finishes loading when navigated to in a browser. Is this expected? Do you know when they'll be available again? Thanks! -Adam On Feb 1, 2011, at 8:52 PM, William

Re: [webkit-dev] Using Visual Studio 2010 for Apple's Windows WebKit port

2011-02-01 Thread Adam Roben
. Patrick Gansterer offered to code up a patch to build Apple's Windows port using the existing CMake build system, which will be very interesting to see! -Adam On Mon, Jan 31, 2011 at 12:46 PM, Adam Roben aro...@apple.com wrote: On Jan 31, 2011, at 3:41 PM, Peter Kasting wrote: On Mon, Jan 31

[webkit-dev] Using Visual Studio 2010 for Apple's Windows WebKit port

2011-01-31 Thread Adam Roben
Hi all- We'd like to switch Apple's Windows WebKit port to build with Visual Studio 2010 sometime in the next 6-8 months, and to drop support for building with Visual Studio 2005 at the same time. The biggest consequence of this will be that anyone wishing to build Apple's Windows port will

Re: [webkit-dev] Using Visual Studio 2010 for Apple's Windows WebKit port

2011-01-31 Thread Adam Roben
On Jan 31, 2011, at 3:41 PM, Peter Kasting wrote: On Mon, Jan 31, 2011 at 12:30 PM, Adam Roben aro...@apple.com wrote: Please let me (and the list) know if this change will cause you trouble, and if there's something we can do to make the transition easier. This may make life hard

Re: [webkit-dev] Potential patch for building webkit on Visual Studio 2010

2010-12-15 Thread Adam Roben
On Dec 14, 2010, at 8:24 PM, Jake wrote: Hello, I've made some changes to the webkit trunk that allows me to build webkit (more specifically QtWebkit) with Visual Studio 2010. I had to make several changes to handle the ambiguous operator = error from NullPtr.h. To get the build to

Re: [webkit-dev] JSRetainPtr and JSStringRef

2010-12-15 Thread Adam Roben
On Dec 15, 2010, at 9:13 AM, John Knottenbelt wrote: I'm looking at adding a method on the LayoutTestController in DumpRenderTree that will return a string. I see that some methods there return JSRetainPtrJSStringRef and some just return JSStringRef. Can anybody comment on when it is

  1   2   3   4   >