Re: [webkit-dev] Reminder: include everything that you use in implementation files

2020-11-12 Thread Adrian Perez de Castro via webkit-dev
Hello Peng, On Wed, 11 Nov 2020 12:05:18 -0800 "Peng (WebKit) Liu via webkit-dev" wrote: > Any way/option to turn off the unified build completely or partially in a > local build? That would be very helpful for a developer to locally verify > that header files are included correctly in a

[webkit-dev] Build bot workers aperez-{wpe, gtk}-ews to be rebooted for maintenance

2020-11-11 Thread Adrian Perez de Castro via webkit-dev
Hi all, Quick PSA: the two build bot workers I run will be brought down for a short period of time at 05:30 PST due to a kernel update; the machine where they are hosted is going to be rebooted. Most likely this will take only a few minutes =) Cheers, —Adrián pgpLIHd8suLcc.pgp Description: PGP

Re: [webkit-dev] Build bot workers aperez-{wpe, gtk}-ews to be rebooted for maintenance

2020-11-11 Thread Adrian Perez de Castro via webkit-dev
On Fri, 06 Nov 2020 15:05:59 +0200 Adrian Perez de Castro wrote: > Quick PSA: the two build bot workers I run will be brought down for a short > period of time at 05:30 PST due to a kernel update; the machine where they > are hosted is going to be rebooted. Most likely this will

Re: [webkit-dev] Removing ACCELERATED_2D_CANVAS

2020-10-13 Thread Adrian Perez de Castro
Hello, On Tue, 13 Oct 2020 14:36:11 +0200 z...@falconsigh.net wrote: > ACCELERATED_2D_CANVAS feature right now is only implemented for ports using > Cairo. Of those ports, I can only guarantee for the GTK and WPE ports that > it works to some degree. The implementation relies on a GL-oriented

Re: [webkit-dev] WebKit Transition to Git

2020-10-07 Thread Adrian Perez de Castro
On Tue, 06 Oct 2020 11:15:05 -0700 Jonathan Bedard wrote: > Seems like most large projects are using some sort of bot or action to solve > this problem: https://github.com/isaacs/github/issues/581 > . Wow, “there's a bot for that” seems to be the

Re: [webkit-dev] WebKit Transition to Git

2020-10-07 Thread Adrian Perez de Castro
Hi there, There is one more annoyance I am adding below Konstantin's list… On Tue, 06 Oct 2020 03:13:32 +0300 Konstantin Tokarev wrote: > 05.10.2020, 23:41, "Yusuke Suzuki" : > > I think security component is special in terms of how to handle it already > > (e.g. not posting a test with the

Re: [webkit-dev] WebKit Transition to Git

2020-10-07 Thread Adrian Perez de Castro
On Sun, 04 Oct 2020 02:00:02 +0300 Konstantin Tokarev wrote: > 03.10.2020, 21:49, "Adrien Destugues" : > > Yes that's why I didn't elaborate much. Whichever tool you pick, there > > will always be people unhappy about it. > > Right. For example, I have negative bias against GitLab, because

Re: [webkit-dev] WebKit Transition to Git

2020-10-07 Thread Adrian Perez de Castro
Hello, On Fri, 02 Oct 2020 13:48:56 -0700 Ken Russell wrote: > Excited about this migration! One comment inline. > > On Fri, Oct 2, 2020 at 9:43 AM Jonathan Bedard wrote: > > > *Patches to Pull Requests* > > In the coming months, more automation will start using the git version of > > the

Re: [webkit-dev] WebKit Transition to Git

2020-10-07 Thread Adrian Perez de Castro
Hello, On Sun, 04 Oct 2020 01:57:56 -0700 Yusuke Suzuki wrote: > GitHub is planning to have review revisions in 2020/Q4. > So, when WebKit repository is migrated, we already have that in GitHub > builtin review tool :) > > https://github.com/github/roadmap/issues/54 >

Re: [webkit-dev] WebKit Transition to Git

2020-10-07 Thread Adrian Perez de Castro
Hi, On Tue, 06 Oct 2020 03:42:11 +0300 Konstantin Tokarev wrote: > 05.10.2020, 13:26, "Frédéric Wang" : > > One thing to take into account is that WebKit's repository is big and > > public GitHub/GitLab prevent creating large repository by default. This > > means it might not be possible for

Re: [webkit-dev] WebKit Transition to Git

2020-10-07 Thread Adrian Perez de Castro
Hello, On Wed, 07 Oct 2020 04:17:45 +0300 Konstantin Tokarev wrote: > 06.10.2020, 18:03, "Michael Catanzaro" : > > On Tue, Oct 6, 2020 at 3:13 am, Konstantin Tokarev > > wrote: > >>  1. Sub-par support for linking issues to each other > >>  

Re: [webkit-dev] WebKit Transition to Git

2020-10-07 Thread Adrian Perez de Castro
On Wed, 07 Oct 2020 08:58:58 -0500 Michael Catanzaro wrote: > On Wed, Oct 7, 2020 at 4:17 am, Konstantin Tokarev > wrote: > > BTW, could you estimate how many of users which have provided > > meaningful bug reports were directed to bugs.webkit.org but never > > made it? > > A lot. I'd say

Re: [webkit-dev] Generating compile_commands.json when building WebKit on MacOS

2020-07-22 Thread Adrian Perez de Castro
Hello, On Wed, 22 Jul 2020 14:42:07 +0100, Philippe Normand wrote: > On Wed, 2020-07-22 at 08:24 -0500, Michael Catanzaro wrote: > > On Wed, Jul 22, 2020 at 11:15 am, shriva...@firemail.cc wrote: > > > DerivedSources/ForwardingHeaders/JavaScriptCore/JSContext.h:40:1: > > > error: duplicate

Re: [webkit-dev] Plugin process

2020-07-20 Thread Adrian Perez de Castro
On Mon, 20 Jul 2020 09:35:24 -0500, Michael Catanzaro wrote: > On Mon, Jul 20, 2020 at 11:47 am, Adrian Perez de Castro > wrote: > > Our tentative plan for sunsetting the NPAPI support is to keep > > supporting > > the GTK3 plugin process in the next stable re

Re: [webkit-dev] Plugin process

2020-07-20 Thread Adrian Perez de Castro
Hi all, On Sun, 19 Jul 2020 15:49:37 -0700, Brent Fulgham wrote: > We haven’t removed it from Apple builds yet, because we think there are > still some WebKit clients that use them. I.e., WebKit framework users on the > platform that are not Safari or one of the other web browsers. For the GTK

Re: [webkit-dev] [webkit-changes] [264332] trunk/Source

2020-07-16 Thread Adrian Perez de Castro
On Thu, 16 Jul 2020 15:01:14 -0700, Darin Adler wrote: > > On Jul 16, 2020, at 2:28 PM, Adrian Perez de Castro > > wrote: > > > > It is not feasible to test unified builds for all the possible combinations > > of > > target architectures and s

Re: [webkit-dev] [webkit-changes] [264332] trunk/Source

2020-07-16 Thread Adrian Perez de Castro
t OTOH, as unlikely as it may seem, Slack could go bankrupt and/or the chat history vanish from one day to another. > On Fri, Jul 17, 2020 at 6:37 AM Adrian Perez de Castro > wrote: > > > Also, some packagers used to carry assorted downstream patches for build > > issues related

Re: [webkit-dev] [webkit-changes] [264332] trunk/Source

2020-07-16 Thread Adrian Perez de Castro
I forgot to mention one tidbit... On Fri, 17 Jul 2020 00:28:53 +0300, Adrian Perez de Castro wrote: > Hello everybody, > > On Thu, 16 Jul 2020 12:57:01 -0700, Darin Adler wrote: > > > On Jul 16, 2020, at 12:54 PM, Kirsling, Ross > > > wrote: > > > &g

Re: [webkit-dev] [webkit-changes] [264332] trunk/Source

2020-07-16 Thread Adrian Perez de Castro
Hello everybody, On Thu, 16 Jul 2020 12:57:01 -0700, Darin Adler wrote: > > On Jul 16, 2020, at 12:54 PM, Kirsling, Ross wrote: > > > > Non-unified build fixes are done to support *all* platforms, because > > sudden unification shifts can happen anywhere. > > I’m not sure that benefit is worth

Re: [webkit-dev] PSA: EWS bots aperez-{gtk, wpe}-ews offline for some days

2020-05-11 Thread Adrian Perez de Castro
Hi again, On Sat, 2 May 2020 00:04:37 +0300, Adrian Perez de Castro wrote: > Unfortunately, builders “aperez-gtk-ews” and “aperez-wpe-ews” will be offline > for a few days: it is sitting at the office, where nobody is going these days, > and I cannot get hold of it remotely. Ne

[webkit-dev] PSA: EWS bots aperez-{gtk, wpe}-ews offline for some days

2020-05-01 Thread Adrian Perez de Castro
Hello, Unfortunately, builders “aperez-gtk-ews” and “aperez-wpe-ews” will be offline for a few days: it is sitting at the office, where nobody is going these days, and I cannot get hold of it remotely. Next time I venture out I plan to stop by and bring it back online—but that may take until May

Re: [webkit-dev] Adrian Perez de Castro is now a WebKit reviewer

2019-10-17 Thread Adrian Perez de Castro
Hello WebKittens, On Mon, 14 Oct 2019 15:17:19 +0200, Carlos Alberto Lopez Perez wrote: > I would like to announce that Adrian Perez de Castro (aperezdc on #webkit) > is now a WebKit reviewer. > > Adrian has several years of experience working with the WebKitGTK and WPE > W

Re: [webkit-dev] Planned EWS improvements

2019-09-30 Thread Adrian Perez de Castro
Hello Aakash (and everybody else), On Thu, 26 Sep 2019 14:27:25 -0400, Aakash Jain wrote: > I have been making number of improvements to EWS. I also have various > planned improvements to EWS […] Thanks once again for your continued work on improving the EWS, it is much appreciated =) > Here

Re: [webkit-dev] Recent EWS improvements

2019-09-04 Thread Adrian Perez de Castro
Hello Aakash, WebKittens, On Thu, 29 Aug 2019 18:01:56 -0400, Aakash Jain wrote: > I want to update everyone with the further improvements I have made to new > EWS. As always, please feel free to provide any feedback (either by filing > bugs or contacting me directly). > > New Features: > >

Re: [webkit-dev] PSA: EWS bots aperez-{gtk, wpe}-ews down for the weekend

2019-08-19 Thread Adrian Perez de Castro
Hello again, On Mon, 19 Aug 2019 17:33:07 +0300, Adrian Perez de Castro wrote: > […] > > P.S: I have just noticed that “igalia3-gtk-wk2-ews” is down, so I'll take a > look into that one in a moment. This one is up again, too. Regards, -Adrián signature.asc Description: P

Re: [webkit-dev] PSA: EWS bots aperez-{gtk, wpe}-ews down for the weekend

2019-08-19 Thread Adrian Perez de Castro
Hello, On Fri, 16 Aug 2019 18:38:03 +0300, Adrian Perez de Castro wrote: > A firmware update has left my build machine unusable, but it looks > recoverable. I will try to get it back running next Monday when I am > back at the office (I will need physical access). After some

[webkit-dev] PSA: EWS bots aperez-{gtk, wpe}-ews down for the weekend

2019-08-16 Thread Adrian Perez de Castro
Hi all, A firmware update has left my build machine unusable, but it looks recoverable. I will try to get it back running next Monday when I am back at the office (I will need physical access). Sorry about the inconvenience. Cheers, -Adrián pgpQVIVTNIVVB.pgp Description: PGP signature

Re: [webkit-dev] Moving to Python 3

2019-07-12 Thread Adrian Perez de Castro
Hello, On Fri, 12 Jul 2019 12:37:43 -0700, Tim Horton wrote: > > On Jul 12, 2019, at 12:18 PM, Jonathan Bedard wrote: > > > > Hello WebKit developers, > > > > Now that the Catalina developer seeds are available, it is official that > > the new Mac developer tools come with Python 3. As a

Re: [webkit-dev] [CMake] Bump cmake_minimum_required version to 3.10

2019-06-27 Thread Adrian Perez de Castro
Hello, On Thu, 27 Jun 2019 08:36:22 +0200, Xan wrote: > Sorry about that. We'll take care of it ASAP. > > Cheers, > Xan > > On Thu, Jun 27, 2019, 06:23 Fujii Hironori wrote: > > > jsc-i368 EWS is still failing. > > Who is igalia-jsc-i386-ews bot maintainer? Done, this EWS has now CMake

Re: [webkit-dev] Windows 32-bit support?

2019-06-25 Thread Adrian Perez de Castro
I was mistaken about one thing (sorry!), please read below... On Tue, 25 Jun 2019 19:01:54 +0300, Adrian Perez de Castro wrote: > On Tue, 25 Jun 2019 10:42:04 -0500, Michael Catanzaro > wrote: > > It's great that you find our stable branches helpful, but keep in mind > >

Re: [webkit-dev] Windows 32-bit support?

2019-06-25 Thread Adrian Perez de Castro
On Tue, 25 Jun 2019 10:42:04 -0500, Michael Catanzaro wrote: > It's great that you find our stable branches helpful, but keep in mind > those branches do not include Windows-specific fixes. > > On Tue, Jun 25, 2019 at 9:53 AM, Arunprasad Rajkumar > wrote: > > Right. Actually the problem is

[webkit-dev] EWS bots aperez-{wpe, gtk}-gcc6-ews will be offline for some days

2019-03-28 Thread Adrian Perez de Castro
Hi WebKittens, These two EWS bots which I run on my build machine will be offline for some days due to an office relocation. The machine will be taken on Monday to its new location, but it may take a few days more for the bots to come online depending on how quick the ISP will be in setting up

Re: [webkit-dev] webkitgtk 2.22.6 tarball inaccessible

2019-03-22 Thread Adrian Perez de Castro
Hello, On Fri, 22 Mar 2019 11:59:46 -0700, "niveditha@oracle.com" wrote: > I am trying to download the webkitgtk 2.22.6 tarball from > https://webkitgtk.org/releases/webkitgtk-2.22.6.tar.xz > > and get "You don't have permission to access > /releases/webkitgtk-2.22.6.tar.xz on this

Re: [webkit-dev] Licensing terms for content from developer.apple.com

2019-03-21 Thread Adrian Perez de Castro
Hi again, On Tue, 19 Feb 2019 18:54:43 +0200, Adrian Perez de Castro wrote: > Lately we have been working on enabling the content extensions feature > in the GTK and WPE WebKit ports [1], and we would like to include in the > generated API documentation a reference of the JSON sour

Re: [webkit-dev] Queries regarding few Components in webkit

2019-03-17 Thread Adrian Perez de Castro
ose it would be good to contact them to coordinate :) Cheers, -Adrián > On Sun, Mar 17, 2019 at 8:59 PM Adrian Perez de Castro > wrote: > > > Hello, > > > > On Sun, 17 Mar 2019 09:08:10 -0500, Michael Catanzaro < > > mcatanz...@igalia.com> wrote: > >

Re: [webkit-dev] Queries regarding few Components in webkit

2019-03-17 Thread Adrian Perez de Castro
Hello, On Sun, 17 Mar 2019 09:08:10 -0500, Michael Catanzaro wrote: > It might be more realistic to try making an existing WebKit port work > on Haiku (either WebKitGTK or WPE WebKit) rather than try to create an > entirely new port. You are forgetting that there is an existing,

Re: [webkit-dev] Reminder regarding formatting uint64_t

2019-02-27 Thread Adrian Perez de Castro
Hello, On a related note... On Wed, 27 Feb 2019 16:35:39 -0600, Michael Catanzaro wrote: > For the past several years, I've been regularly fixing -Wformat > warnings that look like this: > > ../../Source/WebKit/WebProcess/WebPage/WebPage.cpp:3148:46: warning: > format ‘%llu’ expects

Re: [webkit-dev] Moving to Git

2019-02-20 Thread Adrian Perez de Castro
On Wed, 20 Feb 2019 22:30:22 +0300, Konstantin Tokarev wrote: > 20.02.2019, 22:27, "Bug Tracker" : > > > Sorry, for the anonymous email. I opted for it because the list archives > > are public and concluded that it's not that useful to reveal my identity > > for the purposes of this

[webkit-dev] Licensing terms for content from developer.apple.com

2019-02-19 Thread Adrian Perez de Castro
Hello WebKittens, Lately we have been working on enabling the content extensions feature in the GTK and WPE WebKit ports [1], and we would like to include in the generated API documentation a reference of the JSON source format which WebKit consumes. There is one page [2] at

Re: [webkit-dev] Rename AtomicString to AtomString

2019-01-30 Thread Adrian Perez de Castro
Hi, On Wed, 30 Jan 2019 08:31:49 -0800, Darin Adler wrote: > So, did we reach consensus that we should rename AtomicString to AtomString? Let's go with it  Cheers, -Adrián pgpCXmm7f6QX0.pgp Description: PGP signature ___ webkit-dev mailing list

Re: [webkit-dev] Don Olmstead and Ross Kirsling are now WebKit reviewers

2018-12-16 Thread Adrian Perez de Castro
Hello all, On Fri, 14 Dec 2018 06:46:20 +0900, Fujii Hironori wrote: > I would like to announce that Don Olmstead (dolmstead on #webkit) and > Ross Kirsling (rkirsling) are now WebKit reviewers. They have worked > on WinCairo port and PlayStation port, and Ross worked on Web > Inspector Layers

Re: [webkit-dev] Watch out for std::optional's move constructor

2018-12-14 Thread Adrian Perez de Castro
Hello, On Fri, 14 Dec 2018 14:02:39 -0800, Saam Barati wrote: > > On Dec 14, 2018, at 1:59 PM, Chris Dumez wrote: > > > >> On Dec 14, 2018, at 1:56 PM, Saam Barati >> > wrote: > >> > >>> On Dec 14, 2018, at 1:54 PM, Saam Barati >>> >

Re: [webkit-dev] Fujii Hironori is now a WebKit reviewer

2018-07-15 Thread Adrian Perez de Castro
Hi, On Sat, 14 Jul 2018 12:28:40 -0500, Michael Catanzaro wrote: > Fujii Hironori is now a WebKit reviewer. He has expertise in Windows > support, WebKitGTK+, and WebCore bugs. Please congratulate him and send > him patches to review! Congratulations, Fujii! \o/ -Adrián

Re: [webkit-dev] EWS for security bugs

2018-07-12 Thread Adrian Perez de Castro
Hello everybody, On Mon, 9 Jul 2018 20:10:54 +, wrote: > WinCairo EWS is processing security bugs now so we're good to go. Nice! > From: webkit-dev On Behalf Of Daniel > Bates > Sent: Thursday, June 28, 2018 1:53 PM > To: WebKit Development Mailing List > Subject: [webkit-dev] EWS for

Re: [webkit-dev] GTK+ EWS bot sick?

2018-07-09 Thread Adrian Perez de Castro
Hi, On Tue, 3 Jul 2018 19:23:31 -0700, Ryosuke Niwa wrote: > https://webkit-queues.webkit.org/patch/344243/gtk-wk2-ews > > e.g. https://webkit-queues.webkit.org/results/8431213 > ICECC[28449] 18:15:59: flush_writebuf() failed Resource temporarily > unavailable > ICECC[28449] 18:16:01: write of

Re: [webkit-dev] JavaScriptCore on Fuchsia

2018-06-28 Thread Adrian Perez de Castro
Hello, (Just a quick note, below.) On Wed, 27 Jun 2018 21:35:40 -0700, Adam Barth wrote: > On Wed, Jun 27, 2018 at 8:05 PM Adam Barth wrote: > > > > Hi Yusuke, > > > > For some reason, your original email missed my inbox. > > > > On Wed, Jun 27, 2018 at 7:53 PM Michael Catanzaro > > wrote: >

Re: [webkit-dev] Question about ARMv7 JIT maintenance by Apple

2018-05-05 Thread Adrian Perez de Castro
On Sat, 05 May 2018 02:45:02 +, Yusuke SUZUKI wrote: > On Sat, May 5, 2018 at 11:27 AM Filip Pizlo wrote: > > > We aren’t maintaining armv7. > > OK, thanks. I'll replace ARMv7 disassembler with capstone based one once > capstone is adopted :) We

Re: [webkit-dev] Using compile_command.json in sources that go into Unified Sources

2018-03-26 Thread Adrian Perez de Castro
On Mon, 26 Mar 2018 07:54:38 -0500, Michael Catanzaro wrote: > On Sat, Mar 24, 2018 at 6:03 PM, Cadu Bentzen > wrote: > > I included calling this script at the end of the build-webkit (under > > a command line option) script. So far it has work

Re: [webkit-dev] WTFCrash()

2018-03-12 Thread Adrian Perez de Castro
On Fri, 09 Mar 2018 12:59:01 -0600, Michael Catanzaro <mcatanz...@igalia.com> wrote: > On Fri, Mar 9, 2018 at 5:34 AM, Adrian Perez de Castro > <ape...@igalia.com> wrote: > > I would enable printing backtraces to -DENABLE_DEVELOPER_MODE=ON > > instead, > > b

Re: [webkit-dev] WTFCrash()

2018-03-09 Thread Adrian Perez de Castro
Hello, Just a quick note below about the backtraces... On Tue, 06 Mar 2018 23:09:18 -0600, Michael Catanzaro wrote: > After [1], WTFCrash() is used only in debug builds on Darwin. For > Darwin release builds, inline assembly is used to trigger a SIGTRAP. I >

Re: [webkit-dev] Hosting precompiled `jsc` binaries for Linux

2017-12-12 Thread Adrian Perez de Castro
Hello, everybody. On Tue, 12 Dec 2017 01:29:42 +0100, Carlos Alberto Lopez Perez wrote: > On 08/12/17 18:07, Lucas Forschler wrote: > > If the GTK team wanted to support making these accessible, > > they have everything they need. They could either choose to open up > > their

Re: [webkit-dev] Proposal: Remove ENABLE(MATHML)

2017-10-23 Thread Adrian Perez de Castro
Hi Fred, On Mon, 23 Oct 2017 17:42:29 +0200, Frédéric WANG wrote: > There have been some discussions recently on > https://bugs.webkit.org/show_bug.cgi?id=177744 regarding the relevance > of the compile-time flag for MathML. Discussing with Olivier during the > Web Engines

Re: [webkit-dev] Bring back ARMv6 support to JSC

2017-09-05 Thread Adrian Perez de Castro
On Tue, 5 Sep 2017 16:38:09 +0200, Osztrogonác Csaba wrote: > [...] > > Maybe it will be hard to say good bye to 32-bit architecutres > for many people, but please, it's 2017 now, the first ARMv8 SoC > is out 4 years ago, the first AMD64 CPU is out 14 years ago. While

Re: [webkit-dev] Python

2017-08-11 Thread Adrian Perez de Castro
Hi all, What I have been doing is having a Python 2.7 virtualenv [1], which gets automatically enabled (or disabled) when changing directory under (or out of) the WebKit source tree by means of zsh-autoenv [2]. This way the “python” binary is the one for Python 2.7 inside the virtualenv, and I do

Re: [webkit-dev] Intent to implement WebKit for Windows ports

2017-08-01 Thread Adrian Perez de Castro
On Tue, 01 Aug 2017 22:50:35 +0100, Michael Catanzaro wrote: > I will just add that there are some WebKitGTK+ users who would love for > WebKitGTK+ to be supported on Windows once again. Evolution and GnuCash > come to mind. Having a working WinCairo port of modern WebKit

Re: [webkit-dev] WEB_TIMING enabled on all ports - let's remove the flag?

2017-08-01 Thread Adrian Perez de Castro
Hello, On Tue, 01 Aug 2017 18:11:53 -0400, Maciej Stachowiak wrote: > > On Aug 1, 2017, at 5:55 PM, Konstantin Tokarev wrote: > > > > 02.08.2017, 00:49, "Sam Weinig" : > >>> On Aug 1, 2017, at 6:57 AM, Dean Jackson wrote: >

Re: [webkit-dev] WebKit Build dependencies

2017-06-22 Thread Adrian Perez de Castro
On Thu, 22 Jun 2017 15:41:26 +0530, Nagendra K wrote: > To build WebKit alone for a cross platform embedded device, want to know > the list of dependencies/packages required to build on host(Ubuntu) and > dependencies to run on host other than toolchain. Request some to

Re: [webkit-dev] Jiewen Tan is now a WebKit reviewer

2017-06-01 Thread Adrian Perez de Castro
Hi, On Wed, 31 May 2017 14:18:56 -0700, Mark Lam wrote: > I would like to announce that Jiewen Tan (jiewen on #webkit) is now a WebKit > reviewer. Jiewen usually works on the WebCrypto API. > > Please join me in congratulating Jiewen, and send him some patches to > review.