Re: [webkit-dev] New EWS Non-Unified builder

2021-04-29 Thread Adrian Perez de Castro via webkit-dev
On Thu, 29 Apr 2021 19:04:55 + Ross Kirsling via webkit-dev 
 wrote:

> Yeah, I think it's important to clarify that nobody is "using
> non-Unified-Source building for their development", at least to my
> knowledge. Being broken by the shifting sands of unified sources is an
> everybody problem (or at the very least an "everybody that builds via CMake
> problem", which is ultimately an everybody problem).

This is pretty accurate. I do have a build directory configured manually
as non-unified so I can get its “compile_commands.json” to point tooling
at (mainly clangd, for code completion and linting), but actual builds I
do them with the “build-webkit” script.

Another situation in which I explicitly opt-in to non-unified builds is
around the time we make a release branch for the GTK and WPE ports; get
to solve the non-unified build issues and then land the patches in the
release branch as well. The goal here is to make sure that what we release
can be built non-unified, which means header includes and whatnot are
correct (at least for these ports) and we can have the confidence that
people doing cross-builds (where the set of files in each unified build
compilation unit can shift) will not have problems with the builds.

Before I did the above we used to have complaints and distributions
sometimes carrying odd patches playing whack-a-mole to get builds done
instead of properly fixing things.

Cheers,
—Adrián

 
> 
> From: Alex Christensen via webkit-dev 
> Sent: Thursday, April 29, 2021 11:03 AM
> To: Darin Adler 
> Cc: webkit-dev@lists.webkit.org 
> Subject: Re: [webkit-dev] New EWS Non-Unified builder
> 
> I don’t see the goal as “keep non-Unified-Source building” but rather 
> “prevent unrelated build fixes when we add another file later”.  Right now 
> when we add a new file we often have to sprinkle includes, declarations, and 
> other build fixes in files unrelated to the current change.  If we had a bot 
> building without unification we would be informed at the time we write the 
> problematic code.
> 
> > On Apr 29, 2021, at 9:55 AM, Darin Adler via webkit-dev 
> >  wrote:
> >
> > Given the issue is that there are people that are using non-Unified-Source 
> > building for their development, the best fix is to add post-commit and EWS 
> > builders for one of those platforms. I do not support the idea of adding an 
> > additional builder just to “keep non-Unified-Source building” if no 
> > actively-supported platform is not choosing that build style.
> >
> > Specifically, if Sony people are most affected by this, I suggest we find a 
> > way to add Sony PlayStation post-commit and EWS builders.
> >
> > I am not convinced that we should add some kind of abstract “correct 
> > compilation” that is a separate builder.
> >
> > — Darin
> > ___
> > webkit-dev mailing list
> > webkit-dev@lists.webkit.org
> > https://lists.webkit.org/mailman/listinfo/webkit-dev
> 
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev


pgpstgQfzBoDJ.pgp
Description: PGP signature
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


Re: [webkit-dev] New EWS Non-Unified builder

2021-04-29 Thread Adrian Perez de Castro via webkit-dev
On Thu, 29 Apr 2021 15:56:31 + Don Olmstead via webkit-dev 
 wrote:

> When the Mac CMake build is in a working state I'd request an EWS that is 
> Non-Unified as well since Mac builds cover more code.

This would be a great addition, I agree. While I don't have a Mac around,
I can try and spare some cycles helping out with CMake Mac to get the build
in shape :)

Cheers,
—Adrian


> -Original Message-
> From: Alex Christensen via webkit-dev  
> Sent: Thursday, April 29, 2021 8:16 AM
> To: dpino 
> Cc: webkit-dev@lists.webkit.org
> Subject: Re: [webkit-dev] New EWS Non-Unified builder
> 
> I’d be excited to have this.  Those build failures have been bothering me 
> ever since we started using unified builds.  We would have a way to see more 
> problems in our code that are currently hidden.
> 
> > On Apr 28, 2021, at 11:45 PM, dpino via webkit-dev 
> >  wrote:
> > 
> > Hi everyone,
> > 
> > In Igalia we have been discussing the need of deploying a new builder 
> > which builds WebKit using non-unified sources, and we know that at 
> > least the folks at Sony are also in favor.
> > 
> > One side effect of Unified Source building is that it hides 
> > compilation errors. The kinds of errors that usually get hidden by 
> > unified builds are missing headers inclusions and missing definitions 
> > of functions declared inline; the latter being tricky to debug because 
> > it results in mysterious linker errors. This is caused by unified 
> > builds stashing several .cpp files together for compilation, so the 
> > definitions and header inclusions done in one “leak” into the others. 
> > As for missing header inclusion errors, a source file might include a 
> > header definition as a co-lateral effect of being stashed together 
> > with another file that indeed includes the missing header.
> > 
> > These hidden compilation errors may arise later at some point if 
> > unified source files are stashed together in a different manner.
> > 
> > The current situation is requiring periodical maintenance. You can 
> > check build fixes commits due to unified source compilation with:
> > 
> >$ git log --pretty=short --grep "Non-unified"
> > 
> > Here are some examples:
> >
> > https://urldefense.com/v3/__https://bugs.webkit.org/show_bug.cgi?id=222652__;!!JmoZiZGBv3RvKRSx!t22i0IAUrm1zV3LCteGHgJVUHzashK_F9tqjACa4ZTS_y9h8CnFZ7s60jhM-e_2Uo6c$
> >  
> >
> > https://urldefense.com/v3/__https://bugs.webkit.org/show_bug.cgi?id=222755__;!!JmoZiZGBv3RvKRSx!t22i0IAUrm1zV3LCteGHgJVUHzashK_F9tqjACa4ZTS_y9h8CnFZ7s60jhM-cnURaLI$
> >  
> >
> > https://urldefense.com/v3/__https://bugs.webkit.org/show_bug.cgi?id=22
> > 1701__;!!JmoZiZGBv3RvKRSx!t22i0IAUrm1zV3LCteGHgJVUHzashK_F9tqjACa4ZTS_
> > y9h8CnFZ7s60jhM-qQl-arU$
> > 
> > A new builder which builds WebKit with non-unified Source will highly 
> > help to improve this situation. Compilation errors will be detected as 
> > soon as possible and will save a lot of time not only for the 
> > developers who are currently doing this manual maintenance but for 
> > anyone who would like to build WebKit, and may stumble on compilation 
> > errors accidentally introduced due to unified sources.
> > 
> > While correct compilation of the codebase can only be guaranteed with 
> > non-unified source builds, we do not propose switching the current EWS 
> > compilation builders to non-unified because it's slower and the EWS 
> > LayoutTests and API test bots use the products built by the EWS 
> > builders — we do not want to delay getting results from those. That's 
> > why we are proposing a new builder: it will run on parallel, resulting 
> > in no slowdown for the other EWS builders, which will keep using 
> > unified builds.
> > 
> > How this new builder will impact developers? The EWS LayoutTest bots 
> > take at least 1 hour to complete a build. We think that as long as 
> > this new EWS Non-Unified builder is within that time budget, this new 
> > EWS wont' slow down development speed.
> > 
> > Thoughts?
> > 
> > Best regards,
> > 
> > Diego
> > ___
> > webkit-dev mailing list
> > webkit-dev@lists.webkit.org
> > https://urldefense.com/v3/__https://lists.webkit.org/mailman/listinfo/
> > webkit-dev__;!!JmoZiZGBv3RvKRSx!t22i0IAUrm1zV3LCteGHgJVUHzashK_F9tqjAC
> > a4ZTS_y9h8CnFZ7s60jhM-gSTmLtg$
> 
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://urldefense.com/v3/__https://lists.webkit.org/mailman/listinfo/webkit-dev__;!!JmoZiZGBv3RvKRSx!t22i0IAUrm1zV3LCteGHgJVUHzashK_F9tqjACa4ZTS_y9h8CnFZ7s60jhM-gSTmLtg$
>  
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev


pgp8GrVzObtlu.pgp
Description: PGP signature
___
webkit-dev mailing list
webkit-dev@lists.webkit.org

Re: [webkit-dev] Mailman web interface missing

2021-04-28 Thread Adrian Perez de Castro via webkit-dev
On Mon, 26 Apr 2021 13:07:47 -0700 Darin Adler  wrote:
> > On Apr 26, 2021, at 1:03 PM, Adrian Perez de Castro via webkit-dev 
> >  wrote:
> > 
> > - https://lists.webkit.org/listinfo/webkit-wpe/ results in “Not Found”
> > - https://lists.webkit.org/admindb/webkit-wpe/ results in “403 Forbidden”
> 
> I took a look and it seems that the URLs have simply changed, perhaps as a 
> result of an update:
>
> https://lists.webkit.org/mailman/listinfo/webkit-wpe

Thanks, you're right—this URL works!

> https://lists.webkit.org/mailman/admin/webkit-wpe 
> <https://lists.webkit.org/mailman/admin/webkit-wpe>

…but this one still results in “403 Forbidden” (it won't work even with a
fresh profile to rule out saved cookies).

Regards,
—Adrián


pgphr0Fkgq0k3.pgp
Description: PGP signature
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


[webkit-dev] Mailman web interface missing

2021-04-26 Thread Adrian Perez de Castro via webkit-dev
Hello all,

Mailing lists seem to be working fine, and web pages for their archives are
accessible, for example https://lists.webkit.org/pipermail/webkit-wpe/ works
fine—but on the other hand the Mailman administrative interface seems to have
gone the way of the dodo:

 - https://lists.webkit.org/listinfo/webkit-wpe/ results in “Not Found”
 - https://lists.webkit.org/admindb/webkit-wpe/ results in “403 Forbidden”

I noticed this a couple of days ago because I got a notification from Mailman
that there are messages pending moderation for the WPE mailing list; but I
cannot do anything about that because the web interface (second link above)
does not seem to work.

Could anyone at Apple please take a look at this?

Thanks in advance!
—Adrián


pgpxQ4tvbEhQL.pgp
Description: PGP signature
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


Re: [webkit-dev] Build bot workers aperez-{wpe, gtk}-ews to be offline for a week

2021-03-19 Thread Adrian Perez de Castro via webkit-dev
On Tue, 16 Mar 2021 02:18:48 +0200 Adrian Perez de Castro  
wrote:
> On Sat, 06 Mar 2021 16:29:10 +0200 Adrian Perez de Castro via webkit-dev 
>  wrote:
>  
> > I will be moving to a new office in the next week or two, and I need to shut
> > these down today. In all goes as expected, it should be possible to bring 
> > them
> > online in about a week. There are other workers for the GTK and EWS ports, 
> > so
> > the queues will continue running normally--if a tad slower. In the meantime,
> > my apologies for the inconvenience.
> 
> The hardware was moved on Saturday, and I am currently waiting that Internet
> connectivity is sorted out to be able to bring the builders back online in
> the next days.

…aaand they are back online.

Cheers,
-Adrian
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


[webkit-dev] Build bot workers aperez-{wpe, gtk}-ews to be offline for a week

2021-03-06 Thread Adrian Perez de Castro via webkit-dev
Hello,

I will be moving to a new office in the next week or two, and I need to shut
these down today. In all goes as expected, it should be possible to bring them
online in about a week. There are other workers for the GTK and EWS ports, so
the queues will continue running normally--if a tad slower. In the meantime,
my apologies for the inconvenience.

Cheers,
-Adrian


pgpVVeXD1uh4I.pgp
Description: PGP signature
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


Re: [webkit-dev] Reminder: include everything that you use in implementation files

2020-11-12 Thread Adrian Perez de Castro via webkit-dev
Hello Peng,

On Wed, 11 Nov 2020 12:05:18 -0800 "Peng (WebKit) Liu via webkit-dev" 
 wrote:
 
> Any way/option to turn off the unified build completely or partially in a
> local build? That would be very helpful for a developer to locally verify
> that header files are included correctly in a patch. Thanks!

You can use “build-webkit --no-unified-builds” to disable them; though I am
unsure if this will work for the Mac/iOS ports… It surely works with the
ports that use CMake (WPE, GTK, JSCOnly), and when using CMake you can also
use “cmake -DENABLE_UNIFIED_BUILDS=OFF” if you would rather configure and
build manually.

I hope this helps.

Cheers,
—Adrián
 
> Best regards
> Peng
> 
> > On Nov 6, 2020, at 11:21 AM, Brian Burg via webkit-dev 
> >  wrote:
> > 
> > Hello folks,
> > 
> > I'd like to remind everyone to please include what you use in .cpp,  .mm, 
> > and other files. When reviewing patches, please
> > ensure that new mentions of classes, structs, etc. within an implementation 
> > file have a corresponding header include. 
> > All of our headers have #pragma once, so there is no downside to being more 
> > explicit.
> > 
> > I've been noticing an uptick in the number of unified sources-related build 
> > failures. I can't remember the last nontrivial patch
> > I wrote that did *not* include unrelated build fixes. Typically these 
> > failures aren't found until EWS results come back, reducing developer 
> > velocity.
> > And obviosuly it's super annoying to encounter completely unrelated build 
> > failures that must be nonetheless addressed.
> > 
> > Let's all do our part so that hacking on WebKit remains delightful.
> > 
> > Thanks,
> > 
> > Brian Burg (he/they)
> >  WebKit Developer Experience


pgp3EqFjbVP0a.pgp
Description: PGP signature
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


[webkit-dev] Build bot workers aperez-{wpe, gtk}-ews to be rebooted for maintenance

2020-11-11 Thread Adrian Perez de Castro via webkit-dev
Hi all,

Quick PSA: the two build bot workers I run will be brought down for a short
period of time at 05:30 PST due to a kernel update; the machine where they
are hosted is going to be rebooted. Most likely this will take only a few
minutes =)

Cheers,
—Adrián


pgpLIHd8suLcc.pgp
Description: PGP signature
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


Re: [webkit-dev] Build bot workers aperez-{wpe, gtk}-ews to be rebooted for maintenance

2020-11-11 Thread Adrian Perez de Castro via webkit-dev
On Fri, 06 Nov 2020 15:05:59 +0200 Adrian Perez de Castro  
wrote:
 
> Quick PSA: the two build bot workers I run will be brought down for a short
> period of time at 05:30 PST due to a kernel update; the machine where they
> are hosted is going to be rebooted. Most likely this will take only a few
> minutes =)

Done! The machine is back, along with the EWS builders.

Cheers,
—Adrián


pgpKfupEJ_rw0.pgp
Description: PGP signature
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev