Re: [webkit-dev] [webkit-qt] Qt 5.2.1 / 5.3.2 with JIT_ENABLED=0: Assert / Crash in LLIntData.cpp; Windows 7 x64

2014-10-14 Thread Allan Sandfeld Jensen
Hi again Andre I am learning towards the assert being right. It appears sub-classes will be placed on 64bit aligned address on Win x64. This breaks some assumptions on how arrays are layed out. I will have to check where we make use if the assumptions asserted here, and see how bad it is.

Re: [webkit-dev] Webkit seizes sound device

2013-11-30 Thread Allan Sandfeld Jensen
On Saturday 30 November 2013, Benjamin Poulain wrote: On 11/29/13, 4:32 PM, Jeffrey Barish wrote: When I visit a web page that wants to play a sound, webkit opens the sound device and never lets go of it until the application exits. I would like for webkit not to open the sound device (and

[webkit-dev] Qt WebKit removed from upstream

2013-10-04 Thread Allan Sandfeld Jensen
farewell to upstream. We will still be using WebKit, and shipping with a brand new branch in Qt 5.2, and we will be active in the project where it makes sense. Feel free to reach out to us using the usual channels. Thanks for having us The Digia Qt WebKit Team. Allan Sandfeld Jensen Michael Bruning

Re: [webkit-dev] Changes in QtWebKit development

2013-10-02 Thread Allan Sandfeld Jensen
On Tuesday 01 October 2013, Oliver Hunt wrote: having helped as far as we could. But why should webkit have _any_ burden when Qt itself cares so little about QtWebKit that it is happy to have qtisms that were ostensibly necessary for performance, etc removed? So if we try minimize the

Re: [webkit-dev] Changes in QtWebKit development

2013-10-01 Thread Allan Sandfeld Jensen
On Monday 30 September 2013, Oliver Hunt wrote: On Sep 30, 2013, at 7:41 AM, Allan Sandfeld Jensen k...@carewolf.com wrote: Some of this is exactly the reason we want to keep Qt WebKit alive. It may never be possible to fully replace Qt WebKit with anything Blink/Chromium based. I really

Re: [webkit-dev] Changes in QtWebKit development

2013-09-30 Thread Allan Sandfeld Jensen
On Thursday 26 September 2013, Andreas Kling wrote: On Sep 25, 2013, at 12:40 PM, Allan Sandfeld Jensen k...@carewolf.com wrote: On Saturday 14 September 2013, Andreas Kling wrote: On Sep 14, 2013, at 11:24 AM, Allan Sandfeld Jensen k...@carewolf.com wrote: That said, in all

Re: [webkit-dev] Changes in QtWebKit development

2013-09-30 Thread Allan Sandfeld Jensen
On Monday 30 September 2013, Dirk Schulze wrote: I would not necessarily disagree with the problem of upstreaming work. But you said that most likely you wouldn't be able to branch WebKit anymore because of the compiler requirement. At least for Qt. Do you have other interests in QtWebKit

Re: [webkit-dev] Changes in QtWebKit development

2013-09-30 Thread Allan Sandfeld Jensen
On Monday 30 September 2013, Geoffrey Garen wrote: I’m planning to remove m_qStringData from StringImpl, along with any code that depends on it. Any objections? It should be removable by manually reverting r119217, it will hurt Qt WK2 and JSC bridge performance, but in theory not break

Re: [webkit-dev] Changes in QtWebKit development

2013-09-25 Thread Allan Sandfeld Jensen
On Saturday 14 September 2013, Andreas Kling wrote: On Sep 14, 2013, at 11:24 AM, Allan Sandfeld Jensen k...@carewolf.com wrote: That said, in all likelihood the Qt port will not remain part of WebKit forever, ... (This being the main reason.) Since you already know you’re eventually

Re: [webkit-dev] Compilation of Webkit2 on Qt Port

2013-09-17 Thread Allan Sandfeld Jensen
This is exactly what happens when linking with the wrong library. One way to solve it in a development tree is to go into WebKitBuild/Release and run make install. This will install the libraries as they are linked which means later executables will always link with the right version. `Allan

Re: [webkit-dev] Can we disable control reaches end of non-void function warning on Qt?

2013-09-12 Thread Allan Sandfeld Jensen
Don't worry we are still here, just in fewer numbers, and with fewer things to support. I would prefer to keep the warning, it is quite useful at times, and when it isn't you just add a default case with an ASSERT_NOT_REACHED(). `Allan On Friday 13 September 2013, Benjamin Poulain wrote:

Re: [webkit-dev] Can we disable control reaches end of non-void function warning on Qt?

2013-09-12 Thread Allan Sandfeld Jensen
On Friday 13 September 2013, Benjamin Poulain wrote: On 9/12/13 4:48 PM, Ryosuke Niwa wrote: On Thu, Sep 12, 2013 at 4:45 PM, Allan Sandfeld Jensen k...@carewolf.com mailto:k...@carewolf.com wrote: Don't worry we are still here, just in fewer numbers, and with fewer things

Re: [webkit-dev] Are Qt and GTK+ intentionally returning false in shouldShowPlaceholderWhenFocused?

2013-08-20 Thread Allan Sandfeld Jensen
On Tuesday 20 August 2013, Ryosuke Niwa wrote: Hi, Once my patch for https://bugs.webkit.org/show_bug.cgi?id=120049 is landed, Mac port will no longer return false in shouldShowPlaceholderWhenFocused. Mac, Windows, and EFL all return true in this function. Are Qt and GTK+ (and other)

Re: [webkit-dev] Are Qt and GTK+ intentionally returning false in shouldShowPlaceholderWhenFocused?

2013-08-20 Thread Allan Sandfeld Jensen
On Tuesday 20 August 2013, Darin Adler wrote: That’s what this function was about; implementing both styles. Thanks. I guess for Qt we would enable it on Mac, but keep it disabled elsewhere to stay consistent with the host platform. Best regards `Allan

Re: [webkit-dev] WebKit2 and ENABLE_PLUGIN_PROCESS

2013-08-19 Thread Allan Sandfeld Jensen
Hi On Monday 20 May 2013, Anders Carlsson wrote: Hello, is anyone building WebKit2 without ENABLE_PLUGIN_PROCESS set, running Netscape plug-ins in the web process? No but we were building WebKit2 without ENABLE_PLUGIN_PROCESS on Windows because we have plugins enabled in WebKit1, but it

Re: [webkit-dev] Ports not building as C++11?

2013-07-28 Thread Allan Sandfeld Jensen
On Saturday 27 July 2013, Allan Sandfeld Jensen wrote: On Friday 26 July 2013, Anders Carlsson wrote: Hi everyone, when Oliver landed his “let’s break everything” patches in JSC the other day, I noticed that some of the follow-up build fixes by other ports were removing use of C++11

Re: [webkit-dev] Ports not building as C++11?

2013-07-26 Thread Allan Sandfeld Jensen
On Friday 26 July 2013, Anders Carlsson wrote: Hi everyone, when Oliver landed his “let’s break everything” patches in JSC the other day, I noticed that some of the follow-up build fixes by other ports were removing use of C++11 features (mainly nullptr). Are there any ports that aren’t

Re: [webkit-dev] FTL merge (and subsequent mayhem)

2013-07-25 Thread Allan Sandfeld Jensen
On Thursday 25 July 2013, Oliver Hunt wrote: I would like to apologise to the maintainers of those platforms that I destroyed, and offer my heart felt thanks to those who have already started getting the builds running. I will be available all day today if help is needed, but to my knowledge

Re: [webkit-dev] WebRTC

2013-06-25 Thread Allan Sandfeld Jensen
I know of a company working on WebRTC for QtWebKit. They want to upstream it, but I do not know the current status or timeline. `Allan On Monday 24 June 2013, Danilo Cesar wrote: A few colleagues and I are working on the getUserMedia/PeerConnection API for the Gtk port. It works fine for

Re: [webkit-dev] webkit tests fail results running on Windows (probably font-related)

2013-06-24 Thread Allan Sandfeld Jensen
On Monday 24 June 2013, Dirk Pranke wrote: I'm not sure that any of the webkit.org ports actually run with pixel-tests enabled, so the port likely has outdated baselines and getting failures doesn't surprise me at all. Qt does not have our pixel testing bot running on webkit.org, because

Re: [webkit-dev] Does anyone build with !ENABLE(LLINT)?

2013-05-21 Thread Allan Sandfeld Jensen
On Tuesday 21 May 2013, Geoffrey Garen wrote: I'd like to remove the #ifdef, and make the interpreter an unconditional part of JSC. It's sometimes hard to reason about the different execution engines if you can't assume that the interpreter and its basic data structures exist. As far as I

Re: [webkit-dev] Crash in JSC while loading gap.com on 1.6.3

2013-04-30 Thread Allan Sandfeld Jensen
He probably refers to 1.6.3 of WebKitGTK+, the confusion comes from the fact that WebKitGTK+ calls themselves and their library 'WebKit' on Linux with no attempt of disambiguation. He needs to update though. I think they are at 1.11 and 2.0 now. `Allan On Tuesday 30 April 2013, Filip Pizlo

Re: [webkit-dev] Crash in JSC while loading gap.com on 1.6.3

2013-04-30 Thread Allan Sandfeld Jensen
On Tuesday 30 April 2013, Carlos Garcia Campos wrote: El mar, 30-04-2013 a las 09:11 +0200, Allan Sandfeld Jensen escribió: He probably refers to 1.6.3 of WebKitGTK+, the confusion comes from the fact that WebKitGTK+ calls themselves and their library 'WebKit' on Linux with no attempt

Re: [webkit-dev] mouseenter and mouseleave events

2013-04-22 Thread Allan Sandfeld Jensen
On Wednesday 17 April 2013, Maciej Stachowiak wrote: Seems like a reasonable feature to add. Would you mind also reviewing the patch in question then or help me find a reviewer with the right knowledge? Most of the patch is boiler plate work. The central part is how and when the events are

Re: [webkit-dev] mouseenter and mouseleave events

2013-04-17 Thread Allan Sandfeld Jensen
On Tuesday 16 April 2013, you wrote: Hi On Tue, Apr 16, 2013 at 5:08 AM, Allan Sandfeld Jensen k...@carewolf.comwrote: I have recently uploaded a new patch to https://bugs.webkit.org/show_bug.cgi?id=18930 to implement mouseenter and mouseleave events. This sounds nice, but shouldn't

Re: [webkit-dev] mouseenter and mouseleave events

2013-04-17 Thread Allan Sandfeld Jensen
On Wednesday 17 April 2013, Benjamin Poulain wrote: On Wed, Apr 17, 2013 at 12:46 AM, Allan Sandfeld Jensen k...@carewolf.comwrote: That is because it is not meant to be enabled any time soon. The CSS4 definitions are only there to guide our implementation so it behaves in a forward

[webkit-dev] mouseenter and mouseleave events

2013-04-16 Thread Allan Sandfeld Jensen
Hi webkit-dev I have recently uploaded a new patch to https://bugs.webkit.org/show_bug.cgi?id=18930 to implement mouseenter and mouseleave events. These events are part of DOM3 http://www.w3.org/TR/DOM-Level-3-Events/#events-mouseevents and supported by MSIE, Mozilla and pre-blink Opera.

Re: [webkit-dev] Current status of threaded compositor for WebKit Gtk

2013-04-15 Thread Allan Sandfeld Jensen
On Sunday 14 April 2013, Martin Robinson wrote: I'm surprised you didn't focus on WebKit2, since WebKit1 is in maintenance mode now. WebKit1 is easier to develop for. Especially now that we are not allowed to develop in WebKit2 anymore.. Second. Part of what this worl gives us is to unify

Re: [webkit-dev] on coding-style

2013-04-12 Thread Allan Sandfeld Jensen
On Saturday 13 April 2013, Karen Shaeffer wrote: Hello, Was reading the coding-style documentation. Have just one question concerning C++ null pointer value. Quoting the coding-style docs, In C++, the null pointer value should be written as 0. My question is: Doesn't xcode clang now support

Re: [webkit-dev] Feature removal: CSS variables

2013-04-08 Thread Allan Sandfeld Jensen
I think this discussion can be simplified a bit. I too is very sceptic about just removing features and would prefer we didn't remove features based on whether they could be a burden, but based on whether they actually are a burden or in the way of something specific we would like to do. The

Re: [webkit-dev] Cleaning House

2013-04-05 Thread Allan Sandfeld Jensen
On Friday 05 April 2013, Max Stepin wrote: Also, WebP project is unfinished state right now. This changeset requires libwebp version 0.3.0: https://trac.webkit.org/changeset/147048 To me it looks more like it requires 0.3.0 to enable color correction. Older ABIs are still supported. `Allan

Re: [webkit-dev] Cleaning House

2013-04-05 Thread Allan Sandfeld Jensen
On Friday 05 April 2013, Max Stepin wrote: To me it looks more like it requires 0.3.0 to enable color correction. Older ABIs are still supported. Yes, but some WebP images (created with 0.3.0) will not work. I tried, not even the first frame is displayed. Would it be OK to just take

Re: [webkit-dev] Cleaning House

2013-04-04 Thread Allan Sandfeld Jensen
On Thursday 04 April 2013, Geoffrey Garen wrote: Hi folks. Since we no longer need to support the Chromium port, let's take the opportunity to streamline. Hopefully, this will make development easier and more coherent for everyone. Adam and Eric offered to do some of this cleanup, but I

Re: [webkit-dev] Cleaning House

2013-04-04 Thread Allan Sandfeld Jensen
On Thursday 04 April 2013, jpe...@gmx.at wrote: BlackBerry is moving away from Skia, a removal wouldn't hurt us at this point. With EFL being on cairo, it seems like that item can stay on the list. Ah, right. Sorry for the confusion. I had the impression with all the places Skia specific

Re: [webkit-dev] APNG support

2013-03-21 Thread Allan Sandfeld Jensen
On Thursday 21 March 2013, Max Stepin wrote: What do you think? I posted the patch here: https://bugs.webkit.org/show_bug.cgi?id=17022 I don't mind. APNG is a nice simple format. GIF has limitations and MNG is almost inherently broken. To support it though, you need to make sure the patch

Re: [webkit-dev] Can Qt use some of the common DRT code?

2013-02-11 Thread Allan Sandfeld Jensen
On Monday 11 February 2013, Benjamin Poulain wrote: One of the differences is the way the Qt port works. Instead of using the JSC binding APIs, it uses its own JS Qt bindings. Would it be possible for Qt to move to the common code? It would make future refactoring easier as there would be one

Re: [webkit-dev] RGBA8 and BGRA8 formats in WebKit

2013-01-22 Thread Allan Sandfeld Jensen
On Monday 21 January 2013, Benjamin Poulain wrote: On Mon, Jan 21, 2013 at 7:00 AM, Zoltan Herczeg zherc...@webkit.org wrote: In WebKit both RGBA and BGRA formats are used for different purposes and different platforms in WebKit. Do we have a policy which one we prefer? It would be nice to

Re: [webkit-dev] RGBA8 and BGRA8 formats in WebKit

2013-01-22 Thread Allan Sandfeld Jensen
On Tuesday 22 January 2013, Zoltan Herczeg wrote: Where in WebKit do you experience problems with color conversion? As for me WebKit2 transmits BGRA images, which needs to be converted to RGBA before it is uploaded to a texture on GLES 2.0. These conversions seems computation heavy for

Re: [webkit-dev] RGBA8 and BGRA8 formats in WebKit

2013-01-22 Thread Allan Sandfeld Jensen
On Tuesday 22 January 2013, John Bauman wrote: Couldn't you just swizzle the value in whatever shader you use? Or you could use EXT_texture_format_BGRA or APPLE_texture_format_BGRA. Also, an optimized BGRA-RGBA conversion is about the same cost as a memcpy, so if you have any memcpys

Re: [webkit-dev] RGBA8 and BGRA8 formats in WebKit

2013-01-22 Thread Allan Sandfeld Jensen
On Wednesday 23 January 2013, Balazs Kelemen wrote: On 01/22/2013 05:14 PM, Zoltan Herczeg wrote: Where in WebKit do you experience problems with color conversion? As for me WebKit2 transmits BGRA images, which needs to be converted to RGBA before it is uploaded to a texture on GLES 2.0.

Re: [webkit-dev] Adding Web MIDI API support to WebCore

2013-01-19 Thread Allan Sandfeld Jensen
On Saturday 19 January 2013, Benjamin Poulain wrote: On Fri, Jan 18, 2013 at 3:04 PM, Levi Weintraub le...@chromium.org wrote: I see that this is intended to go in as a module. My understanding is that concept was created to allow this sort of thing with minimal impact to core

Re: [webkit-dev] Multiprocess networking in WebKit

2012-12-04 Thread Allan Sandfeld Jensen
On Tuesday 04 December 2012, Adam Barth wrote: There's been a somewhat fragmented discussion across webkit-dev and various bugs about how we ought to approach multiprocess networking in WebKit. In an attempt to organize my thoughts, I wrote up a short design document that compares various

[webkit-dev] Baselines ignoring metrics

2012-09-19 Thread Allan Sandfeld Jensen
Hello WebKit, Some time ago I wrote a patch that would make the test runners detect baseline that had been generated with the --ignore-metrics flag, see https://bugs.webkit.org/show_bug.cgi?id=94815 . This makes it possible to generate baselines that would always be testing ignoring metrics,

Re: [webkit-dev] Baselines ignoring metrics

2012-09-19 Thread Allan Sandfeld Jensen
On Wednesday 19 September 2012, Dirk Pranke wrote: After some limited amount of thought, I'm inclined to agree with Ryosuke and Ossy here. If we have tests that don't depend on checking the metrics, can they just be dumpAsText tests or reftests instead? They could be. The tests I had in mind

Re: [webkit-dev] Baselines ignoring metrics

2012-09-19 Thread Allan Sandfeld Jensen
On Wednesday 19 September 2012, Dirk Pranke wrote: If you can point to specific tests you'd like to try this for I can comment in more detail, but I'm not really okay with a blanket approval for using --ignore-metrics whenever we feel like it yet. In the referenced bug I added an example

Re: [webkit-dev] unsigned vs unsigned int

2012-09-17 Thread Allan Sandfeld Jensen
On Sunday 16 September 2012, Darin Adler wrote: On Sep 16, 2012, at 2:30 AM, Allan Sandfeld Jensen k...@carewolf.com wrote: On Thursday 13 September 2012, Dan Bernstein wrote: On Sep 13, 2012, at 1:29 AM, Kenneth Rohde Christiansen kenneth.christian...@gmail.com wrote: I was telling people

Re: [webkit-dev] unsigned vs unsigned int

2012-09-16 Thread Allan Sandfeld Jensen
On Thursday 13 September 2012, Dan Bernstein wrote: On Sep 13, 2012, at 1:29 AM, Kenneth Rohde Christiansen kenneth.christian...@gmail.com wrote: Hi there, I was telling people to use unsigned instead of unsigned int, as I have been told that was the preferred style before, but

Re: [webkit-dev] image downscaling during decoding

2012-08-13 Thread Allan Sandfeld Jensen
On Monday 13 August 2012, Anton Obzhirov wrote: Hi, We are looking for ways to improve page loading speed and reduce memory usage for WebKit in general and for GTK port of WebKit in particular. One of the ideas is to implement downscaling of the images during decoding for image elements

Re: [webkit-dev] WebKit memory instrumentation

2012-07-24 Thread Allan Sandfeld Jensen
Hi This is very interesting. I have been trying to debug memory-comsumption lately as well, though I have used different methods: I guess this API is to make the data available in web-inspector right? I have gathered similar data using valgrind's massif which can tell you which objects have

Re: [webkit-dev] Using namespace std

2012-05-16 Thread Allan Sandfeld Jensen
On Tuesday 15 May 2012, Darin Adler wrote: On May 15, 2012, at 5:48 AM, Allan Sandfeld Jensen wrote: To me it seems like an odd practice, so I would like to ask what original rationale behind that style guideline is Adding a list of using declarations like using std::min to the top

Re: [webkit-dev] Using namespace std

2012-05-16 Thread Allan Sandfeld Jensen
On Tuesday 15 May 2012, Darin Adler wrote: On May 15, 2012, at 10:04 AM, Allan Sandfeld Jensen wrote: The conflict is between isinf, isnan and std::isinf and std::isnan, but the conflict only exists in C++11 when constexpr versions are introduced. We should try harder to come up

Re: [webkit-dev] Using namespace std

2012-05-16 Thread Allan Sandfeld Jensen
On Wednesday 16 May 2012, Allan Sandfeld Jensen wrote: On Tuesday 15 May 2012, Darin Adler wrote: On May 15, 2012, at 10:04 AM, Allan Sandfeld Jensen wrote: The conflict is between isinf, isnan and std::isinf and std::isnan, but the conflict only exists in C++11 when constexpr versions

[webkit-dev] Using namespace std

2012-05-15 Thread Allan Sandfeld Jensen
Hello webkit-dev I would like to bring up an issue in the style guide that I have run into and find a little odd. In my recent patch to compile WebKit using C++11 and GCC, I had to resolve a name conflict between global and std namespace. To do this you have to avoid expanding the full std

Re: [webkit-dev] Double-Resolution (Retina) Images - Re: -webkit-image-set

2012-04-25 Thread Allan Sandfeld Jensen
On Wednesday 25 April 2012, Chris Hutten-Czapski wrote: Assuming I'm understanding Kalle correctly, it seems this could already be accomplished with @media resolution? http://www.w3.org/TR/css3-mediaqueries/#resolution Not to be too cute about it, but CSS dpi is _always_ 96 CSS pixels

Re: [webkit-dev] Following up on removing -khtml- and -apple- CSS vendor prefixes

2012-04-05 Thread Allan Sandfeld Jensen
On Thursday 05 April 2012, Adam Barth wrote: In July 2010, there was a thread on webkit-dev about removing support for the -khtml- and -apple- vendor prefixes: https://lists.webkit.org/pipermail/webkit-dev/2010-July/013519.html At the time, we tried an approach recommended by David Hyatt

Re: [webkit-dev] Making overflow clipping cheaper

2011-12-28 Thread Allan Sandfeld Jensen
On Tuesday 27 December 2011, Julien Chaffraix wrote: Hi fellow hackers, while investigating some slowness related to painting big HTML tables [1], RenderLayer's painting code path was pointed out as the source of slowness. The problem stems from RenderLayer not being aware of the

Re: [webkit-dev] Content sniffing in WebCore

2009-01-06 Thread Allan Sandfeld Jensen
On Friday 10 October 2008, Benjamin Meyer wrote: For what it is worth with Konq with its KParts system will follow the content type and just load a a text editor in the browser if there is no content-type for example. Not entirely. While Konqueror does no content-sniffing. It simply trusts the

Re: [webkit-dev] WebKit licensing and LGPLv3

2007-07-25 Thread Allan Sandfeld Jensen
On Wednesday 25 July 2007 01:51, Maciej Stachowiak wrote: 1) We will continue to accept only code that's licensed under a BSD- style (no advertising clause) license, or LGPL 2.1, or other compatible license. We don't want to accept code that's LGPL 3 only, as that would make the whole project

Re: [webkit-dev] Box shadow

2007-01-09 Thread Allan Sandfeld Jensen
On Tuesday 09 January 2007 16:04, Mike Reed wrote: Do we need to use clips for round-rects? In my implementation these are always hard-edged (no antialiasing). Is that true for Qt as well? CG? I would prefer being asked to draw round-rects (filled or stroked) directly with no clipping... The