[webkit-dev] What's up with the CHECK_CONSISTENCY macro?

2014-04-25 Thread Andrei Bucur
Hello Webkittens, I'm trying to add some line boxes sanity checks and I've noticed there's a CHECK_CONSISTENCY macro guarding some consistency validation code (go figure!) but that's never defined in WebKit/Source. Anybody has an idea how that macro is used? Andrei.

Re: [webkit-dev] Make accelerated compositing mandatory

2014-01-30 Thread Andrei Bucur
The patch that makes AC mandatory has landed here: http://trac.webkit.org/changeset/163079. As I said before, no build systems were affected by the patch so port maintainers can adjust to the change as they see fit. Thanks, Andrei. ___ webkit-dev

Re: [webkit-dev] Make accelerated compositing mandatory

2014-01-29 Thread Andrei Bucur
Hello! I¹ve posted a patch at https://bugs.webkit.org/show_bug.cgi?id=127833. There¹s also a comment detailing the scope of the patch. If there are no objections, I¹ll land it tomorrow. Thanks, Andrei. Hello webkittens, Do you happen to know if we still have ports that build WebKit without

[webkit-dev] Make accelerated compositing mandatory

2014-01-28 Thread Andrei Bucur
Hello webkittens, Do you happen to know if we still have ports that build WebKit without accelerated compositing? If not, I'd like to write a patch that removes the flag and makes AC mandatory. From IRC, I've heard that the Haiku port (not upstreamed) disables the AC flag, but they agree they

[webkit-dev] CSS Regions diagrams

2013-05-09 Thread Andrei Bucur
Hello WebKittens, I've built two diagrams that should help contributors ramp up on the CSS Regions code. https://docs.google.com/file/d/0Bw3uLBB0FreFWC1HZVM2YnRkeFE/edit The first diagram is a class map covering the relevant parts of the regions code. Two important missing pieces are the

Re: [webkit-dev] CSS Regions diagrams

2013-05-09 Thread Andrei Bucur
] On Behalf Of Ryosuke Niwa Sent: Thursday, May 09, 2013 11:30 AM To: Andrei Bucur Cc: webkit-dev@lists.webkit.org Subject: Re: [webkit-dev] CSS Regions diagrams I can't zoom enough to see anything on the first diagram. Could you post a regular PDF or PNG/SVG somewhere? - R. Niwa On Thu, May 9

[webkit-dev] CSS Fragmentation in WebKit

2013-05-02 Thread Andrei Bucur
Here is an introductory blog post I wrote a while back about fragmentation in WebKit. I think it's in line with Dave's presentation on pagination: http://blogs.adobe.com/webplatform/2013/03/05/css-fragmentation-in-webkit/ Andrei. ___ webkit-dev

Re: [webkit-dev] Multiple inheritance in the DOM

2012-08-01 Thread Andrei Bucur
Hi Adam, On 7/27/12 1:55 AM, Adam Barth aba...@webkit.org wrote: Perhaps it would make sense to start with a smaller CSSOM for Regions that uses established patterns and techniques. That way we can gain experience with these patterns and techniques before jumping into API designs that don't

Re: [webkit-dev] Multiple inheritance in the DOM

2012-07-26 Thread Andrei Bucur
Identifying what the Region actually is sounds very similar with identifying the nature of a Node using NodeType? Is this pattern applicable here as well? https://developer.mozilla.org/en/nodeType Andrei. From: webkit-dev-boun...@lists.webkit.org [mailto:webkit-dev-boun...@lists.webkit.org]

[webkit-dev] About WebIDL supplemental interfaces

2012-07-19 Thread Andrei Bucur
Hello Webkitters! The latest WD for WebIDL defines a supplemental interface of an interface A as any element of the acyclic graph of interfaces that is connected to A through implements statements or through the inheritance chain of another supplemental interface:

Re: [webkit-dev] About WebIDL supplemental interfaces

2012-07-19 Thread Andrei Bucur
Hey Kentaro, On 7/19/12 6:20 PM, Kentaro Hara hara...@chromium.org wrote: Hi Andrei I'm asking this because CSS Regions spec defines the Region interface as an WebIDL supplemental interface that needs to be implemented by any object that can be a region (Element, Pseudo elements etc.). Is

Re: [webkit-dev] About WebIDL supplemental interfaces

2012-07-19 Thread Andrei Bucur
...@webkit.orgmailto:aba...@webkit.org Date: Thursday, July 19, 2012 7:31 PM To: Andrei Bucur abu...@adobe.commailto:abu...@adobe.com Cc: Kentaro Hara hara...@chromium.orgmailto:hara...@chromium.org, webkit-dev@lists.webkit.orgmailto:webkit-dev@lists.webkit.org webkit-dev@lists.webkit.orgmailto:webkit-dev

Re: [webkit-dev] Web APIs and class name collisions

2012-07-13 Thread Andrei Bucur
, Jul 12, 2012 at 10:03 AM, Andrei Bucur abu...@adobe.com wrote: From my knowledge the CSS prefix is reserved for the CSS engine classes in WebKit. Prefixing the Region class with CSS could prove confusing. Regards, Andrei. From: Alan Stearns stea...@adobe.com Date: Thursday, July 12

[webkit-dev] Web APIs and class name collisions

2012-07-12 Thread Andrei Bucur
Hello Webkittens! While implementing the Region interface ( http://dev.w3.org/csswg/css3-regions/#the-region-interface ) I've noticed that the name Region is already taken by a class in platform/graphics. I'd like to know what's the best approach in these kind of situations: 1. Rename the

Re: [webkit-dev] Web APIs and class name collisions

2012-07-12 Thread Andrei Bucur
...@webkit.orgmailto:aba...@webkit.org, Andrei Bucur abu...@adobe.commailto:abu...@adobe.com Cc: webkit-dev@lists.webkit.orgmailto:webkit-dev@lists.webkit.org webkit-dev@lists.webkit.orgmailto:webkit-dev@lists.webkit.org Subject: Re: [webkit-dev] Web APIs and class name collisions The spec itself consistently

Re: [webkit-dev] Using ref tests for repaint bugs

2012-06-06 Thread Andrei Bucur
I want to give everyone an update on how things are evolving. For now, I've focused most of the development on the Mac platform. For the ref-tests-as-repaint-tests path, I've added an optional parameter to LTC.display() that should control if the repaint rectangles are tracked or not. If not

Re: [webkit-dev] Using ref tests for repaint bugs

2012-05-28 Thread Andrei Bucur
On Fri, May 25, 2012 at 4:05 PM, Julien Chaffraix julien.chaffr...@gmail.com wrote: I second Simon's fragility argument. His solution is more viable, platform agnostic and may even remove the need for dumping the pixel in some cases. Even if the existing harness has the subsequent paint

Re: [webkit-dev] Using ref tests for repaint bugs

2012-05-24 Thread Andrei Bucur
...@chromium.org wrote: Do you just need to force a layout at the end of repaintTest, e.g. document.body.offsetHeight;? On Thu, May 24, 2012 at 6:34 AM, Andrei Bucur andrei.bu...@gmail.comwrote: Hello WebKittens, I'm trying to simplify the patch for a certain repaint bug ( https://bugs.webkit.org

Re: [webkit-dev] Using ref tests for repaint bugs

2012-05-24 Thread Andrei Bucur
Ojan, As Simon states, some repaint tests will likely not be possible to write correctly as ref tests, but some of them I think they fit very well in the happy-no-pixel-test bucket :). If people decide it's a direction worth investigating, I'll give the idea a spin. Simon, On Fri, May 25, 2012

Re: [webkit-dev] Regarding cache memory leaks

2010-10-18 Thread Andrei Bucur
I don't know if this is the use case but it should be noted that the CachedResourceLoader (the old DocLoader) never drops the CachedResource handles it has. This prevents resource deletion while the CachedResourceLoader is alive and kicking. This means that modifying the source of an img element

[webkit-dev] Cairo and -webkit-mask-clip: text

2010-06-23 Thread Andrei Bucur
Hello! I'm trying to implement this CSS value on the Cairo backend and I'm stuck with a problem regarding the Porter-Duff composition operators (why is CAIRO_OPERATOR_DEST_IN unbound?). I've made the following changes to reach this point: 1. I implemented a version of