Re: [webkit-dev] Experimental new code reviews

[Andrew Scherkus]

Here's the prototype I made during the hackathon that simply uses a bunch of
Javascript to make it easier to type up comments:
http://ascherkus.appspot.com/bugzilla/index.html

I'm not a WebKit reviewer, but from what I gathered during the session
there's a lot of copying and pasting involved.  I focused on trying to fix
that particular issue.

Double click a line to add a comment.  Code context + comment gets appended
into the patch comment box.  It's purely visual -- nothing gets persisted.

Andrew

On Mon, Apr 19, 2010 at 4:20 PM, Ojan Vafai o...@chromium.org wrote:

 I don't know if it's up anywhere. The other group's approach adds more
 directly upon the current review system. I don't think we need to choose one
 vs. another (at least not in the short term). Not that you were suggesting
 that.

 Ojan


 On Mon, Apr 19, 2010 at 4:06 PM, Adam Barth aba...@webkit.org wrote:

 +scherkus

 On Mon, Apr 19, 2010 at 4:01 PM, Maciej Stachowiak m...@apple.com wrote:
 
  I heard another group coded up a different approach to improving reviews
 -
  does anyone have a URL for that, so we can compare?
  Cheers,
  Maciej
 
  On Apr 19, 2010, at 3:35 PM, Ojan Vafai wrote:
 
  At the hackathon last Tuesday, a few of us put together mashup style
  rietveld integration with bugs.webkit.org. It currently requires a
 chrome
  extension. We'll integrate properly with bugzilla based on feedback if
 this
  seems to be a value add for the project.
 
 http://webkit-rietveld.googlecode.com/svn/trunk/chrome-extension/webkit-cr.crx
  You can try it out on the *last* attachment
  on https://bugs.webkit.org/show_bug.cgi?id=37531.
  You'll see another link next to each attachment labelled Fancy Review.
  This loads a page much like the current review page, but
  with wkrietveld.appspot.com in the top frame (wkrietveld is our fork of
  rietveld). You can then make comments in rietveld. When you click the
 submit
  button, the comments are published *both* in Reitveld and
  to bugs.webkit.org.
  We do not intend to remove the old code review system for people who
 prefer
  to stick to that.
 
  Known issues:
  -Currently, only works with patches that are uploaded using
 webkit-patch
  upload --fancy-review.
  -Due to using a chrome extension rather than a tighter integration, some
  things are a bit janky (e.g. the initial load).
  -Each time a patch is uploaded, it currently creates a new rietveld
 issue.
  Ojan ___
  webkit-dev mailing list
  webkit-dev@lists.webkit.org
  http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
 
 
  ___
  webkit-dev mailing list
  webkit-dev@lists.webkit.org
  http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
 
 



___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Trouble reviewing patches since the experimental commenting support went into bugs.webkit.org's action=review page

[Andrew Scherkus]

On Thu, Apr 22, 2010 at 1:13 PM, Adam Roben aro...@apple.com wrote:

 On Apr 22, 2010, at 4:01 PM, Darin Adler wrote:

  - The comments all cite only a single line of the patch and I almost
 never have a comment that's for a single line. So I have to do a lot of
 editing, pretending to comment on multiple lines.

 I think it would be nice if you could drag to select multiple lines of
 code. When you release the mouse button, the comment box would appear, and
 when you commit that comment all the lines you selected would be quoted.


The other person who I was working with had this feature implemented, but I
forget his name and didn't grab his email.  I hope he reads webkit-dev :\

Andrew
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev