Re: [webkit-dev] Reducing / removing use of Makefile based DerivedSources.make

2020-10-20 Thread Andy Estes
Hi Sam, > On Oct 18, 2020, at 11:01, Sam Weinig wrote: > > One direct benefit of moving away from DerivedSources.make would likely be (I > say likely, as the details of how it works out are far from certain in my > mind) removing at least one place that a IDL file needs to be listed as we >

Re: [webkit-dev] -Wpessimizing-move and -Wredundant-move

2019-03-18 Thread Andy Estes
Hi Michael, > On Mar 18, 2019, at 2:35 PM, Michael Catanzaro wrote: > > Hi, > > GCC 9 has new -Wpessimizing-move ("warning: moving a local object in a return > statement prevents copy elision") and -Wredundant-move ("warning: redundant > move in return statement") warnings. These are enabled

Re: [webkit-dev] WebKit Commit Queue blocked by build errors in ToT

2018-12-06 Thread Andy Estes
> On Dec 6, 2018, at 4:37 PM, Chris Fleizach wrote: > > > >> On Dec 6, 2018, at 4:37 PM, Ryan Haddad > > wrote: >> >> Chris, >> >> I'm assuming that this is in reference to the patch in >> https://bugs.webkit.org/show_bug.cgi?id=192373 >>

Re: [webkit-dev] SVN server broken?

2017-09-08 Thread Andy Estes
> On Sep 8, 2017, at 9:28 AM, Alexey Proskuryakov wrote: > > > Is anyone still seeing issues? I see a number of patches landed overnight, > including by commit queue. Yes, I’m still seeing the same issue Carlos saw last night. I just tried to commit a build fix: $ git svn

Re: [webkit-dev] Growing tired of long build times? Check out this awesome new way to speed up your build... soon (HINT: It's not buying a new computer)

2017-08-30 Thread Andy Estes
> On Aug 30, 2017, at 11:54 AM, Konstantin Tokarev wrote: > > > > 30.08.2017, 21:05, "Alex Christensen" : >>> On Aug 29, 2017, at 5:54 PM, Sam Weinig wrote: >>> In a completely other direction, what does this mean for use of

Re: [webkit-dev] "webkit-patch upload --no-review" submits to EWS by default

2017-08-23 Thread Andy Estes
> On Aug 22, 2017, at 8:10 PM, Keith Miller wrote: > > Does it make sense to have a --wip option that’s basically --no-review / > don’t run EWS? There are times I upload clearly broken patches for early > analysis that don’t need to be run on EWS. `webkit-patch

Re: [webkit-dev] Python

2017-08-07 Thread Andy Estes
> On Aug 7, 2017, at 8:41 AM, Andy Estes <aes...@apple.com> wrote: > > > >> On Aug 7, 2017, at 6:47 AM, Michael Catanzaro <mcatanz...@igalia.com >> <mailto:mcatanz...@igalia.com>> wrote: >> >> last I checked, macOS did not provide a p

Re: [webkit-dev] Python

2017-08-07 Thread Andy Estes
> On Aug 7, 2017, at 6:47 AM, Michael Catanzaro wrote: > > last I checked, macOS did not provide a python2 binary either. I am hoping > that has changed in the past few years. Has it? Nope. Andy ___ webkit-dev mailing list

Re: [webkit-dev] Idiom for functions with all return values in a switch case

2017-05-10 Thread Andy Estes
> On May 10, 2017, at 3:17 PM, Michael Catanzaro wrote: > > On Tue, May 9, 2017 at 2:57 PM, Ryosuke Niwa wrote: >> One annoying thing is that I've seen clang complaining about that >> return statement being an unreachable statement while gcc doesn't

Re: [webkit-dev] Idiom for functions with all return values in a switch case

2017-05-09 Thread Andy Estes
> On May 9, 2017, at 11:35 AM, Michael Catanzaro wrote: > > Andy suggests returning one of the enumeration values directly, then we can > use ASSERT_NOT_REACHED() instead of RELEASE_ASSERT_NOT_REACHED(). That would > work too, though it forces me to think about which

Re: [webkit-dev] Idiom for functions with all return values in a switch case

2017-05-09 Thread Andy Estes
> On May 9, 2017, at 11:06 AM, Michael Catanzaro wrote: > > https://bugs.webkit.org/show_bug.cgi?id=171851 > suggests this approach: > > static WKAutoplayEvent toWKAutoplayEvent(WebCore::AutoplayEvent event) >

Re: [webkit-dev] Some text about the B3 compiler

2016-01-28 Thread Andy Estes
I was just going to suggest something similar!  Andy > On Jan 28, 2016, at 4:48 PM, Filip Pizlo wrote: > > I guess we could put it in Websites/webkit.org/b3 . > Then patches could edit both B3 and the documentation in one go, and the > documentation

[webkit-dev] PSA: WTF::move has been renamed to WTFMove

2016-01-02 Thread Andy Estes
Hi folks, As of , WTF::move has been removed and replaced with a macro named WTFMove. This allows us to take advantage of some new warnings in clang while still retaining the checks provided by WTF::move. More details can be found in

Re: [webkit-dev] virtual and override

2015-02-20 Thread Andy Estes
Good idea. Andy On Feb 20, 2015, at 4:11 AM, Antti Koivisto koivi...@iki.fi wrote: We have traditionally marked virtual overrides with the 'virtual' keyword for documentation purposes. Nowadays we also have the compiler checked 'override'. Using both at the same time seems redundant.

[webkit-dev] webkitbot unable to roll out patches

2014-08-18 Thread Andy Estes
I tried using webkitbot tonight to roll out a patch, but it’s encountering an error running `update-webkit`. [23:42:16] estes webkitbot: rollout r172697 made two webarchive layout tests start flaking [23:42:18] webkitbot estes: Preparing rollout for

Re: [webkit-dev] webkitbot unable to roll out patches

2014-08-18 Thread Andy Estes
On Aug 18, 2014, at 12:17 AM, Ryosuke Niwa rn...@webkit.org wrote: How could Ossy reboot the bot!? As far as I know, he doesn't have the access to the machine on which webkitbot is running. webkitbot has a restart option. Having said that, are you sure there are no conflicts? That

Re: [webkit-dev] How to download the patch and apply it to git

2012-08-06 Thread Andy Estes
It looks like everything but the ChangeLog was patched cleanly, so you should be fine. You can do a sanity check by typing 'git diff' and comparing the output to the original patch. -Andy On Aug 5, 2012, at 10:57 PM, talking1...@gmail.com wrote: I use patch -p1 patch file and it show me as

Re: [webkit-dev] How to download the patch and apply it to git

2012-08-05 Thread Andy Estes
On Aug 5, 2012, at 10:25 PM, talking1...@gmail.com wrote: I use follow command patch -p0 D:\work\bsquare-code\jit.patch in the git -bash, but it no response. patch reads from standard input. Your command should look like: patch -p0 path-to-file -Andy

Re: [webkit-dev] How to download the patch and apply it to git

2012-08-05 Thread Andy Estes
On Aug 5, 2012, at 10:25 PM, talking1...@gmail.com wrote: I use follow command patch -p0 D:\work\bsquare-code\jit.patch in the git -bash, but it no response. Also, you probably want -p1 instead of -p0. I'm sure someone would be happy to help you with this on #webkit if you're still having

Re: [webkit-dev] Changes to window.focus/window.blur controlled by a setting?

2012-05-21 Thread Andy Estes
On May 21, 2012, at 12:25 PM, Andrew Wilson atwil...@google.com wrote: No, because the setTimeout() callback would be executed outside the context of a user gesture. This isn't always true. User gesture state is forwarded to the timeout's callback if the timeout was scheduled in the context

Re: [webkit-dev] Is it possible to programmatically set the Safari Extension Whitelist?

2012-05-14 Thread Andy Estes
Hi Sam, Apple's developer forums would be a more appropriate place to ask this question. You might try https://devforums.apple.com/community/safari/extensions. This list is for discussing the development of WebKit itself. -Andy On May 14, 2012, at 2:39 PM, Sam Halliday sam.halli...@gmail.com

Re: [webkit-dev] git.webkit.org is offline

2012-02-15 Thread Andy Estes
I'm seeing this when I try to update my tree: [estes@bestes OpenSource (master)]$ git fetch git.webkit.org[0: 17.254.20.231]: errno=Connection refused fatal: unable to connect a socket (Connection refused) -Andy On Feb 15, 2012, at 11:29 AM, William Siegrist wrote: All services are back.

Re: [webkit-dev] Core bots build system

2011-05-04 Thread Andy Estes
On May 4, 2011, at 18:36, Leo Yang leoyang.web...@gmail.com wrote: Hi, I want to add .h, .cpp and .idl files into WebCore platform independent parts. The questions are: - How many build systems are there for build bots? Eight! - For each type of build bots, where are the project files

Re: [webkit-dev] Platform LayoutTests are out of control

2011-04-20 Thread Andy Estes
Sent from my iPhone On Apr 20, 2011, at 21:33, Brent Fulgham bfulg...@gmail.com wrote: As I sat tonight, waiting for my local repository to update (~1 hour and counting at this point), I had a bit of free time to contemplate the ever-growing size of the platform results of the layout test

Re: [webkit-dev] map.d.co.il broken - back out r66156?

2010-09-19 Thread Andy Estes
Hi Jeremy, I'm working on this. Thanks for bringing it to my attention! -Andy On Sep 19, 2010, at 2:17 AM, Jeremy Moskovich wrote: Thanks Maciej, The original bug had no information on the sites that were fixed, very good to hear that this improves compatibility! Can you comment on

Re: [webkit-dev] Mouse wheel event precision

2010-06-09 Thread Andy Estes
On Jun 8, 2010, at 8:34 PM, Nathan Vander Wilt wrote: What Safari 4 seemed to do was simply provide much greater precision, where scrolling half a line simply yielded about 20 units instead of being ignored. So the above code would yield integral deltas in browsers that only fired events

Re: [webkit-dev] Mouse wheel event precision

2010-06-08 Thread Andy Estes
Hi Nathan, It is true that Safari now emits mousewheel events in increments of 120 for compatibility reasons. However, there is no loss of granularity in the sense that events are generated on fractional wheel ticks and are accelerated on platforms that support it. The only difference is

Re: [webkit-dev] Mouse wheel event precision

2010-06-08 Thread Andy Estes
On Jun 8, 2010, at 19:50, Andy Estes aes...@apple.com wrote: The only difference is that you will see increments of 120 rather than increments of 1 Perhaps a better way to say this is that the old wheelDelta values are now simply being multiplied by 120. The precision hasn't changed, just