Re: [webkit-dev] Gardening our pull requests
> On 16 Oct 2022, at 21:05, Darin Adler via webkit-dev > wrote: > > Hi folks. > > I love to keep the WebKit project moving along, and one way that I personally > like to contribute is helping get pull requests reviewed. I looked at the > list of pull requests for the project, excluding closed requests, draft > requests, and requests that have been reviewed: > > https://github.com/WebKit/WebKit/pulls?q=is%3Apr+is%3Aopen+draft%3Afalse+review%3Anone+sort%3Aupdated-asc > > There are 113 of those right now. > > It seems like we should convert many of these to drafts, close some others, > and review most of the rest. I think it would make the project healthier if > we didn’t have so many pull requests in an ambiguous state, including some > that were last updated 4 months ago. > > What do you all think? Do you own some of these? Would you be willing to > convert ones that represent work in progress to drafts to clean up this list? > Other ideas for making this work well? I owned one open PR that had not immediately recent activity and was pending additional work, which I converted to a draft. I don’t know if it’s the best signal of that PR’s state of “got some review feedback, need to address it but not working on it immediately” but it does work in removing it from the “need review” queue and it also lets me easily find it when I have more time to devote to any pending patch. Antoine ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Safari Tech Preview 96 available on wpt.fyi!
Hi Stephen, > On 27 Nov 2019, at 16:07, Stephen Mcgruer wrote: > > One thing that surprised me is that the release blog post[0] mentioned Web > Animations being enabled by default, but we see no differences in the test > diff for web-animations/. It's possible we enable some flag that turned on > Web Animations already, but I can't see it obviously in our safari setup[1]. Safari Technology Preview had been shipping with Web Animations on by default prior to that change. The value DEFAULT_EXPERIMENTAL_FEATURES_ENABLED is true for STP builds. So it’s correct that you don’t see any change. Antoine ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Logging in iOS simulator
> On 31 Aug 2019, at 05:33, Ken Russell wrote: > > Hi WebKit developers, > > Is it possible to log from the WebKit build for the iOS Simulator? I've had > difficulty getting LOG() statements to work even on macOS, so just tried > NSLog, but the result didn't show up in the system log when opened from the > simulator. This has been working for me using the Console app, you just have to make sure that you select the simulated device in the left panel. Antoine ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] XML Events in WebKit
On 8 déc. 07, at 01:14, Ian Hickson wrote: On Fri, 7 Dec 2007, Antoine Quint wrote: XML Events basically come in handy when you want a generic markup- based way to add event listeners for custom events. For instance, if XBL was implemented in WebKit, and I had my own custom magic UI control implemented with some custom XML element, [...] ...then you shouldn't be sending it over the wire, so it shouldn't matter... (You shouldn't send custom, aka proprietary, vocabularies over the wire, since you have no way to guarentee the end user can handle it.) We're drifting away from the original topic a bit, but I'm wondering if such a statement would jeopardize the validity of the existence of XBL, or if you see XBL as a technology for standalone, browser-based application? Personally, I see no big problem using custom grammars when XBL is available on the client. Antoine -- Blog — http://the.fuchsia-design.com ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] XML Events in WebKit
Hi, On 7 déc. 07, at 17:38, David Hyatt wrote: Yeah, they don't seem particularly compelling to me either. If someone does implement these, they should put the implementation behind an #ifdef so that those projects that aren't interested in them can turn them off. XML Events basically come in handy when you want a generic markup- based way to add event listeners for custom events. For instance, if XBL was implemented in WebKit, and I had my own custom magic UI control implemented with some custom XML element, I'll likely want to fire custom DOM Events, and XML Events would be a neat way for users of my widget to listen to some of these custom events without resorting to a purely script-based approach using addEventListener(). It's a lot of ifs, but if WebKit ever supports XBL and custom DOM Events, then it'd be worth re-thinking the usefulness of XML Events in WebKit. Antoine -- Blog — http://the.fuchsia-design.com ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
[webkit-dev] WWDC 2007 WebKit SVG Demos
Hi all, Dean Jackson and myself just posted the demos that we presented at WWDC 2007 about Vector Graphics and Rich Media in WebKit. These mostly showcase SVG, but also its integration with other core technologies such as XHTML, CSS, XMLHttpRequest, JavaScript and the DOM. http://the.fuchsia-design.com/2007/06/wwdc-2007-webkit-svg-demos.html Hope this proves useful to showcase the great SVG support the WebKittens have been building for the last few years. Antoine -- Blog — http://the.fuchsia-design.com ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Nightly builds of Feature Branch?
On 21 mai 2007, at 14:26, Andreas Neumann wrote: Would it be possible to offer nightlies of the feature branch as well? I woudl appreciate that as well. Antoine -- Blog — http://the.fuchsia-design.com ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] SVG Stabilization
Hi everyone, Maciej, On 20 févr. 2007, at 10:12, Andreas Neumann wrote: From your list in 1) I agree that SVGImage, Animation, Filters and ForeignObject probably need more effort and testing and they are candidates to be disabled. This also matches what Firefox can do today. However, the support of the use/ element is very important. use/ is widely used in SVG content out there and I would welcome it if it could make it into the next main Webkit version, even if this means additional efforts from your side. I volunteer to do testing regarding the use/ element. Webkit would be the only major browser/UA that doesn't support use/, which would be limiting content wise. This doesn't mean that use/ is correctly implemented everywhere. I agree with Andreas. Although it is a bit of a shame that advanced features such as SVGImage, animation, filters and foreignObject won't be supported in the stable WebKit, it is a fact of life that I assume we have to live with for the time being. However, use is a feature you'll often encounter in SVG content given that both Opera and Firefox have supported this feature from their first release supporting SVG onwards. If any kind of push is required on a single feature at risk for stable, it should definitely be this one. Sorry to say that I can't commit resources in terms of making it happen, but I thought I'd voice my support for Andreas's opinion. Antoine -- Blog — http://the.fuchsia-design.com ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
