Re: [webkit-dev] [webkit-help] ResizeObserver

2019-01-23 Thread Antonio Gomes
moved to webkit-dev, bcc'ing webkit-help +Cathie I know Cathie is working on it. Cathie, feel free to provide a status update. On Tue, Jan 22, 2019 at 4:06 PM Eric Gorr wrote: > > Will do. > > Might be worth mentioning this feature on https://webkit.org/status ... ? > > On Tue, Jan 22, 2019 at

Re: [webkit-dev] Incorrect expectation for fast/forms/range/slider-delete-while-dragging-thumb.html

2016-07-27 Thread Antonio Gomes
Does it pass (or is un-skipped) for any platform/port? If so, how does its result differ from Gtk/Qt's? On Wed, Jul 27, 2016 at 7:32 AM, Konstantin Tokarev wrote: > Hello, > > Test fast/forms/range/slider-delete-while-dragging-thumb.html is marked as [ > Failure ] on many

Re: [webkit-dev] Should overridden methods use 'virtual' keyword in addition to 'override'?

2016-03-04 Thread Antonio Gomes
On a side node, there are lots of lines like virtual void foo(..) override final; .. ending up like: void foo(..) override final; Ideally though, "override" could also get removed and it would read as void foo(..) final; It is a good follow up once the first patch bakes for a while in ToT

Re: [webkit-dev] support for navigator.cores or navigator.hardwareConcurrency

2014-05-07 Thread Antonio Gomes
(I am not in favor of this feature but not strongly opposed neither but..) I think a similar analogy is: $ make -jX #where X is the number of physically available cores. If I am working/browsing/text editing, etc and building say WebKit in the background, I really do not set X to actually

Re: [webkit-dev] Heads-up: ENABLE_GESTURE_EVENTS removal

2013-10-10 Thread Antonio Gomes
+1 for that. On Thu, Oct 10, 2013 at 6:18 PM, Anders Carlsson ander...@apple.com wrote: Hello, I’m planning to remove the ENABLE_GESTURE_EVENTS ifdef and related code. It was used by Chromium (and perhaps to some extent Qt) as well as WebKit2 for trackpad events before we switched over to

Re: [webkit-dev] Announcement: CSS3_TEXT_DECORATION flag

2013-10-04 Thread Antonio Gomes
All (?wincairo I'm not sure?) ports on trunk use the new Inspector, and the old one is being removed: https://bugs.webkit.org/show_bug.cgi?id=122295 On Fri, Oct 4, 2013 at 2:24 PM, Sam Weinig wei...@apple.com wrote: Or better yet, enable it for all ports on ToT. -Sam On Oct 4, 2013, at

Re: [webkit-dev] Announcing new port: Nix

2013-09-13 Thread Antonio Gomes
So will you advocate your users to use your external GitHub version or the one in WebKit? Please consider not being half upstream. On Fri, Sep 13, 2013 at 2:37 PM, Hugo Lima hugo.l...@openbossa.org wrote: On Fri, Sep 13, 2013 at 3:00 PM, Anders Carlsson ander...@apple.com wrote: On Sep 12,

Re: [webkit-dev] Are Qt and GTK+ intentionally returning false in shouldShowPlaceholderWhenFocused?

2013-08-20 Thread Antonio Gomes
On Tue, Aug 20, 2013 at 1:52 PM, Ryosuke Niwa rn...@webkit.org wrote: Thanks for the confirmation, Martin! I've started to wonder if we can tie this to the editing behavior instead. Isn't this more about the platform UI than each framework? +1 ___

[webkit-dev] Scrolling overflow:hidden boxes..

2013-08-16 Thread Antonio Gomes
Hi. Bug https://bugs.webkit.org/show_bug.cgi?id=119760 (Text dragging can scroll overflow:hidden boxes) caught my attention to the following situation: - imagine a page has an input field within a overflow:hidden div, and user starts text selecting from the input field text by dragging with the

Re: [webkit-dev] Scrolling overflow:hidden boxes..

2013-08-16 Thread Antonio Gomes
: On Aug 16, 2013, at 2:45 PM, Antonio Gomes toniki...@webkit.org wrote: Hi. Bug https://bugs.webkit.org/show_bug.cgi?id=119760 (Text dragging can scroll overflow:hidden boxes) caught my attention to the following situation: - imagine a page has an input field within a overflow:hidden div

Re: [webkit-dev] Adding ENABLE_CSS_DIRECTIONAL_FOCUS to WebCore.

2013-07-25 Thread Antonio Gomes
Given that we have a port shipping it (GTK), and usage and interest from on the TV industry and that Opera is working hard to get it included to CSS3 UI spec, it looks good to me for implementing this feature. If there is no objections, please proceed and guard it behind a build flag. Cheers, On

Re: [webkit-dev] Adding ENABLE_CSS_DIRECTIONAL_FOCUS to WebCore.

2013-07-25 Thread Antonio Gomes
, Antonio Gomes toniki...@webkit.org wrote: Given that we have a port shipping it (GTK), and usage and interest from on the TV industry and that Opera is working hard to get it included to CSS3 UI spec, it looks good to me for implementing this feature. If there is no objections, please proceed

Re: [webkit-dev] webkit-patch and clearing flags

2013-05-29 Thread Antonio Gomes
I found it very useful while reviewing to look at a bug and see what a patch has been r-'ed before. Even if it has been marked as obsolete by a follow up patch. It is a valuable quick reference of the patch/bug/work history. On Wed, May 29, 2013 at 12:21 PM, Bem Jones-Bey bjone...@adobe.com

Re: [webkit-dev] Christophe Dumez is now a WebKit reviewer

2013-05-10 Thread Antonio Gomes
Congratulations, Chris. --Antonio Gomes Software Engineer Samsung Research America - Silicon Valley. ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Feature announcement: WebCL

2013-05-07 Thread Antonio Gomes
Hi. The input received, including during the WebKit meeting, will be discussed within the WebCL working group, before proceeding with any upstream action. In the meantime, feel invited to check our current implementation [1], and to express their views on WebCL either here or on the Khronos

Re: [webkit-dev] Feature announcement: WebCL

2013-05-01 Thread Antonio Gomes
generally works on specifications internally, before they are made public. However, for web-based APIs, such as WebGL and WebCL, the members were allowed to share working drafts of the APIs, prior to completion. --Antonio Gomes On Tue, Apr 30, 2013 at 8:36 PM, Oliver Hunt oli...@apple.com wrote

Re: [webkit-dev] Feature announcement: WebCL

2013-05-01 Thread Antonio Gomes
On Tue, Apr 30, 2013 at 8:14 PM, Benjamin Poulain benja...@webkit.orgwrote: On Tue, Apr 30, 2013 at 5:10 PM, Antonio Gomes toniki...@webkit.orgwrote: At this time, I would like to contribute our WebCL prototype implementation [4] to WebKit.org. Feature would be defined behind a ENABLE(WEBCL

Re: [webkit-dev] Feature announcement: WebCL

2013-05-01 Thread Antonio Gomes
On Tue, Apr 30, 2013 at 8:33 PM, Geoffrey Garen gga...@apple.com wrote: Over the past weeks, some discussion involving WebCL took place in this mailing list ([2]), when some concerns were raised, and to which I later on tried to address in [3]. I believe your answer in [3] to the security

Re: [webkit-dev] Feature announcement: WebCL

2013-05-01 Thread Antonio Gomes
On Wed, May 1, 2013 at 8:41 PM, Oliver Hunt oli...@apple.com wrote: On May 1, 2013, at 5:29 PM, Antonio Gomes toniki...@webkit.org wrote: - 4.3 Out-of-Range Memory Access The validator will perform static analysis on WebCL kernels to determine violations of WebCL kernel behavior

[webkit-dev] Feature announcement: WebCL

2013-04-30 Thread Antonio Gomes
/pipermail/webkit-dev/2013-April/024747.html [4] https://github.com/SRA-SiliconValley/webkit-webcl -- --Antonio Gomes ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

[webkit-dev] obtaining webkit.org address?

2013-04-28 Thread Antonio Gomes
Previously people used to get SVN accounts associated to a @webkit.orgalias. Today it seems like it is preferable to get a company email as alias, and credential to write-access SVN. On Sunday, April 28, 2013, Glenn Adams wrote: How does a committer/reviewer obtain a webkit.org address? I

Re: [webkit-dev] Is there a plan for supporting multi-process and WebCL in webkit

2013-04-26 Thread Antonio Gomes
On Fri, Apr 26, 2013 at 2:19 AM, Oneal Bluce onealbl...@yahoo.com wrote: Hi Mikhail, Like what's you said, now WebCL have some serious security issues, we also try to some approach to fix this issue or make the security issue in a limited scope. such as we can use provide some high level

[webkit-dev] Some thoughts on WebCL

2013-04-19 Thread Antonio Gomes
Hi. Over the past year and a half Khronos has been working on a specification for WebCL - a JavaScript API that exposes GPUs and multi-core processors for computational tasks. Samsung and others have developed various prototype implementations. Recently we have been updating our WebKit-based

Re: [webkit-dev] Is there a plan for supporting multi-process and WebCL in webkit

2013-04-10 Thread Antonio Gomes
Hi On Wed, Apr 10, 2013 at 12:59 AM, Thibault Imbert timb...@adobe.com wrote: Yes, leveraging multicore and the power of GPUs for general computations is great and very powerful but first, securing such kernels is hard, and authoring these would be pretty brutal to most web developers, I

Re: [webkit-dev] Is there a plan for supporting multi-process and WebCL in webkit

2013-04-09 Thread Antonio Gomes
Hi. Correct WebCL link is https://github.com/SRA-SiliconValley/webkit-webcl . Cheers, On Tue, Apr 9, 2013 at 8:01 AM, Jesus Sanchez-Palencia je...@webkit.orgwrote: Hi, WebKit already support a split process model which is what we call WebKit2 [1]. I'm not aware of any official plans of

Re: [webkit-dev] Is there a plan for supporting multi-process and WebCL in webkit

2013-04-09 Thread Antonio Gomes
Hi Oneal. As pointed out by Jesus, Samsung is working on a WebCL implementation for WebKit. https://github.com/SRA-SiliconValley/webkit-webcl is being our staging repo. As for your question, it is a bit unclear that if by multi-process support you are referring the Web/UI process model provided

Re: [webkit-dev] Do any ports still disable SVG?

2013-01-25 Thread Antonio Gomes
QtWebKit has a --minimal option where SVG is disabled IIRC. On Fri, Jan 25, 2013 at 2:27 PM, Jochen Eisinger joc...@chromium.org wrote: Many chromium developers disable svg for faster building. Jochen ___ webkit-dev mailing list

Re: [webkit-dev] Changes to the WebKit2 development process

2013-01-09 Thread Antonio Gomes
Hi Sam. Some comments below. Cheers, --Antonio Curious about this myself, I just reviewed a patch only affecting the GTK-specific parts of WebKit2, I believe that is OK? Should we ammend the Owners file to include information about port-specific directories and reviewers? Cheers, At

Re: [webkit-dev] MS Open Tech - Initial Prototype of Pointer Events

2012-12-19 Thread Antonio Gomes
Please read this: http://lists.webkit.org/pipermail/webkit-dev/2012-November/022949.html On Dec 19, 2012 4:45 AM, Kenneth Rohde Christiansen kenneth.christian...@gmail.com wrote: Hi there, First of all I want to say that it is great that Microsoft are contributing towards WebKit and I want

Re: [webkit-dev] Chromium for Android upstreaming has been completed!

2012-11-06 Thread Antonio Gomes
://lists.webkit.org/pipermail/webkit-dev/2012-July/021516.html [2] https://bugs.webkit.org/show_bug.cgi?id=84186 ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev -- --Antonio Gomes

Re: [webkit-dev] New WebKit Reviewer: Caio Marcelo de Oliveira Filho

2012-10-09 Thread Antonio Gomes
://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev -- --Antonio Gomes ___ webkit-dev mailing list

Re: [webkit-dev] Chromium for Android builders have been added to the EWS

2012-08-12 Thread Antonio Gomes
that we have for the Qt port. Same for the BlackBerry port. -- --Antonio Gomes ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] can we stop using Skipped files?

2012-06-10 Thread Antonio Gomes
, and tooling is not an exception) are arguing for. -- --Antonio Gomes ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] EFL Debug Buildbot Green

2012-05-12 Thread Antonio Gomes
://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev -- --Antonio Gomes ___ webkit-dev mailing list webkit

Re: [webkit-dev] Moving to Git?

2012-03-08 Thread Antonio Gomes
. ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev -- --Antonio Gomes ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Moving to Git?

2012-03-08 Thread Antonio Gomes
-- --Antonio Gomes ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

[webkit-dev] Bugzilla request

2012-02-16 Thread Antonio Gomes
Hi all, I would like to request a WebKit / BlackBerry new component in bugs.webkit.org, as well as a 'blackberry' keyword. Could we please get help from the bugzilla maintainers to get them set up? Thanks in advance. -- --Antonio Gomes ___ webkit-dev

Re: [webkit-dev] Users of PlatformGestureRecognizer?

2012-01-30 Thread Antonio Gomes
___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev -- --Antonio Gomes ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org

Re: [webkit-dev] Question regarding rebaseline for Layout Test Result for EFL port

2012-01-16 Thread Antonio Gomes
___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev -- --Antonio Gomes ___ webkit-dev mailing list webkit-dev@lists.webkit.org http

Re: [webkit-dev] The Purpose of Core Builders

2011-11-08 Thread Antonio Gomes
. The information is clearly provided in the build bot configuration page. Thanks, -Brent ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev -- --Antonio Gomes

Re: [webkit-dev] NRWT Migration Update

2011-10-21 Thread Antonio Gomes
/webkit-dev -- --Antonio Gomes ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] NeedHelp_In_SpatialNavigation

2011-10-19 Thread Antonio Gomes
then we can skip the traversing of whole DOM tree. If the RenderTree can tell us what elements in the DOM tree are 'focusable' (which I do not think it can), yes. 3) Is Spatial navigation is related to Hit testing? Not at the moment. -- --Antonio Gomes

Re: [webkit-dev] NeedHelp_In_SpatialNavigation

2011-10-17 Thread Antonio Gomes
for the reply. Thanks Regards, Sanjeet ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev -- --Antonio Gomes ___ webkit-dev mailing list

Re: [webkit-dev] Enable -webkit-tap-highlight-color on all ports which support TOUCH_EVENTS?

2011-09-28 Thread Antonio Gomes
. Suggestions and comments are definitely welcome. Thanks! -- Best Regards. Johnny ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev -- --Antonio Gomes

Re: [webkit-dev] On touch based device touch/click response looks a bit flaky

2011-09-16 Thread Antonio Gomes
/ Any Thoughts/Suggestions. Thanks in advance. Arko Saha -- --Antonio Gomes ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] A Media Element ie: Audio or video, without tabindex cannot be selected with keyboard (TAB Key). BUG: 67190

2011-09-14 Thread Antonio Gomes
What would script see as focused if we allow subcontrols be focusable? Since controls are part of shadow DOM, scripts wont be able to see that. In this case then they would probably end up with respective media element. Well, then that should be layout tested as well. -- --Antonio Gomes

Re: [webkit-dev] Do you maintain OS(WINCE)?

2011-09-13 Thread Antonio Gomes
OS(WINCE), I'm inclined to remove it in a follow-up patch. Thanks, Geoff ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev -- --Antonio Gomes

Re: [webkit-dev] how about nav-up, nav-right, nav-down, nav-left in CSS3-ui ?

2011-08-10 Thread Antonio Gomes
bugs.webkit.org than e-mail communication? Well, you should file a bug anyways, imo :). -- --Antonio Gomes ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Extra review requirement for web-facing API? (Was: Re: Spellcheck API for WebKit)

2011-06-22 Thread Antonio Gomes
for such cases. For other cases, looking for a reviewer that domains this code is still the best thing to do. -- --Antonio Gomes ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] review flags (was bugs in pending-commit)

2011-06-19 Thread Antonio Gomes
Hi Darin. Few comments inlined. On Sun, Jun 19, 2011 at 2:31 PM, Darin Adler da...@apple.com wrote: On Jun 18, 2011, at 9:01 PM, Antonio Gomes wrote: I actually do not like the way the review flags are cleared today only in order to make the tools and pending-xxx pages happier. IMO

Re: [webkit-dev] review flags (was bugs in pending-commit)

2011-06-19 Thread Antonio Gomes
Adler da...@apple.com wrote: On Jun 18, 2011, at 9:01 PM, Antonio Gomes wrote: I actually do not like the way the review flags are cleared today only in order to make the tools and pending-xxx pages happier. IMO the review flags give much about the history of the bug. In that matter, I

Re: [webkit-dev] 194 bugs in pending-commit

2011-06-18 Thread Antonio Gomes
___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev -- --Antonio Gomes ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi

Re: [webkit-dev] Expected behavior of scrolling attribute for IFrame element

2011-06-13 Thread Antonio Gomes
___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev -- --Antonio Gomes ___ webkit-dev mailing list webkit-dev@lists.webkit.org http

Re: [webkit-dev] Expected behavior of scrolling attribute for IFrame element

2011-06-13 Thread Antonio Gomes
to allow controlling this to give sites a workaround? The real problem to fix would be not have scrolling tied to having or not scrollbars, as I see it. --Antonio Gomes ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman

Re: [webkit-dev] Expected behavior of scrolling attribute for IFrame element

2011-06-13 Thread Antonio Gomes
ignore the scrolling attribute show the scrollbar (this needs a change in the spec as well). Will this behavior have any side effect? Thanks, Rahaman On Tue, Jun 14, 2011 at 12:01 AM, Antonio Gomes toniki...@gmail.com wrote: overflow:hidden divs are used to implement custom

Re: [webkit-dev] Cherry-Pick Bug Comments

2011-05-27 Thread Antonio Gomes
Apple's internal bugtracking work on that matter, but there is the 'InRandar' keyword. Maybe Qt could get something similar and JIRA could be used for tracking progresses on QtWebKit releases? Well, as I said, it is not an easy problem :). -- --Antonio Gomes

Re: [webkit-dev] Cherry-Pick Bug Comments

2011-05-27 Thread Antonio Gomes
An important question: besides the notification e-mails, does the rest of our release process bothers someone? Not me. It works fine and is very transparent. -- --Antonio Gomes ___ webkit-dev mailing list webkit-dev@lists.webkit.org http

Re: [webkit-dev] Cherry-Pick Bug Comments

2011-05-26 Thread Antonio Gomes
by the EWS are intended for the bug authors and so they probably should continue sending mail. ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev -- --Antonio Gomes

Re: [webkit-dev] Font Name

2011-05-22 Thread Antonio Gomes
@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev -- --Antonio Gomes

Re: [webkit-dev] Adding ENABLE_GESTURE_MANAGER

2011-05-09 Thread Antonio Gomes
webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev -- --Antonio Gomes

Re: [webkit-dev] WebKit blog post proposal: Remote debugging with Web Inspector.

2011-05-02 Thread Antonio Gomes
capabilities ( http://www.berryreview.com/2011/04/15/hot-webkit-web-inspector-on-the-blackberry-playbook-for-web-developers/) or both Chrome and Playbook. Any RIM people around? -- --Antonio Gomes ___ webkit-dev mailing list webkit-dev@lists.webkit.org http

Re: [webkit-dev] Who are the EFL reviewers?

2011-04-12 Thread Antonio Gomes
I think the WebKit/EFL patches are 100% valuable to be submitted to WebKit.org. ProFusion and Samsung are doing a great job improving the port, and we should not discourage them to keep contributing. I've been rubber-stamping and reviewing their contributions as much as I can, and I have to agree

Re: [webkit-dev] Who are the EFL reviewers?

2011-04-10 Thread Antonio Gomes
of WebKit.) -eric ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev -- --Antonio Gomes ___ webkit-dev mailing list webkit-dev@lists.webkit.org

Re: [webkit-dev] Progress

2011-04-01 Thread Antonio Gomes
___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev -- --Antonio Gomes ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman

Re: [webkit-dev] bugid in ChangeLog

2011-03-28 Thread Antonio Gomes
number. This is where I do not agree. Review is a requirement, but I don’t think bugs.webkit.org should be. -- Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev -- --Antonio

Re: [webkit-dev] code review tool changes

2011-02-15 Thread Antonio Gomes
the context though as long as you start inside the existing context. Alternately, adding ctrl (shift is probably better) to expand the context wouldn't be a difficult addition. Ojan On Mon, Feb 14, 2011 at 4:01 PM, Antonio Gomes toniki...@gmail.comwrote: Previously, I was able to increase the context

Re: [webkit-dev] code review tool changes

2011-02-13 Thread Antonio Gomes
Previously, I was able to increase the context of my inline review comments by clicking on consecutive line numbers while pressing CONTROL. It seems regressed. Am I the only one noticing that? -- --Antonio Gomes ___ webkit-dev mailing list webkit-dev

Re: [webkit-dev] More thoughts on cleaning up the root directory

2010-12-28 Thread Antonio Gomes
. -- --Antonio Gomes ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

[webkit-dev] Gtk Linux 32btis Release needs a full build.

2010-12-18 Thread Antonio Gomes
(...) GTK Linux 32-bit Debug and GTK Linux 64-bit Debug are ok though. -- --Antonio Gomes ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Is the default height of the replaced elements 150PX ?

2010-12-04 Thread Antonio Gomes
solved it? -- 波澜壮阔心无涟漪 ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev -- --Antonio Gomes ___ webkit-dev mailing list webkit-dev

Re: [webkit-dev] Bools are strictly worse than enums

2010-12-03 Thread Antonio Gomes
://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev -- --Antonio Gomes ___ webkit-dev mailing

Re: [webkit-dev] Bools are strictly worse than enums

2010-12-03 Thread Antonio Gomes
(UnderstandableParameter). I'd rather have readable code than comments attempting to excuse unreadable code. -eric On Fri, Dec 3, 2010 at 1:57 PM, Antonio Gomes toniki...@gmail.com wrote: I do not think that XXX:repaint(true /* immediate */) is so bad either, if I understood Hyatt's comment correctly, and I agree

Re: [webkit-dev] commit ownership and commit-queue

2010-11-29 Thread Antonio Gomes
with it. ps: why do many people have more than one email in committers.py then? Cheers, On Mon, Nov 29, 2010 at 1:56 AM, William Siegrist wsiegr...@apple.com wrote: On Nov 28, 2010, at 10:21 PM, Antonio Gomes wrote: Hi. In committers.py I have tonikitoo at webkit and agomes at rim subscribed

[webkit-dev] commit ownership and commit-queue

2010-11-28 Thread Antonio Gomes
Hi. In committers.py I have tonikitoo at webkit and agomes at rim subscribed as my working emails. ... Reviewer(Antonio Gomes, [toniki...@webkit.org, ago...@rim.com], tonikitoo), ... However, when I use the commit-queue and sign the ChangeLog with the later email (agomes at rim), the commit

Re: [webkit-dev] WebKitGtk app memory leaks , please help

2010-11-04 Thread Antonio Gomes
-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev -- --Antonio Gomes ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Clobber builds in windows bots needed?

2010-10-30 Thread Antonio Gomes
, and should fix the Windows build. Brian On Oct 29, 2010, at 11:12 PM, Antonio Gomes wrote: Hi. After http://trac.webkit.org/changeset/70975, Windows Debug bot started failing to build: http://build.webkit.org/builders/Windows%20Debug%20%28Build%29 . The build error shown

Re: [webkit-dev] Clobber builds in windows bots needed?

2010-10-30 Thread Antonio Gomes
://bugs.webkit.org/show_bug.cgi?id=48721 about it. -- --Antonio Gomes ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

[webkit-dev] Platform specific editing behaviors

2010-10-27 Thread Antonio Gomes
#else // Fallback EditingMacBehavior #endif ; } Before anything I would like to point it our here, and hear from the port maintainers any possible objection about it, specially from the cross-platform ones, including Chromium and Qt. -- --Antonio Gomes

Re: [webkit-dev] Platform specific editing behaviors

2010-10-27 Thread Antonio Gomes
: On Wed, Oct 27, 2010 at 2:17 PM, Antonio Gomes toniki...@gmail.com wrote: Well, despite the naming to be used, in the same bug I am proposing that the editing behavior of each platform to be set according to the OS it is running on. As an example, Chromium when built on Mac would have

[webkit-dev] Ordering bugmail in committers.py

2010-10-11 Thread Antonio Gomes
fix its own ordering, so the autocompletion works nicely for everyone. Thanks, -- --Antonio Gomes ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] On frequently hosing other port's WebKit2 builds

2010-10-06 Thread Antonio Gomes
, if this souded like an offense. WBR, Andras Becsi On behalf of the QtWebKit Team at the University of Szeged ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev -- --Antonio Gomes

Re: [webkit-dev] Fwd: [webkit-changes] [68146] trunk/WebCore

2010-09-23 Thread Antonio Gomes
/webkit-changes ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev -- --Antonio Gomes ___ webkit-dev mailing list webkit-dev@lists.webkit.org

[webkit-dev] Changing API for Document::nodesFromRect

2010-09-22 Thread Antonio Gomes
://mxr.mozilla.org/mozilla-central/source/dom/interfaces/base/nsIDOMWindowUtils.idl#416 -- --Antonio Gomes ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Treat warnings as errors by QtWebKit

2010-09-08 Thread Antonio Gomes
-- --Antonio Gomes ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Updating the tradition for new reviewer blog posts

2010-08-02 Thread Antonio Gomes (:tonikitoo)
://lists.webkit.org/mailman/listinfo.cgi/webkit-dev -- --Antonio Gomes ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] SIL Open Font License and WebKit

2010-07-20 Thread Antonio Gomes (:tonikitoo)
Russell in a footnote of Principles of Mathematics ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev -- --Antonio Gomes ___ webkit-dev mailing

Re: [webkit-dev] Proposal: Rect based HitTest for a better touch experience

2010-07-07 Thread Antonio Gomes (:tonikitoo)
this request. But, well, in order to make it work that way (give *all* nodes under rect X), there would be some less simple changes needed, so we can go first for with what we have working at the moment. Cheers, -- --Antonio Gomes ___ webkit-dev mailing list

Re: [webkit-dev] STIX Fonts and MathML Tests

2010-07-07 Thread Antonio Gomes (:tonikitoo)
webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev -- --Antonio Gomes ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Proposal: Rect based HitTest for a better touch experience

2010-07-06 Thread Antonio Gomes (:tonikitoo)
Hi Simon. Thank you join the discussion! On Tue, Jul 6, 2010 at 1:46 AM, Simon Fraser simon.fra...@apple.com wrote: On Jul 5, 2010, at 7:35 PM, Antonio Gomes (:tonikitoo) wrote: * adds a Document::nodesFromRect method, exposing the functionality to the dom. It returns a NodeList with all

Re: [webkit-dev] Proposal: Rect based HitTest for a better touch experience

2010-07-05 Thread Antonio Gomes (:tonikitoo)
Hi guys. We've uploaded a patch for review in bug https://bugs.webkit.org/show_bug.cgi?id=40197 (attachment https://bugs.webkit.org/attachment.cgi?id=59789 - chromium build fixed in r61955) - Grace and I joint effort in fixing this issue. As ways to expose the functionality, the patch: *

Re: [webkit-dev] Proposal: Rect based HitTest for a better touch experience

2010-06-10 Thread Antonio Gomes (:tonikitoo)
-- --Antonio Gomes ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

[webkit-dev] feedback{?,+,-} flag in bugzilla

2010-06-10 Thread Antonio Gomes (:tonikitoo)
not necessarily have to build it or even do style checks, but it is optional. What do you think? -- --Antonio Gomes ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Proposal: Rect based HitTest for a better touch experience

2010-06-10 Thread Antonio Gomes (:tonikitoo)
every method name dhyatt both patches need to stop using a vector for the node list and use a hashset heh On Thu, Jun 10, 2010 at 11:21 AM, Antonio Gomes (:tonikitoo) toniki...@gmail.com wrote: Hi, As Grace pointed out in the spun-off thread,  bug 40197 was filed and a patch was put up

[webkit-dev] Proposal: Rect based HitTest for a better touch experience

2010-06-02 Thread Antonio Gomes (:tonikitoo)
). Before going this way, I would like to know of any known problem or show stoppers. Cheers, -- --Antonio Gomes ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Proposal: Rect based HitTest for a better touch experience

2010-06-02 Thread Antonio Gomes (:tonikitoo)
. I can certainly prototype something to see the idea in practice before any final judgment, if you prefer. Cheers, On Wed, Jun 2, 2010 at 5:22 PM, David Hyatt hy...@apple.com wrote: On Jun 2, 2010, at 2:46 PM, Antonio Gomes (:tonikitoo) wrote: Hi, As most of you have experienced

Re: [webkit-dev] HitTest'ing scrollbars

2010-05-17 Thread tonikitoo (Antonio Gomes)
on the other platforms. Maybe he can comment on this? -- --Antonio Gomes ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

[webkit-dev] Help with reviewing Spatial Navigation patches

2010-05-05 Thread tonikitoo (Antonio Gomes)
://bugs.webkit.org/show_bug.cgi?id=37803#c5 -- --Antonio Gomes ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Help with reviewing Spatial Navigation patches

2010-05-05 Thread tonikitoo (Antonio Gomes)
does not need to know the feature code in deep to review it. * Spatial Navigation: refactor hasOffscreenRect to work with scrollable content -- has a patch , but not set r? because it depends on bug 36463, which depends on 37803. ... I forgot to write: that is bug 38590. -- --Antonio Gomes

[webkit-dev] HitTest'ing scrollbars

2010-05-03 Thread tonikitoo (Antonio Gomes)
([Qt] Clicking on the frame's scrollbar trigger a click event in the page.) [2] https://bugs.webkit.org/attachment.cgi?id=20748 -- --Antonio Gomes ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi

Re: [webkit-dev] webkit-patch, check-webkit-style and git now support --squash and --git-commit

2010-04-26 Thread tonikitoo (Antonio Gomes)
! -- --Antonio Gomes ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

  1   2   >